From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACD76E75455 for ; Tue, 3 Oct 2023 13:03:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 452F28D006E; Tue, 3 Oct 2023 09:03:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40E6C8D0003; Tue, 3 Oct 2023 09:03:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A46E8D006E; Tue, 3 Oct 2023 09:03:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 179348D0003 for ; Tue, 3 Oct 2023 09:03:53 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5FA2D1402FF for ; Tue, 3 Oct 2023 13:03:52 +0000 (UTC) X-FDA: 81304167504.26.747D2DE Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf21.hostedemail.com (Postfix) with ESMTP id AA5CD1C0093 for ; Tue, 3 Oct 2023 13:03:26 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=lk7jzy3k; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf21.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696338208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MCw89XvWZCHmndxFc4KWV08Rgyb0HbAqrU0uJncC/sk=; b=g5bYXr2i7n1B1RK4hoJuLob9Ye/m+7G3xm+vjgziBgbu3fbmUzzOc/UoeesVM8WKNbyMl9 3M6QFsOG6ldlravVrvaybCTp9lUhgTkmztj2O4gD9Qrwdv3IyhVVcRFZf6zVCKbqZzqJZM iMU6m+MUXZYh79IfxJlVS98CX/BWIuM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=lk7jzy3k; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf21.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696338208; a=rsa-sha256; cv=none; b=OWDfUSsJIyksojMzrtalL6Rl7rI/NR/0HQqWXJORTyBZY3ksBjR4cfpfd7BVL4uBhfq0uo NjqEEoW97cecW7EYjW39VYX+IcwRtfzEMSpP9JgvIFUgEIz6fSL56oBd19Xwrxztckr0wT kEhNyudikSlpRpyB7JyGnXFVTYo15uM= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-41983b83e53so6070761cf.2 for ; Tue, 03 Oct 2023 06:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1696338205; x=1696943005; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MCw89XvWZCHmndxFc4KWV08Rgyb0HbAqrU0uJncC/sk=; b=lk7jzy3kTc5cGYrBBI8c+T3p4JU2PumMb0Bx95JXpzrzBERKSBMqGkt+3fHasUNbn8 wm/wDnbNBguuIhvaEWn0fA/tjjt4Sg/s6iXYD9N9q/5/krWD2CjbSMcN6t8fnfIqGI6l XDPlpVKD8TuwMxznFe9L4LrTU4EVs+BqKIE6At5xEnWS9QMPuAA4nj/0hjFuPBsc/noS 1tyR7jwQiWSMtQJS73auL6xLf2wJ4hicW5X1jKAmfFibsGMeZjpxxE36/FZo5rk/WIls ke7JQm3H2/pEwDvccZKksgAQsyN3LwNhLJ5fDgAi0ieE5+jTExDOFgJKNm0sEgC6UeM4 M6xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696338205; x=1696943005; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MCw89XvWZCHmndxFc4KWV08Rgyb0HbAqrU0uJncC/sk=; b=CC4oE6LbgslOxPzWnDZ6e/VdBs9AJSeD5hoNYiJgaxIQYxG2bL9YGdwvcFvNH/lTwB y6bGp5BEcyAGq/nmsa922gKeARodJyEAcp2wEFkvRJI6oWkxBNhWfvdAswCm1UKrphpp WlWNxzG2MwcZCJCu8Z+zL+cSJKUgL9pdzwAzw57ZqXQTNX8CtuptmeGLHI2gWCqqQ26X ILfbBIVpoujj+7Hi5EihTtIl7T7g23hbG5QZ4/060smUQw41uMS/qG0MTZfunKT4/uZO b8JhdYV+T1dxThHLDsnGe4XdsHeLP87sfYc3A2pBAoEghhvJWAIhpBimvdObT+flU3y8 ReoA== X-Gm-Message-State: AOJu0YxBCKpRZ9waipj+bBcwXjQgHuG8ceN0A7yDG7fWA6kX1J2/zv6s MJggfc9Q1+E2ktIUAomj2g9cZA== X-Google-Smtp-Source: AGHT+IHJRnQwY/cLx6XnU1FucbI8lpoWcQVVxYTA0fLNl6NJEePNW8Yk3Bxbjfb+E/rxyi+rGXbwNQ== X-Received: by 2002:ac8:7d44:0:b0:419:4c9d:8738 with SMTP id h4-20020ac87d44000000b004194c9d8738mr20418260qtb.46.1696338205642; Tue, 03 Oct 2023 06:03:25 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-3012-16a2-6bc2-2937.res6.spectrum.com. [2603:7000:c01:2716:3012:16a2:6bc2:2937]) by smtp.gmail.com with ESMTPSA id z5-20020ac87105000000b004197a3872f9sm416244qto.86.2023.10.03.06.03.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 06:03:25 -0700 (PDT) Date: Tue, 3 Oct 2023 09:03:24 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Andrew Morton , Shakeel Butt , Michal Hocko , Roman Gushchin , Muchun Song , Michal =?iso-8859-1?Q?Koutn=FD?= , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm: memcg: refactor page state unit helpers Message-ID: <20231003130324.GC17012@cmpxchg.org> References: <20230922175741.635002-1-yosryahmed@google.com> <20230922175741.635002-2-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230922175741.635002-2-yosryahmed@google.com> X-Rspam-User: X-Stat-Signature: 6bikffbid78mti9964q37kqs7xm5cuwt X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AA5CD1C0093 X-HE-Tag: 1696338206-592853 X-HE-Meta: U2FsdGVkX19jxPmNDHoOv2G6bBJvVLKOtZT2S2huYpwOcWdG+uUqPr6acqZEYeLGdVbbb76OfKCXnI+pJbQ2HXS/V4h0vvWx6gudbv4PkIry5eFIgUEevGLr+8NyiQ3bT+q98s57kvGA/qk0hUTzC8ETlMaFioq+178jpPjXuwtt0lVmc0nThV2VgdtDIRWfVAnCXWNW8SeVBOvznxf9f3KIOVSbi6fo/vAkqTFco6oUOSCTqoyty5hRMBAxtsDm5suom1nCLO8k3g1i1V/r/N8g9mGK0bD8Ms9XPutqy9KlkqjKiCMdXAp8W+JY/xdP82WyWxgtmd4Jq6H2Q0bnbDiQVQ0SGvgVldxS45TWclDY8fnu0tU4RQ/ZOekaOkGwJSkCEE0gGpDp7wix4EVFqyWkybqkyaKo5v1ByDDFYec2LCWBw+N2LsqNOobWzCAE/J9mrVvh5jP5Q9QpUhZMqO+JXegjJ+AAdHFro0n8rg7ZDKf6l73xvn6ny4SzPuLT4Oy+cBk+aEvs9vmN+tYebE6NUdxfjJeT8Fyal0vHw9wAbWpSqU2wMEZ61VBgheqyguS1JBZHNAHP2RRLqBoKeUYadWuXxwdw57NjLC6mV2YWy36AuiVRXcTL6VBmVvAY8l5LNu8lZyyD6PfwQZdQUssKkXKVAKzfIiZyIWhrvUHGGP/6dZLWWB2sSuk4AuiOhvURTsK/jMus/vDc3aPBhyLasTyYcbGoeTeDTGUPyLTBWOH+klnqhZLzSBdIRASwt3hB0p9+uLb/b9j74WEbs7excpQG/02hFqC58nGtGe8oCqYPDkQmBWUsvh/5Y1Azc4NMcLFoWsa83vem9Z3XMqGu3zlho9WqR9QNlLJOwRsGlcv1bjsXCxMxlLtINysZVD+OIQWtPlqQN1CcrQDFuH0XwKhUWor+kwfZjPomqR5Ly+/cXxAfawlmIziHIYvgLTCpQk0UPbZ0eM+bvxC MKSaxS1t lVOF7D20xLZ54fw/jaYNvoSEcnCMiPagDHA1EtFvie/YQIlNZnP0MCGYlVtWiZnWprqrCj4Wrmgn2yuYzexNbAqxSnnarti+BRGLiohPSdqT0Sqkp21vL1zKdixZ4YkyP5wvbMF4OTp9fhZ7LH1ASsBiiU/eE08aoN/RGFA8eO7fnBQhzK5+4qAtUTe+ybITgyzNeVhLiCBk9ITrhPMhT6MiCzSrDT90cI1Ot0nFi5DG7V+MERBtZh08Dn3w9Xe7GKBxvuEP2XKAVjXKRL+rnAt+aAK8W/lixYbDQs4G6Ru6q66CPzKNZEp7aZvRk1oeQ9fHbFYjlK2Hg0jdi4ALgZ2WFVJVNpoM9rv71Q0TyqCl2VS9V79yiuff16GFIrJWCpzqFmHRAwqmQF8V5hB5W+8WekXW8ei7GkfEy7lS1oienl3KTU1NREfj5YA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000043, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 22, 2023 at 05:57:39PM +0000, Yosry Ahmed wrote: > memcg_page_state_unit() is currently used to identify the unit of a > memcg state item so that all stats in memory.stat are in bytes. However, > it lies about the units of WORKINGSET_* stats. These stats actually > represent pages, but we present them to userspace as a scalar number of > events. In retrospect, maybe those stats should have been memcg "events" > rather than memcg "state". > > In preparation for using memcg_page_state_unit() for other purposes that > need to know the truthful units of different stat items, break it down > into two helpers: > - memcg_page_state_unit() retuns the actual unit of the item. > - memcg_page_state_output_unit() returns the unit used for output. > > Use the latter instead of the former in memcg_page_state_output() and > lruvec_page_state_output(). While we are at it, let's show cgroup v1 > some love and add memcg_page_state_local_output() for consistency. > > No functional change intended. > > Signed-off-by: Yosry Ahmed That's a nice cleanup in itself. Acked-by: Johannes Weiner