From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71328E7AD7A for ; Tue, 3 Oct 2023 16:49:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03A736B016E; Tue, 3 Oct 2023 12:49:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2BFF6B016F; Tue, 3 Oct 2023 12:49:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E24A46B0174; Tue, 3 Oct 2023 12:49:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D03C16B016E for ; Tue, 3 Oct 2023 12:49:16 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A4BD01A03C8 for ; Tue, 3 Oct 2023 16:49:16 +0000 (UTC) X-FDA: 81304735512.03.58F3164 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id D2F9B40013 for ; Tue, 3 Oct 2023 16:49:14 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="ns/DbDiT"; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696351755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gqq3Qeh8awHLWFtKu+hJZmtZ55DGHc5XD1oRUudejGY=; b=PHLcQkgg8b6VupChCVTpr2kwiEy1CeoohGWT9an+otMNHyJirakdsQ+Pu4ApWF7XMWfo+p 2VcSIRK2SCS0seO+U1Gxtr6zlesA7URGpLfwEx+pmPXeUnTYGv0tlp/A0hns2fL7MEIDJk COylxvTE0DfzFXiG8ZT9XFsrk1q7yFo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="ns/DbDiT"; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696351755; a=rsa-sha256; cv=none; b=ING2O3nsmQyFe6fQfOVUQQyMvC0U/IHuedHrf+pLTXvai0PuUSVVt238/hM0cYGqz1eeGe Sr/zMnV0GkYRzrZMZ5p8WyAeQdK8Xld1JCjuW3vy6i4aTtSL5Tfoz+Xgy55CWeE2MX9ba2 P2AJwhO/eVVsVuXT+XT+qZk0oj2ZgYE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A9F78612C9; Tue, 3 Oct 2023 16:49:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22B05C433C8; Tue, 3 Oct 2023 16:49:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1696351753; bh=iEwy5TFfW38GUWMzKpl2xUh3tcJyNxUXX2NNuztvv9U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ns/DbDiT/6XDOd6Uk8EkSsMmWp8ic4CpREMt2sxYNdXgCKGD++IGUO9aqxrQsFvI0 yoIxS0oz2Z0K6oU3DjugeJXE7Oomocvl/fRH4t4eQocEoxGYaiFGelq0UnGhaloiv8 wvOIruSKsDxb/4lMOsQ64f5Zg4KmBLNUJpwqkX9k= Date: Tue, 3 Oct 2023 09:49:12 -0700 From: Andrew Morton To: Gregory Price Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, arnd@arndb.de, Gregory Price Subject: Re: [PATCH] mm/migrate: fix do_pages_move for compat pointers Message-Id: <20231003094912.08cf57998135446ef475dd19@linux-foundation.org> In-Reply-To: <20231003144857.752952-1-gregory.price@memverge.com> References: <20231003144857.752952-1-gregory.price@memverge.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D2F9B40013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gdk6zo9dwwtijr4w1gkgnpq1hugxqyo8 X-HE-Tag: 1696351754-639439 X-HE-Meta: U2FsdGVkX1+Lvq0C06BHzA761mxmYhyvgB1vS1ud3g7041KEM55RE90wHe6WZR5jgAaLNtBGa2cKIoDuBYd4u88ATmJ3XJc1abl0Z7/XqCOZIpCYIqqtC1ADtCKsQxsEopwsYnL4yX9DmhqBYDi+82/f7FiE7f44Bbb/oPpPdmudM/hGGX2X+wNdJpaNLxx2soHu9USAtQQX4rzYpHzeJLT2sQJ8iQe36vfaHW0MGxWx1SWPaaLRsdMrpLyrmoY8n22/uyb0ZUIO+s/KhuhOCGtyXrLrxCJjhxRRGgVs1c67GCUhtkXtmlUoIIInDPrid6uBY32zMjfmcnYl5fl4T1vVMTaKqeYeVBseRGqwIks2MeV4Je9FaMAesORWMOHXCQ77dA7D+zhVjK5NuC2NLLs1+eSTUJfLRKuBvXc8fXlUGLMqvXaGs/HnER+DaVYQQeBSBg6v0O+N7EggyDiUvVEVSimeDoy+5O/w/jefKCpe5Gxm3vhT8P7vRb7K5H9I2wcwdIKjjNg+nAxt3p3w0l9hxnUmfuM5UHjqgfvN6QLmx8TTZhHBUq8FOHq46rOAzbQPNrdH+DbfZLYcd4jmzrNKLvakWZywWHsI1Sm87mtHOEY2xBFwhMF93wFCsSXcnp45XfYQa3fy8dWDrQpw76FsVMZqbmTL7FuO1ftXMX4SsKJAo89jOW9H0w9tCawOWN7mTEWFWGXjBaZmRcEFTGaXr3JY++FKO/dY2+pmXRioi4vlpT//H/iCpnzjJjpOw0Qe52mouOLovI1esUKyye6DYBJokBz+4zsO15JZzeM8jr98tsaPDgYEbk8AMGSIxdRdSUr3nWpz1ncTVB8O6Gp0DRqirLNKJYD7ZiB7JZsSHDwhvGfNK+tMSyQC0Dehv/PzrSHU0mfsXfRcRD42nFw+W1HynKrNNuvCwCjTVFIDhDzsKEX3PeFQbLFE0hbDl/RJ6+KdZPHQRpdtgIy fJ8sSzwt qWZsUWQvuNsMfjO/zk3WPnT8eYq53F8rGNVm99Y88CN/kxd3QktkZ/RgImf7n/D6N3ZGlF7kD6TzPgVqLQIGvL238aYJpVgOFpVF11g866MHrpHAc7S7ecx/fQ/3sxDk5X2Gm4PV32mw95PmNrLrfG6R9WRwXLhAla2pCKfD64esMQDTIO8rUsKQNqIBniJ6KXU6MW8HLbCkepPrxmdx8SXWdzxsG3pTlT4w4nNyeaMPSkoFG+B3KsjYM9Tl8KgNCHyG6bTCE6qJrskBBV7Vo/Kh2+8NfaowiXfxN0/KTy4zzOFgPkDmNMBmNRzMhx7OGsCZFRWUfgQMUPO7E4ujsPzMAhs/vKhbrBpPy28IxWSM2ChgtdgDQEpJGFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 3 Oct 2023 10:48:56 -0400 Gregory Price wrote: > do_pages_move does not handle compat pointers for the page list. > correctly. Add in_compat_syscall check and appropriate get_user > fetch when iterating the page list. What are the userspace visible effects of this change?