From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80F78E784BC for ; Mon, 2 Oct 2023 15:36:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DCD78D0031; Mon, 2 Oct 2023 11:36:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08D838D000E; Mon, 2 Oct 2023 11:36:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6F728D0031; Mon, 2 Oct 2023 11:36:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D5CAF8D000E for ; Mon, 2 Oct 2023 11:36:10 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9F8001A036F for ; Mon, 2 Oct 2023 15:36:10 +0000 (UTC) X-FDA: 81300922500.08.D3B8D95 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf24.hostedemail.com (Postfix) with ESMTP id 688E418001E for ; Mon, 2 Oct 2023 15:36:08 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=tfc8Ylnw; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf24.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696260968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RJCeoYI4MdW2Vg1VXnFe6BioTBJsiwn/a/IEZV9MrFI=; b=t9NK5njTRv9YL0Y7RXyJhdZNcS6CR6cXG741bNUS2+VMlfAsG/Rg5XNA/7mn2ycOEFeZzc 5kAUAndB/63gvt6sR2RZ45ThPJBa+x5RLpTPptOgSxUcL2d8y1GUtdH9rLxSb37Ya6LD/6 Aw+eNN2BVWWiOX2NgaOVPUSlrgz/WGM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=tfc8Ylnw; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf24.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696260968; a=rsa-sha256; cv=none; b=uKzRLQ3W2n8MothgKkHg2c8PVgxJIJ2pa/9Ce7ETpLoXm1Nax1/jeMIcMLgT63gHdBaMZ+ Ovvubw37TtEijAQb4uOGjlnPkjm8tKXXWhA4gxt0YwMrbjUWB7grQ8hB7xY7f1ZZvbcNaK 1PXZbFQUe25CLnVYOvPp1GyMYT3glZk= Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7740729ae12so1138206885a.1 for ; Mon, 02 Oct 2023 08:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1696260967; x=1696865767; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RJCeoYI4MdW2Vg1VXnFe6BioTBJsiwn/a/IEZV9MrFI=; b=tfc8YlnwmArB2Xo20oRIB3bBHC5kX6nh38KHES8yNcegHGDse7lqkdVgDOLK3QnWdJ K67DIQWNC+Scttb3L0W7Uoy8LkHPkGfmc7v/T04gUn7u9/fb5NFfl2Jk5GssbnBmtEgX zPfoxIlu62d1DNvr2yP7+EtH0MsWkdiYUUjPcdHknj5CE2ll5ILxl+mSa6lK7H3ZpIc5 2UP3JMARYPB4+/A0vgaER3bz16bFcTMD++sY56d7qenLw4btuyHfPAP12zt7lUrpojXE ILPdplZWM1dNrxjvfXfp2G4MTCHPOCZI5N3r96Xn9HxGpoDPIAfS45uU/WHHznPCgMxR gYsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696260967; x=1696865767; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RJCeoYI4MdW2Vg1VXnFe6BioTBJsiwn/a/IEZV9MrFI=; b=p6fK5M1jO+/cwxlC8qaMgUijjP1ldcObZgNKzgRTRUB3wt9TsKrPxlbTRmCi3N2M5q Kg3OzwwhGNxnRf+bHMqUfhltkud1TIABwuOLtBegvjm0RUM9cBQpMB0dLWLy+jmEG2+Y 0GlYikCut32wBPm3sfhtdM6W9Qrpoi4N5GmqPXDBNeMASNaPBEuaaxkH+xBh0EYQ+++L vEVctzQ6TBNLequOzhEUE2TAihFntf1M4p1isS28Mj/I+37EVOQO9G1iGqozkM+zhPve ESBrSJMewyZMo8hyBigAGkCR/eIBFdqGX5QuNxHil3uR3gVaWKpTXVAUsZyMsQ8XdcW2 xB9w== X-Gm-Message-State: AOJu0Yy+nZtMnyyP7FPwgq59Z3rpLB2Vififl0+PGSOrO/Mjke2MrUzs fTy4Eni5VNamntHYzXMVwbTQTA== X-Google-Smtp-Source: AGHT+IFF7jCfjDq8C5HlvxijPDsuuv1R1dJYVyC0Ykg+iTQehAD8V0XEHiC5mEXTWNubAjbj8/02RA== X-Received: by 2002:a05:620a:29c4:b0:775:6a78:5f9a with SMTP id s4-20020a05620a29c400b007756a785f9amr16126546qkp.6.1696260967363; Mon, 02 Oct 2023 08:36:07 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-3012-16a2-6bc2-2937.res6.spectrum.com. [2603:7000:c01:2716:3012:16a2:6bc2:2937]) by smtp.gmail.com with ESMTPSA id h8-20020ae9ec08000000b0076e672f535asm8992682qkg.57.2023.10.02.08.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 08:36:07 -0700 (PDT) Date: Mon, 2 Oct 2023 11:36:06 -0400 From: Johannes Weiner To: Michal Hocko Cc: Mike Kravetz , Nhat Pham , akpm@linux-foundation.org, riel@surriel.com, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, shuah@kernel.org, yosryahmed@google.com, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH 0/2] hugetlb memcg accounting Message-ID: <20231002153606.GB5054@cmpxchg.org> References: <20230926194949.2637078-1-nphamcs@gmail.com> <20230927184738.GC365513@cmpxchg.org> <20231001232730.GA11194@monkey> <20231002144250.GA4414@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 688E418001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: aqz1cm473e99at6du5w8ecwgc1to7dak X-HE-Tag: 1696260968-421951 X-HE-Meta: U2FsdGVkX1/NJoovigcatAikTpQWn+xawYHPza5BK+qeAhZbsLhGIPCV0K5EGj4Q6k4ZdStotMrRcHiRPIPxqT45qs0p01DNi2RAsxTPH9cqUVgnVSAq/f7Fp93PJa8aD/24we+ZN9M0s27szr7YHl2NugvN8N+kU4ygg5OBnSFmMAmkdf5Zbm0L9e9bt6npyUW9jpslSS1IwMOrAxzQGXEewMi7lKqbc8bp6Mxamppd7ThbqQHbRNLlI4k8lw+GhII852c5zK7AgoFri7cMmaI25/+bD9d7tGXP9J71VJ4bUnP7mWDd6knX8AMWX9/D5jC19GHVNT7Xi12nS926pXJ6z7kHtMZ66liX5LUbjZzyVsqpqIBh40lTP2DHg+P8SosWpOHj4fRiTlxaGHNLVYyRtAkdtl/mfLkqyUMexfbJQb7kupaEDy/BkS2d2PShV8DEFXsHOjRlkzbVsXi08cUfWyWfEItd0fhGjmmVm2PN/hfRU0n+LHjNYu8wLvgfqMYaXloS4szieDAJtrDXYd5o2j7WrQyWDf1+n9mfrexuDsMkWqjmXbt+ZJv2PwSruq3odH2OTb9jYAVUuvfX9HNgPZC/gH2yZv0pxoi7Z2sjp7sKGKCbf8f0cb955OZsgI+6G+3GFHJKsNcevuK/7N3txRew1n1CkkYpBcSlFa4QqWScJkE+sxYtIULKAHxoSJU9C5FGICkPcmbYzPbGAkvliZkGg5NJjej8S5phDbpyeYCVlrFqhZlTMy7LceT+sb4/ws2TVq20s490Ll61ivWunmEnRo//Ry/jDYxcovBFBUm5ZDFGKtVWGQaHWCzSnTOLQ4FuYCStdn5znk5h8rxAvvK/sGMfQG/QhytqFLzbg9tsVaM6jycikAtUkDY5OVGDSvpRAW03Vvy51U75Tc6OniAtQO3Pi7A6QVZWNsN/3c18uHctyzj1pTWoCN4NP0jWPu03Z/Dyt8UbtaY lQBSODsm VlQ7mQLXUD88tAxofTdEOJpMsWcCdYzod61TQSvpENZ914CqGkE5nBbSM2FjUWgf0S0/4vq52I9YxXCCyh3b5W7+ckrGkQinZ+lW1MuyiZiuh//DJ46Qg5z4cPC79vACypBxXr7jgc5vKDkoHetoyLot/eYCGt1XX2nO91Xv4oT4EjiB+4cQ5iqjrdodWoCCd9DS/tk0kRKzQJSXFZL7sD2uuM+cafDfg95jRxXLF+kvK6sOjZFX6+3GdUWLIGJl+tzgp85lCoJPazzxMmOXfvvDgi5nslvz2Z4bJR9hwhQpLVStTQOt96Vs5H/IMXryS6rWwLl2Mo3kLYkJ4RujpmPDIHhrkIoRSna7DI/s7Z3rMbVU5zFEU9LkI/vihnpxOKry7EsNEciN2eBQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 02, 2023 at 04:58:21PM +0200, Michal Hocko wrote: > Also there is not OOM as hugetlb pages are costly requests and we do not > invoke the oom killer. Ah good point. That seems like a policy choice we could make. However, since hugetlb users are already set up for and come to expect SIGBUS for physical failure as well as hugetlb_cgroup limits, we should have memcg follow established precedent and leave the OOM killer out. Agree that a sentence in the changelog about this makes sense though.