From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B1C7E784BE for ; Mon, 2 Oct 2023 14:58:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 070E66B019F; Mon, 2 Oct 2023 10:58:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 020636B01A1; Mon, 2 Oct 2023 10:58:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2B516B01A2; Mon, 2 Oct 2023 10:58:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D1A576B019F for ; Mon, 2 Oct 2023 10:58:36 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7EAA31602F0 for ; Mon, 2 Oct 2023 14:58:36 +0000 (UTC) X-FDA: 81300827832.27.A41259D Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf27.hostedemail.com (Postfix) with ESMTP id 6DC1B4001C for ; Mon, 2 Oct 2023 14:58:34 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=wyMqLYDf; spf=pass (imf27.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.46 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696258714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1sFWixVT1aJ1xZnbcfQwd2hXqQRNB5cMO+e1QJYiddA=; b=4J1wltRmmP961DuY0MikdOtYzrrUw7KF53gUlZTeR/FKYkafgtrbLuD7yb7FvFVE0WRoK2 WY+ruTcmypaErsxUschZsjIzjeqXEZV5r5ooFiptfZHmBcXOdbZUmcr5LGB92CMucaEvwI tSb/TZKaINTk8uprFytir8Qc3CXNoCE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696258714; a=rsa-sha256; cv=none; b=CQEd5UXbCtsmi3enYobUORx+D39XswNdEHIzFzFxDLTwSNAsGDod6THXw2KYpjSDKr6AU3 fHg1hjscoxsY4HVGdT2DtqGz7fuS+jNid8EOifMm/BcTMUnNv/fSTfUfcGvnsPKmht9Zk7 zlE495BYwCyKgdhmg5+ZutUlZnqGBLc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=wyMqLYDf; spf=pass (imf27.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.46 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-66437c96caeso17186066d6.3 for ; Mon, 02 Oct 2023 07:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1696258713; x=1696863513; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1sFWixVT1aJ1xZnbcfQwd2hXqQRNB5cMO+e1QJYiddA=; b=wyMqLYDfWQZ1Oq9nS6/nJWVY8VuAV7zIf1Y5jaQAen+8FBGUxbeuV4U8/9JmLKbbtO uvZC4+q+omkVyOnV60CCEetFDZ3xO9Dze8j6CIBeLzNvy6QvIYjtwg1rIOsN9e4fo5Zd xq6AT1Lv+XVWVtV6jBNfCTKvS8NYU/q7878UX+W0P8OaZavGJ0GXBN79/RqISpvy1FQj 5aNGol/f1HkusZgfATBaygxlg83uM8xLbcExeku1zP5kjgo05RpRJmr7jm90sXPn+a7X YzEBNQw1njUnRA5vCxAFBZldHgOfCzBARlUnWfKpLtlWmVaPnU55ly3HZU4WXeNsHLtT p9Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696258713; x=1696863513; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1sFWixVT1aJ1xZnbcfQwd2hXqQRNB5cMO+e1QJYiddA=; b=BdfGG9KMJJyIFOiMuTVnl28K7QcWyA+Jgc3jZjVNV5iz8+eEumU9b36jYU0WSvSfPX o7HE5ZaSQv8+YX/+l1/YVpuWxpbS1mqr1wDp7Y07Cyn2ciZk4V68VO2jIvM1w+ZMniqb Vg7bOZG1U8LylcNX1AzeaTxQr2lEhala5BJ4y0xmUM9IhIKBh+RrPVTFp9xnTyJo/iCl WCmw43/AKENvlC4DrKkGePJ3+4ZrV5z/J+PpUpFLRqsuzOaF0E+G183RyDEm/g+lzdk6 HEVd82YZiKeiQPlw1eT8GOocVyzIvlKGvP8eGjvTD2wkUqx8z5wampCFA0QI6mduQ5kh Bpzw== X-Gm-Message-State: AOJu0Yxk+28bQWhS78BQEGl0qy7pK/BnjphnDRJSac1W9HPHNQTc+PJ/ ERMgJG8x34Glbp4Q8gyqJ9jA5Q== X-Google-Smtp-Source: AGHT+IEYMyB6kO3EaICU1eCypYWYXZYQCfEUvn2XQ+5lFcitH6GpMhzkUOZ5TPGoksk8znqkDZF4+w== X-Received: by 2002:a0c:c302:0:b0:65a:f9f3:e779 with SMTP id f2-20020a0cc302000000b0065af9f3e779mr11660343qvi.34.1696258713315; Mon, 02 Oct 2023 07:58:33 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-3012-16a2-6bc2-2937.res6.spectrum.com. [2603:7000:c01:2716:3012:16a2:6bc2:2937]) by smtp.gmail.com with ESMTPSA id t9-20020a0cde09000000b0065d0dcc28e3sm3440408qvk.73.2023.10.02.07.58.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 07:58:33 -0700 (PDT) Date: Mon, 2 Oct 2023 10:58:32 -0400 From: Johannes Weiner To: "Huang, Ying" Cc: Andrew Morton , Vlastimil Babka , Mel Gorman , Miaohe Lin , Kefeng Wang , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] mm: page_alloc: remove pcppage migratetype caching Message-ID: <20231002145832.GC4414@cmpxchg.org> References: <20230911195023.247694-1-hannes@cmpxchg.org> <20230911195023.247694-2-hannes@cmpxchg.org> <87y1gsrx32.fsf@yhuang6-desk2.ccr.corp.intel.com> <20230927145115.GA365513@cmpxchg.org> <87pm20p9ra.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pm20p9ra.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Rspamd-Queue-Id: 6DC1B4001C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: t919yp4h5aharohz8q16iyog6x9myr48 X-HE-Tag: 1696258714-765763 X-HE-Meta: U2FsdGVkX18WwIuCcZMUON8fpLPng5eK6KVfwpSqV6KvhcKSQPZR3P76WbhD6OTHnZcAZHajOycg89OTZh9sx9wH8hwJcdPwz1dBOX9jiq624KVVx4esDsQhb1GbJntr3CbC6NOZQy5ODY9sUdNceIlpdcJTNF94QCAyWfcmYE0ZVqis/eXQriJOnnvqE0g1TwCP4KiUgTlMzKU8+Phe1vRuAa1Zvcx0PTrx2/hyUwuzzVwXcjjBJprj/gAt7e1ClHIl9jIPktKPbS486++Ph/2TNKyYaCrcEHazmi4Y0LhNZlELRmNWF/yFZuxBmzjobQ7dNsuxGLo5POG1R9+Y6JMjfJi/KPpojAMXH9OVq9kWgVrwpRrWmZxdO8T6KDJRDoQ7u7Qv29VMzqBa2JiaKdHnwfR5btNkZCYDR3047REuzKD98U1rfGE3XdIzyny+ftDRA8vDustoe63SlRJEGbsFwmkaQ5If0wtNxaBwBDIPSXZ2ixRBPi6k6x5L/KwX1q8X4nlgQTFH33hPc4lUVu9T28kRxGg1Pa20FYylVG0fi/fFcxJwedENpOiCvCb8w9Sd3ZPGmejQQqLCJfnpkyXAkDyB0uktbhwWp3DXYf3pbkkiJw5zqTygIaqMiCRjYIGXrqsc41IYfAs1Ry2UL1FW5lwWNWmBqpB51oh5yx2FXGpuF8JDIJYbWSBhd1jmzKSLX9+a03FJYNn0vMOYmbn076c2CqIzWnl5xE56BZVKF8um/QqEBvV+00+ccXJYtGsdBK6WHfPvDoFIo7ucrAaz80oX9SMw/1UBdBY8KRUp1uE9SEDGZnb3sRYwwrE64vD7BiVrFF9aRwHmelPu0K3a9TOAb6qLibDX/7BMchNj3HmH6XJh7R7tYAtQlKzxonp4h6wLPOVvgU7OmQz1/L7Aafl7t7r7RkmgL1WqJ2I4y7GkmwewrOSnRPTqmACl8hBfQL5F7Oa0fp+MNBc oGXty5y8 EMGiSsQjxe3d02O9t+EATY9ha1gEWNh2WNs8LF2UAqg6y60aJBatsh7CkswM9p8sg0uebSTHpDsHWRKPL4uhA259EP4frOTRchaPY9Qp/GxD1cE/Mq5ggmDafwQAr8d5IndVGoaiVnr6pH7/w3+OybTI8xXzfCl4/kzSh6LEvjTisj+U51/SmwP73XQ8cy4No37sJCI7MH8qWg/QyOZeGXkyjtE2gH05v3CCSjaXYbEkk+A3wKpReSoHOyLf9ss9E2zoCT+vH2b4aHYOhOWlTxubHudo9orztN6ds7S/3U5EGBGV79Z1E70eY4Qh1BQ7AdhNI+FApYOLnreMVvst7Am9PGiNf0yS7LxQMlFAnaIAwk8slsdMhaf9rd0s2hbLlUPbz8vTHqofaFi6tbYegBGkIc7mIQ+hfg2jt5okATFLkgrtY/4TomtXcIB+sZ4n5RVww X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Sep 30, 2023 at 12:26:01PM +0800, Huang, Ying wrote: > I have done more test for the series and addon patches. The test > results are as follows, > > base > perf-profile.children.get_pfnblock_flags_mask 0.15 (+- 32.62%) > will-it-scale.1.processes 618621.7 (+- 0.18%) > > mm: page_alloc: remove pcppage migratetype caching > perf-profile.children.get_pfnblock_flags_mask 0.40 (+- 21.55%) > will-it-scale.1.processes 616350.3 (+- 0.27%) > > mm: page_alloc: fix up block types when merging compatible blocks > perf-profile.children.get_pfnblock_flags_mask 0.36 (+- 8.36%) > will-it-scale.1.processes 617121.0 (+- 0.17%) > > mm: page_alloc: move free pages when converting block during isolation > perf-profile.children.get_pfnblock_flags_mask 0.36 (+- 15.10%) > will-it-scale.1.processes 615578.0 (+- 0.18%) > > mm: page_alloc: fix move_freepages_block() range error > perf-profile.children.get_pfnblock_flags_mask 0.36 (+- 12.78%) > will-it-scale.1.processes 615364.7 (+- 0.27%) > > mm: page_alloc: fix freelist movement during block conversion > perf-profile.children.get_pfnblock_flags_mask 0.36 (+- 10.52%) > will-it-scale.1.processes 617834.8 (+- 0.52%) > > mm: page_alloc: consolidate free page accounting > perf-profile.children.get_pfnblock_flags_mask 0.39 (+- 8.27%) > will-it-scale.1.processes 621000.0 (+- 0.13%) > > mm: page_alloc: close migratetype race between freeing and stealing > perf-profile.children.get_pfnblock_flags_mask 0.37 (+- 5.87%) > will-it-scale.1.processes 618378.8 (+- 0.17%) > > mm: page_alloc: optimize free_unref_page_list() > perf-profile.children.get_pfnblock_flags_mask 0.20 (+- 14.96%) > will-it-scale.1.processes 618136.3 (+- 0.16%) > > It seems that the will-it-scale score is influenced by some other > factors too. But anyway, the series + addon patches restores the score > of will-it-scale. And the cycles% of get_pfnblock_flags_mask() is > almost restored by the final patch (mm: page_alloc: optimize > free_unref_page_list()). > > Feel free to add my "Tested-by" for these patches. Thanks, I'll add those!