From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B43CE7849A for ; Mon, 2 Oct 2023 11:11:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 041328D001E; Mon, 2 Oct 2023 07:11:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F332E8D0001; Mon, 2 Oct 2023 07:11:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E22228D001E; Mon, 2 Oct 2023 07:11:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CE54F8D0001 for ; Mon, 2 Oct 2023 07:11:56 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AC5E7A0216 for ; Mon, 2 Oct 2023 11:11:56 +0000 (UTC) X-FDA: 81300256632.23.D7503D1 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id C2A741C001B for ; Mon, 2 Oct 2023 11:11:54 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KNWQHKrq; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696245115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zx6TtcCMnOwwVX71i87MAZdUPKBoLfYl77wT1erjQDY=; b=ZFNpEKoIPXarc5mKhKMpFq9dNBTn699jC3dWI/Q5ei2dAz4ef09AT/5UIhixJSA+0a+QYE U3NAS25xvR4NxFMBtHfTMRHoxU/FDIMLqOLA9blYNgsUan0wSZDVuruoXHhEooiPD1Jafx PKyLuJOngY1zbvMz6yPlDwciytO7PZ0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696245115; a=rsa-sha256; cv=none; b=h3eBqNHk1ATb8yTcBxjaaIV+kyFL2oiipijVrf21yRyWhRuMaFuJB4Yqjw6NrjSpw70r8b 0fHNEFn6B1SYGRNmQE/mWJDFJLYI5DT3q1Q9CMhjuuKT6GbmBKgtr4CAj5PWWpklTukCcG MRZI8sffO2TDcWJe7Fh2MevrD2yj/+k= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KNWQHKrq; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id C310CB80E5C; Mon, 2 Oct 2023 11:11:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B33FBC433CB; Mon, 2 Oct 2023 11:11:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696245112; bh=kbkrwKTyIxylaq6Q7PjftUb//yn55MwJY/P5RMw2Ddw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KNWQHKrqVZDQP0mmpkxARDUq+RNr6KswvMEDjZDX4RVENMK8hvS9EUzVFtndr8B2y rBSxbYVgClaPoG4LUz/4glx4iD/b/wxCWNh1O7GEH5+2g7Hx5iNXETPVqKhQNzjpko sEuRciF/UNG5g5YUROS4Nd56PyxAbmjeaOqAwEBSHp2wleTnp8PiO2aY5I6WeidB8d fEYpj3Q+mcTKf751o+R4yMdR/fGEsCrqA5Xx3tB2UJxb7ZFVBOdf3jR2p/zOugFx8a A36bF0lBnIyZcQ4tpDfEZF2xLrXv/oJdgzf9IelJ9XeBC33/nFHAMxNbAPEtHqV923 8No7Txsv48EDw== Date: Mon, 2 Oct 2023 14:10:51 +0300 From: Mike Rapoport To: David Hildenbrand Cc: Yajun Deng , akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] mm: Init page count in reserve_bootmem_region when MEMINIT_EARLY Message-ID: <20231002111051.GA3303@kernel.org> References: <20230928083302.386202-1-yajun.deng@linux.dev> <20230928083302.386202-3-yajun.deng@linux.dev> <20230929083018.GU3303@kernel.org> <20230929100252.GW3303@kernel.org> <15233624-f32e-172e-b2f6-7ca7bffbc96d@linux.dev> <20231001185934.GX3303@kernel.org> <90342474-432a-9fe3-2f11-915a04f0053f@linux.dev> <20231002084708.GZ3303@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: 134cbqko5fgc5y19niyiruihzdeycy95 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C2A741C001B X-Rspam-User: X-HE-Tag: 1696245114-25000 X-HE-Meta: U2FsdGVkX18nVVRiJFr9etPRm91ddvE2nTTgRWcnefDRDbk2/iFBVLGGC5gMb3BwcvBXyw8QrLoIJc2yiCcrjKSHNWW83djLLzJQYwPXFJB67go/7MWpnILt/4MILqx4ABBlYAv34PzlwBda78XcB4JOfZc6O4JWffMaPZtBYGY81HcSrmZ8vVb0a7tr5mXYziKY9lb9PQStPX4MRegKmoNceNLplpWZtqw3+WdydSahdauodyNpFsxTNctpAhe/GW8/cEthmbquV+QbtKK3IcXkm5adaA/UGr03jtb4VF/VTjkINvrDhkXoOYg2suIjrDFkZZQdnFd1a3SbkKqnQNMY+AzEqDjmmIsjULh0jJv4/XhD6rpn8IBeG2LW2Sm9r6E4IOeGbgxX3hMrL5gHqNq2239BwHUTQBethRthBjrYuqD9r2t3ziTxw737OvSw3OIj5sItSGRksORZh7EOX1V2R7pt++FhMccX9VWcQ/t+DmPTpBs2MKEveFtuIK/wsb3s7bk8fBMy06WbTqCSZ47fCpiDoeViEm4A/7m8FjmJ7nBkFMhoi7Te2MN2YU68qbGw8hwJnq3lG7rINKU0fwy008L//vdzycuNMiYasZCF7BYAhG8Hsi3M1yk91bvyZgwBR96LvX3GE7wSnCdUHI2nkIm0ke+5aE3WI/iyjVC0Wf6jtgSnb6jrJJ3E5BbxpLlAQMiDsdJNQsGluF93QBYcpmn6F6lJ8peOCJyM1hCEzz9WRXGXkMYF3XIEDCNxt+diTeps0EQwQjW2dY7hXYsetj5rbjCHtl9bI+P9jr9n6nXm2qN3vrJCYC1X7cApxejhP7o/kQUeJhldSC/FFzy1jI7i63T4+rq7X9HprCRGwTspylESgT/icm1/A0l3mUJN3Z+AXQXImaxIXaptIznHAatVKgsnk87kbG6t4cTe21j2GKyAraZseA/OvgYWELNZWH06fCUAev9e6nw ZY4qFJUV U6vEs+ihmF21eSfGmQ7nB1zUgQ1OYRMqDZ0L4Sey55vE5g9SmMWm9haSV/p7MtkAHyPTV2mhHY/1NeOIElJCrK+10ui8Ja6Oqba3xQoI2Ta6J4xBd1SqQuhqjzR+BV0xA7KgPqr0eoriClzJP3pid1/WScRNpzTuAqzHuraeUL0r7DM4/bns9vDus++3swuWpWVRMy4JE9atTa6CegkT7bNkS34AZ+bYWK4DvzXVdZVQBkdaZ3gzv5G8DuQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 02, 2023 at 10:56:51AM +0200, David Hildenbrand wrote: > On 02.10.23 10:47, Mike Rapoport wrote: > > On Mon, Oct 02, 2023 at 03:03:56PM +0800, Yajun Deng wrote: > > > > > > On 2023/10/2 02:59, Mike Rapoport wrote: > > > > On Fri, Sep 29, 2023 at 06:27:25PM +0800, Yajun Deng wrote: > > > > > On 2023/9/29 18:02, Mike Rapoport wrote: > > > > > > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > > > > > > > > index 06be8821d833..b868caabe8dc 100644 > > > > > > > > > --- a/mm/page_alloc.c > > > > > > > > > +++ b/mm/page_alloc.c > > > > > > > > > @@ -1285,18 +1285,22 @@ void __free_pages_core(struct page *page, unsigned int order) > > > > > > > > > unsigned int loop; > > > > > > > > > /* > > > > > > > > > - * When initializing the memmap, __init_single_page() sets the refcount > > > > > > > > > - * of all pages to 1 ("allocated"/"not free"). We have to set the > > > > > > > > > - * refcount of all involved pages to 0. > > > > > > > > > + * When initializing the memmap, memmap_init_range sets the refcount > > > > > > > > > + * of all pages to 1 ("reserved" and "free") in hotplug context. We > > > > > > > > > + * have to set the refcount of all involved pages to 0. Otherwise, > > > > > > > > > + * we don't do it, as reserve_bootmem_region only set the refcount on > > > > > > > > > + * reserve region ("reserved") in early context. > > > > > > > > > */ > > > > > > > > Again, why hotplug and early init should be different? > > > > > > > I will add a comment that describes it will save boot time. > > > > > > But why do we need initialize struct pages differently at boot time vs > > > > > > memory hotplug? > > > > > > Is there a reason memory hotplug cannot have page count set to 0 just like > > > > > > for pages reserved at boot time? > > > > > This patch just save boot time in MEMINIT_EARLY. If someone finds out that > > > > > it can save time in > > > > > > > > > > MEMINIT_HOTPLUG, I think it can be done in another patch later. I just > > > > > keeping it in the same. > > > > But it's not the same. It becomes slower after your patch and the code that > > > > frees the pages for MEMINIT_EARLY and MEMINIT_HOTPLUG becomes non-uniform > > > > for no apparent reason. > > > > > > __free_pages_core will also be called by others, such as: > > > deferred_free_range, do_collection and memblock_free_late. > > > > > > We couldn't remove  'if (page_count(page))' even if we set page count to 0 > > > when MEMINIT_HOTPLUG. > > > > That 'if' breaks the invariant that __free_pages_core is always called for > > pages with initialized page count. Adding it may lead to subtle bugs and > > random memory corruption so we don't want to add it at the first place. > > As long as we have to special-case memory hotplug, we know that we are > always coming via generic_online_page() in that case. We could either move > some logic over there, or let __free_pages_core() know what it should do. Looks like the patch rather special cases MEMINIT_EARLY, although I didn't check throughfully other code paths. Anyway, relying on page_count() to be correct in different ways for different callers of __free_pages_core() does not sound right to me. > -- > Cheers, > > David / dhildenb > -- Sincerely yours, Mike.