From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E3F6E7849A for ; Mon, 2 Oct 2023 07:57:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECCBC8D000D; Mon, 2 Oct 2023 03:57:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7B1D8D0001; Mon, 2 Oct 2023 03:57:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1BB08D000D; Mon, 2 Oct 2023 03:57:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BF2078D0001 for ; Mon, 2 Oct 2023 03:57:37 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 799EFB36FB for ; Mon, 2 Oct 2023 07:57:37 +0000 (UTC) X-FDA: 81299766954.12.F68E974 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf15.hostedemail.com (Postfix) with ESMTP id 32FCDA0017 for ; Mon, 2 Oct 2023 07:57:34 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AelUG9FS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4yX5F6ZD; dmarc=none; spf=pass (imf15.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696233455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HRtvvsbDRmaIGA2qlEwuFNnN4SG9to1RwhMyTnDS1Ek=; b=iS01+NNCebt3NVutGRszv94bN0WvZXaewycpxp2aVDivrpTWH7NwG0CnIb0D30cn1jxvN8 FCVBdmjbUj5LuIZJ2vLMwl3Rwwkt3B+468lBn2Jt6MtO2yt39f8X/50+jsu0QEyunoCpIi npEyx0G3JEdjMIwPBi6QNtKUF2vvANE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AelUG9FS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4yX5F6ZD; dmarc=none; spf=pass (imf15.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696233455; a=rsa-sha256; cv=none; b=qSs3mCoYoFDAjXPGRxsfBnaYYA4oS6jO/yj2gE9ezxcimXDf1jKx/VS+vWPMsX1gir1n4R Q6JJZHEY2xlXnyoor0UOfyA1SlvM37Jtrglqri3sVG1JNDjTH9vPjbSsWEl+AEO65OVGxC rblRX4tUhYgeLlzJU6a7BOxZDfNOATU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AB8121F459; Mon, 2 Oct 2023 07:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1696233452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HRtvvsbDRmaIGA2qlEwuFNnN4SG9to1RwhMyTnDS1Ek=; b=AelUG9FSlQyUcQTA9I9qRJmPzMA6mvk2OLx4Qv2PacqmgU2FkeI54uQfwuwk8GDISDrHf1 K6okkr5Yua+jK8r2TTOukY7745vay4e4z1caiTsHAigkH18O5VWdMY9s+0PKMe8/Ta1ITc H4lySULw9TgNQsjwAFd513U/tj8Iifc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1696233452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HRtvvsbDRmaIGA2qlEwuFNnN4SG9to1RwhMyTnDS1Ek=; b=4yX5F6ZD5YaXQ1SgLuHClpbWfxc1xKg7esoSW59wSh/oO7HSeTROmd590v4TgEevJu81R5 RAceDQWhH8NjA0AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 83FA513434; Mon, 2 Oct 2023 07:57:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JLsgIOx3GmUuEgAAMHmgww (envelope-from ); Mon, 02 Oct 2023 07:57:32 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 27D44A07C9; Mon, 2 Oct 2023 09:57:32 +0200 (CEST) Date: Mon, 2 Oct 2023 09:57:32 +0200 From: Jan Kara To: Christian Brauner Cc: Jan Kara , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH v4 0/29] block: Make blkdev_get_by_*() return handle Message-ID: <20231002075732.4c5oslpabrmw3niz@quack3> References: <20230818123232.2269-1-jack@suse.cz> <20230927-prahlen-reintreten-93706074e58d@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230927-prahlen-reintreten-93706074e58d@brauner> X-Rspamd-Queue-Id: 32FCDA0017 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7hujmojsmb4acx5f5wnwgr7178ob9o5i X-HE-Tag: 1696233454-394852 X-HE-Meta: U2FsdGVkX1/wEkb5vJ1xLzpKl2lPlfhSD5z3rpvQYuuCwOuo1wvZNokwrPDDSsS+4MN6kjRw3ccL3zL55OLQmnbgszvO4WuCeDp8GQNgsqACVj1AQJbRCimtHOrx9ixTxddcQ8+OrJwou5wfmjm3YvRgh6YTAa+iq/etO1PrHuGa3T+kPtDKfjCo1eZttv3X15xuWPMWRfPGVKXTVdpw/Wkw99rm5Ghwsacra6nfybqX9RaB0MV92dlnC/eJIIEoCfr7YgzRVIha7Zugc0Y5kJKer/gxVLXja/9Hmp5YwK3eAP8yByHfYtiosMs5zEdrD4pNxVTTEP/FqORl5gSn49TJ/aTs0X5AZ0RpzeEJSS5KdvEcJF6U3BQSNHfWX9x2Y9wFvEsbVNSJXXErq+sdlZIAxZqQBscugc6/fZ0cf/GSCXBAIxKuOAqZADegjsosQ/oB9qPPejfI3BC86b3o0aL3Zy9tiNzgiRiljhywolQ1OOGplUujpEfjZKAKpPTzEfxHlBHeTUjxu9l9g/gQx+ZUvPjuMkReYUZr+RiFj79rrgo1udETtBxpbE9jh+M+ryJJUitWl/c6BfRRUfUppCNbR+CyXlrP+Gm7XvKFX14T4wIp1x9GNbZ1q4oivwheyZOC+7R8wvMemJRdYgvXpyxh/Zbz8q/nxFfP2iof9afZbweOaf5NWgh8catPVcIhi9U1/yWheXY+X9edFx8JbWTvuE9my0QhDErBLlvDvPYZOqXwkr/RBbcvTXAAYmESeiilknZ0juDOH8RdsLo3QX3BjLg7J/XSY+0GkuxLlDB03rCtYHdwUl4++5YwqGwnQWw7OGiEj2EmBYNBsfiRUkD7Sf/uzi8uon/UtCDXcQDY0I0+xulQ4W4kBmtC1tbzN+WcgntdvdDuPyizFJ8wYEnVc4TFpBFrekpJSvyaaFlhLqcxHmTckGB/p5iaDZskrNDQg3tMDIXThQksqYH X/glm9J+ DV195rYRPOtTuCE9NkScFOVvOJGPN5NOldMGKVeVN5u/F31bhLUU4QSdkauFsTIlOsZt4MtwMm8r2EKpQknzfjbIAahKhyEOVnDflsR9pGOBMSoU+KWsiqtrjX7GmgskDa9gB1pcNe546wvxn5Jvl5WeFb8KqELaOcQ5chmPrC6Y5DeoRXScpxpT3vgV3sVqq4zAxTqKDdGtK9Z/iwmBJcCBClQlIk9RJJhTZ3/M6tmmJa6p4GVDmfwKVisbxjhvNPW9p7/fcbKTzxDY3teecBVkM+NMng84dnMGgpi4/tClEU8VMAd9/coTXpnl518lKoRiDChp1qncw9tSxQQLUKxeRrmwHZ1dlRgcRx1mcY3Ib42PZmR8vf/LZJqZOjWU1L77IkI4H0NWC189+tib7TUoIqY85D6spQ2dHzpqaDpP5tglZcQkz8FkMWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 27-09-23 18:21:19, Christian Brauner wrote: > On Wed, 27 Sep 2023 11:34:07 +0200, Jan Kara wrote: > > Create struct bdev_handle that contains all parameters that need to be > > passed to blkdev_put() and provide bdev_open_* functions that return > > this structure instead of plain bdev pointer. This will eventually allow > > us to pass one more argument to blkdev_put() (renamed to bdev_release()) > > without too much hassle. > > > > > > [...] > > > to ease review / testing. Christian, can you pull the patches to your tree > > to get some exposure in linux-next as well? Thanks! > > Yep. So I did it slighly differently. I pulled in the btrfs prereqs and > then applied your series on top of it so we get all the Link: tags right. > I'm running tests right now. Please double-check. Thanks for picking patches up! I've checked the branch and it looks good to me. Honza > > --- > > Applied to the vfs.super branch of the vfs/vfs.git tree. > Patches in the vfs.super branch should appear in linux-next soon. > > Please report any outstanding bugs that were missed during review in a > new review to the original patch series allowing us to drop it. > > It's encouraged to provide Acked-bys and Reviewed-bys even though the > patch has now been applied. If possible patch trailers will be updated. > > Note that commit hashes shown below are subject to change due to rebase, > trailer updates or similar. If in doubt, please check the listed branch. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git > branch: vfs.super > > [01/29] block: Provide bdev_open_* functions > https://git.kernel.org/vfs/vfs/c/b7c828aa0b3c > [02/29] block: Use bdev_open_by_dev() in blkdev_open() > https://git.kernel.org/vfs/vfs/c/d4e36f27b45a > [03/29] block: Use bdev_open_by_dev() in disk_scan_partitions() and blkdev_bszset() > https://git.kernel.org/vfs/vfs/c/5f9bd6764c7a > [04/29] drdb: Convert to use bdev_open_by_path() > https://git.kernel.org/vfs/vfs/c/0220ca8e443d > [05/29] pktcdvd: Convert to bdev_open_by_dev() > https://git.kernel.org/vfs/vfs/c/7af10b889789 > [06/29] rnbd-srv: Convert to use bdev_open_by_path() > https://git.kernel.org/vfs/vfs/c/3d27892a4be7 > [07/29] xen/blkback: Convert to bdev_open_by_dev() > https://git.kernel.org/vfs/vfs/c/26afb0ed10b3 > [08/29] zram: Convert to use bdev_open_by_dev() > https://git.kernel.org/vfs/vfs/c/efc8e3f4c6dc > [09/29] bcache: Convert to bdev_open_by_path() > https://git.kernel.org/vfs/vfs/c/dc893f51d24a > [10/29] dm: Convert to bdev_open_by_dev() > https://git.kernel.org/vfs/vfs/c/80c2267c6d07 > [11/29] md: Convert to bdev_open_by_dev() > https://git.kernel.org/vfs/vfs/c/15db36126ca6 > [12/29] mtd: block2mtd: Convert to bdev_open_by_dev/path() > https://git.kernel.org/vfs/vfs/c/4c27234bf3ce > [13/29] nvmet: Convert to bdev_open_by_path() > https://git.kernel.org/vfs/vfs/c/70cffddcc300 > [14/29] s390/dasd: Convert to bdev_open_by_path() > https://git.kernel.org/vfs/vfs/c/5581d03457f8 > [15/29] scsi: target: Convert to bdev_open_by_path() > https://git.kernel.org/vfs/vfs/c/43de7d844d47 > [16/29] PM: hibernate: Convert to bdev_open_by_dev() > https://git.kernel.org/vfs/vfs/c/105ea4a2fd18 > [17/29] PM: hibernate: Drop unused snapshot_test argument > https://git.kernel.org/vfs/vfs/c/b589a66e3688 > [18/29] mm/swap: Convert to use bdev_open_by_dev() > https://git.kernel.org/vfs/vfs/c/615af8e29233 > [19/29] fs: Convert to bdev_open_by_dev() > https://git.kernel.org/vfs/vfs/c/5173192bcfe6 > [20/29] btrfs: Convert to bdev_open_by_path() > https://git.kernel.org/vfs/vfs/c/8cf64782764f > [21/29] erofs: Convert to use bdev_open_by_path() > https://git.kernel.org/vfs/vfs/c/4d41880bf249 > [22/29] ext4: Convert to bdev_open_by_dev() > https://git.kernel.org/vfs/vfs/c/f7507612395e > [23/29] f2fs: Convert to bdev_open_by_dev/path() > https://git.kernel.org/vfs/vfs/c/d9ff8e3b6498 > [24/29] jfs: Convert to bdev_open_by_dev() > https://git.kernel.org/vfs/vfs/c/459dc6376338 > [25/29] nfs/blocklayout: Convert to use bdev_open_by_dev/path() > https://git.kernel.org/vfs/vfs/c/5b1df9a40929 > [26/29] ocfs2: Convert to use bdev_open_by_dev() > https://git.kernel.org/vfs/vfs/c/b6b95acbd943 > [27/29] reiserfs: Convert to bdev_open_by_dev/path() > https://git.kernel.org/vfs/vfs/c/7e3615ff6119 > [28/29] xfs: Convert to bdev_open_by_path() > https://git.kernel.org/vfs/vfs/c/176ccb99e207 > [29/29] block: Remove blkdev_get_by_*() functions > https://git.kernel.org/vfs/vfs/c/953863a5a2ff -- Jan Kara SUSE Labs, CR