From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7700E784AD for ; Mon, 2 Oct 2023 04:52:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0ADDB6B0190; Mon, 2 Oct 2023 00:52:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05DE26B0194; Mon, 2 Oct 2023 00:52:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E67B76B0195; Mon, 2 Oct 2023 00:52:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CA3B56B0190 for ; Mon, 2 Oct 2023 00:52:27 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8ABF11A0115 for ; Mon, 2 Oct 2023 04:52:27 +0000 (UTC) X-FDA: 81299300334.28.0FD90CD Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf24.hostedemail.com (Postfix) with ESMTP id B743D180002 for ; Mon, 2 Oct 2023 04:52:25 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=j78bsHYO; spf=pass (imf24.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696222345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vgZc1gl8r9gpj8F7Au1ygxE46XZZIEmRRHjiEVQPVBA=; b=VIMRRDkulPlgz63ph7pIjaosvnt6gwCrX1LlNH3228v6klmFWt4JmlBZvKCcFiJtPvScJR DzqOfDdmcIM61LfuLWtIiVn+qMlnfoKkSAZj2JxIfJR8oQ7xwgAgRJ625e8vyOK/cAb7X+ Pskpgbn/NLk9j9CppO1M6Af6kxQVCEk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696222345; a=rsa-sha256; cv=none; b=4RpWwvuRFgkUuB8psagLX8Y0b7CzH7/cLVN3ZggRmo5Q35b8xTz6PjovYXzkxlNUl4LV6P /JKOXoXj7HrxXNKRPispD1CQz7VIXrLrOjf76Ff/S6TYnX5TmeWR49CRbIfb+Uc6hmvXjH coXhLky3ndvPGpdTLc2PqaHwwMsZjHU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=j78bsHYO; spf=pass (imf24.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1c7373cff01so17795365ad.1 for ; Sun, 01 Oct 2023 21:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696222344; x=1696827144; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vgZc1gl8r9gpj8F7Au1ygxE46XZZIEmRRHjiEVQPVBA=; b=j78bsHYOW6jqe3srrPvVMkkVdi9z+pj9427AZqE+eV8GZsRtZ7EbgG7/Gh0xR5d/Mc TRlyUGkFyiRhs/6TDxq3y20+/NrUv6AJNPjjKxUYXn3VBwslaTEVoY7nBSMT8VDJv8cR YqDeUM2MOzy5CfEsyc13pff0m+NuroRoUz7cA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696222344; x=1696827144; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vgZc1gl8r9gpj8F7Au1ygxE46XZZIEmRRHjiEVQPVBA=; b=AtHMhd+0yJGslqQkZe9qCl3ShM5y1mbFqmLJ8HWJz9TVqIGiUsuGUwrkkjFyWwtzcO o2v4EBKpSMgVVpTCH1TD3+fW7r4BeFtfhzc5vBzFu/C6SLGvILAE7h6EA/0JJOolvhOT 4M//4yUR2082X+EWL1LzL0sRCQLzAVscZLmtzsUepC+xlPGvn4uMR/knps332TVyL1E7 5UIAwmdWNHLZlpV8HBFe7+74z7F9eTlVQAwdYT71v6nILgPwbFAEvqEL1/k+19Pk4NF5 K38lSIBamwbjmEdmojvzMI/Zz5fT1JMDhRLnjvCX2Fij4a/ga9dJB9Nj1An0FhBRzYzN o3PA== X-Gm-Message-State: AOJu0YwtlewnBvOQlef87SfdxFx7TcuPKiMvPbemp5D/YlYZSTdPY+0Y xU5+77gDZdFwMjvhKAT3csqrMQ== X-Google-Smtp-Source: AGHT+IEoCHeBBwDUL5/duEukBlE8ayroCrMSrtJAST1F9vN+5909TzVhFCg4Lq92qLJoTTJZW7Qzsg== X-Received: by 2002:a17:902:e54a:b0:1c5:6f4d:d6dd with SMTP id n10-20020a170902e54a00b001c56f4dd6ddmr18858004plf.24.1696222344309; Sun, 01 Oct 2023 21:52:24 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id b18-20020a170902d31200b001b03a1a3151sm9883404plc.70.2023.10.01.21.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 21:52:23 -0700 (PDT) Date: Sun, 1 Oct 2023 21:52:22 -0700 From: Kees Cook To: Kent Overstreet Cc: Andrew Morton , Brian Foster , kernel test robot , Linux Memory Management List , linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [linux-next:master] BUILD REGRESSION df964ce9ef9fea10cf131bf6bad8658fde7956f6 Message-ID: <202310012150.72AAB06FAD@keescook> References: <202309301308.d22sJdaF-lkp@intel.com> <202309301403.82201B0A@keescook> <20231002032239.t7ghpigbq5jy3ng7@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231002032239.t7ghpigbq5jy3ng7@moria.home.lan> X-Rspamd-Queue-Id: B743D180002 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: bwyks9jxwpjcbj3yyurr55xdf6exofot X-HE-Tag: 1696222345-850456 X-HE-Meta: U2FsdGVkX18r2pZkFClfRfjH7itLTaIJsZYtIz+07YmO+Hn6RuWvGDA9PDBnuVABCqidWS9Ru0i5Ez1Zf6eeC0Il/Uw+M9eO2RNivVnRxOTjlLhKwksyrCNLxLI9ba154YRtGQiBj2BCRMlsvlukk7T1CaDPyvChFAq1IHfmpeqcA6ea8HUg1tE6zziWMxUa0vn45lG/2LB9k371NsCr191elP8CRN6zAoIuXdSe79mcRCwwShzFrsYOZsA22K+wEBhYCggz1cVF4JRMTnEoSSW8aAIKMqtVKalgAJGOJgeUsl6veaeAQ5WA082DWJ01gX3OaemGqEpftmLFZy0HZp3WTA7PQutDWoACXOQ695TAMldbGkVxf++yD1rNDCKZW8P2Tnabw6rJCMdJye+kCYlcann0jRV8uoymQ/iPQTrujAUPe8EAtqBabYU1nl90kx7RaI3QEUDgQdNqEqqZUEilOh7ZmtgD1TDxv5uIdPKWvoZzMrLoNM7DdGLjmdnoyvBKKm4qA/vFATWOqyX3RcUCLMkg19W+3hZ7kojFR1C+fhU0UwDRQVW19wp4C/n92RCnJf+AeM8jmjHISO2Sy1QKOvkKYRDDUZCeggaKBNSJAjILzDOiNkjzvsEasLyjZhLiaZb4WFz5WQ+fg6Il9wxrjQpXOiM80CmXZBURNUKcp6JFqFqruti5AafcI2hrQLLLltIu8bVmbrrd0YWuH9/q7L+nYk3OFiWI3D0EvJHo50Crph1DvpRg1SCnt9o4ge4VftkDTgVlDS3FLolVJYZiMoBOwcx8OSC7Pvk/ejiM8Bo3hlwX6G0wTwTlSTET8FDDpDIzdgCkRk+H+Lh0SL96WTkNs4sWSIEz0u8Of83xtip3TH1BSQw1CcLMYLhhVKte7k0Yu7tyhcGOxkJo9uHVoFusOll+4T94cwF5QLXxrGIAN66t0Gn/61fJlTSbglbwUg7DBda9uofd2Rl YcIg8P3w /koTWjoxbs5wMdbEmuabmM1M5kK3LIODQem0sQjwkHLRU8thnGWvkpN1fkrclKBvhO1UQRMmrjPnsVih9w0qIdohfEgt3g1UuyDvFaAdRaxX3vpmlrLfRDzkIIcj+D43+6zqg4Ca+dgImc8u+FFKJ7gKadCVp36Fkc7U4F/Oq6ZGJAC204Ut/FtXij+Tw/iM6RXdxlVN7yWlFZ2UGbtbYk4cAQIne/iwUVymB7D/zjeP4dpwALkIf368tEVsZJ7Mq5LmNf3tX2uuoKpMq1YaogyLx4mHUMQCC6wwecgE1NVCDCAyq3CwCsaP0ZvQuYTszx+ej6pa2/R0Khjq2mPCmgGsxmycPx2Cwzhhn X-Bogosity: Ham, tests=bogofilter, spamicity=0.411763, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 01, 2023 at 11:22:39PM -0400, Kent Overstreet wrote: > I'm not leaping at the chance to reorganize my fundamental data > structures for this. Yeah, understood. Thanks for taking a look at it! > Can we get such an escape hatch? Sure, please use unsafe_memcpy(), and include a comment on how the sizing has been bounds checked, etc. -- Kees Cook