* [linux-next:master 8148/8790] fs/proc/task_mmu.c:2105:17: error: implicit declaration of function 'pagemap_scan_backout_range'; did you mean 'pagemap_scan_push_range'?
@ 2023-10-01 7:50 kernel test robot
2023-10-01 19:47 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2023-10-01 7:50 UTC (permalink / raw)
To: Andrew Morton
Cc: oe-kbuild-all, Linux Memory Management List, Muhammad Usama Anjum
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: df964ce9ef9fea10cf131bf6bad8658fde7956f6
commit: 588d06cd90cfb015926def2469ab99f3c72a205d [8148/8790] fs-proc-task_mmu-implement-ioctl-to-get-and-optionally-clear-info-about-ptes-fix-2
config: x86_64-randconfig-005-20231001 (https://download.01.org/0day-ci/archive/20231001/202310011545.iHTT4Y7S-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231001/202310011545.iHTT4Y7S-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310011545.iHTT4Y7S-lkp@intel.com/
Note: the linux-next/master HEAD df964ce9ef9fea10cf131bf6bad8658fde7956f6 builds fine.
It may have been fixed somewhere.
All errors (new ones prefixed by >>):
fs/proc/task_mmu.c: In function 'pagemap_scan_thp_entry':
>> fs/proc/task_mmu.c:2105:17: error: implicit declaration of function 'pagemap_scan_backout_range'; did you mean 'pagemap_scan_push_range'? [-Werror=implicit-function-declaration]
2105 | pagemap_scan_backout_range(p, start, end);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| pagemap_scan_push_range
cc1: some warnings being treated as errors
vim +2105 fs/proc/task_mmu.c
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2068
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2069 static int pagemap_scan_thp_entry(pmd_t *pmd, unsigned long start,
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2070 unsigned long end, struct mm_walk *walk)
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2071 {
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2072 #ifdef CONFIG_TRANSPARENT_HUGEPAGE
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2073 struct pagemap_scan_private *p = walk->private;
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2074 struct vm_area_struct *vma = walk->vma;
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2075 unsigned long categories;
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2076 spinlock_t *ptl;
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2077 int ret = 0;
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2078
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2079 ptl = pmd_trans_huge_lock(pmd, vma);
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2080 if (!ptl)
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2081 return -ENOENT;
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2082
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2083 categories = p->cur_vma_category |
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2084 pagemap_thp_category(p, vma, start, *pmd);
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2085
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2086 if (!pagemap_scan_is_interesting_page(categories, p))
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2087 goto out_unlock;
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2088
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2089 ret = pagemap_scan_output(categories, p, start, &end);
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2090 if (start == end)
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2091 goto out_unlock;
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2092
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2093 if (~p->arg.flags & PM_SCAN_WP_MATCHING)
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2094 goto out_unlock;
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2095 if (~categories & PAGE_IS_WRITTEN)
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2096 goto out_unlock;
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2097
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2098 /*
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2099 * Break huge page into small pages if the WP operation
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2100 * needs to be performed on a portion of the huge page.
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2101 */
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2102 if (end != start + HPAGE_SIZE) {
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2103 spin_unlock(ptl);
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2104 split_huge_pmd(vma, pmd, start);
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 @2105 pagemap_scan_backout_range(p, start, end);
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2106 /* Report as if there was no THP */
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2107 return -ENOENT;
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2108 }
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2109
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2110 make_uffd_wp_pmd(vma, start, pmd);
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2111 flush_tlb_range(vma, start, end);
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2112 out_unlock:
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2113 spin_unlock(ptl);
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2114 return ret;
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2115 #else /* !CONFIG_TRANSPARENT_HUGEPAGE */
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2116 return -ENOENT;
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2117 #endif
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2118 }
fef1d15288b455 Muhammad Usama Anjum 2023-08-21 2119
:::::: The code at line 2105 was first introduced by commit
:::::: fef1d15288b455d957cdee6ebf8118b525872bde fs/proc/task_mmu: implement IOCTL to get and optionally clear info about PTEs
:::::: TO: Muhammad Usama Anjum <usama.anjum@collabora.com>
:::::: CC: Andrew Morton <akpm@linux-foundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [linux-next:master 8148/8790] fs/proc/task_mmu.c:2105:17: error: implicit declaration of function 'pagemap_scan_backout_range'; did you mean 'pagemap_scan_push_range'?
2023-10-01 7:50 [linux-next:master 8148/8790] fs/proc/task_mmu.c:2105:17: error: implicit declaration of function 'pagemap_scan_backout_range'; did you mean 'pagemap_scan_push_range'? kernel test robot
@ 2023-10-01 19:47 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2023-10-01 19:47 UTC (permalink / raw)
To: kernel test robot
Cc: oe-kbuild-all, Linux Memory Management List, Muhammad Usama Anjum
On Sun, 1 Oct 2023 15:50:38 +0800 kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: df964ce9ef9fea10cf131bf6bad8658fde7956f6
> commit: 588d06cd90cfb015926def2469ab99f3c72a205d [8148/8790] fs-proc-task_mmu-implement-ioctl-to-get-and-optionally-clear-info-about-ptes-fix-2
> config: x86_64-randconfig-005-20231001 (https://download.01.org/0day-ci/archive/20231001/202310011545.iHTT4Y7S-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231001/202310011545.iHTT4Y7S-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310011545.iHTT4Y7S-lkp@intel.com/
>
> Note: the linux-next/master HEAD df964ce9ef9fea10cf131bf6bad8658fde7956f6 builds fine.
> It may have been fixed somewhere.
>
> All errors (new ones prefixed by >>):
>
> fs/proc/task_mmu.c: In function 'pagemap_scan_thp_entry':
> >> fs/proc/task_mmu.c:2105:17: error: implicit declaration of function 'pagemap_scan_backout_range'; did you mean 'pagemap_scan_push_range'? [-Werror=implicit-function-declaration]
> 2105 | pagemap_scan_backout_range(p, start, end);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> | pagemap_scan_push_range
Thanks. Seems this was fixed in a later fix.
fs-proc-task_mmu-implement-ioctl-to-get-and-optionally-clear-info-about-ptes.patch
fs-proc-task_mmu-implement-ioctl-to-get-and-optionally-clear-info-about-ptes-fix.patch
fs-proc-task_mmu-implement-ioctl-to-get-and-optionally-clear-info-about-ptes-fix-fix.patch
you are here -> fs-proc-task_mmu-implement-ioctl-to-get-and-optionally-clear-info-about-ptes-fix-2.patch
fs-proc-task_mmu-implement-ioctl-to-get-and-optionally-clear-info-about-ptes-fix-3.patch
fs-proc-task_mmu-implement-ioctl-to-get-and-optionally-clear-info-about-ptes-fix-3-fix.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-01 19:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-01 7:50 [linux-next:master 8148/8790] fs/proc/task_mmu.c:2105:17: error: implicit declaration of function 'pagemap_scan_backout_range'; did you mean 'pagemap_scan_push_range'? kernel test robot
2023-10-01 19:47 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox