From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F94E748E7 for ; Sat, 30 Sep 2023 21:01:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 656BD6B0254; Sat, 30 Sep 2023 17:01:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 606096B0256; Sat, 30 Sep 2023 17:01:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CE266B0257; Sat, 30 Sep 2023 17:01:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3D2E96B0254 for ; Sat, 30 Sep 2023 17:01:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 096CC1601EF for ; Sat, 30 Sep 2023 21:01:17 +0000 (UTC) X-FDA: 81294484194.17.C7C3756 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by imf29.hostedemail.com (Postfix) with ESMTP id 26580120030 for ; Sat, 30 Sep 2023 21:01:14 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=iLPG8hSN; spf=pass (imf29.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.50 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696107675; a=rsa-sha256; cv=none; b=mO5vHLidsovNeHRAJGIAaDb0LQPmgPrPTg11ipTJDITaoM+8uS/JH2rddKbGtznW/tVWIN 724R3W7EWUoPHhR//2Rch+QTV6jFBAeQ0SLZRJKZWbivhROkQSaKbNzdErB/6DPjrXErg7 dxL2zI75ZK+ZOtvVGF4apQmhbPT0y7k= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=iLPG8hSN; spf=pass (imf29.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.50 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696107675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=27IFQu1p2zMt99rhR1KNh/9hYoodXsLNJNCuaLad3CU=; b=vy4b/nD+Co+bBiwYISKuhshN6wug59oU3LDvUk+KJqGDLEdJXXDfD3/W2sfbwBYSNCplVC UncCfJu8tSrx/G1HWlFv6oiCY4xe8aBO7BHqMh3vLMrkOmSIBx67RubklTiOfdEIl1pd8V rvZ17GoeTzYHKLUfyVihooquW1Rv43I= Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-6c454a5f3c7so9284010a34.0 for ; Sat, 30 Sep 2023 14:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696107674; x=1696712474; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=27IFQu1p2zMt99rhR1KNh/9hYoodXsLNJNCuaLad3CU=; b=iLPG8hSNZGwFThb3e2TmIn+rQdh1oxibbuSCHVvdZLs4QviByqIDvPwDAoinXFd465 E/7LRekv9kHTbkd1aDhGZYtbe0qkEIKNmoPIgTm88MSxF6KwA2SeRIZnza/gVrzNniUU BXItC3kKZLTMEl7QZxsDMRvqSed0xk4IEAf+o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696107674; x=1696712474; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=27IFQu1p2zMt99rhR1KNh/9hYoodXsLNJNCuaLad3CU=; b=Pip07I/z7pXf4ISqZyvnXgRZVTqpOWuMocPHuYdhIOQBoTUiQSCt/B10xsIvX2i0p+ 2bkONu+VGbXciEqLWcwWsfxNebpJ1yhtuHM++Si8Et6lAWPvgeUNKbRf+G37bcLZHkue gsbgGTwS+MqjGDmzkYKRuCX67h43IpriJkZpmQ3KYIJ+AKBoPy4KwPl9cQGmyKOeAUdR jeNwClC2tLdDFNqTtXwjg1n56PN4L5J9BwqVC+nCLdZc2MkEt4LCcAfIh9aMt+OXuU9U Ndof2mBh1O123A4VwHAB2SWy31bSntlLwhvynu8Hx753HO2ByKX10pHcrHoa03KzgxAd wpdg== X-Gm-Message-State: AOJu0YwllzvlQoSSftQDYHdwzssXm87Y556nV91CDCZzQSRlglFUnJLY SMS94TM7tkzybZbpDPDRh8q04w== X-Google-Smtp-Source: AGHT+IFeOcxaHIbtr3OOPjBvPc8vpAIKWTbtjxf4uBFCfxJieFURN+yasje/os/U6MRlxkFgpLgoBg== X-Received: by 2002:a05:6830:2091:b0:6c4:c607:7346 with SMTP id y17-20020a056830209100b006c4c6077346mr8189210otq.23.1696107674143; Sat, 30 Sep 2023 14:01:14 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id ey1-20020a056a0038c100b0068a13b0b300sm17483758pfb.11.2023.09.30.14.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 14:01:13 -0700 (PDT) Date: Sat, 30 Sep 2023 14:01:11 -0700 From: Kees Cook To: Conor Dooley Cc: Sami Tolvanen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , linux-mm@kvack.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] riscv: mm: Update mmap_rnd_bits_max Message-ID: <202309301400.4E1AD87@keescook> References: <20230929211155.3910949-4-samitolvanen@google.com> <20230929211155.3910949-6-samitolvanen@google.com> <202309291452.66ED9B4D83@keescook> <20230930-emporium-share-2bbdf7074e54@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230930-emporium-share-2bbdf7074e54@spud> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 26580120030 X-Stat-Signature: gu6siiuy3ga9fodct3wi4ytipg6feo5r X-Rspam-User: X-HE-Tag: 1696107674-261570 X-HE-Meta: U2FsdGVkX1/IYJqlOln1BbHQWg6WTpbvZXDR9SNLioaRMXkAY6eDU18G5vVdkiIgh5GHOQjBiSw4k/5Il43Uwd4hcwHfvlzD/DV8t5+lDNOeRgDyMCkQ98YzD0S0/6R0ZAk/DmjP9/mDTju1KF/HBEmvFiQOiSdMWJxVaTiLti/ubuJ//B+M6Nizsjd+aNs4Js5HqUoEXmZjdscQy/tI32s5x2THWXUyxdkQg4aobneSyEYckwCsHjXtB9e+3UW7WtkcgQj+wOCPBbkirSbAtN0T8iYQ+sX56usWBcMhB3+Rch4LZJjBDswT4DSzJNmOB6c9uc8jcs6NJfoYZSnVuBLcF0qvlLnV919apbt/jqL7/pKnyWo9HJZJh7iKtkHpclCrhbT8Qi7zgwVp/SmmCKFTtC6PfAlxYGfUOveZ0jXh3z0SMhaol7Pb0vy/Lg/RQv6BYtNZongY472b93eV01F3sg8vHJbF5aGK2/W5T4/iWD7pEoUlq6mAPi0q/cJBuSPvEL/3lZPyUynW+snwjXw9aK7rn6J4DPJscTbPOkHdgA0itFY6UAdn2aBCxRGzLN863MU4cGYxRq/O7ILIKU9WT57aBipSUMpaEgPKGOYkx3n3mDrfGbQZHRqNKKNklfuExKctN/zBMLX3/FWOqExo4ekZBHivX1bVYszOHrPf391Squ1Y1q2RxezCCKe2MsUuaLEudOIVcaSlg4HUPEwVunMUtPG9i/6hbZe2TMdH7SRQwzsrX7iz8wLp/g2J0pbusoeheX+hyQkVLvDynJn36XniZaMOTRRHkredj5sarf5XqkeVrexsjP5LvkYBeAn+xKBBeApuRXeH9twkcApbGEudckuHQAhI27869nl66s/atBarBHrS8VDYWngZJtDPKM8yfyHqk1z/YecejtELBewYG7BbCQmf7l+vbl3PqWqcdqdvbJ9EEcOx2cXb6ZZBJApmDHKtcnMg/rr VUBfgYqL GWpZ/3Y60hvwcOXkBwe5fqJMgD+/Z6B0xrtImiRh6QjNpYjyfKnAlemFDdrff29Av8uxQQglxsQvrZQ5Q+afp9WwHI31DO7aZhpVW+aIR+Rb4UKm98dem2bsJoE1d0rJ8vZd+ZQaCTgY6Gf/aaijF3ykCx/YDeWU1MGSNCP0MFxfqWgQnd5UcachgJcFdpCk2kKOJvIYftNaqI2gwi9uL/aJvIroiSaLmiyDD1KOVhgDU1nVhsSIYyyDjjR7oojF/Q8FDhFENIer9pJS3MkcIsaIQi3CTNiYT+8O0XaInjHDtXqAQn/qQA3p6GFhX8wX9T6fWnZ/23VOf/Zbz2vfnnAiZox/D1NOKPxNhFzGLYJl5wy69ywSnSAHTgrqFfZhtDkKhl2m6jFDY3sjc7UBLTGbXml/uiVjKggZUUKJ4ynSDZ8YNCjTBVIiaT4rgN3+wU3h8Q2O/BIP9+V0lXjC/KTgWyK/0CStgWij9tm6UEhqvn2l3/Rtb0T+1Nisbm4SOqj9u X-Bogosity: Ham, tests=bogofilter, spamicity=0.055237, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Sep 30, 2023 at 10:02:35AM +0100, Conor Dooley wrote: > On Fri, Sep 29, 2023 at 03:52:22PM -0700, Sami Tolvanen wrote: > > On Fri, Sep 29, 2023 at 2:54 PM Kees Cook wrote: > > > > > > On Fri, Sep 29, 2023 at 09:11:58PM +0000, Sami Tolvanen wrote: > > > > ARCH_MMAP_RND_BITS_MAX is based on Sv39, which leaves a few > > > > potential bits of mmap randomness on the table if we end up enabling > > > > 4/5-level paging. Update mmap_rnd_bits_max to take the final address > > > > space size into account. This increases mmap_rnd_bits_max from 24 to > > > > 33 with Sv48/57. > > > > > > > > Signed-off-by: Sami Tolvanen > > > > > > I like this. Is RISCV the only arch where the paging level can be chosen > > > at boot time? > > > > I haven't seen this elsewhere, but I also haven't looked at all the > > other architectures that closely. arm64 does something interesting > > with ARM64_VA_BITS_52, but I think we can still handle that in > > Kconfig. > > AFAIU, x86-64 can do this also: > > no4lvl [RISCV] Disable 4-level and 5-level paging modes. Forces > kernel to use 3-level paging instead. > > no5lvl [X86-64,RISCV] Disable 5-level paging mode. Forces > kernel to use 4-level paging instead. Ah-ha! Okay, well, then let's track this idea: https://github.com/KSPP/linux/issues/346 -- Kees Cook