linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] radix tree test suite: Fix allocation calculation in kmem_cache_alloc_bulk()
@ 2023-09-29 20:13 Liam R. Howlett
  0 siblings, 0 replies; only message in thread
From: Liam R. Howlett @ 2023-09-29 20:13 UTC (permalink / raw)
  To: Andrew Morton
  Cc: linux-mm, linux-kernel, Liam R. Howlett, Christophe JAILLET,
	Matthew Wilcox

The bulk allocation is iterating through an array and storing enough
memory for the entire bulk allocation instead of a single array entry.
Only allocate an array element of the size set in the kmem_cache.

Fixes: cc86e0c2f306 ("radix tree test suite: add support for slab bulk APIs")
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 tools/testing/radix-tree/linux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/radix-tree/linux.c b/tools/testing/radix-tree/linux.c
index d587a558997f..61fe2601cb3a 100644
--- a/tools/testing/radix-tree/linux.c
+++ b/tools/testing/radix-tree/linux.c
@@ -165,9 +165,9 @@ int kmem_cache_alloc_bulk(struct kmem_cache *cachep, gfp_t gfp, size_t size,
 		for (i = 0; i < size; i++) {
 			if (cachep->align) {
 				posix_memalign(&p[i], cachep->align,
-					       cachep->size * size);
+					       cachep->size);
 			} else {
-				p[i] = malloc(cachep->size * size);
+				p[i] = malloc(cachep->size);
 			}
 			if (cachep->ctor)
 				cachep->ctor(p[i]);
-- 
2.40.1



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-09-29 20:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-29 20:13 [PATCH] radix tree test suite: Fix allocation calculation in kmem_cache_alloc_bulk() Liam R. Howlett

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox