From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12847E81815 for ; Fri, 29 Sep 2023 21:54:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 297B38D0102; Fri, 29 Sep 2023 17:54:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 248328D00ED; Fri, 29 Sep 2023 17:54:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 138BD8D0102; Fri, 29 Sep 2023 17:54:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 076038D00ED for ; Fri, 29 Sep 2023 17:54:11 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CE08EA05C9 for ; Fri, 29 Sep 2023 21:54:10 +0000 (UTC) X-FDA: 81290988660.22.237BDC0 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf01.hostedemail.com (Postfix) with ESMTP id 082914000E for ; Fri, 29 Sep 2023 21:54:08 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Y+V1Ub0M; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf01.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.51 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696024449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MHH0ku3cnEfuovvq4TN+nU7rjq4fes2yQy9ZicPmfy0=; b=Ba3/6WuHZfK+VKReOVdXVW6wGAgABhy9DZ3Z5QYTVHBqg5yh2i5Tj8fxQxo0LV05NP3pL/ QK6uSCSltR5bb9a3iU3xlXu60DUcGfgRMrUduFmRuhD88E/cYPhLXIVwD1YXN/f5O4s/QP m6PYTSzWiobAZ5Aydc1HGsyUGxNuBLw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Y+V1Ub0M; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf01.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.51 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696024449; a=rsa-sha256; cv=none; b=cevZ9wVWJIm0bR0Sweflf0thPwXNqOWDEpex6jML2nCJ4qIfD6ZbBpwHVfnmmh9T63Ld+n uZVSQ2ZxHbE2+V2urfdcd5WWGlCp5a0MQAeoVShTUbV3qtTqlD5P4cXE5O+mpYjurNBx8y qbuiDc3i5fqHmBRxxavYjaCGEO7DRE4= Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-27736c2a731so9448154a91.3 for ; Fri, 29 Sep 2023 14:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696024448; x=1696629248; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MHH0ku3cnEfuovvq4TN+nU7rjq4fes2yQy9ZicPmfy0=; b=Y+V1Ub0MNqZITYt01LQYZm1ckw33wt2RULlKm7JOjCB6kOmufjZxBAQmxEqLwRtxhe 3i/4akkiZB3ADOnSO8ONgu4KkymbDqx/HxPug9ltkNlGojmShJQal3AHzmisT7Q97kmk ZSlo+osxoZzAqffAcL3M1qzuXlHMiNBjtavPI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696024448; x=1696629248; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MHH0ku3cnEfuovvq4TN+nU7rjq4fes2yQy9ZicPmfy0=; b=GCoFx87dEhPaOBw2jsSygziepr6ZlBXvevdhluzB0ACF+HweOTntxElA41cGNyMUp/ MwOaJL4165BbmqRNSWahjFrgBVs9fgVo2vURL8gp1Vm18rO4HQ8fQ6sa0J4iRZg77fJb ZVpB3KxEb1N8O+M9EvK7bCKFGXayDQFrX5c3mkHtyhii2mB81uLAcMS+oKJyoCAzevVv mFO6sy9LGNT0/18UT7qXUfXp2ebehhYUJdbMPaQYx2Rtqa7N+516AK5koFlFKe0AOWZp Bwu3Jp2XPgw6LL3obGZb6zKBFMe0TYbluA498Cggi/f5v6cvq4Bt/uhpix27XF0O0zEu xVIQ== X-Gm-Message-State: AOJu0YwKQ1EmqrjZy9y9wDrqClV0iTsl1mzloUaEYRUzaIdYOa/NqZv8 4t1iuuckC0qZtC6aafO/Z0/pyg== X-Google-Smtp-Source: AGHT+IHoF/OLpRNDzLcj85xtbvZ3DJsBh49hVBXu73MEqXR3MZRoTXPQbKi7O4iIRyczmIbUISS/lw== X-Received: by 2002:a17:90b:8c6:b0:26d:2bac:a0bb with SMTP id ds6-20020a17090b08c600b0026d2baca0bbmr5064809pjb.6.1696024447861; Fri, 29 Sep 2023 14:54:07 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 11-20020a17090a004b00b00273fc850342sm2114438pjb.20.2023.09.29.14.54.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 14:54:07 -0700 (PDT) Date: Fri, 29 Sep 2023 14:54:06 -0700 From: Kees Cook To: Sami Tolvanen Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , linux-mm@kvack.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] riscv: mm: Update mmap_rnd_bits_max Message-ID: <202309291452.66ED9B4D83@keescook> References: <20230929211155.3910949-4-samitolvanen@google.com> <20230929211155.3910949-6-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230929211155.3910949-6-samitolvanen@google.com> X-Rspamd-Queue-Id: 082914000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: bdatoiyco9t6ie53uscdifm7doe7xukc X-HE-Tag: 1696024448-908994 X-HE-Meta: U2FsdGVkX18puMapzWhguKWTCazX7vFIOwcc1YNu7IJhRZ2qplhK460QxkFmR1rMhOeqREy0iNlepgw0BRckOyO30eMFlpAAmFVWFZnIGYZqBzcyLnyFTzM8ixTe2e0WPXb2004WA+TgHEeKZLZBz/9iDr1rxzR7OZfBRMXo3Lj02u1kshj7hz9CUsBxmd4kzaIavBnXC6G9+FTm4P2KkJWyXZk3lkrnfEXxfQJBiNPy2MtFjZRlKTTkWVOoNFLDHi7/fN4mHuko6v0n4dVEidCSp5X4qpaOUrGCm5sMaHBKhdpaUifibQDLGKsjHwupuyvFYUNp/n5F8rb4m+rvhM6I1O1E1MuAaDf5m8tq++0N3H+37+ckvaP2wXwKUjPvpMvHykHEPRlvcOH3O8cHEULSPmwQdBSbRHGU+a27gmIMG91jL+IJ9QIa4VISaDrZDFxnOmOc0dywVw1cnv8/9k+vKdwlE+i8kcDI4r253nyOpTKd7RiK3sMYPRBUO6EfGiZhXjztewrZReZGpESnHILzQ7nHbmmP5HQMQbh9kOh/IStMqjNQbX7mOs6PIIoDw1HyKuqm4pWBd1A0L45zlYfcJwDHjEjmGLKL7sVTOmB7oijmHzac6Jtl75pLZ4Xr95l9j2EpvkHblfb/c42wv8TlDWRTuYlC5XfkELo9LyWCycTFu5vc6dgeKzPGkIdhR3Fc5aPQbsxGFqd9/m9RpnmMlKeyzZFy6feTTGV2W1wHJsP0zcZChdt/ArF6n9aZV18RvreqIp7Proem+LAd6RgM4M/Nn7otQcJgokJtMsCzPWfS52Hv8wg7eoVOceQLOR5XgiNMX6sNZailL0ZYYjqWqBfMff01Ro0sR8VZxaok+vvyv6OfSlcYj41KVUqqz4mNYb8FpHcQvySyO0mG5WXfR1gw1KGRLKW6lph+xEsQ5CeaWoKiDCwyPhmAz9CObLr5yqglYT9TkdgQtml fjTBD8GC c4YolvMOvTFv7Mi0CKV2LqomKcMTmqHxeS1QnEsnU7YF5/U2+yKvPVYe8GX4Xbk25fqPfLGD+ik/IRZQ9hWLLL/b1/RDT80+Sc/7p8HNnE3F9SFGTOF18jWAcDv6OgyK3irR5QHRGen6Mr7NGNwUzYrtM4Da/3vQo3MuApW45lKK7wSCX21L2B7zFHIZlWg+2PWa1vU6iDcQuGQ05MENOS1nzOagzMWhnpejvheGJ/TSTLiXaWMYgyfpmf3XIfHcDDL2h5HimXl8EkRpYUzn1+dYVuxiD29lRBg3nLDM3B0aHaqRbTeg2j9I5tpfaCADPEKFGye4WM9P3UOCi2JqFB6RCdhMJt8y+Fo0LQeBVzdmGjmtbbpuqtyGfXAuSPgQaliOgImqVtpqYQxgR1Me0tj3idREOaH5pXwKqKgi0z3LpI6P9MVriNqSS7gTNMZUtCniFHAd3Icda/+OtjsbFlpjCXUNf+CZEu+tYQX8XCjG+GmNT1hqj+eVjNAiG7CN9r+6a X-Bogosity: Ham, tests=bogofilter, spamicity=0.072118, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 29, 2023 at 09:11:58PM +0000, Sami Tolvanen wrote: > ARCH_MMAP_RND_BITS_MAX is based on Sv39, which leaves a few > potential bits of mmap randomness on the table if we end up enabling > 4/5-level paging. Update mmap_rnd_bits_max to take the final address > space size into account. This increases mmap_rnd_bits_max from 24 to > 33 with Sv48/57. > > Signed-off-by: Sami Tolvanen I like this. Is RISCV the only arch where the paging level can be chosen at boot time? Reviewed-by: Kees Cook -- Kees Cook