From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB4F6E728CA for ; Fri, 29 Sep 2023 17:32:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B8148D00F4; Fri, 29 Sep 2023 13:32:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 440948D00E3; Fri, 29 Sep 2023 13:32:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BE178D00F4; Fri, 29 Sep 2023 13:32:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1DBB68D00E3 for ; Fri, 29 Sep 2023 13:32:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DCA7C40B88 for ; Fri, 29 Sep 2023 17:32:00 +0000 (UTC) X-FDA: 81290328000.30.2C3E84B Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf25.hostedemail.com (Postfix) with ESMTP id 025E0A0007 for ; Fri, 29 Sep 2023 17:31:58 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=U4rbuKOm; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf25.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.176 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696008719; a=rsa-sha256; cv=none; b=KytVDSNjScXDJftgBkcs0071F77RSaURAfheTG+G9cOwrDGGfLBIx0T2wzRG1XSkjMz3EK Lp9Tv8ekhTON3Gn6cUcMYiyuw0uMlr3u9qso3xgUrA2IAE1mqUy2NgrOL11YillDfMfi6s SOCIbvtW7ZaEUf/b8RovgXlK2jSBrso= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=U4rbuKOm; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf25.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.176 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696008719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pjfe+9DAgkAH6WItI1dT6HVJUqUjV4pKi1IHzGz52K4=; b=4Ccd5ZZpLoy3unWziXpmVGjnVCLXqRHxSZyER1tysAOoipUwlqW12yPWDh3R2H+5EIYNVk jNVSUpbtxambQ/YNl+ezmpfrl0i2eaEHp0LJbR6xeNYcFCY+AeUWHCh1Wz8LkpJNLn3vdq /ulyC6b9piYAdAdg+Xu+j6vnxtVk+/A= Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-68c576d35feso12714006b3a.2 for ; Fri, 29 Sep 2023 10:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696008718; x=1696613518; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Pjfe+9DAgkAH6WItI1dT6HVJUqUjV4pKi1IHzGz52K4=; b=U4rbuKOmvHrtuuysiiP7gNnZ9fG/hKLssgHA/uASXZd1d7vpMCelBlU87k0ESXK81G Y5D+zrFlgLSdI4r1foLarKcy92W09RfZd1KRBnvoRY5UonjEkipBVEVCOKO1JGtpIW2s Mmp7mxUf9cgTfIIHFSJNDZ+oJW/dNbFIKty9M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696008718; x=1696613518; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pjfe+9DAgkAH6WItI1dT6HVJUqUjV4pKi1IHzGz52K4=; b=a4vCUa2dwdeIkvODbq2CSPh5XPqE353a0n1purRiyQyL+JVNv9palYmqXl1TlNIFDz GoVbTC1iWdpuIergprw3isgSDp0Ymprx7HazYVYFbfep7UjK+sTXio3YPYH6KhU/Q1cZ atR/gLNzP9Urhg2MBbiUL4OIgeozvhU5CsvxdvxVfyK4PyrJ+tE+iHDcF2Qp5iDh6iNZ ws9f1fNT4K1eNEE6wRfuQy+C96S08LUZ+YWJbiP+B6AotELeEV9wdOxzkliFiWE1kmlo 6NPGX4rfZLrv7XcDwNnl56Vw+6f7JugFQyCFCBLUL93si5qtt6xUXloegUCwu4VEyXR3 hzag== X-Gm-Message-State: AOJu0YzHumf5shGF3c1cwiVgkQbbXqUcrm2wY18o/1wXhUFHlNiRkTTW aF3VlpmGMXDCJRhcaTxKTuEhxQ== X-Google-Smtp-Source: AGHT+IGfzsOOkJOPX9riY6Xxy/JU2BErzwzUVNeNoe1Yb+UlJJejoAy1cqSlz7xFqUqpsuSCjKY80g== X-Received: by 2002:a05:6a21:601:b0:15d:4a2b:b513 with SMTP id ll1-20020a056a21060100b0015d4a2bb513mr3838810pzb.36.1696008717818; Fri, 29 Sep 2023 10:31:57 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id cm22-20020a17090afa1600b0026b6d0a68c5sm1751514pjb.18.2023.09.29.10.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 10:31:57 -0700 (PDT) Date: Fri, 29 Sep 2023 10:31:56 -0700 From: Kees Cook To: Mark Brown Cc: Shuah Khan , Eric Biederman , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] kselftest: Add a ksft_perror() helper Message-ID: <202309291031.1B2A2EE@keescook> References: <20230928-ktap-exec-v1-0-1013a2db0426@kernel.org> <20230928-ktap-exec-v1-1-1013a2db0426@kernel.org> <202309281747.594B3352@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 025E0A0007 X-Stat-Signature: n1qhgfhkkha4oh9o8gkforjayaf3admn X-HE-Tag: 1696008718-985626 X-HE-Meta: U2FsdGVkX1+imgZeRLzjFoTk682gpM6lpr70zqjW7sSAf7tIwo2RXxrSqeYvA90qmOFbhgb1qKuKsla8XnirY2LlsZ1lPuJ+DjvKKoGZaPC72kBvmr0D9uoUJohR7giKqeCL6UzxuwiiLpI0oFcUwZoY7wO0pmEoI1/7D873chUeJAngT8NdxHY9RUvSdEqdwNEtdCnagkCfxroTEfg4CNN2EfwsPVWsL6xwh9TzOef9i7Sq9Q1YuAGLFlv97jsf+dQWkBlML6NfnjhlbrrmDIpwrqYl1aaap0jhStZyIxnf7zBV8FE/fPvX3IjbhZR3XYuVD/ZHzq9WUgv2EzKq5NDpLTDPY873SDtrYaNwxJCJz23UxPEODzqenDG6st/xUK5Y4HpeCqKafdYFPd8Otm3mfaLthUbDcv/ewU+k+nEfgm9kiEYbsrlJQzQVbfonXh1nT9sS4ayerknv+kQxa9Vje5a99c/28stxjPa/V8dGHiNFTZz3ajgavtHHrJUhgE0Fqlygxu3S7DJDm1RuEFD9P7eCLdYV8stfj2io1Y+3w97QAO8ncosKT32N15aM0KPO+uDM1uA9qGzYZu42L4fIWW1wp6JcMLs5TkrrN7JkA3ZmRJoc3Qy4JPaeAVA0e+d8XRy6a14Aoi9K1HzIjl3pPHNH8FSR/JeamFA9zxtCX1UTQKEe/sNDzxRpeLQe0gwh+M9+CHbcOcAuOFCbUVCrjB9fRu9KJ57kpkjj8o6ZOTPAIyHTvUXYY8icEEZbIjwkjULP3hYr3VHKGLS4jq361VzYXi/srybgVa9Eih+8TJG4gDbR/zZB9nWlgTHAV/UPCVOK6RoZxTLEWrhwUQACLcfMfUX7xaPAjh65LBPb2ocileXVA/o6ZmUTetO55M61s+iJ15ydd0Xcip5Mugm2PR6IxW0J/V1eKvyaAPUBLQLlx0Qblh0Z5FEaG0OZwnNJe/ACmXGKf2sDg3a vjHQICMJ eH/QEjHUU9csDepX7yo6zt7yETcdJ3zAs5DomAacIlola7YIY4HNjUfq2xKe6wDwwwKigZwm808JTcU+khHzuuhxow00VSl7yhtJ9aEpHhfLVqy+/gbRrRlYZ3BCa9/mXUmDd3JQj0p9GXnCtbdPJwBA0TXxnDbZmcoeTfkb+xyFbaDA+gisc26WgSp/eGVlZYR2doIJWiu8BW+4iL4LQWq+Vo6WE/3zrbBqWR0KTdgqG3pFm1BtuIpQQamJzV0sItlB3ORp9NGBZgXsDgkzzmC27WPAWs7v8J2VvMo6SaCl5WJ9Tjhnn8RF5UF6OXNwReLQ54M9aO8MP/FenuaczLFBYOOoQSiP0nEODjo1F13akGd7dXkX2nEXFfI6OjsRq9yU3vEZthuQO1m23d7N9NgK92g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000258, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 29, 2023 at 09:50:53AM +0200, Mark Brown wrote: > On Thu, Sep 28, 2023 at 05:48:22PM -0700, Kees Cook wrote: > > > > nolibc doesn't have a strerror() and adding the table of strings required > > > doesn't seem like a good fit for what it's trying to do so when we're using > > > that only print the errno. > > > Oh, interesting... what environment ends up without strerror()? > > Like I say it's for nolibc - it's just some header files (all in the > kernel source), while it generally aims to be libc compatible it's > intentionally very small. Right, I mean, how would one normally encounter this environment? Running the selftests on m68k userspace or something? -- Kees Cook