From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03564E743D0 for ; Thu, 28 Sep 2023 23:51:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2454D6B01A8; Thu, 28 Sep 2023 19:51:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CECF6B01AA; Thu, 28 Sep 2023 19:51:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06F356B01AB; Thu, 28 Sep 2023 19:51:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E361A6B01A8 for ; Thu, 28 Sep 2023 19:51:06 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B890F1CA688 for ; Thu, 28 Sep 2023 23:51:06 +0000 (UTC) X-FDA: 81287654532.07.72C914C Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by imf06.hostedemail.com (Postfix) with ESMTP id 3C2E7180010 for ; Thu, 28 Sep 2023 23:51:04 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=i2LioXFA; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of lkp@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695945065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=YmmdcLwDLGqyBRCljREFqBIJuMVN3b75Z1MNjME3wRM=; b=E7eQItCysaIGCko13o5zaF8xU713bMh8HYniQB8HJjWqzrhjVZ2Oc8Sfqy8i+2JH//GMwk xJOY2bO4q4bKPjE3l/qVvTq3lmsZiQOjNKgEt9Yeon/1N2isNH+qTIWxyqVX8lvBZc00ab BL0kxI6SJ3hJstzpDEpDk60bxY03+mk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=i2LioXFA; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of lkp@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695945065; a=rsa-sha256; cv=none; b=UayokjVW/BcEiVluqrrHxzAL5AySFJTkgpMAhFAwbVcyvZh1nz2Zdqg3l78rlQK5Swp2Uu h/Si50bHql2WdHFuz+Ou2krrm9muN+T1dOKBth8CA80Sf7B5S9GSGH+Y/P9Zp36BcNUzqM UiaWykCbyOv0XvFU/G56QzumymJEdRY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695945064; x=1727481064; h=date:from:to:cc:subject:message-id:mime-version; bh=mKs99KJLfHcfqm2ikhkM8Pv44KtoaxJhB6BDDtBPjuE=; b=i2LioXFAo6CxELrjGTIEdQRqGKMnGgBeLWiIr24sZJJPdZ0S9UNhEA/X bdJn8pcgvq9oxa/dcZWNOMLCKlK98KkJPFxmARiVIhy21ScrY+WQ/f00e b+MBIq5vHE+c4nnTiYQAAFupnw695h4aU/1MnVEaUydCDefgwgnMhQXMi yfhFQzd9hdln8lUqsd633IsrE8/BIpmxgrW6XhqA7qIpc2JmXD7Yv4ah+ Q0yHBrgoYUku7Zp+RCI1vJqIEL190FjOTJBLDmuKNlyUYs0y1qKn4NHZX H9c4C8QeFwbx5k4sMjlctztqSNeQxBvxK2KQffSfPBq6i6GLlwx6Zw1LZ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10847"; a="367263785" X-IronPort-AV: E=Sophos;i="6.03,185,1694761200"; d="scan'208";a="367263785" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2023 16:51:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10847"; a="996747534" X-IronPort-AV: E=Sophos;i="6.03,185,1694761200"; d="scan'208";a="996747534" Received: from lkp-server02.sh.intel.com (HELO c3b01524d57c) ([10.239.97.151]) by fmsmga006.fm.intel.com with ESMTP; 28 Sep 2023 16:50:59 -0700 Received: from kbuild by c3b01524d57c with local (Exim 4.96) (envelope-from ) id 1qm0mX-0002AL-0B; Thu, 28 Sep 2023 23:50:57 +0000 Date: Fri, 29 Sep 2023 07:50:08 +0800 From: kernel test robot To: Joshua Hay Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Tony Nguyen , Alan Brady , Madhu Chittim , Phani Burra , Sridhar Samudrala , Willem de Bruijn , Pavan Kumar Linga Subject: [linux-next:master 4519/8507] drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c:194:29: warning: variable 'tx_buf' set but not used Message-ID: <202309290750.bYBcf6Q2-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Stat-Signature: 3pizdbi1xjgafc81kr9k9xa1yhfr83t4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3C2E7180010 X-HE-Tag: 1695945064-895839 X-HE-Meta: U2FsdGVkX19C3taTnPkJvl26kjoUnctzn2U1QclSZMkLb27oqHzwSQ+BvyEzvB6AgqLBIwVOSsw8UhslkMGXZHIZM//jTU76L5y2ItxSokhgazV+XxSI0QcDML5KtHYJM+m1BlsxDbCsDwAn9vv8pY1wvyjlHmuZUHGCRy3psegZZAdotlKW3jj6Wb69PDbjDoYnahtH0umDji0DIA2V73YjtGjDRMsGdnim2q6my98ihiz6ekqoqb0kRxVhRusmS3CV7RLZOj+sQ28CQtfhxJyJmaKVYspStX/ESMDYs2AkQppmYGPIk7KECQnd+IMU+GtyvIha48gS8RSPLrelO+mjTl4pv3vhpQ8h+xLjVSYbzBUN2o11CGmRrdtrcF/gjlkBxXgyajXCl03YvRsm29g8grPyAeJ3mOFId4BrgwfHub5+FMbOwyFLh4q0YmWxABj+e+c3SMSZL7R5edMSg8X7m20dJfbPHoRtZFRM4WFCFckZxXXHqWstSXPid9o+bfCglKAHZ97FMQqxF0Z7YuwxF0AD0q1cWkbBBL4X8xSKBYWZzoys4aqHhQpZDPekEu4SSXiw9mLqGI1nOIx93o/0nXzclIsqmztQpuzpzMHNY1vhOKDzUcSUGs86q6lnvwnXEX28xo3cE7JI8caNAxtVnfwvmtOMlOOvLkffmM+//l6q4uOSQei8MSwd8eNwRHLIuWbqQCn6F8go/pJ/e6C18ZBqmlX3zmt2gLdp57bkXx3PAA7ikN72h+hNn2AJnxtgf+1Nyd+OJZ+1m2+z1e4BehPUios/4LeMZE4Y+D3Vs0F9Cc3y7aakJSR4rmWD223b+jaDfQsg6jy9lt6pqI4an+8VSbzFMwWjcMEyIrpOoumLUtQ3mqs/6mrWaJiip5A/RwxFmmvOdoqFi1K0hKcnQBUeDlm01S3wcHNQpJ9iJof9eIStrYPRAH9UL4WhUhxuLwcB5I3RHkgQF0l 3if+D7CA E2x269+3sPyLrrB0s+Wf2PDpYM5ge1kszWZ/+WGWA2Idt+msyq5rBQunqr5JMcba+Z6gsNSXrru9bF8FeEjQbDTrdg3Jg0i8mL6jH58Oi9NbMDGFcFbb8phJpzZzH2LU9G4lHsdT1qBZ9yuNy+ZSOIEdMulopbj1uNRZi3pu7XBTy77Sx5ZViy0mfhwT0+WfUzxa+dMBUj1ZVF27Aj9oQYGiaFI92EYPA8RN7WbnFkxTHnZOZLVbDvw3uWI2IlADpt1PfmPlnrgBVyHpz41jIYsR+LU4Z8i/L+5fZqbYJl9MBI/n34xhcAqkkSELX8pzElgGX6ZEXSw8r5ztEYriFb1EnjAji7+Cxf9dzEqrAKwevg5E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Joshua, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 719136e5c24768ebdf80b9daa53facebbdd377c3 commit: a251eee62133774cf35ff829041377e721ef9c8c [4519/8507] idpf: add SRIOV support and other ndo_ops config: powerpc-randconfig-001-20230929 (https://download.01.org/0day-ci/archive/20230929/202309290750.bYBcf6Q2-lkp@intel.com/config) compiler: powerpc-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230929/202309290750.bYBcf6Q2-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309290750.bYBcf6Q2-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c: In function 'idpf_tx_singleq_map': >> drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c:194:29: warning: variable 'tx_buf' set but not used [-Wunused-but-set-variable] 194 | struct idpf_tx_buf *tx_buf = first; | ^~~~~~ Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for HOTPLUG_CPU Depends on [n]: SMP [=y] && (PPC_PSERIES [=n] || PPC_PMAC [=n] || PPC_POWERNV [=n] || FSL_SOC_BOOKE [=n]) Selected by [y]: - PM_SLEEP_SMP [=y] && SMP [=y] && (ARCH_SUSPEND_POSSIBLE [=n] || ARCH_HIBERNATION_POSSIBLE [=y]) && PM_SLEEP [=y] vim +/tx_buf +194 drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c a5ab9ee0df0be8 Joshua Hay 2023-08-07 178 a5ab9ee0df0be8 Joshua Hay 2023-08-07 179 /** a5ab9ee0df0be8 Joshua Hay 2023-08-07 180 * idpf_tx_singleq_map - Build the Tx base descriptor a5ab9ee0df0be8 Joshua Hay 2023-08-07 181 * @tx_q: queue to send buffer on a5ab9ee0df0be8 Joshua Hay 2023-08-07 182 * @first: first buffer info buffer to use a5ab9ee0df0be8 Joshua Hay 2023-08-07 183 * @offloads: pointer to struct that holds offload parameters a5ab9ee0df0be8 Joshua Hay 2023-08-07 184 * a5ab9ee0df0be8 Joshua Hay 2023-08-07 185 * This function loops over the skb data pointed to by *first a5ab9ee0df0be8 Joshua Hay 2023-08-07 186 * and gets a physical address for each memory location and programs a5ab9ee0df0be8 Joshua Hay 2023-08-07 187 * it and the length into the transmit base mode descriptor. a5ab9ee0df0be8 Joshua Hay 2023-08-07 188 */ a5ab9ee0df0be8 Joshua Hay 2023-08-07 189 static void idpf_tx_singleq_map(struct idpf_queue *tx_q, a5ab9ee0df0be8 Joshua Hay 2023-08-07 190 struct idpf_tx_buf *first, a5ab9ee0df0be8 Joshua Hay 2023-08-07 191 struct idpf_tx_offload_params *offloads) a5ab9ee0df0be8 Joshua Hay 2023-08-07 192 { a5ab9ee0df0be8 Joshua Hay 2023-08-07 193 u32 offsets = offloads->hdr_offsets; a5ab9ee0df0be8 Joshua Hay 2023-08-07 @194 struct idpf_tx_buf *tx_buf = first; a5ab9ee0df0be8 Joshua Hay 2023-08-07 195 struct idpf_base_tx_desc *tx_desc; a5ab9ee0df0be8 Joshua Hay 2023-08-07 196 struct sk_buff *skb = first->skb; a5ab9ee0df0be8 Joshua Hay 2023-08-07 197 u64 td_cmd = offloads->td_cmd; a5ab9ee0df0be8 Joshua Hay 2023-08-07 198 unsigned int data_len, size; a5ab9ee0df0be8 Joshua Hay 2023-08-07 199 u16 i = tx_q->next_to_use; a5ab9ee0df0be8 Joshua Hay 2023-08-07 200 struct netdev_queue *nq; a5ab9ee0df0be8 Joshua Hay 2023-08-07 201 skb_frag_t *frag; a5ab9ee0df0be8 Joshua Hay 2023-08-07 202 dma_addr_t dma; a5ab9ee0df0be8 Joshua Hay 2023-08-07 203 u64 td_tag = 0; a5ab9ee0df0be8 Joshua Hay 2023-08-07 204 a5ab9ee0df0be8 Joshua Hay 2023-08-07 205 data_len = skb->data_len; a5ab9ee0df0be8 Joshua Hay 2023-08-07 206 size = skb_headlen(skb); a5ab9ee0df0be8 Joshua Hay 2023-08-07 207 a5ab9ee0df0be8 Joshua Hay 2023-08-07 208 tx_desc = IDPF_BASE_TX_DESC(tx_q, i); a5ab9ee0df0be8 Joshua Hay 2023-08-07 209 a5ab9ee0df0be8 Joshua Hay 2023-08-07 210 dma = dma_map_single(tx_q->dev, skb->data, size, DMA_TO_DEVICE); a5ab9ee0df0be8 Joshua Hay 2023-08-07 211 a5ab9ee0df0be8 Joshua Hay 2023-08-07 212 /* write each descriptor with CRC bit */ a5ab9ee0df0be8 Joshua Hay 2023-08-07 213 if (tx_q->vport->crc_enable) a5ab9ee0df0be8 Joshua Hay 2023-08-07 214 td_cmd |= IDPF_TX_DESC_CMD_ICRC; a5ab9ee0df0be8 Joshua Hay 2023-08-07 215 a5ab9ee0df0be8 Joshua Hay 2023-08-07 216 for (frag = &skb_shinfo(skb)->frags[0];; frag++) { a5ab9ee0df0be8 Joshua Hay 2023-08-07 217 unsigned int max_data = IDPF_TX_MAX_DESC_DATA_ALIGNED; a5ab9ee0df0be8 Joshua Hay 2023-08-07 218 a5ab9ee0df0be8 Joshua Hay 2023-08-07 219 if (dma_mapping_error(tx_q->dev, dma)) a5ab9ee0df0be8 Joshua Hay 2023-08-07 220 return idpf_tx_dma_map_error(tx_q, skb, first, i); a5ab9ee0df0be8 Joshua Hay 2023-08-07 221 a5ab9ee0df0be8 Joshua Hay 2023-08-07 222 /* record length, and DMA address */ a5ab9ee0df0be8 Joshua Hay 2023-08-07 223 dma_unmap_len_set(tx_buf, len, size); a5ab9ee0df0be8 Joshua Hay 2023-08-07 224 dma_unmap_addr_set(tx_buf, dma, dma); a5ab9ee0df0be8 Joshua Hay 2023-08-07 225 a5ab9ee0df0be8 Joshua Hay 2023-08-07 226 /* align size to end of page */ a5ab9ee0df0be8 Joshua Hay 2023-08-07 227 max_data += -dma & (IDPF_TX_MAX_READ_REQ_SIZE - 1); a5ab9ee0df0be8 Joshua Hay 2023-08-07 228 tx_desc->buf_addr = cpu_to_le64(dma); a5ab9ee0df0be8 Joshua Hay 2023-08-07 229 a5ab9ee0df0be8 Joshua Hay 2023-08-07 230 /* account for data chunks larger than the hardware a5ab9ee0df0be8 Joshua Hay 2023-08-07 231 * can handle a5ab9ee0df0be8 Joshua Hay 2023-08-07 232 */ a5ab9ee0df0be8 Joshua Hay 2023-08-07 233 while (unlikely(size > IDPF_TX_MAX_DESC_DATA)) { a5ab9ee0df0be8 Joshua Hay 2023-08-07 234 tx_desc->qw1 = idpf_tx_singleq_build_ctob(td_cmd, a5ab9ee0df0be8 Joshua Hay 2023-08-07 235 offsets, a5ab9ee0df0be8 Joshua Hay 2023-08-07 236 max_data, a5ab9ee0df0be8 Joshua Hay 2023-08-07 237 td_tag); a5ab9ee0df0be8 Joshua Hay 2023-08-07 238 tx_desc++; a5ab9ee0df0be8 Joshua Hay 2023-08-07 239 i++; a5ab9ee0df0be8 Joshua Hay 2023-08-07 240 a5ab9ee0df0be8 Joshua Hay 2023-08-07 241 if (i == tx_q->desc_count) { a5ab9ee0df0be8 Joshua Hay 2023-08-07 242 tx_desc = IDPF_BASE_TX_DESC(tx_q, 0); a5ab9ee0df0be8 Joshua Hay 2023-08-07 243 i = 0; a5ab9ee0df0be8 Joshua Hay 2023-08-07 244 } a5ab9ee0df0be8 Joshua Hay 2023-08-07 245 a5ab9ee0df0be8 Joshua Hay 2023-08-07 246 dma += max_data; a5ab9ee0df0be8 Joshua Hay 2023-08-07 247 size -= max_data; a5ab9ee0df0be8 Joshua Hay 2023-08-07 248 a5ab9ee0df0be8 Joshua Hay 2023-08-07 249 max_data = IDPF_TX_MAX_DESC_DATA_ALIGNED; a5ab9ee0df0be8 Joshua Hay 2023-08-07 250 tx_desc->buf_addr = cpu_to_le64(dma); a5ab9ee0df0be8 Joshua Hay 2023-08-07 251 } a5ab9ee0df0be8 Joshua Hay 2023-08-07 252 a5ab9ee0df0be8 Joshua Hay 2023-08-07 253 if (!data_len) a5ab9ee0df0be8 Joshua Hay 2023-08-07 254 break; a5ab9ee0df0be8 Joshua Hay 2023-08-07 255 a5ab9ee0df0be8 Joshua Hay 2023-08-07 256 tx_desc->qw1 = idpf_tx_singleq_build_ctob(td_cmd, offsets, a5ab9ee0df0be8 Joshua Hay 2023-08-07 257 size, td_tag); a5ab9ee0df0be8 Joshua Hay 2023-08-07 258 tx_desc++; a5ab9ee0df0be8 Joshua Hay 2023-08-07 259 i++; a5ab9ee0df0be8 Joshua Hay 2023-08-07 260 a5ab9ee0df0be8 Joshua Hay 2023-08-07 261 if (i == tx_q->desc_count) { a5ab9ee0df0be8 Joshua Hay 2023-08-07 262 tx_desc = IDPF_BASE_TX_DESC(tx_q, 0); a5ab9ee0df0be8 Joshua Hay 2023-08-07 263 i = 0; a5ab9ee0df0be8 Joshua Hay 2023-08-07 264 } a5ab9ee0df0be8 Joshua Hay 2023-08-07 265 a5ab9ee0df0be8 Joshua Hay 2023-08-07 266 size = skb_frag_size(frag); a5ab9ee0df0be8 Joshua Hay 2023-08-07 267 data_len -= size; a5ab9ee0df0be8 Joshua Hay 2023-08-07 268 a5ab9ee0df0be8 Joshua Hay 2023-08-07 269 dma = skb_frag_dma_map(tx_q->dev, frag, 0, size, a5ab9ee0df0be8 Joshua Hay 2023-08-07 270 DMA_TO_DEVICE); a5ab9ee0df0be8 Joshua Hay 2023-08-07 271 a5ab9ee0df0be8 Joshua Hay 2023-08-07 272 tx_buf = &tx_q->tx_buf[i]; a5ab9ee0df0be8 Joshua Hay 2023-08-07 273 } a5ab9ee0df0be8 Joshua Hay 2023-08-07 274 a5ab9ee0df0be8 Joshua Hay 2023-08-07 275 skb_tx_timestamp(first->skb); a5ab9ee0df0be8 Joshua Hay 2023-08-07 276 a5ab9ee0df0be8 Joshua Hay 2023-08-07 277 /* write last descriptor with RS and EOP bits */ a5ab9ee0df0be8 Joshua Hay 2023-08-07 278 td_cmd |= (u64)(IDPF_TX_DESC_CMD_EOP | IDPF_TX_DESC_CMD_RS); a5ab9ee0df0be8 Joshua Hay 2023-08-07 279 a5ab9ee0df0be8 Joshua Hay 2023-08-07 280 tx_desc->qw1 = idpf_tx_singleq_build_ctob(td_cmd, offsets, a5ab9ee0df0be8 Joshua Hay 2023-08-07 281 size, td_tag); a5ab9ee0df0be8 Joshua Hay 2023-08-07 282 a5ab9ee0df0be8 Joshua Hay 2023-08-07 283 IDPF_SINGLEQ_BUMP_RING_IDX(tx_q, i); a5ab9ee0df0be8 Joshua Hay 2023-08-07 284 a5ab9ee0df0be8 Joshua Hay 2023-08-07 285 /* set next_to_watch value indicating a packet is present */ a5ab9ee0df0be8 Joshua Hay 2023-08-07 286 first->next_to_watch = tx_desc; a5ab9ee0df0be8 Joshua Hay 2023-08-07 287 a5ab9ee0df0be8 Joshua Hay 2023-08-07 288 nq = netdev_get_tx_queue(tx_q->vport->netdev, tx_q->idx); a5ab9ee0df0be8 Joshua Hay 2023-08-07 289 netdev_tx_sent_queue(nq, first->bytecount); a5ab9ee0df0be8 Joshua Hay 2023-08-07 290 a5ab9ee0df0be8 Joshua Hay 2023-08-07 291 idpf_tx_buf_hw_update(tx_q, i, netdev_xmit_more()); a5ab9ee0df0be8 Joshua Hay 2023-08-07 292 } a5ab9ee0df0be8 Joshua Hay 2023-08-07 293 :::::: The code at line 194 was first introduced by commit :::::: a5ab9ee0df0be82aefb099d29b707d2b106e1c87 idpf: add singleq start_xmit and napi poll :::::: TO: Joshua Hay :::::: CC: Tony Nguyen -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki