From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B804E7F154 for ; Fri, 29 Sep 2023 09:45:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E311F8D00C1; Fri, 29 Sep 2023 05:45:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBADC8D0023; Fri, 29 Sep 2023 05:45:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE51A8D00C1; Fri, 29 Sep 2023 05:45:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AB8008D0023 for ; Fri, 29 Sep 2023 05:45:21 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 766DB40AED for ; Fri, 29 Sep 2023 09:45:21 +0000 (UTC) X-FDA: 81289152042.22.F71F827 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id BDDEB1C0002 for ; Fri, 29 Sep 2023 09:45:19 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WlV6Iok6; spf=pass (imf20.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695980719; a=rsa-sha256; cv=none; b=oCSku4q8dx3M7TkbKRX4uzG9o0WBPuMoAHeCV6n3p4lu4TmzYBve7DaYqRN2PLUMSbO/Q8 89s9MOVFkvj5Jh8YmRThRRa7y+8nkdtfhRh0tkirSC2BsP0NppHkOIPnvWciTa2P4me5au j+Gy55idIHwMvgm0RBpkcI/gS+QceWM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WlV6Iok6; spf=pass (imf20.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695980719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oQTvAmCkCsoaLNjfsaMUmlY4D/qoWr90XSuheIQAYtc=; b=LmXw2ggmKY9b2N4664YmCms6IyeUvhovjYkurwMzmv2xr0OcMRoNL8r/CRs4Q+wcUz66sg hpZzpBRY5wvb0FfGvsGQq2G56Oc7Mhf73L0OPv5uP1q67LeMbqe+g6xLs53ngHtlDxElJb TxQDalxsJCOKIbLhQcjlSgRLC21gvv8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 59C9F61D59; Fri, 29 Sep 2023 09:45:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CB9BC433C8; Fri, 29 Sep 2023 09:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695980717; bh=oQTvAmCkCsoaLNjfsaMUmlY4D/qoWr90XSuheIQAYtc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WlV6Iok6t6x6wqtPDr2u2AsUWg4hMLM7cqaWPUDEeTpPDmS0JTVgMZlUl0HPmoBuT /MtXZyL5oovwNZMVTtYCnXU5O+6UqBVLwaqKXfjDA7Gi3QJjfoFg0kuMJ76nbuwBFl FM+QH0bvVjfmuBVMp9s5CgN9psq1cDgIpp1TcndUbm+j24otqfdnexR7nd6Jf+tuT9 QFRyk1BHauhj4nL9X9E976w/vvMYaEWzc8Ucm1v15cgYx/ItXrPfVSX9rwflr20Upl 1p24LfpWvr++mxmy87xjKVxbcTxjBWdURGxp63tvXsg372LYC0Zasv3SIGFC2AHpa8 8VA1Ctle4jMgQ== Date: Fri, 29 Sep 2023 11:44:15 +0200 From: Christian Brauner To: Jeff Layton Cc: Arnd Bergmann , Alexander Viro , Linus Torvalds , David Sterba , Amir Goldstein , Theodore Ts'o , "Eric W. Biederman" , Kees Cook , Jeremy Kerr , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Mattia Dongili , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Brad Warrum , Ritu Agarwal , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Mark Gross , Jiri Slaby , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Joel Becker , Christoph Hellwig , Nicolas Pitre , "Rafael J . Wysocki" , Ard Biesheuvel , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Christoph Hellwig , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , Mike Kravetz , Muchun Song , Jan Kara , David Woodhouse , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Chuck Lever , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Mark Fasheh , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Iurii Zaikin , Tony Luck , "Guilherme G. Piccoli" , Anders Larsen , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Sergey Senozhatsky , Phillip Lougher , Steven Rostedt , Masami Hiramatsu , Evgeniy Dushistov , Chandan Babu R , "Darrick J. Wong" , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Hugh Dickins , Andrew Morton , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-rdma@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-efi@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, gfs2@lists.linux.dev, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-hardening@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, Netdev , apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH 86/87] fs: switch timespec64 fields in inode to discrete integers Message-ID: <20230929-yuppie-unzweifelhaft-434bf13bc964@brauner> References: <20230928110554.34758-1-jlayton@kernel.org> <20230928110554.34758-2-jlayton@kernel.org> <6020d6e7-b187-4abb-bf38-dc09d8bd0f6d@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: BDDEB1C0002 X-Stat-Signature: derwbn34u7dgduxb7asi3yfmshs388kz X-Rspam-User: X-HE-Tag: 1695980719-758910 X-HE-Meta: U2FsdGVkX1+GvM+QeXKFHKOIlnOwKImOSFZrZfuMgViROHZfwHO5rz3qGFgtS1m4X/fRPD6MvIVJFyaEFtdHHdCJkZ4iXL9clfPxPv0ej4eB5xw/GpUH2KMQZDAd2jDfn6ZrkTNfQ9XJwWII46gMckVBsF+Jx8qClwdrCylWNeQzm2lTuZn/pqxS67YLis2DNjIKhE+byuFcCDGmwd+fhYX4qh6Wa56rjsG2pDuykRoYg6Hg3WkUm9rSBjwZfflbspoInSIML8Eem5XuJAbpUYHF7pw97pUbHOQ7Bn40HlqXMIUs5QfZ85ioeYoJUR/NctxBFpQLui+yCFqnDc+kl1Sd/u8ulQNzjHMjdCNGHaKuBAes5PrkjfA3A8FbdE1bwhN9Kz9thFzDO5YyM+/vkUOsk4i8JfavPhomnySPMFS/vAcjU18v9Sm92DBE2/LaPwCePMwxV9chhQkzzkrJ6u1kKn0e3IF1mKpNWFY1JOwRy02bcecpRFi92UX4u2TgWeADzvgQ3UO8liYGOXWygVKs4yEdDu1/92rj9Zw564DZFlsuu23cteKIXUH8qfogUr7FhouIUN0e1QT1NEmUvM4jNo1jHImZLfDUi7gRX120+wFNnfo2u6BTLwgKw2Biu67k5FtBMch7uypTzr0KmTGrE+Sp6SNW8nQLA9eUTppA+2r6L8Kcqs8+4ftew6zZuAl2WxJmqLckH5vrLI1wa5xQAX01Ogcp3owpVOJUFO9uPlSiBee+lAde4ARMg1UxVbue/Wp6Y14gbI5BCpGlMbsJJSF/1ce7dqqYw9bSwD1BhB5vEXSp+WPNJPlk1eYGlO7Isoss6CRYM9RsUfAyNhM7NLAZRhC5pBvgoYYxuTrYkC8o89USdsr1fK/L5JsoN/NjGKVOcZ+FyYcF8+gjOjMrN9fh6ZczgpBSaOOFW8NOdKbJkdYPPbAKUcfoUhihbuCCnMpaQp+f/+Gvhll c2X3WFnf xly+v2ER8Vibo5DsS/cI+TTwPF8ZmxzkhSUVxUruCUqYFZliwvXGQDrUQ1f6Kj0bDIjJFDmzf3P7Oj02wpBniotKnauCWAONn/5rKJxOSWZuMQHAnULvDaZ72ED5ClGZMv3UkQnrdYR0WfExDzNCueg6p85TcTRWmUvlO3YtEjrONykTOeHycPfDhh6uTseTPZwWFh5Nf+3AS3OV1SoQ+o9za0oXN+HYinBgctpvCWSj1+jNTGVwB2v1/BxsANfZrHDSeRCAUWbFefad0q8udQUZb9qqAEBTEbB1fd1gagrzlX5ZZkXN0ASE+KcoUTLbBjELCnEAQ8PimhBdOsaeiUVPK8dEp6UOkhiL7CdMiX5CjgXU9vadZRGOZCVCIyxDu39rChDZDvzlRoIO8D2xMD4EuWL1+U1BbKmGwBr37Wbul4wosEKVFKML1taP33JxINqMPFnDqsN8pEUss2lLKjdcneMW1bL/DQPRM4Sm4uW7saEtqUrEYExZ/r3b4SfRGac1zNlfO27nkSDTWtZrjL8cpObRx86IfJMjlf1AcAaa5m+ZlBhbWMPVV7/6f3ueQ/Ea+eZ7mQOFlOI4HEfa2TKqnfH9ePQGYahM2WPyI7WIYtZK8d/Y7VCGgOnfMx94guywugjS3/DVw73xsKX/BMlfU9n50rX6FISwx/WS0wPPTv5sMlX0Ff+itPOm7TFRkHDpvk53USvDCDo63bldU563oMi8Vr5zt3XLK228V4aiw+6CDlGx/33tVnix91ZpP8CfOqT2obpkpvImxoolfMkauX8bUNPNNiT9u+JlXgOBSj8L0mn5bDeMrC2VFVi2jeY62yieU0Sf6yA6bgEVAQ9a5jOWM5WJmZJFFx+RTgVtbpvUwt/fUuw9QzFHy4QLdW1WSMFyD2U3aBA2XnKLSkP7qMoWFg/p2u63pBxNCfi3TpBWfeKn45SU5jhWtljMC3ayTdJM6QkWMs6POSip7J7sKwAy/ OijEC6fb qsOiCA2p/hu16prFHew+DWmkPKfCCWGphFFNq0F6448aOtgRX7wCxtblsOFKMuW3ujsL/Ul1Mu3XE5seIyYDcwfMj6U5O1MpkEklDdiwyjkKuPF1HpKHu27J/qcHjJUlZVCgxSh0PftrJT+YKrmHdYgDbhGASny8DsSh4GKLrjqmvI2QlWKOSuGguFyY0wUHBLXrNLM7ABWumcoEqCx8ZW3DujecLIJXSOOa3beB/qYVv0mFUmXCxe9DwMp5wEERavQl93fRQb+kDiv19sntmhBc+a7iDMXmrPf/1OjXz3UdCYcV9ZFdqKyWwUYNILOBcBq3L+FKIJPJ1ZROyZDnYhfan6adgj/wTtDm2Py2q6kmlSH7S0Zr7CAn709bKp1uq+qPaJ+oGdI8JtQiDjdzAO/aIzWPzKSenjCJiuuM3pNlOc8SjrA9WSQNnN55uryqW2KdqP2WOEnRzpQFAo1aM1ws1/pFyDDfq168B4XZHp0MDiV+1PNGzKiuITXOqiVvekUQpV5P00NHZvWtRjHkaI3qli9UgQtCH2m+KIIoxWD83sUUzpgL68PjLiDrCFtDnUAtY0ZbU/MBuDKJ0olMpeeQtqmJzhxRkgYgpoJdD26vXt7oApmWqj8uVRDJpWoVcB31YasfigXCc9gE+wE0HGqtR0GzVMwuHMHbPJLOp2mfPl7XmCxs8VbQYBt3BVj7FAPonkxUlUBL66fr2G0EOm1oih4wAqRXBaoM4g81bftsAlNQBrEPLI3tYYYW3Sfuo3ig2Ni0jbqELGDrvfoVIb2C0pMESrdl0y2btLhtbgvlRkPUtcELizS/xv/XvWwmgRQh5j9oQRcxm9+mB3rBlZDjwBLWqvsYXDK2KljNc1roaafhD6cnLMNedfBGnQR8O8eU8J8ayouxs/lJ0/x/DelqAupAdXvY+sOW6whUaLuRHcnHMx67wNndqtwgvdvooG+U9xi7Wv8BWEsKpR1KyZcJVqRD1 AWubjrFy ruD2VObaRREgDO5uKoUOf+irXDER1H6qq6NHdji6YjUmiyB5yoyUfOmrVpfGOKIOvCeGb8vzkRANIUcrQ1FGdK3tXQl29xCLHTPqhBCZ74TcaPrUpDJMwS+IpadrBM66aE0Z0PJGYRtIBezRI8Ic5cjWUyZdSG4rC4R8NcNWamNXPJ1MZPc9t66TG6LBVO2G+qS1tncU3WeoNP6/4KQ/A4Pz+xEi0AysJYmnYeM74s9k2tW0HD9y4BztSLF4OAMsR5eUgXq75d7d4hVXp5phPXNr2PkM3oxHnPhynGV2APTwGDfYxG/h2i0zvA1Y2W/2LROZ2uecCaTjjUQTUFMzeBEO4kdiMcBqUCk9pzlSeHzkpWpjYS7i6N4mcMLGJB2iqk6QlPOWoxDrck7szIkAdUF//Ap6hXGWN+f+RYI7G2mSRV66+8szKvM00xoS7XwPkuTKJjyvvdZf4gPuU/C7eoXvFJLGxhHMpdSr6h6o5GjocjWxWiGd+YRu4XmkJtQMhYTyyMssIRgW0OPKyzifBshBmYoh7grfhdC4BBQXAJa3daN0XcW6zsfVEYpPSyGleqrNl40zmVKqQf3HPfeKhisQhnl9In9YFVbTmj8/VJOnzC3DTjVo3LhbNYVV8Q1d4oID4HsbihX4V5PcPjS/ZyNW+BZNyQ3sOpmaZHymSok6RvQK0zWgDxncqgTMQ0eA8grQS4USZF+vajGM5EntAhEqGnxt+An9c0diAKvTkDUEK+sRAFi547XoWBCBvhv9E3zNIEmXqacXg2PEgaO81ZmOEUTUNohOB1bwhtUeGkXx/azarZN+jYiUYVTJgrjkk9bC37xY8r9wPh3XabV6uUFhV5UQH599+VEm4VgJikNmOuHnarLYDfUmrbVGYwisBgVfqZAWj5mo5YeCOuN/1q0I/O0yaha6ZVctmx7fj0GnF3cTBqJ1zQhm0NwK1+o/M0xnUrey648VNK9ePBI/6cTEUfgKF vX5ps7lU evw4PJanhw/bWEYHwaEXlYCkGudTjzmX6vCCFR26mv0AD7cIgZktxqvWsPcmNmymU9Vmot8naM/9veh8uyeV5prxNzc4XYVnRiEQtx97xGq6+3KtIoUiH7dGew+jj+C/VP/C6dVxuAMvcdi4Ng8HEARTZNd+v87YNxu0q9myRw4kl2lwVXvkIhlHNI55DoLSzn4+9ge/3LKJ2zIGbTlfI8X+h+Rihk93VIiIFl/ukbNyegDK4451IMmB45AAGSXx+brQKRRAS9fniQ+YXjG8qHUJ0ndwG9X1HLGHkSI+iGZR6K+BEo0hJ9Hv4J+uLavffrgwAY0r8WaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > It is a lot of churn though. I think that i_{a,c,m}time shouldn't be accessed directly by filesystems same as no filesystem should really access i_{g,u}id which we also provide i_{g,u}id_{read,write}() accessors for. The mode is another example where really most often should use helpers because of all the set*id stripping that we need to do (and the bugs that we had because of this...). The interdependency between ctime and mtime is enough to hide this in accessors. The other big advantage is simply grepability. So really I would like to see this change even without the type switch. In other words, there's no need to lump the two changes together. Do the conversion part and we can argue about the switch to discrete integers separately. The other adavantage is that we have a cycle to see any possible regression from the conversion. Thoughts anyone?