From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A423CE743C2 for ; Thu, 28 Sep 2023 21:28:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0952D8D0053; Thu, 28 Sep 2023 17:28:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01E4C8D002C; Thu, 28 Sep 2023 17:28:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D64768D0053; Thu, 28 Sep 2023 17:28:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C24F88D002C for ; Thu, 28 Sep 2023 17:28:05 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 96C16B4505 for ; Thu, 28 Sep 2023 21:28:05 +0000 (UTC) X-FDA: 81287294130.14.6E1B7FE Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf21.hostedemail.com (Postfix) with ESMTP id BF9CA1C0011 for ; Thu, 28 Sep 2023 21:28:03 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=NGPOVv6a; dmarc=pass (policy=none) header.from=mit.edu; spf=pass (imf21.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695936484; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w4hql40FuyyfsTNK9D530X9ExV2y5b7TU7/1a0HHsnU=; b=eotYFqLC6dBblwZA0+iu151amygGeumh0On0qezsfPFo6EsDZhG0oKPgoIneKbBRXuUd5M fY6kcn4JBe2J78VDPi3BMSKaa0rND9zT2y8WZ4G1lFYf9tOWK6Cgdooo+ovXz85SDuoKxc g3TYD3Wg3Yn17ffDS6ih0sUcdjs96ZY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=NGPOVv6a; dmarc=pass (policy=none) header.from=mit.edu; spf=pass (imf21.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695936484; a=rsa-sha256; cv=none; b=3Dxec8AMB+2V7hxHpyOQHqaahG6xgIvsoH5j7GIduArGf/SHON1aKcw/sJMdeI15XUGWQo +f0I6UPZZD7bkc8UGdNcSHXKA9TkXBsX+qxuB7EtYF/BlLNRz20HSBV3t9OtEj6Lzzihvy ImyVuEHGnFpmCcP0pcBymYFwVJLtRI0= Received: from cwcc.thunk.org (pool-173-48-111-87.bstnma.fios.verizon.net [173.48.111.87]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 38SLQvsA021537 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Sep 2023 17:26:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1695936425; bh=w4hql40FuyyfsTNK9D530X9ExV2y5b7TU7/1a0HHsnU=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=NGPOVv6aP7Wgx4/k9ruqGjDYWmjUQVAfEL5fppG6yE2RNxUM6uiyoWrXBZfGmZyL2 gb1zEZjWcSSCFd+NWg1/BYhZ5jeEptXNin1ZAM6seg38Angccj8YOPtyzxOx/hDFrb Q+ePr/t98/fHq2BcSzJCThnFTNb50fVmlIrGfb3oMvB11ToZpH+p8R2mhaDk4/44dl uEHGVh6Q6Ih5iyFuN8+PasXijpXT1PXJm+5Rkla8PX5Glna1OAsFe3wre6CQl62oa4 RAr1Z2b44rKF067M11yaRPI56z2wMDur4vLyEnjrhgmaYzW5D9XQ8I+PJlbP887wDq NXSNNWLPWiTbQ== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 06AD715C0266; Thu, 28 Sep 2023 17:26:57 -0400 (EDT) Date: Thu, 28 Sep 2023 17:26:56 -0400 From: "Theodore Ts'o" To: Jeff Layton Cc: "Darrick J. Wong" , Arnd Bergmann , Alexander Viro , Christian Brauner , Linus Torvalds , David Sterba , Amir Goldstein , "Eric W. Biederman" , Kees Cook , Jeremy Kerr , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Mattia Dongili , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Brad Warrum , Ritu Agarwal , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Mark Gross , Jiri Slaby , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Joel Becker , Christoph Hellwig , Nicolas Pitre , "Rafael J . Wysocki" , Ard Biesheuvel , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Christoph Hellwig , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , Mike Kravetz , Muchun Song , Jan Kara , David Woodhouse , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Chuck Lever , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Mark Fasheh , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Iurii Zaikin , Tony Luck , "Guilherme G. Piccoli" , Anders Larsen , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Sergey Senozhatsky , Phillip Lougher , Steven Rostedt , Masami Hiramatsu , Evgeniy Dushistov , Chandan Babu R , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Hugh Dickins , Andrew Morton , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-rdma@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, linux-efi@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, gfs2@lists.linux.dev, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-hardening@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, Netdev , apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH 86/87] fs: switch timespec64 fields in inode to discrete integers Message-ID: <20230928212656.GC189345@mit.edu> References: <20230928110554.34758-1-jlayton@kernel.org> <20230928110554.34758-2-jlayton@kernel.org> <6020d6e7-b187-4abb-bf38-dc09d8bd0f6d@app.fastmail.com> <20230928171943.GK11439@frogsfrogsfrogs> <6a6f37d16b55a3003af3f3dbb7778a367f68cd8d.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a6f37d16b55a3003af3f3dbb7778a367f68cd8d.camel@kernel.org> X-Rspamd-Queue-Id: BF9CA1C0011 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6mbxxqdwcwijcxyk74eg5yikk3gqww1u X-HE-Tag: 1695936483-111180 X-HE-Meta: U2FsdGVkX1/I7jnrM++gBJEdhUFilLwXD5eGw79vxqwiUGAHoOiuMzIMXm5YH219YLPjnyVeRW/eHIvtyhU6XkGWbljjArTN9XIB0MBhjF98HxiREazQXrDXft50fiuH4OUgcp2mvHZWZvZDKYiaaSAexFLXuY7c4Od2kgZSlX3gP0ogALXUP5xPQejp/S5CMmf/4QcgZVIxTGuvuOfORZRnsaZMPuRnvFUIndUfvtDIinzVta3oYRlKousOl9UdmTV3fnowmqPS7PZDgn3/K6xWOxpfJFnK6B3bKT8vkxdf6etpc66nZzy44rCDkQPV1htySLQA2Mwz5y5aJSNDsB5XoK9U6MCReUZaKhgX5Ln4H4oaiplz+BDGapQ47l87KLH2mIZQ3rl2/2af93vLXe6KJpPI8cmM3qXkK9GhntB9b4vXny0uK2PDKjoA4wr7VOWFlcPi8toa4C7ZrvQkFQZmOOIisBtXG1YLvqI4l3F/9JSNDU9/zf4os/y5hKxsHrhfDG4PDQwV7hs1R758ytHt/jWC+X4eFb5vsIayqZq+DmN9teO3P5V4/h/y/I3bYz3LgqF0VPZ2+y2j6zzzEOgTDpKC4uFNdnEWIi7CsH9EzN71ZSWzGzi9xt/MG3MY5O0a4OC4kwVOIOOBFc+E0iBEBtAFpBg5FunH1HxxE2S+UZQPiC0M0LA4LLt6lGd66qwypt384saMtq/s63dtkIpzDh+tQvy9AOEyqHJhq3tbWZMhknYaCBbpi1CTO/AisHZNSi+/cHVahMRlS3czoNW7xQLoEJEvy9NbQVaSIJNB8r9hCfGfr4gTGxKBcHaizEY0tYlw0CQ7Ztu40+/AWktdLJcDNwrWE7TjnSNqfz8dCg8ouUDL6ynXL8B4eaiOz1XdUqe4H9cZRg/7XDBGaxWCoCdF5HX80ZR8vPUiv+PTtwNgc/vJhvOh2eQjIfSJhYY4zcdq6F3dDMd+STU KHtcc2cE yuXPFYnn+aOzAm8h7p0XCgpWoYCV9/kwvrOZ1D5BA48Jrmx/HMYLn8ejKLi1Ks4bfO6iOr95bCIJJ/l/b/SowPa6ffk4EsBgxHrLpwXZaKWWktSbDJzXphyS0FCUWe5tywoDP7mT6DXl+MctS458NXVN3hh2qWOkFXdRzIl69iw/YQeAWuYUOUmsoTbJ7/qQ2+VL5Hlf9+bUod03gTtpvob1jm8ZZat+VEMg4riJpedgDdZKwKbNJMl7FPTQAntQubGi4/iov2UPIZQdUD7hmKCwhjctNPYm5UBSIurbvWeLkgLpZFXhicOVifOSVu2amxEgDk+xwLE+JUr6CF5vXdkMGZ+CLYme365njp6YIC2d9gjGQPAnC8ZKTU0Q9rgYOsc4focl+FpSOHrSCERkB4G7I5IglZYUBKssquunQv7rgns/kRLKiVGkBwdswpmJAkRRBWEFAjrdt0dQH8yqjprpLlyaO9I3RDzlZVCIndPlyd254FVHkIqtG4bZQip/R8N8HFduL03ZUFhV6ug+LQKA+43B+xLIRtpqbpg90H8RXUS6DE3OoSJDMz7AkBNuUbpTDq/zClpdhwYncFsOxWjS8E4TCMLjcgBj6bNiOoYib2Rnl4Wzzvu+EL5q0YOVemvgD4EhQCqagDoJyBbyDEAFcG2WO6aBSbHdvs2Tz5g3NQwVZ7Q7PhyT1Facq6cyvH6SuPgvdR8GKSiSJH0z0aUV6oGAJJ1hYyQZwv3ZXSvXm+iPBVLu4EZ5f9xM2uZF32KS3futMZ9YIHIkesGr85gBD7IUyNYXarpNjlwT44x9xZ4sKjwSIDu8xEhpsseYA6Hy8POzpACpSCrXz05xIs3AnbfDIDaOf98ePaxeIs74edTZh4ZH2C8BNbHZ/RyBNrpoMPKtdI+FLRnxdix5yiMxfY742wLVuYQkG+ZOTih+fFauzFRb9M1NODws5UDCHaiJMB489bwGJfHs8we/sZV+EDvXR E7hTSuiJ UqDq7HUtPG/4RPFG5Yxw+xDNjD523E6Nab3Ij/xrs/2kXPW3aEYTGMSiJpI7KALNoVg35Yi2BRVKnHfFUpoGCxNQZwnBckwu48MaG1MqDTH+rvlhnYBGPydDSjveXCv7+h8nhl84GP9XFxe7ewCE7Cy8lmfp1wkDnb7eA98gDWP4Xbtw+tYqVpRsRxPfl7JmVSa/lCrAkCBi2n0qJtyMp9+f8Uu+TogbljEbzhLxaP4MHcLj3jHAtmLbjIdLwShoAfFG/BBWG3EF0Qyg0IodbsiMVc3zMsmuNZiVfNfF2eO/oHg8xsLuLIfmQ1aGx42BdTWsbGpYNeVud5VydiBE5Kci/b1mYlkn4LNxqtnDwcvKApRwboPrPGx5hY0xx212V5PaRkwyNQfut0oXyjxY2p3Nh2yi0VF82jMfIU96Q+KB8YBqXCl9bFmUQI9GDGAGNFFUcDtz6/ce5ANgk5ZqxLUfAIWw2Vta5RpWYj7OMyNp7TcA/uP08fVJ/JUdPDOQkTa2+yQGoHof1vAo1aimQL20+chDz4qrbNbzVorSk5I0Sg0FNc5t53M4FJYVoHrln7LNduOVRxQs/3EK/cGYAu3LbAlSMVKNFbIwbucTWwWNIo+O40dKAVZMWFihBUcdbI74NpD140HESlEKsxauo/BJyvhUmx2g7fIubIcrWXCAWO4nhNnKszDrH1h2pbAxgVsdvoPj12qjfwz0TbilzHTNXoPcbSU+SeYeQxPqCap3Ht0wHOfayd1BFNpkkSfWNe94G2K0wUQDOPqSJ/haTD3tZjcsjgpyB6lweqcNbiOjiEU8kDjmqqkc6rVDdvGngk2fIMV31ZSqiua+Fk90HbPpHRFL3kQ3jNu3oIpjj3TYfdIBA95iPo5xLRmHa4vMgPKNjUlFdkdQI5u5MGZVm7L+8laHC9XKZim4oULAkJro8sj2WCU7iid7H2Y9+gnIAXE2ABV77a3uVMFJTqOFKOVqDLvIN A9aOsv7v QPR7IGYoXbyEXkQtCaJdRC9IjNRIfrUxbB+5T45dJ8O6vucBaNJCOIhDmORzRDmzc/8BrZbaxLvtaRwmoQ3J9uic4oVYM+/y7LmkxxId0uPBjvCzuXwF7+5N4XrulSy1OWg7QjA7/OsSeqyIPI02bGpqJ/i0xAi7RG8B9zlPQH/Ny0QqaeCOYGoluilcg/h8OLN9zzl14rorJTvsaKLGVGhN7VkLPRyNe+bo1Fy0egtf34zFxCeH8kTUP/nPzTVEBLYlu7DHYxlZsQxs4M+DRofJTwtF/wCqkSGfCEprqcQkcBsIOzkHaO0z+Nf0cUREwhSRdqJVJW2+0i/7THZqxTJ64X4gDMbYK6GmHK/ayeVooymLn7CFqDVZ+JtEahd1TCEYYylvoNWelvIFzNcsqvkdXu9Lus5P75SmJUsZKwuf2lQQUyzrLR9NIEa3bWdghZzdD0EC+JTxpHUeR+EvgcOEbaKKNvIQMPSKo2S9zZCJw5hsOmZ1av2mg2P+/zc7VfOwzCMDLYoeQdNkkvYHxioPM4I1ZmLfBmMDq1nvr1ReD+Z3MLusI8H/MtQkEWHKIzVKTwjU8xX3WMHMBkSxzrmfzxBbc+cv7fftMs/jkN1BHGKskp2418GuRHm2MpFE4pzdCqId4HNbMelDwgqzRLfhck9quU+XiDsNIChM++qCBr6A06bCWtqWTP8xCp+hSamYjwnaLV1mePe999RtgRGEqGLlVapADwWpgUYJl1dSNzXIDelBTPwBYqhAc3EAFKgky+eIrZnJK6gDzc6xSh9NS2QrOv+v7pKEdfG4mm7eO+ntIRm5FfgIBI9bulMN+ExuTEdwIdo4eG8SpojvCJ8vvaMmIYs+XHwsuX22JlKlO0Bz7cwh6Z+5WC0DX7VhStvHaFzy1prwzivNPPwkUdCWjpPrLlIzZoGBo3LLZd9z5NnveyTxF9weT2vNlFLb24D5m1yFcKH4vN1OxEkuyLhOKsCCO XZt+Zg7p RKEsFyfFy/x8kBsDRG649vihlgQWRLim5R9NZHRV9zFEqouPqGOubhxnjexsk1mDZX8R9zGgXwedklRRDGp0Fo8rJxmhCSZGDsBkf5XUBptX49eAlanTOazjLlZZzY6V1D2fRXij3yozo8tdx6FCyrTJhy8p4qXx0ygOU+U+aEI5EWchQGD4RLFRDL7mgfwMgZhJZ54ZzUO5ufVhKQrQXH15PoyYi5iErsmTsTWCWuLpezgsWETnc9MM5+mehhp3n46IcBaeTDp2abFn+ms4AcMgrIvjMl1QGvQ6y2zh5Cug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 28, 2023 at 01:40:55PM -0400, Jeff Layton wrote: > > Correct. We'd lose some fidelity in currently stored timestamps, but as > Linus and Ted pointed out, anything below ~100ns granularity is > effectively just noise, as that's the floor overhead for calling into > the kernel. It's hard to argue that any application needs that sort of > timestamp resolution, at least with contemporary hardware. > > Doing that would mean that tests that store specific values in the > atime/mtime and expect to be able to fetch exactly that value back would > break though, so we'd have to be OK with that if we want to try it. The > good news is that it's relatively easy to experiment with new ways to > store timestamps with these wrappers in place. The reason why we store 1ns granularity in ext4's on-disk format (and accept that we only support times only a couple of centuries into the future, as opposed shooting for an on-disk format good for several millennia :-), was in case there was userspace that might try to store a very fine-grained timestamp and want to be able to get it back bit-for-bit identical. For example, what if someone was trying to implement some kind of steganographic scheme where they going store a secret message (or more likely, a 256-bit AES key) in the nanosecond fields of the file's {c,m,a,cr}time timestamps, "hiding in plain sight". Not that I think that we have to support something like that, since the field is for *timestamps* not cryptographic bits, so if we break someone who is doing that, do we care? I don't think anyone will complain about breaking the userspace API --- especially since if, say, the CIA was using this for their spies' drop boxes, they probably wouldn't want to admit it. :-) - Ted