From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88686E743D5 for ; Fri, 29 Sep 2023 00:48:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17C018D00AF; Thu, 28 Sep 2023 20:48:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12CB98D0002; Thu, 28 Sep 2023 20:48:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F36D78D00AF; Thu, 28 Sep 2023 20:48:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E4F658D0002 for ; Thu, 28 Sep 2023 20:48:37 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C07731CADF4 for ; Fri, 29 Sep 2023 00:48:37 +0000 (UTC) X-FDA: 81287799474.26.10AED61 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by imf09.hostedemail.com (Postfix) with ESMTP id 03AEC140008 for ; Fri, 29 Sep 2023 00:48:35 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TY3LwEEv; spf=pass (imf09.hostedemail.com: domain of keescook@chromium.org designates 209.85.167.174 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695948516; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tylYhPEWtThqOdjkF6waboL48MfnCro3UFLr0GQ9x28=; b=DC8kk2ug442pF9RHAQN3E3ZD1Wmjl3wiBKqbHCitSGgvH1+DGia8gvuGi7bZnegMEom8pW b74R+jZc/yHklJyorDdpOfCdC4vlYVYa1p0UTo2wqfeCNWjE4dTgFt+bWHcr0nCYhcb52D fSMcybEofZzmVDJhQytq6NT0wJ6IpWY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695948516; a=rsa-sha256; cv=none; b=QuvkRdlB/+9XN0+pv3kQhYjJr4UCC1pfdHcRfHTCC0t7C9PkOnzAUmgVk6gJafF6mQStue 0m0jhpuyy3ZF2+2QEhKFRjqH+U3TMEkAFz4NKGlw4DwHMnmtyjeZDdBietWJPjYV+DDiG4 vSbluiDKm/toy4kchLpcydjETG7zbgc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TY3LwEEv; spf=pass (imf09.hostedemail.com: domain of keescook@chromium.org designates 209.85.167.174 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-3af5fcb5e37so1635845b6e.0 for ; Thu, 28 Sep 2023 17:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1695948515; x=1696553315; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tylYhPEWtThqOdjkF6waboL48MfnCro3UFLr0GQ9x28=; b=TY3LwEEvGanwePSOrEkeyfM0BAEsaIn6Ov/hJ5Nv+yhlHFQKXE9D7UNzVRjUezP/Pu gwPn6pj7tpzgz6+b5677AmVGpvjf9h6xRdY+2h/5kSoJIihfDKGVgBbzZh0xvYkW2Gc6 u9+fy4E3srXecZs6cY26MId6FPk/PcJOPsgBo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695948515; x=1696553315; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tylYhPEWtThqOdjkF6waboL48MfnCro3UFLr0GQ9x28=; b=N7QgNxnJZK9EfudLB8ICsoDG6KGe9FYer2xaDOsWzo/xuUmSBNj9rZZDsnleIx29jc WIymdcljO3PcFmuCGZ47zFC6mkfgNz7guXNTncYkbu15NaRT5/Q70cZNIJqD58y8MRP6 dKS9mJZ/mD+/2BWFrv7l1mP8SnawsCoh8ZuAKvMvF4OImIklR2vOlV0itjRkRp5VnDDf QbXhmWaaOPVU6TUGjIbTRgUpq5J32l5vGtj2SztgYBa3h94S+bPaXSu/BUEZ6u2i9fZf lzDuScQQBToYEgdN0neJIkiQv7Gbo0Pc1OaP0v8doOkL753wHYNCD0jPQr375B95fBji 6z0w== X-Gm-Message-State: AOJu0YyAgaBTRP+ks94pUKilQgdvuvjLBleR5cZL/L0h5Sm7SejPg9zR ALVyP9iHASl1nfK1HDHD1Px2JQ== X-Google-Smtp-Source: AGHT+IEWHpwzSGA33eSq7rADLwnpRwf9x79Yvho2lnmUCGF45oywwNmstL7fJN9k86IblRlfWA/0BA== X-Received: by 2002:a05:6808:14d5:b0:3a7:36f9:51aa with SMTP id f21-20020a05680814d500b003a736f951aamr3226322oiw.17.1695948515082; Thu, 28 Sep 2023 17:48:35 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id q26-20020a62ae1a000000b00689f1ce7dacsm14033655pff.23.2023.09.28.17.48.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 17:48:34 -0700 (PDT) Date: Thu, 28 Sep 2023 17:48:34 -0700 From: Kees Cook To: Mark Brown Cc: Shuah Khan , Eric Biederman , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] selftests/exec: Convert execveat test to generate KTAP output Message-ID: <202309281748.7BAE187A@keescook> References: <20230928-ktap-exec-v1-0-1013a2db0426@kernel.org> <20230928-ktap-exec-v1-2-1013a2db0426@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230928-ktap-exec-v1-2-1013a2db0426@kernel.org> X-Rspamd-Queue-Id: 03AEC140008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: cth11xcr8gtq9edymr69p8f41d5jwosy X-HE-Tag: 1695948515-763096 X-HE-Meta: U2FsdGVkX1983ULW6+5FMETXB9kxo7wqeeMyRRKfjJyOqulnBojzTJsM+9+8QGRfGQFa2JnmUrDJShbF8nbIV7HuOhLLCV/JmHH1rVeQlG2lk9hAta+EVqAbA7NpqiaJkZ4sEOoFzBLUQm4JLHSJxLbOlzYSV38f3EpUGMfjo5tjRC9QaTar+nOhKdUkXsO2w4YtkoE3dDB9WlVmlaFXGoud9hSUmOhRph4/25UuSIYAtiLRbRpQdjZXtbVj6BfKNcPsiBwFySCb716sOmXVzObIolzUbqDfPi60KF2ShfqZOwHe/3ah5uq1b87+Sp+O8ZFSZhwad9oSdB+O+HnTuRYTTtrNsCvYgbm5McFNhJj2Ie2IpCgvGhbA3He+KAkOfC/Y9vUC/mDVo5IOKoRITFM0TOGOmky0My2kKh+0ZT7dlwBWjM6lhTGUKa1v5ei/oeAmxlvyVoStma45iPF+Kn5pUs2xfn0BmgiI+82h5Acc8MuV6UVEV++bngdAfsMDqYFb6fMhFwayxFck3k66vOEtp4GXNVcqmbD1vVun0pUUhRULoN7MSxKWQ69M8nRhuNyFEgI2u+3exhXLbDe5Br1RiFwy8lzDEdDLuLYNTArX0nOK1Ut+7bwuRrFkKnaiJq8m+3yvP2ROtaYVqVC8OaEvjK1B/de/1CSPGIzh5hiSgkAMpXNgIbaoajCanMJ7mXRO+oghaO1My0Irf22K3JLcc42j4FKpH0zow/g8briRZEqzNn7c/efZdanvl2AeCtTwSEW3KzqeP51BvaFSgTUamYsMxHVT1TVqh7tMkxoPLShhculcT3LLDUZWnmXgYtGIMOVm29sgzfGDZ52ktT4TpO1iU4vcLxRkhhGIJFz2Uk+QiBS51vz87GaBgj+cmMU8eSLUBceJ2+6BcN7/K3bt0SBLsQizE5yluvMX68P1vsmXzhqzkW2RkvQHX/ONJRURLTtQcHkD5UduqT8 +11Lgvur R8ZzGHlmR5kQ/TKAWDDRSpV1qBlvmEl9qe4mVubg4VF+ES9Hfo3s68MCImm3zkCc6VHOmQKHfP323sXW83d/Jum0MgTy2494RZBnmIirPW4LV6ZjsOG69qUfPToYYuMZOW+p5W4toqznTVgguOvStz3QhoP2DCmRepRDc96HF2M5OctE8aGeEb+KEHC7XmhnrInQzfRjgCcFR7B5e/tb+6LdQG92e+I2QuNT5l2H7qU94y0gcK3MpsbuJBmenLEuUyxRiPzaWQTB9KNJ/AyUWCChdllPQJ1EyXunO9P0IP/T1Wv5GIYkedKZabwCHZQ2h0UX+Y+ejouWYUSC2EFdB0UA3URWwN7zSYhDYK6Uq9zUlGIGuNZzuePSzX7LmEr4ypzUHH9l8NUNN/R0/0Y7Zki0wDetzwUEo11e030XYcS9/A1pVwLMQZg+0/myT+1lRgjOgbKWX7MAhIUhrDMXtNjJaxWzfspek5jNnTNmU7KZN5KY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.083232, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 28, 2023 at 04:38:12PM +0200, Mark Brown wrote: > Currently the execveat test does not produce KTAP output but rather a > custom format. This means that we only get a pass/fail for the suite, not > for each individual test that the suite does. Convert to using the standard > kselftest output functions which result in KTAP output being generated. > > The main trick with this is that, being an exec() related test, the > program executes itself and returns specific exit codes to verify > success meaning that we need to only use the top level kselftest > header/summary functions when invoked directly rather than when run as > part of a test. > > Signed-off-by: Mark Brown Yay! More KTAP! :) Reviewed-by: Kees Cook -- Kees Cook