From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D351E743D3 for ; Fri, 29 Sep 2023 00:48:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4D7D8D009C; Thu, 28 Sep 2023 20:48:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFD958D0002; Thu, 28 Sep 2023 20:48:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC6238D009C; Thu, 28 Sep 2023 20:48:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BE0D38D0002 for ; Thu, 28 Sep 2023 20:48:26 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9445BA106F for ; Fri, 29 Sep 2023 00:48:26 +0000 (UTC) X-FDA: 81287799012.21.35EA2CC Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf10.hostedemail.com (Postfix) with ESMTP id C892CC0016 for ; Fri, 29 Sep 2023 00:48:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ChQwSFWH; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf10.hostedemail.com: domain of keescook@chromium.org designates 209.85.222.175 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695948504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iXnFgtnhV35/5nraOkVV+b+6GuFhRtwpj0ASChSU/YM=; b=8J0f+jNOOFaN7Az0Lz92OlvTuyxz6IgyH82LcD5gzniNx/wMNiScLHD2swRYaMcETBHG50 PD9t/T3EI8Ca8r1M5p1eJ6xNVAbaw+HxPXEM+EqCp8cdhZnQKfdCx85u+8eYVu2NxLMEa+ 0UlwBIBgR2bgjCsw5R7Aqi2DU71KkUk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ChQwSFWH; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf10.hostedemail.com: domain of keescook@chromium.org designates 209.85.222.175 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695948504; a=rsa-sha256; cv=none; b=t56OPZA7ipajnZ7wG+xt9Ql5DZj1UlAsUYORCJ7rtfllFeXXNXm7kryVtq8EqQYZ37OO0D Q+fLNDHyDG2b9n3A2PsP2pn0pj8zWhGUPOGQFR9dj/0qcEJ6uxtiKkreNGXD2h+Z/DELEy JFNapWjWiPLVGZ5XlBJSymCANoBhnKc= Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-7741b18a06aso841856285a.1 for ; Thu, 28 Sep 2023 17:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1695948504; x=1696553304; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iXnFgtnhV35/5nraOkVV+b+6GuFhRtwpj0ASChSU/YM=; b=ChQwSFWHpwq5r6jQf+IkK53+0ay+knrnAwZCbWwQtEBT3gVBzPMRQV/oJNwrb8YQqD APAbXHZcHNyU6CtyPrpT/LO8NcCL/JWJuQOxvy7x23GGmUlX2PNiv5IWfh0Vy5LkwR3y qecsmgZJvhSTedn7GaLC8j6wMUjYpj3y15vAM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695948504; x=1696553304; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iXnFgtnhV35/5nraOkVV+b+6GuFhRtwpj0ASChSU/YM=; b=m6cBFWtsJpdpWjgSBkqW1i6mQIzwXlo4lMyJNYxZ1+5jz3zn3PbqnwohGF4+zLnFZW gG64CRHn8UxsAT9qDjDXM5U2xGsktT5OIgbGOEWNVs2LfZ/XQkSpv0ynr7q32jEy98tz iTlcld3TRj2NkMNFmTdnMu7AM7sUwB7+uXRUbGDOVxk3igYeaHkqj1cYK9AuZYfYEpOG TuJ1IWuct9E+n994m5wHr/WtStK1MB+9iARMU3YPOtF6qOijY9t1S5gS6vjjgtoD61n/ qK2FmRreQVq/AWshnhWSF0y8nc4FzC2hJSTh1l2eUSoQWDwVwL9OLaYyp7/CeRRNlWaO dGlA== X-Gm-Message-State: AOJu0YxKhdAj3hqvWNZLSae79Jolx3OyCNF+Lh8ine6t5h+BFnOGRjNP u9znssZgK7gv5U6lm0yetbMECQ== X-Google-Smtp-Source: AGHT+IE83wxkVeKmbXMfPZtwhbMZP6G2xuz6158Pb6qsN4X25QL/jHQ9mWomvJzOpwl0T2tBq93Mbw== X-Received: by 2002:a05:620a:893:b0:773:eeb1:ed1 with SMTP id b19-20020a05620a089300b00773eeb10ed1mr2724234qka.51.1695948503850; Thu, 28 Sep 2023 17:48:23 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id j26-20020aa7801a000000b0068c10187dc3sm13893826pfi.168.2023.09.28.17.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 17:48:23 -0700 (PDT) Date: Thu, 28 Sep 2023 17:48:22 -0700 From: Kees Cook To: Mark Brown Cc: Shuah Khan , Eric Biederman , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] kselftest: Add a ksft_perror() helper Message-ID: <202309281747.594B3352@keescook> References: <20230928-ktap-exec-v1-0-1013a2db0426@kernel.org> <20230928-ktap-exec-v1-1-1013a2db0426@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230928-ktap-exec-v1-1-1013a2db0426@kernel.org> X-Rspam-User: X-Stat-Signature: qgssjymr867zb5oitiscwosb318eaz56 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C892CC0016 X-HE-Tag: 1695948504-537887 X-HE-Meta: U2FsdGVkX1/qCp61R4kauK2PRSwroYuAdM3di5X7u1XpFkOf8vlraBC2Lyz8FLeP1MIE37rWT4hQAmTL8Bez1ZGroW9aFgQcZzAivHqlymqlPo0Xmtoyk80kWgywpd8SpOZzMx34EVcH1ka1LO8CO1uC4HCHGcRVfsacMq2VebZIJSI0f9yAOqLyQySbsVhXb5Q3VhW8bPKj48K2K+lW5M5y51dHXrII33T1fmXyr2iw3ETWkcZIlLJU7X29g1fmpsWdsdVsPM7Gb5YBDtPeDk/k3QbhIoPs4kupmMedNbosqLjE71wtd9cZdI+pgs8Na4jfSsMbPtpc+DxTdq1iNHrjJh4DHzJsUGdsXc4xxsm9ENAQXjgVBMr8jmY9gJcraXtOlH7mHKYLQGfvXk1SFNo8r41GYqD+kN+7VXzdEUowre2ZNdMKWQHuWiRQLIxg+k6H2SrNF9ueqp6RI4qRqNJiinNUX3IpYjZ3jAhk0+WQW0/Jg/7YNHwJTGvAVEwbXinmVNJX36dWdlkyLDO3GFFOn6Vfyzc48JSxrvvtc+1xedgRMXedmsLx3AHT3cCEsF0R94Zr08LnQv0jlyiVhlfVw+pplkvCuxDacgTXabLLPobSVzyo2PBfPKqHMcH3LJcKXxa3aInWPPNvZR9tyLVx+NJXBZMHU+G9P7w7DXC5+v0uDEpic1m7DSpaTD5Nz2zk2DqtQCZwTuOKbwgsXV+Eni9ZSH13/5mc9o3ak49cbEnNeURYpdV2KujoMwwh+sGZW59mgA2AvPw+BBewhxDoudt6qkEFUw/5cbM3Aw6eTQWZUX62TOHsZ7PVY0kZWECcjz6EZRj8dsxW5mU9uSMDIyaTZP0Qf3Rd3/63PB0l0qrHhf2JMN4yQOITQQ0JJJv9PpH8khrJ9/FWGLK8xsaN8/4YDjOp/v19YwvyuWNEf84g46zZKhbZ3wWbICCDVgAIfuksUoL9+BOUNS5 E0qyArgn VFsMILeZrgIdU+JvXcaKWKPh/q0QqQjWGEmyvpGVvPqxIh/Ho3A0x5Lk59PfUNBtH602eatAadmDJB3vPGzOLAIhe4T5LFuZCp5N10MEdlZ9KVzj0gWFsH836h5vgB5KwNI0IOWTHNNakoj8Ax2EN9Bz87dDBjcxr3NrL7Jy6RMGo/tdPvvXjgemhtLWQsmhRockfWdZfLAimJ4UrGIa0gPTinOAyQ8HVtWsg6KIUmfeqI2pb8Miu3vx8fAHbNodaaU+vO9c1ACIaJwsNQ2puMrz3ap03I2XdwhB2BU99ETmaeKykzXGvE2eryfjAvr8m4QGFNyRMXdh/krrFe2u7t9wREug3wxSS98RuzdJu8sQjyty+vZveUmRoQUJmM6NmlihpCpoHxZ15xxrxIoLzj50/IciOiWwI1zpKEKFvW2CXbKl7OAzdcPjK6fWR2t7RVuoPmJOxTxQVDOlbHun23tPri5dcRpJjsxFXbjoHm4fL+b7Ge9k8UPzH1BNngy/82mNcISHkOqOdK+E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000212, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 28, 2023 at 04:38:11PM +0200, Mark Brown wrote: > The standard library perror() function provides a convenient way to print > an error message based on the current errno but this doesn't play nicely > with KTAP output. Provide a helper which does an equivalent thing in a KTAP > compatible format. > > nolibc doesn't have a strerror() and adding the table of strings required > doesn't seem like a good fit for what it's trying to do so when we're using > that only print the errno. > > Signed-off-by: Mark Brown Oh, interesting... what environment ends up without strerror()? Reviewed-by: Kees Cook -- Kees Cook