From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 685C2E732DB for ; Thu, 28 Sep 2023 14:47:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0E488D00B4; Thu, 28 Sep 2023 10:47:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBE518D0023; Thu, 28 Sep 2023 10:47:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C858D8D00B4; Thu, 28 Sep 2023 10:47:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B93718D0023 for ; Thu, 28 Sep 2023 10:47:16 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7832BC09E9 for ; Thu, 28 Sep 2023 14:47:16 +0000 (UTC) X-FDA: 81286284072.30.DF573CB Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf25.hostedemail.com (Postfix) with ESMTP id 648CCA0026 for ; Thu, 28 Sep 2023 14:47:12 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=Ll1gXe5e; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf25.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695912432; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tPU8iyjpgSIBCOSk7Wcxg0E9kh+miOLhLUIx3QkgCHU=; b=OsqKuVQ3uzPLBfmQN27FY9GpT/Aj/OO7WtjB2Ek0AdSo1i7eQ0HccimMXlVQ3AnH/etItv lMM0479z7115wHqXUjtbWSZNu+dopRJpN3+hu7cEq9uI5JM5/Q28Sv/ED5Cp9N9zYryF6x iCneTzsi7qoFQhTDfIYJMpsxnA/Ww6k= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=Ll1gXe5e; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf25.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695912432; a=rsa-sha256; cv=none; b=og+BUogHWKfl2QpXHx5OAA9WVHXPOp/h5Q//hogWzw5SgjnFCncf1VhyrMc5r0ffRfSgIo dF8FpMUL6JJMugtF51BBs37817xwhLN1KUp1UUSqPG1aaJ4RVLI/1METF4dJakD8AZ5XgA lrAkonh+AXELY3GtaHolz7RHx258a20= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 1CF7E40E0198; Thu, 28 Sep 2023 14:47:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id N5pJ5cn_zyMK; Thu, 28 Sep 2023 14:47:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1695912422; bh=tPU8iyjpgSIBCOSk7Wcxg0E9kh+miOLhLUIx3QkgCHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ll1gXe5e3fpQ+szMHmOHc//PTgpilvT7S57e0IhATDq6tDehQ1o2EgoeCSI3zAsOv qLVwdxpZ+qYC/b7BX0RvHDqR/ZJh9mBvjVSE2WZv0pIlr84uYoOdc67yRLc+Eo+hE1 v2Pg11lRg/BSvQU3bFmybtXtMo0YECtYBA5cpNRoVipS9y1xGTtLH9BZr2Fi4ONlMb uGYzpt3Yd+6AnMrLawD9QtPwfC8B0eRUH3Tpy50UTZZ8oFios1DjxXwX+3aeNWQku0 A10Gxc28sw7EpIUasKSPCHEj2tyXssapZOMiyrYxvAcxlDTGoD4imkyj0SWvJBtXjU 39xT6FcjXg2qgoS/js4We3RiaJNc6r+iQbhDT7RWlnU43MNPbtHmBHoY6I3YITtohr VckEzdycdx+VfDUprobZdo3u3ga7ikM0rxh/prcT9/gqYvNnJbxVESsVIS8V/1lU2T Q9WYW0nN+FHfenvuPDPLDmqaDZc2aDwRyUGhNMSRHdkIyfLEVzsgTxPl63Q1F73s7e PDU3q6FHB8dJkwgh8Cp+rCpGcmtUdWoetVfw2wrus17tp0nL6mHg8Ei7V7KtFQrsFi VV0DsvItSODlgmWqQajBBVIxGbjMw43m0FrOGyXk9cWLoO+8AGwt8PnhXmwH2QTvEQ rI6+ntonm/tg4EWbBwe1M3T4= Received: from nazgul.tnic (unknown [88.128.88.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D96CC40E00B3; Thu, 28 Sep 2023 14:46:41 +0000 (UTC) Date: Thu, 28 Sep 2023 16:47:07 +0200 From: Borislav Petkov To: David Howells Cc: Jens Axboe , Al Viro , Linus Torvalds , Christoph Hellwig , Christian Brauner , David Laight , Matthew Wilcox , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Williams , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , x86@kernel.org Subject: Re: [PATCH v7 02/12] iov_iter, x86: Be consistent about the __user tag on copy_mc_to_user() Message-ID: <20230928144707.GBZRWR693kYmj8Z0NX@fat_crate.local> References: <20230925120309.1731676-1-dhowells@redhat.com> <20230925120309.1731676-3-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230925120309.1731676-3-dhowells@redhat.com> X-Rspamd-Queue-Id: 648CCA0026 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: up5w3n7ofy6pwjfy8jewuxw89uidrfzg X-HE-Tag: 1695912432-364202 X-HE-Meta: U2FsdGVkX19Po2EIdeOYhgvsT7uRrHq6IWmL2I1U/wgHZ1ZLT+X73jHwyKO7nskcso4OOBwSNMeKjaamaPp9e169zUKTqTAKeRWK1GMR8YPVd7eQHBgtO+5Q/iapk0IUbJ2p02YyNCe8XKSpj1qymPMtA0Y+kSI8S0Zi1J+E0uQOXycbXH+S3AQqz68YlHm0NGjB7Y2raMJiXFbzU0+PZwWTxogJwxUSglkHhE3NbxfeNFCtkBO0VIfQDZ1XSAxBLdLeLeWY9AKcH5PEpa7zE6MWGEWW2BxKX+ggBrwD9VsK5/LBs4YzGbHjANGLnUXo7yHCL5TD2+jMhyyAUWDrML8A6PCh2OK1cQuS+QV2Zr1fD6Gm9BC4fZjIMilG0VSA9lP8WQxWUne8bDwWjaa3VDChjA2uqa9YLu8/swBUn5K1FMYC/58y2YnufMbrEYUqvKVM19Hy+z3RpC8vA5Fp8Q7Rpe8zJEamzXObiX/BlIX8TMjnepIld+yur105QPjcabATPMSzWJ0J3EX789NSI/UjZlYv+HWkeKwvXh1gLygPtqDUvH9e0MeAbHveKSlsxenU+9ALm6964/xy+sC5k1ldGP9uMkK4+Y9gjdtHXl2HWOVFQjvAKRsv8vTMPBUkclm3hv98r4L2bEDb9AnJIZHMb7Ygyi6QnTTmp3zFNPlk2dXA8++kSIXOZY8bnd3UYPOmPlCCWWdg7JV4etm0wv56hxbIyo5Q1ZQ9x2vJEW593obShylijEU7sT0pKr8x8Y+RuDVKhjIJLwiXCCvty8oaNnPGTn04ny2OiZb/jYCJf7JZ/xKmkYuJf5jW6OWWYFOyb/ZT5AdVFWVjC2tjyYClGyQ+ezy1fVOC75/zkpIg9OaZ3NMFWVLVXkvkvY6A9M3aqv/im2vazWm5CAHTvNHrxmblmrIKImSGdhaF4KyQayZnyFu7NIV49YoR04rA3U2KNdbCAX5khXQAcWN T0rE1iWY ZwvhlrjBm4dScsdbMJb8+frzmPnuoGJadE3j3PDXNx1i/DBe2Q/MC9+fgISE4wsOoSK8bGzVY/nTE6DFbnuaCSUPpLPkr5fYSUkBvE4CuToVWCQcvhyGDea74GdAT/jbrl9JTLWssvHCvr/kw78xpvpoV16kq/5USzm+hLObeVw9K7LC1mSoKtPKu7UZU+HRbPuez7cvX4IcwHvjZ6lQfrkzeSFHWTgPMXHRuoVbV1YcnpK4vHLL8itp4qKVCA21w+1x2wihRJd0+9y81HUDtqZrEZ5mbE4bf0rnukJox38WXuA5k9ZkYhu/hFBIF0G6WwwtSNpdZYrI9lu7tnEj0eY6+T9zOS6Oe/UqXxMaUTgiVfqdzYRE+eAdPrE6duXF5Inna2L+uNxNruE0xb1FsxOOwVffACUmldaMtLJLCbiAoyqoVRmHl3OBtTBiE5Cq7JKdawDfSxfNJYo1cnctNxv91IEuqy5rp8Tn05M0oJpvvJO6dDZg2mNCVLSUfPKXwIKkGC6sxeOvVBnh/dZY+J5Oyh1iSGmWEDE5DLe0jqKtaDUmQg0KGsAQOZuDOKhZwrxqpDqnpk+JTy+ctqgTnuaTcSe2aTgs17dLizl7ASZWbdZGFQaTRrHnvKNbj67ZG+jVgpHkw9qI0259ftW9PeuqBBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 25, 2023 at 01:02:59PM +0100, David Howells wrote: > copy_mc_to_user() has the destination marked __user on powerpc, but not on > x86; the latter results in a sparse warning in lib/iov_iter.c. > > Fix this by applying the tag on x86 too. > > Fixes: ec6347bb4339 ("x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()") > Signed-off-by: David Howells > cc: Dan Williams > cc: Thomas Gleixner > cc: Ingo Molnar > cc: Borislav Petkov > cc: Dave Hansen > cc: "H. Peter Anvin" > cc: Alexander Viro > cc: Jens Axboe > cc: Christoph Hellwig > cc: Christian Brauner > cc: Matthew Wilcox > cc: Linus Torvalds > cc: David Laight > cc: x86@kernel.org > cc: linux-block@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > cc: linux-mm@kvack.org > --- > arch/x86/include/asm/uaccess.h | 2 +- > arch/x86/lib/copy_mc.c | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) Acked-by: Borislav Petkov (AMD) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette