From: Andrew Morton <akpm@linux-foundation.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Yang Shi <yang@os.amperecomputing.com>,
hughd@google.com, willy@infradead.org, mhocko@suse.com,
vbabka@suse.cz, osalvador@suse.de, aquini@redhat.com,
kirill@shutemov.name, rientjes@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] mm: mempolicy: keep VMA walk if both MPOL_MF_STRICT and MPOL_MF_MOVE are specified
Date: Thu, 28 Sep 2023 09:38:09 -0700 [thread overview]
Message-ID: <20230928093809.75de08561b0fa1af03bf4a89@linux-foundation.org> (raw)
In-Reply-To: <CAJuCfpExMWXHfZjgZ=UKf4k=zxrNOLx2R-a_wQdZ3O_+JTOq4w@mail.gmail.com>
On Wed, 27 Sep 2023 14:39:21 -0700 Suren Baghdasaryan <surenb@google.com> wrote:
> > >
> > >> The code should conceptually do:
> > >>
> > >> if (MPOL_MF_MOVE|MOVEALL)
> > >> scan all vmas
> > >> try to migrate the existing pages
> > >> return success
> > >> else if (MPOL_MF_MOVE* | MPOL_MF_STRICT)
> > >> scan all vmas
> > >> try to migrate the existing pages
> > >> return -EIO if unmovable or migration failed
> > >> else /* MPOL_MF_STRICT alone */
> > >> break early if meets unmovable and don't call mbind_range() at all
> > >> else /* none of those flags */
> > >> check the ranges in test_walk, EFAULT without mbind_range() if discontig.
>
> With this change I think my temporary fix at
> https://lore.kernel.org/all/20230918211608.3580629-1-surenb@google.com/
> can be removed because we either scan all vmas (which means we locked
> them all) or we break early and do not call mbind_range() at all (in
> which case we don't need vmas to be locked).
Thanks, I dropped "mm: lock VMAs skipped by a failed queue_pages_range()"
next prev parent reply other threads:[~2023-09-28 16:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 22:32 Yang Shi
2023-09-20 23:36 ` Yang Shi
2023-09-25 15:48 ` Andrew Morton
2023-09-25 17:16 ` Yang Shi
2023-09-27 21:39 ` Suren Baghdasaryan
2023-09-28 16:38 ` Andrew Morton [this message]
2023-09-28 17:35 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230928093809.75de08561b0fa1af03bf4a89@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox