From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1035CE7AF8 for ; Thu, 28 Sep 2023 05:31:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D4666B0148; Thu, 28 Sep 2023 01:31:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 284916B014A; Thu, 28 Sep 2023 01:31:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1734E6B014D; Thu, 28 Sep 2023 01:31:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 048516B0148 for ; Thu, 28 Sep 2023 01:31:37 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C816B80475 for ; Thu, 28 Sep 2023 05:31:36 +0000 (UTC) X-FDA: 81284883792.13.6E78128 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 2ABCC40010 for ; Thu, 28 Sep 2023 05:31:34 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PI99Mn6I; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695879095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZCwPpYPnIKJ23+FQx9rK0cVVUoPdRh3hzIoGlVDACG8=; b=I5523GV3oVAYG2uq/jvkUzYZ4ODBgdegrAoSjiMQ5AJrCK2G/mt7sWVPnbW6zoUkaYqCHs 7Te5GoE/ziMErVR42ifg0t2KQsZ1asQosWjdpo1Z91IoIFU/tGuaElsdqy+ApQPT5Cp+Px yq4I2rOar2X49KRQox8L+FLmSZx1nao= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PI99Mn6I; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695879095; a=rsa-sha256; cv=none; b=sJMox/l/Y9iT0aFvG/hKbyhcWpUhP0X7VTJGn/sscwjK964tzH/Us5c/InVPxHCOuGfmr0 JcMnIRejXtnxDKxJdP97wvMlpwn0kVx9n8AaL38QjgNq/8wUYGnOix6BhbrtRKPOzf9bEc K9LZbqjnjmEmRFjYW3vXQ0VG38XXUvE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3C68761A2F; Thu, 28 Sep 2023 05:31:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50A53C433CA; Thu, 28 Sep 2023 05:31:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695879093; bh=jLJr0+v2Tu+NU/8srovtu2AdASkhpyBHDz0WXnuiKO4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PI99Mn6IhUjmgddAYTialnPteqviOBMI3VHWk6CQf8yJCFtSWPBasoWP1N0nEvjnw cx30LVN/rSqc7zRaWyXk5MuKoYJyV/CYcKtDtvUGHOBIeMqBCI6Kh1r56Jb1LQBO9g SDeD0Vwrva8hQAMttkML9Ws26NKg7e6aNb2DyQyKtj0H6V/skjHT4ReaY8jWwX3bfu SpPsVVcg9GSm8wPV96sIFVHnKuu6xAIR07Cv2vebKAKdERiAraD4vFXTgYAtMdZiJZ n60mQV3VRBHQXxLvWmGJaaJiekB0+YaQrZwNobnjZTlnWhWqcvN3mYRL2hwpxgXoqD g1YETPY4DwdTA== Date: Thu, 28 Sep 2023 08:30:39 +0300 From: Mike Rapoport To: Yajun Deng Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, willy@infradead.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] mm: pass page count and reserved to __init_single_page Message-ID: <20230928053039.GR3303@kernel.org> References: <20230926023341.991124-1-yajun.deng@linux.dev> <20230926023341.991124-2-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230926023341.991124-2-yajun.deng@linux.dev> X-Rspamd-Queue-Id: 2ABCC40010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wnwpm5tugz1ky7nkcky71og386uq4tf1 X-HE-Tag: 1695879094-4423 X-HE-Meta: U2FsdGVkX18Ghq9iTnbi9H87fY3WFnhI4GfAA39RCqJXywpNSVatnCihgoq5SoZCeEpc5NrnlVwVZusMuzz9fUeJ1Tr0zwpz3XhulH/JxdLPV3r22xCDAOK95U89MH5kQo2aGFRXHItTpV56cxpZcf6WYPCvRe64t5SfHwJuB5MTlovNGq3eX4AhZdnojLeW6i+xvGqJLIiAO4Dm16mOSxP7A9CjQigpqIbN0ds7MVR+kQwIh60A7vKYwQQcn+17bZAuea1nw7zZlW6UHZ6/Od3+vd1SWpeGABjxYxrjIypYtm0DJ+WKLsrd+xkMN1nnG7FwESO4LqQlLI+U3LkrSSxT59uK6kJODenzTPJIio4SZXMZL2mNzz+jvfLakNRhn2FDpGmItkws9aummdHZ2i0uNcYBQ3hjE4SE99YD4PEvNhpniY38CneCOBB7JNzW5icMUE9rxjbrg7fUY39EhkSoRw6QfIdcSS4D3XoZtffFO5e4xw/AWcL4No8qKDxpg+RDKKvc0Ww0jTCQF4sMz147kZD68OlVDhi2owAgTb/4qDcTIlK1JS2Np+CsfH5X0clFaLru55tFgyvklbL8xCLqcbvdlI4TRyOfrQpwxD9Iss6BkhUApaXmYhzRxE5gmVphvdBqs2GnQQYoiHD9+bcxDZ846nc68JGowYyJSn2mM1nNlszfEaLb/ocCLxIrSvktIEpqZZeh//aEgyOaxX7cG8QknICIE7OMgifcZCa/R8bomTUBmjLaVwKK9rw57VUlXhMaD53N+AcJZ7/e71aSAosRjt0WxGj6ennm14cGaNO4wKxYKmtfpNF9yC2hBM/70fzK75xkQjLE8lzwwHy+7irQw45mk6KcYH4sUVEsvmxVqPreUentYnC1Vr4frg86gOUFZkZhDsq2VFSBxpuABJDm+b1vdW9kLhEqfF8TuXYiAluIIWbM7FCHZ3ctfOtYZUazSJMR7QKxTiY JfYURnQf 5DaCOt/YlKaXo8urzcWDWWqYy59/5WrmGi0JfJMThQ0GsRzNBPelADzy2cB2bztSEk+C/EULX6bANmpp3Ll6IAQse9SA6zGVhGfvTCltC5OVFPIFDi6xm5zMKKASgaVT0yJMs9P04UUwHSe36n7X0sRnyNZNpjxkblzGO/nEqz6AHUyaOWpqscWf046h0XU3+Bz/UTC0d8ftKwJslaNjCp4nZCcJmZpRyvCyu7osvnd4ApLx1oCcYtHgUQbEncdwTUInf6mTFMn74acoj9z+5gWC4lAcA96iEVk+dt8N+ukBf22w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 26, 2023 at 10:33:40AM +0800, Yajun Deng wrote: > When we init a single page, we need to mark this page reserved if it > does. And some pages may not need to set page count, such as compound > pages. > > Introduce enum init_page_flags, the caller init page count and mark page > reserved by passing INIT_PAGE_COUNT and INIT_PAGE_RESERVED. > > Signed-off-by: Yajun Deng > --- > v3: Introduce enum init_page_flags. > v2: Introduce INIT_PAGE_COUNT and INIT_PAGE_RESERVED. > v1: https://lore.kernel.org/all/20230922070923.355656-1-yajun.deng@linux.dev/ > --- > mm/hugetlb.c | 2 +- > mm/internal.h | 8 +++++++- > mm/mm_init.c | 31 +++++++++++++++++-------------- > 3 files changed, 25 insertions(+), 16 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 06a72c223bce..07fe7e489769 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1041,7 +1043,7 @@ static void __ref memmap_init_compound(struct page *head, > for (pfn = head_pfn + 1; pfn < end_pfn; pfn++) { > struct page *page = pfn_to_page(pfn); > > - __init_zone_device_page(page, pfn, zone_idx, nid, pgmap); > + __init_zone_device_page(page, pfn, zone_idx, nid, pgmap, 0); I think the first patch should not contain any functional changes, but only add the flags parameter to __init_single_page(). > prep_compound_tail(head, pfn - head_pfn); > set_page_count(page, 0); > -- Sincerely yours, Mike.