From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAA9EE7F14B for ; Wed, 27 Sep 2023 02:36:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65D668D0030; Tue, 26 Sep 2023 22:36:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60C5C8D0002; Tue, 26 Sep 2023 22:36:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D4478D0030; Tue, 26 Sep 2023 22:36:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3B7AF8D0002 for ; Tue, 26 Sep 2023 22:36:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0D1A6120E14 for ; Wed, 27 Sep 2023 02:36:02 +0000 (UTC) X-FDA: 81280812564.21.9D94456 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf11.hostedemail.com (Postfix) with ESMTP id 9636240004 for ; Wed, 27 Sep 2023 02:35:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=none (imf11.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695782160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TsaRnoIwmlBXORY3Z2FLxJyfJzi6RROOxWn8MOHu9jU=; b=HkPuu5xkh+kkhCcQinXi8yZDHvLqT7IV737A3HBGeV7yFlFXOIKrhehWRvatERP1aiWTGj P44FPKQr0Cd8odHBk/izBFW3Pb8ucRhjOHnaDHMX1ftUdrZb0f9Ecu3qkYONV6Rn1FHabA RSnam/agyAHZ0S4vBPymfWPrp49+N/4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=none (imf11.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695782160; a=rsa-sha256; cv=none; b=2Te9jKxYsGaf90ONIw9bv6JdDnSSeGx4rlIKoN6r+WKlSHHU8Eh6K7Ux2l7J8v3nNyFdlg FHi+X5h5uMoLdnNnkvgckLUFfd3ix9K96kGRJFY82639Brb6MUe7ClZdk4/zUSv2GMT3n7 M47tnJD05QsLZsQD5fwNdr6LiJGB1eU= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RwLMF0nsRz4f3n64 for ; Wed, 27 Sep 2023 10:35:53 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAXqtkIlRNlpd30BQ--.22085S4; Wed, 27 Sep 2023 10:35:55 +0800 (CST) From: Kemeng Shi To: akpm@linux-foundation.org, naoya.horiguchi@nec.com, osalvador@suse.de, willy@infradead.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] mm/page_alloc: remove unnecessary next_page in break_down_buddy_pages Date: Wed, 27 Sep 2023 18:35:14 +0800 Message-Id: <20230927103514.98281-3-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230927103514.98281-1-shikemeng@huaweicloud.com> References: <20230927103514.98281-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgAXqtkIlRNlpd30BQ--.22085S4 X-Coremail-Antispam: 1UD129KBjvdXoWrZr45Zr15Cw18ArW7ZF47urg_yoWDArb_CF s7twnxtFy5tFy7ta13C3WxJrWkW34Fkr4xXF1aqrn8Ja4DXFn7J3WDJFy5CrWUuayru348 uasrX3y7tr4I9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbf8YFVCjjxCrM7AC8VAFwI0_Xr0_Wr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r15M28IrcIa0xkI8VCY1x0267AKxVW8JVW5JwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26F4UJVW0owA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28E F7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F4 0EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_ Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28IcxkI7VAKI4 8JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xv wVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjx v20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20E Y4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267 AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IUnwa9DUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspam-User: X-Stat-Signature: x88fxxabr7a9bc6hch5zmqimje774a9j X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9636240004 X-HE-Tag: 1695782159-288329 X-HE-Meta: U2FsdGVkX18sWPMfdhZXErrDqeWM1DmIJ3uVH53l5ZaEsCQwazVRtGCtptRWtUiHQc2/K0Wd4bEKx5GGTq7oZ66oZVHdr2lvvZiTZOTBQZ6TXOMQZZ4AZBYV3cbJ9mbq8dajdzM2IfYL2iCBV+m/D81wvLyxacXmWdZoFn8XL2OnDN6X+ZABT+avcg3gP59Cg4CpiD3yIsdZLZseoCDXv+BS6BRocSTc9OKt4TQVxbrnXNIG8CuoG/IIT87WE1f5nTrNahWZAef+muBek0H5r/1rA2KmuopONCZAPTrb8MLsUDT6h00XGkd0cktzLVgXwgymjixswz7v8CVwJFUc4NmHz8aUWfYo/2HophMn6bAKo0imuY8phPXZKYDMjeWksJG8yEJPXkylVRJCLaB11TuXFAvqmWVOdtZCj18alPGgmTvJ3al/CRmKo/0SQnHASmdAfdJkXml57GT2N1igMFWp3AA/dz4l30bRDJ8680rSu2M0siehNSNPXRJhQOB1OiuXIVD3SgWD4wZl4HliqpE1oONf1UgZG0Sopokbv7mHmiB+uPhofQTQx4feIRSim+9P5bOZroDaJYBk5EA6Zbh1R06iOK5Q70ONRJMwjmHbyeZr0N8QvZt3bLflc3xWZzPIeoZrwcU58k/H+HHSv6ajF5AkKpWY+gSbW1cFbhJIUKs3bamMt0oWlVg83GgOpfEgTmgzcscK+avosfxKulK5SnRftbkHXH1LgJLAYJ82rnYVtZZM5zSbJOMaX9+PkXSCMuO7wCxfNiDOjLcwYBA4ZSa08DvK4S9IdFWJWKlJ4jNlrQgYERPev+acJQcNHR3wj8rjdByt18AjhkSJh94BeqJloJ/3qJ6YjhvzIde19w79DPKlOP0Lzku0YSynuY7xjJMLfETGkpjB6DBQOepuFD9KUs3p1m65TcZbgHr7RHlnSvZHp7uHSxV3Eg9c5uBtNIIvBLswLNY0jsE XJphb5mh quu5c+HgDyH+fsYhtuEval6MYEpuSR0YzyZzeOpywlQ74Km4mGcVWvgYiwf5eZdiLerGoBUfYS8Rl721jFb6AM6laEHMbxO3vjQlpfeh+EwdK7+KNyqkP8mGvE9p4iInTAEdwZTYF8lqSVuZSo/gRvKYMrgpMOx6MW6UPgdt/a68VS+7Z0IZRhOkLD82FvCtcMSAzE083Mq6DiYny1lGiSCMnhq3n7Ki/ZpM3PpkUkKGyjVATMfp0/pSZJnBFbrPQhPqWJuQfdfvu7Qx9MdhZ89YNOJ439ww2UlU2heLE6egVIlMUzFksWRyQrpsoV2l0fkY+ZbgK1RRwdI0gEnO5vySt7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The next_page is only used to forward page in case target is in second half range. Move forward page directly to remove unnecessary next_page. Signed-off-by: Kemeng Shi Acked-by: Naoya Horiguchi --- mm/page_alloc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index bad979493dde..7df77b58a961 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6678,20 +6678,18 @@ static void break_down_buddy_pages(struct zone *zone, struct page *page, int migratetype) { unsigned long size = 1 << high; - struct page *current_buddy, *next_page; + struct page *current_buddy; while (high > low) { high--; size >>= 1; if (target >= &page[size]) { - next_page = page + size; current_buddy = page; + page = page + size; } else { - next_page = page; current_buddy = page + size; } - page = next_page; if (set_page_guard(zone, current_buddy, high, migratetype)) continue; -- 2.30.0