From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18068E82CAE for ; Wed, 27 Sep 2023 16:05:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88B0F8D007D; Wed, 27 Sep 2023 12:05:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83B408D0030; Wed, 27 Sep 2023 12:05:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72B788D007D; Wed, 27 Sep 2023 12:05:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 64DB18D0030 for ; Wed, 27 Sep 2023 12:05:11 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3FC96A0806 for ; Wed, 27 Sep 2023 16:05:11 +0000 (UTC) X-FDA: 81282851622.10.2051E5A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id C8792A0053 for ; Wed, 27 Sep 2023 16:05:07 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=utL1b4AZ; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695830708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d1MiuqcRScfUaMCAoAo8A9y62zwM5gi3R5YECRrGTU8=; b=U9upKyc+PHz+MVdSLjFevyR95FFqDivHCD5w72WMGH90zeR2vKZe6BBiVMHUXHc92LmOpR FGbFG1gCQpsiPYPpuL4Ib3QAYR7askXxilkoAR0udw/uXZyhuqRs+9y2xmiFAtqFtE/prA FdSvY9c3ufulH/8YdS0krIVHffV71BA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=utL1b4AZ; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695830708; a=rsa-sha256; cv=none; b=57TlHOI1W1a5KzrMrsF9FxWF52RtkPnXA7dLoP5bThLMHefCD8awiNIyBhZg+wYWZhYilo 6ktIZLZbo7YfER5mWhwumT1usyCo0xZOzZpc9aeIfnGvNr5eotjQK/ZnEnvz8jrQRERVY8 uW7s9QOM8w9V/EBCTOOpyVp3H8jCs0c= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B445660EAC; Wed, 27 Sep 2023 16:05:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 894D2C433C7; Wed, 27 Sep 2023 16:05:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695830705; bh=PrFvZ4k1hwv64LB7gobXsxrGNWxskL6dT4erfDoxXjc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=utL1b4AZyAMIiaqgHvwkLxcHvw83gspie08WKEoSRxKq9G2MBJ+3B7HXEp0k3MqP5 39uMjtQnjoDLT201VUBcr4txuEJNNw3+dX1CePiAjFEfPJ2rI20XP234Jg8UgYisHU HIuhldDX9xFWb+jqeYdGZ4fyt7VPUNbi60DCCe9Y= Date: Wed, 27 Sep 2023 09:05:04 -0700 From: Andrew Morton To: Liu Shixin Cc: Catalin Marinas , Patrick Wang , , Subject: Re: [PATCH 1/3] bootmem: use kmemleak_free_part_phys in free_bootmem_page/put_page_bootmem Message-Id: <20230927090504.f3ef3b9123bcdb7d131b3daf@linux-foundation.org> In-Reply-To: <20230927035923.1425340-2-liushixin2@huawei.com> References: <20230927035923.1425340-1-liushixin2@huawei.com> <20230927035923.1425340-2-liushixin2@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C8792A0053 X-Stat-Signature: 8yzj7xk8ahhwidhsawxjkgzn7s5coigq X-HE-Tag: 1695830707-597507 X-HE-Meta: U2FsdGVkX1+cTyRHDTiCe6JZn8dETI4mUKPYiuVJRZU2DjaoHGN0XG4IePIavYcu6DGoCKlB4CMOc7gLyHs9luJC2ebzSR7YQ2FcMxi1fWdikMe7mtnCaAyVf2l4gmTdAIdWzntWE0OcM/I2aVtQdoOI6Z1DCF6rq2ta76zP2Y2tj0/e8Qm1T9ZEC7zsGXN1O9Xt27LtkaOH52g/VApk8cSKQQv7+tkqxCk0TtmZBhkAiLOq4YkhbBUa9vzFvR+q2QSSpYaLYA0n7D8U03GtL7ysXRTMi7dAJuFfPZfVjhzq3BgHOoQpmYRA8+mag4ltDIr8Q0DHumswkTs0+AzBEoCRhly7rkU8QXx4gcywxUzi7Gqp8JpMatk1LLEaLu2dYyBnj5+8gQQwrDbyd4MDuN2iL2FCyiquWiYVCT/NC44YXdh1NdaDo+METnrMNvRYiIrMYb/A4GzvpSuTLPGDmaxUeIyb5EyU2tPTL7cOyXH248nuz3M1g6JjkGpiA/gKFPvmzBS0tqwkWE9uvrt8dclOHrEZdaR0fZl5h5eKeqdZDs05MGrcxUa3kIMQg22aElu9I7o6ye4suh2uK8ZSTfLHirm9pGvRbTP/gwe4oExZv4G43rec6J2WLjbPAu764B8m/NkZWn/4jvOtEiEh4o8veBQq0GLq+mxvSgaaIF8UlH38PIxiydSLjU83MD39aFSrBdwEpgIwBAZgIZRWIxxwfwcTMJ1QJjbrul94SBEVMKvtFJGBNx43QuNhPq2goC+AhWzWlnb6ympnnbLZNYyU95BkGNuVVm8rVxpaixnN6uCuzX88WOCI/dOcKUDe60tLzItxpWTKTffhKPvFOdqsfFxAKbZNpVrgcvcAP3uVoD6/Vfd0nB2CLTWFKPaZ7qMtICsSkiwc6ow21mCZwViJDfbtetFBv4XAA9qHeF9NnDVvCdCnunop+jrLYCKHTYUiEiwcadPy/0uOvBC 71la4Uip AArQCFflqwF3YcTzWYd3reTdcwg5AuMt1SGlsoFdOzMbscxNt93uf0taFZgeRRBPnRfQ814kl9q7YMPIRyVKIscaDb77eVrWkHBGiOj6Xei83d/Ata5Q9Vl0diROYvj9YAygm7opIStTqoJ/OgZbmvcLlDC3IjZUSalEfStkmQHpmt3nJadgN8fbOhfKvB3mHfnUsEVy0cG0TSeN91IFCGnEeET6vwGk6OIxQqBURyJIQYYW0FBB/HkalvPl/Vi8UeYsL8QzKKq0ho6EEdXn/UrWc+Lemo8eK+zXbyU2ncibaa/yhtGeFZ1+0E6XVyX/QWQRAoXR4FSE6ZawqNY5txLB2cvJcIstTyPT2woEWd/TUQP/TkpLcLipkhg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 27 Sep 2023 11:59:21 +0800 Liu Shixin wrote: > Since kmemleak_alloc_phys() rather than kmemleak_alloc() was called from > memblock_alloc_range_nid(), kmemleak_free_part_phys() should be used to > delete kmemleak object in free_bootmem_page() and put_page_bootmem(). > > Fixes: 028725e73375 ("bootmem: remove the vmemmap pages from kmemleak in free_bootmem_page") > Fixes: dd0ff4d12dd2 ("bootmem: remove the vmemmap pages from kmemleak in put_page_bootmem") Having two Fixes: is awkward. If someone is considering backporting this patch into earlier kernels then which Fixes: target should they use to decide whether the fix is applicable? So I think it would be best if this patch was split into two patches, please. And let's decide whther these fixes should be backported into -stable kernels. For that, please alter the changelogs so they tell us what are the userspace-visible effect of the bugs.