From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D439FE82CAF for ; Wed, 27 Sep 2023 16:21:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 563778D0097; Wed, 27 Sep 2023 12:21:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EB4F8D0093; Wed, 27 Sep 2023 12:21:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3660A8D0097; Wed, 27 Sep 2023 12:21:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 200078D0093 for ; Wed, 27 Sep 2023 12:21:39 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E554D140CE3 for ; Wed, 27 Sep 2023 16:21:38 +0000 (UTC) X-FDA: 81282893076.26.1B82695 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf12.hostedemail.com (Postfix) with ESMTP id 8762C4001B for ; Wed, 27 Sep 2023 16:21:36 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=K+SdxwDZ; spf=pass (imf12.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695831697; a=rsa-sha256; cv=none; b=KGhsNa+tTwdlvROVkpkcLN65+kLnk8cJg2zAPOidZ9O3A+wD77bazoVic5S1dz4KgS/xWV XtIb3d4oBGJCZ8u2dkQKxaLjxfhumvjeDl7B8HnvvMkANjLHQW1DWyeo86GizqLvMeYteC wVe770vDvTDVx6OY9NVLmMnVCUgOzgQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=K+SdxwDZ; spf=pass (imf12.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695831697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pGSXFW875XdfGIucswtJNPAM/ZfOGJND2OExEMVRxgE=; b=T6KSPEeM23/i+1Yaep2BxKZ+qkD7Lk1BTk5mtI577t8iKlOZDLR/TogHEFLCyQ15jdF0hT Rya817um8EAlJuochPHgmIGe082/JnU48UHtSNcG1zP9bELZCXhUcAvhonhlK0GsPlHAfB 0huIInMoxJhQix5cC6qkxTTirdibqHA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 89EFFCE1A9C; Wed, 27 Sep 2023 16:21:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF3E3C433C7; Wed, 27 Sep 2023 16:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695831690; bh=5fVqTod0fsU3D85/NgpH5eX11yWtVW2s8jme29QI3SA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K+SdxwDZhx8uxbb5abeHgPolVgmwSiIBL6/AzX/eEpmg7s5Jd1TwEPpueT17Z+y1i r/3aJFhGZoIRaqB+ADboLRaAQZpJm6SMvyfu5jpdUX9fmjLLqHrtdJHSnoHaBHBoNB 1Ras0NDOeGzjZ5rjoNJ7hj3RFSgjPFHQeOCu0doiR1ZFlmc7Dtn7+Tg4yFYE5HRxY7 FflbgLOEB1zCas3wjtrhbqXfzlZd6DZqKcBXDoRDLeETsNHRLxD2cXgjOH7guvx0ma AufPlRnLwdi+pMqoWiBGk6SGa+Snjtz53w/pXkwTjOc2fDnSaUxFN105snuKm+T14u FBsBAdYo6oMFA== Date: Wed, 27 Sep 2023 18:21:19 +0200 From: Christian Brauner To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH v4 0/29] block: Make blkdev_get_by_*() return handle Message-ID: <20230927-prahlen-reintreten-93706074e58d@brauner> References: <20230818123232.2269-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230818123232.2269-1-jack@suse.cz> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8762C4001B X-Stat-Signature: 3izrybr6isqw7xy4k9qbq4yogfjz6m9e X-Rspam-User: X-HE-Tag: 1695831696-681324 X-HE-Meta: U2FsdGVkX1/b3zrzxAvoAjDBXfjsYi2FPT50X0Cb/fmZczC85FJJt4U77HcASlbatqtXhYdgRAOtl2PSBHkeYsHSPfvbguFH5dqA12KRW4LngRMLvOZHU7qWeag4/vXoRwLRKRTOHWisCPwtYbaQimkOyqYD+6vDxLHl/npslhbJ686yqxkCGW4WGHH9tJkjKnHTNRQtF7lI6qMXC8O3eipH0EkuNBM3Hb+alViN3qMJAsCNzCY2LP9HetahxXV89AXgKzvFL/LEaYLUHE+lpdvCZf9JlY3YC3lysOFz0L67EnzQzn7DhHWkpwjwYCdlgwxhcJvAbduj84LD2zsTZyu6y7GnRm+2cnVzgFuW2rJTZQFXue7ziLSNCD7QOPytM7IwlzY1jechTzBHuI+nIW2MV9GBmP3++Uo4D+6c8zv9EVseur5zqaMUINTQ7fpfIFt3mmHB1o2dv2lfxWkHuRhHGy4z6CNGVI2heFDVTUUKmjumaelw7G8eigQe11kOk8ZNLEBRRQh/Gh062Iq7+gunlsx3PfyOo7idAYir7Lcs6QGklvNcDZWwb7PUnCjrofJWi6hIYTvlFzMr+pbBOsVXfOWWyPKmbFd/4CMMRiXYyu5R6pMOpHLAMeqD53GY+pYc9hmxhVi5q627zqHdQWRWjjqztHKYl+ytdJoOi0jny0hivsMRJopgn7VpCy+f43jtjGyY4Cv6mjeKbys9/AhVPoAlwStjhZVH+bqFOY4qHMa/VvPGrkorcuW9Olrg1ahOo+SHDDQegUUg1JKmhIn+u6oDmZMUJxa7Y48xIGKdU5QFgQEQ5Zj8H5vr8CjzljEAkWF59iI+orRJYNAAn+HygDUEjbvvRsLdXuE5huMXWjSoYTzPuIOro9plvZuVvdNGOvk/0JA67/AWZeRTGMpenXmClxbzEzLulSeTY3LqUJb4lXs4GmRcG2AWCV1zyv7ySKzkAkcLVJEC3vb q+WYHMxc 7zmrMczO8SkJ6+JKix51bxNw2BV1E0VWRTvBk9pa0NAeeye01gzTKm/GM3DfrcwDDicTj2jBVC0MMTIhMTE7i55VVloZI3q2PGG2eC8f/M4fug+LpMQere2vrLDigwWMrsS+AspdyOKqcSb1HKwHLzh3RrwYFGNDko3HdIRdD91v/KPdthAKeQAodtPv3e+Dbh12d8h57CZeNTKu8RFmnxMgW2BWKkVnsFDEeHPf74oXHfRYWluP4nxQivQyhlmrDGXeS/BCRTxfDQ2IGkDNiPYqgT7kmg/bE77MCMuqAjZG8C/JTDvNtcAN2tayuM+40vTQD/juSOiJIksJsPVxkDvsFWWD4TQbHWbjKBzfgkjE1GwzaSzo6gNCcFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 27 Sep 2023 11:34:07 +0200, Jan Kara wrote: > Create struct bdev_handle that contains all parameters that need to be > passed to blkdev_put() and provide bdev_open_* functions that return > this structure instead of plain bdev pointer. This will eventually allow > us to pass one more argument to blkdev_put() (renamed to bdev_release()) > without too much hassle. > > > [...] > to ease review / testing. Christian, can you pull the patches to your tree > to get some exposure in linux-next as well? Thanks! Yep. So I did it slighly differently. I pulled in the btrfs prereqs and then applied your series on top of it so we get all the Link: tags right. I'm running tests right now. Please double-check. --- Applied to the vfs.super branch of the vfs/vfs.git tree. Patches in the vfs.super branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.super [01/29] block: Provide bdev_open_* functions https://git.kernel.org/vfs/vfs/c/b7c828aa0b3c [02/29] block: Use bdev_open_by_dev() in blkdev_open() https://git.kernel.org/vfs/vfs/c/d4e36f27b45a [03/29] block: Use bdev_open_by_dev() in disk_scan_partitions() and blkdev_bszset() https://git.kernel.org/vfs/vfs/c/5f9bd6764c7a [04/29] drdb: Convert to use bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/0220ca8e443d [05/29] pktcdvd: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/7af10b889789 [06/29] rnbd-srv: Convert to use bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/3d27892a4be7 [07/29] xen/blkback: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/26afb0ed10b3 [08/29] zram: Convert to use bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/efc8e3f4c6dc [09/29] bcache: Convert to bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/dc893f51d24a [10/29] dm: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/80c2267c6d07 [11/29] md: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/15db36126ca6 [12/29] mtd: block2mtd: Convert to bdev_open_by_dev/path() https://git.kernel.org/vfs/vfs/c/4c27234bf3ce [13/29] nvmet: Convert to bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/70cffddcc300 [14/29] s390/dasd: Convert to bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/5581d03457f8 [15/29] scsi: target: Convert to bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/43de7d844d47 [16/29] PM: hibernate: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/105ea4a2fd18 [17/29] PM: hibernate: Drop unused snapshot_test argument https://git.kernel.org/vfs/vfs/c/b589a66e3688 [18/29] mm/swap: Convert to use bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/615af8e29233 [19/29] fs: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/5173192bcfe6 [20/29] btrfs: Convert to bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/8cf64782764f [21/29] erofs: Convert to use bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/4d41880bf249 [22/29] ext4: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/f7507612395e [23/29] f2fs: Convert to bdev_open_by_dev/path() https://git.kernel.org/vfs/vfs/c/d9ff8e3b6498 [24/29] jfs: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/459dc6376338 [25/29] nfs/blocklayout: Convert to use bdev_open_by_dev/path() https://git.kernel.org/vfs/vfs/c/5b1df9a40929 [26/29] ocfs2: Convert to use bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/b6b95acbd943 [27/29] reiserfs: Convert to bdev_open_by_dev/path() https://git.kernel.org/vfs/vfs/c/7e3615ff6119 [28/29] xfs: Convert to bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/176ccb99e207 [29/29] block: Remove blkdev_get_by_*() functions https://git.kernel.org/vfs/vfs/c/953863a5a2ff