From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D6A6E7D27F for ; Tue, 26 Sep 2023 19:49:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBF148D001C; Tue, 26 Sep 2023 15:49:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6E2D8D0002; Tue, 26 Sep 2023 15:49:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0E9E8D001C; Tue, 26 Sep 2023 15:49:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9E7288D0002 for ; Tue, 26 Sep 2023 15:49:53 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6C666120755 for ; Tue, 26 Sep 2023 19:49:53 +0000 (UTC) X-FDA: 81279789066.20.1887765 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf07.hostedemail.com (Postfix) with ESMTP id B21A14002E for ; Tue, 26 Sep 2023 19:49:51 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FDRxYBpI; spf=pass (imf07.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695757791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=eOqgy57dPqf5vnOZG5GluAdrnFdDMotUGmbkzIntuoI=; b=fCKjlW8ODMwmOhAIA7R7K5sJuYdGbbXT1LiBzH7LlWzVPwd9yLYg7tKsDcuZoV4BAUYv30 oXKeFD8zKm7KCC57RkmlJlNqukW+2IW3FZ35/MrYuokCxpcmHxhbTxEYOc4y5ezPj0UUFU 0uPqPaXOkXpjHLzyIDU/XUggr/cfh6M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695757791; a=rsa-sha256; cv=none; b=b/7cbLldxDFXHAZZ0wwd779d1jdSAvEPjHNbDhW6L11JTOjbQ1vBz0DKikiNt/koCK33ot PBsBmaOci01hM9AYSDXYFS+zCqaGO5TboWlLR4O7hmDjWvnOoFWf/q8886jzhRfFlWhS51 GRdDAOcRGs7YbBIJ/pH+Vyh7Bih/Sao= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FDRxYBpI; spf=pass (imf07.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1c5db4925f9so69183385ad.1 for ; Tue, 26 Sep 2023 12:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695757790; x=1696362590; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eOqgy57dPqf5vnOZG5GluAdrnFdDMotUGmbkzIntuoI=; b=FDRxYBpIXOKHwcbv8k6VtK5xfJHDx8/GdcuPmTVxxvQGeK+6TsdGdWZZ6e74W2TMvO NxQOepLQCkBs13QgELLUd4XVI1kZkuCLsCk1ODCn/8FXWQ7I7v3EQGa4s1bk18WZFWpL Y7N56/N9RL2ht4Xp3x3CvklzNKv96UQZSaEz3iPamqVFa0rTVbCuGcw30NqtwJcreQIK jlQyTcnG/3wzzzpr9tFq8D/AkJbAiwPA6IAIjpWJz0GQk0gLMnmd2oowUc73uGkOMFPx 0DbrZSHp1NvOAO/5iKgY65CZhD6uCO8FGNjAyuhqL6lcUjXmbqdK5Vf5E/DPf93Bl7cQ 78Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695757790; x=1696362590; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eOqgy57dPqf5vnOZG5GluAdrnFdDMotUGmbkzIntuoI=; b=IDrx1/rtKWNrGHjEjwqDIFCcQjRm+d3rUGy4CYWDRKbyuZtEp88VHjvCBubPf7VoFX 9Q8tI1JjxUNekNJs6Ey3SMeRkwWDIZpqVebVX7ruUCNYi3nPpcw4xIClF82BiranMz9s NN6gCCoxXiI9a5IGD0IY60pK+W/r2y7/F7KTnmbHupn9dNy2HcpDsj5C4wIP+9Q8w4UW +ttoRXlvtdcWIRffNCtezAyGyYIwM4mGq5u2DCNo5pQzWlSdO0uAz2hBhPXIs/vrtTl/ NT5luQr96c+m53O+0ru+vcPzyGz8Opjdgbr+2ACaAZ+o6SvJglWj3Yt8ErLYZ6e28GBp jE1g== X-Gm-Message-State: AOJu0YxEe6BMpBBLqorkQqlhDU3xv8iOzQ9SBU1HpH33vWQzWe8ujxU1 dUETC4CDcIci8cYVm03nRy8= X-Google-Smtp-Source: AGHT+IFQfxmqpXOGPhPftE1Oew2BkuLJR/1RBVCaXchkMkCZp8u2HGDbytSnuJCV42SIu1TGzStKUw== X-Received: by 2002:a17:902:ecca:b0:1c3:432f:9f69 with SMTP id a10-20020a170902ecca00b001c3432f9f69mr5532611plh.23.1695757790307; Tue, 26 Sep 2023 12:49:50 -0700 (PDT) Received: from localhost (fwdproxy-prn-007.fbsv.net. [2a03:2880:ff:7::face:b00c]) by smtp.gmail.com with ESMTPSA id o3-20020a170902d4c300b001b8622c1ad2sm11395931plg.130.2023.09.26.12.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 12:49:49 -0700 (PDT) From: Nhat Pham To: akpm@linux-foundation.org Cc: riel@surriel.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, shuah@kernel.org, mike.kravetz@oracle.com, yosryahmed@google.com, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: [PATCH 0/2] hugetlb memcg accounting Date: Tue, 26 Sep 2023 12:49:47 -0700 Message-Id: <20230926194949.2637078-1-nphamcs@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: hxq9x7755sgpdnyjwdomar861h14hddf X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B21A14002E X-Rspam-User: X-HE-Tag: 1695757791-311201 X-HE-Meta: U2FsdGVkX18/aY2OQEdudA9fPR04VDUgpJw0ZtML43qSwhESBABGqd1PVOUI3grZ9aK1bkroDNoLwJPunAOvyN5nCVq3FOtxZbxmH3ebPjoa0tVFd3rSyNKKwlWAIhkr6Fe/NgdRuj5G+tLgKVzPSvADonpWreS3V1nRXuiNA4tvVwqtVIK5tDLLB0ZsRqjST2T/xdYXAqa1CLplpCU2IKsTCN49hvSfHmy512oiLMbholRPRkuqVmOJRREUzsVcLxcz+k5BndxTRmWjrPf3Rplgr55pv8ilKupfRIHrS2wQXYnAH5P8hhh9k1QzdmmkroCIvuM8CDhUn3UEqHQmzeOQKf9wARQUVFutdD8yY3zAQMOjVOSwnZ5AotN/xksXBiaQwv+Lv+u+S5l4lCJbLPwDiHAk4RUkbMd404ZAcOaW5L30tsY6asa189KD+vlqLsBjmjKQkTRYoHsPSrnRrHn9iPw/svhPmt8cCLfko2NguINYeOHyF7YxxdL7huvHE8SKl84RZmjRTVp+zk9myUd18vWgF2uNKi52T5NCPVU4ZFmwth2lQnNYozQEJDy/RJASWBH6slPKTlmMP1pZ8A27lP4rVKj1+ehsUxfCe0xoduX3bEZ6QY0dLNFlDPb5JyUKOxQeqf0+wCjsrUSTWet2w/h0aywihEfO0U4jkJ8B8psjA2OQooKTBc1R7EkS0iBYzv6CmrWXPBlZglqbbCrTMClGnf5FsUOdk6IOJ1pXt1g2lI8Z4oTfzeeLwQVRLV/uFwn6981RmaikMG96uAKzLRlI1eXd/IjdFKvqrm2kvk/wY6hpzYVpC07U1NFqOk4moDG6n52L8hTDDOjYo1eXqcCC4XVSw5VlSmGgPo6cj/ic+sMV1H1tu2KNUw4WlgipNYXCLEX+2xqZgNzCNtZ6sw+XAJchwaS1UHg3x9qEOgRY7dgMhgb59u/anuyg7EKRHQwU7nBgNGrpME0 dFpyOBD9 z7TjLkSagpyo/a0ASitP1NQuRQU3q4il7Ius8tMhm5xKQm/H1COsjo3huSH6W58v7zI/va0qH9B3wPrEjWMB04iO0zR3cs+q8Eb9o4M+AKlbD36egKibTdymJ3xQO6+MDGdzbhS8LFluUAe+oAwzKKXcIgZFVJStcMWUfd1zpS65IovHxkw7Hoo19nqS5xyLZnMrAjkjml5dQgN9IfAV78X7zg03M06DYU88S3Pnr0dBSvRT7FdfPIQsfG2MOCa5qKXNjLQiz4G2M9VjGSWCA7GSZqqmxswuLERFAjqEEhnlt0pCh82Y0OaW32wQk/xcnV8DtH8zP3k6Q4M4r5N1ZgR7CcBzWBzn7QZ3heBuOdh+ieWfjUo+KCgqcJnSpKI2C23eM+6kT+2IydHmE7xAT3vjryA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently, hugetlb memory usage is not acounted for in the memory controller, which could lead to memory overprotection for cgroups with hugetlb-backed memory. This has been observed in our production system. This patch series rectifies this issue by charging the memcg when the hugetlb folio is allocated, and uncharging when the folio is freed. In addition, a new selftest is added to demonstrate and verify this new behavior. Nhat Pham (2): hugetlb: memcg: account hugetlb-backed memory in memory controller selftests: add a selftest to verify hugetlb usage in memcg MAINTAINERS | 2 + fs/hugetlbfs/inode.c | 2 +- include/linux/hugetlb.h | 6 +- include/linux/memcontrol.h | 8 + mm/hugetlb.c | 23 +- mm/memcontrol.c | 40 ++++ tools/testing/selftests/cgroup/.gitignore | 1 + tools/testing/selftests/cgroup/Makefile | 2 + .../selftests/cgroup/test_hugetlb_memcg.c | 222 ++++++++++++++++++ 9 files changed, 297 insertions(+), 9 deletions(-) create mode 100644 tools/testing/selftests/cgroup/test_hugetlb_memcg.c -- 2.34.1