From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C0ABE7F12E for ; Tue, 26 Sep 2023 21:23:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69C048D0050; Tue, 26 Sep 2023 17:23:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64D298D0002; Tue, 26 Sep 2023 17:23:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 515178D0050; Tue, 26 Sep 2023 17:23:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 41BC68D0002 for ; Tue, 26 Sep 2023 17:23:24 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 195BC1A02DC for ; Tue, 26 Sep 2023 21:23:24 +0000 (UTC) X-FDA: 81280024728.25.AEB6982 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf17.hostedemail.com (Postfix) with ESMTP id 266E04000D for ; Tue, 26 Sep 2023 21:23:20 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KJ8zcHVQ; dmarc=none; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695763401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rnVkDxwPqrcfEVAn+RN8HNWTx1LRCHetMzi+wIRyFuk=; b=0IgMIG9Rga8VeFWVNnDhBgu8N4bfM5OY8beXQxELJ3SMGIDPFloBWnQrd92SHopsBSAiZr /PWzd9Ci0bazxw/iqmfp7pbHbVHcrhfGau01UgvDtkO+XvNrDulAus/+1n8m7d3VVz/h1c QAzZ46NmOXdaXoZtL/aJ14ETy2peFkI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KJ8zcHVQ; dmarc=none; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695763401; a=rsa-sha256; cv=none; b=l9yiZq5RKouDOZoTB5rOeKXMtpufZ6O9Hjm/0IHPkNE0FtmlCAYXJVuCuIwpGZ03H/KO3p 11U5xcwzH4QT7CS9L7HA3bN6Bpqb0ZkADcpYgZEUVwGQY2RJzdbNAFy03XzJdMOWNlv4Un 5bjIqs9fREKMukg7Puz7+FhI6IkKOvU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 94906B81074; Tue, 26 Sep 2023 21:23:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5736DC4166B; Tue, 26 Sep 2023 21:23:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695763398; bh=DlxP2CXCbVJasxbRyBVxVkyjBSZhsVre5sFgvi0B/xE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KJ8zcHVQZCNdTVRvpY4wGxTEiVHj8qJPwTE6p0mRLayBmlnWs9777pA7X2kxD2csM Ol9GM0vRbN39bSUtitAFOtxZjo5RWjggBtrsDSOYAM+/vPAlmjd+hvl93iNOA4hHb7 vPq5ILLsiWUOEdcGxFfMgTn9RqlD51PQN3SMiFsQ= Date: Tue, 26 Sep 2023 14:23:17 -0700 From: Andrew Morton To: kernel test robot Cc: Muhammad Usama Anjum , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , =?UTF-8?Q?Micha=C5=82_Miros=C5=82aw?= , Andrei Vagin Subject: Re: [akpm-mm:mm-unstable 264/269] fs/proc/task_mmu.c:2018:13: warning: 'pagemap_scan_backout_range' defined but not used Message-Id: <20230926142317.3a7cb6314a72912251b91131@linux-foundation.org> In-Reply-To: <202309260903.qzpqNFz3-lkp@intel.com> References: <202309260903.qzpqNFz3-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 266E04000D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: o4sjgdb5fux6sj6dcsxymnpg17syotfj X-HE-Tag: 1695763400-318454 X-HE-Meta: U2FsdGVkX1/L66ZzoogfTonbo41yLBjw6mpcY5K9+OSmpe0PlMLZ3+3QbEd5IJ0u6Uf8FoquN/NuvvQsqLENkINtHrl47Biobr5aNMpmnS0VCjCSTRYbZSpFvlmhfuNW2Z+2bNCM7/dwQsuq756A9dDvZ64Zi3aETCFtnn5SPu3F7rft8J6s3T3iSXsEEpzP6/gDH+wr5wdTVisafQJ06lt1ZW0OkCQieL4xOY0dDD0ovYftcOM6Fxz5YKwxKDwiioyZN5ZxLHXH47fSh1TRaFndABJJpY05EQMcz/7DVgJvKlpfyYlkfcZau4oNjdlsT9jFF4W0+Ewh5JTQT60VXrrMPcYtxTnjuOHGkCsVx73SfHs63BijQhGiuDV+Zy7OEZIhO3pPwVQg8ZpFcfuUU5PcVwHF4/gbTeEsZQv/jO2m1yIkt0yewuwgNs9r+yMxP9mtzdjg26as1yMFJQj5fdnDOYwWXf7O+8Yz5XFNhWyxqWo/V2KwaKc+5xw/TEzj9Xj5/hBkFs9lQ1EWRNSRiLMpkF6nm6QY1IlPB/KBqRsC/ADTxTc1nsqBeblzmcQygQBOmUzugs3WFdfzcUAybTRCNi7QGXTUk7NhDK7fBqSgqmmFJZNdigZipR9m4tfwyL+Rptw/GzDMJ2qYYNg5kqBb614BI4H0KdLXizlUj6iPhvPh/Z9LT0Px7ZOZTXD+rNty4BvLbpi+8yFGI/JknbH4dokMxq6fRAUvTXV/OIeaYWrZ8ZIoYqNRSn43zL9SNoXaJiNiJWBQodSS37nCHhWxMqzlrkdf/bZX5jTVmYuClnIO/VXW+I4vLv0lfcnT2Neb6MZI6zb9xZy9kvqhwQdK756z6CKtV/Ux0tx736tM+hqusyOOwJ0hzpg5+bFeiztfeyDBGiJtn8yq45V7x2Igw6KSFG7cEGQA75yNQwgPYeM2qOhFuC0K/weCvP6EAnaS38LsKfy9DWV929C t27/D6bD YUS1oRUecur3/+XA/O1ye30vTmHundWJvYGPxCuDwtrvGDPt2zYsZaBnPidjgWKfkosVUpHDYhkdENpeWzrREtfTwaECGJDXciNDSnTgv3YSGht/fC8hBmPEQxPuLB9IWT1lKn5qsDxOdEZWKzIEfMJLYxtB3cC2laRoDJP6BakkYXN+aDiUVQZCSIzGcim+d0PL4oo/ieFPv+MhLGVkXiNZLN8tRPefh2MkVtQ5pJheXFvJF3C69LTVVMNXTh/ZX0A62CihfPnBPUFrbNv+PPhfKoHcFx/Ae0uyzKnj8GssW09qOpFoXYlzhVkov0kMAFNmb51WclUIZ0mYMxf2Dx3CgCZCTXiLk/m28o96DhHy2Z2S5Zo6LVY/BaH0kuqkJ2x1TkWqiCrQUq85VvM8FkBC7QLV6myQ+qhea+uHN1kiRRN4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 26 Sep 2023 09:32:34 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > head: 81fd55e0d6b6bd11a50070f7639c996a0e3aeea8 > commit: 93538f467c0f64ef3fda61cd862115dca782faa4 [264/269] fs/proc/task_mmu: implement IOCTL to get and optionally clear info about PTEs > config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230926/202309260903.qzpqNFz3-lkp@intel.com/config) > compiler: alpha-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230926/202309260903.qzpqNFz3-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202309260903.qzpqNFz3-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> fs/proc/task_mmu.c:2018:13: warning: 'pagemap_scan_backout_range' defined but not used [-Wunused-function] > 2018 | static void pagemap_scan_backout_range(struct pagemap_scan_private *p, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > Thanks. I guess moving the definition inside CONFIG_HUGETLB_PAGE will suffice, --- a/fs/proc/task_mmu.c~fs-proc-task_mmu-implement-ioctl-to-get-and-optionally-clear-info-about-ptes-fix-fix-fix +++ a/fs/proc/task_mmu.c @@ -1940,6 +1940,19 @@ static void make_uffd_wp_huge_pte(struct set_huge_pte_at(vma->vm_mm, addr, ptep, make_pte_marker(PTE_MARKER_UFFD_WP), psize); } + +static void pagemap_scan_backout_range(struct pagemap_scan_private *p, + unsigned long addr, unsigned long end) +{ + struct page_region *cur_buf = &p->vec_buf[p->vec_buf_index]; + + if (cur_buf->start != addr) + cur_buf->end = addr; + else + cur_buf->start = cur_buf->end = 0; + + p->found_pages -= (end - addr) / PAGE_SIZE; +} #endif /* CONFIG_HUGETLB_PAGE */ static bool pagemap_scan_is_interesting_page(unsigned long categories, @@ -2019,19 +2032,6 @@ static bool pagemap_scan_push_range(unsi return true; } -static void pagemap_scan_backout_range(struct pagemap_scan_private *p, - unsigned long addr, unsigned long end) -{ - struct page_region *cur_buf = &p->vec_buf[p->vec_buf_index]; - - if (cur_buf->start != addr) - cur_buf->end = addr; - else - cur_buf->start = cur_buf->end = 0; - - p->found_pages -= (end - addr) / PAGE_SIZE; -} - static int pagemap_scan_output(unsigned long categories, struct pagemap_scan_private *p, unsigned long addr, unsigned long *end) _