From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1DF3CE79A4 for ; Mon, 25 Sep 2023 21:36:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E15E8D004A; Mon, 25 Sep 2023 17:36:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 490C08D0041; Mon, 25 Sep 2023 17:36:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 358258D004A; Mon, 25 Sep 2023 17:36:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 262E38D0041 for ; Mon, 25 Sep 2023 17:36:29 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EDDF0A0607 for ; Mon, 25 Sep 2023 21:36:28 +0000 (UTC) X-FDA: 81276428856.07.BF1AC12 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 3FABA1C0013 for ; Mon, 25 Sep 2023 21:36:26 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=le9+MgwV; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695677786; a=rsa-sha256; cv=none; b=gwUre1XoNru04UGOkBH1Qtg15x2XgVT8cXfJs0CHci1s0nVEjyezVOcHz4nOLIt0WVIQ+Q nthAEtueCP+OU4t56XHxs0w1+F/y18Q+E58/FbprzTc84RcJRJVZVOMTJ+hM0n/RgtknT6 /OULIHtHwjy1MGYw6h7LtbzLfVUwMK4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=le9+MgwV; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695677786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lQLrlNGCb+vPilO6lJn6u66CNIMOvJVRBqliTOSp9uM=; b=wOanyUXRVeNw3yfZnEjvxMhmp9r5RAS4fiaNdlLCZVG3JffeareUVssF5j7V8Tcm9m0lzq hCgDFlQY9eHrI/1Q9uC0Vk6H1HPujVCk0pE1uKtp2SWPqZUeEU9WfwmMlfwWPCNHqqy7EA mEKRos+Q/PmsYx5Mof3ozJGYkTdGBY8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 40E54611F2; Mon, 25 Sep 2023 21:36:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A892C433C9; Mon, 25 Sep 2023 21:36:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695677784; bh=u4uv3DNKD0E0OuUaQU04JetZHmO/2pYOxTl9tE5dGww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=le9+MgwVi4N5+F9Uv4AIUXziNl8bJUB2zWxVlerYDjUSun6niHz+jfuQGiyaNWoeK DlMrAy4Q5GHkT0m1pXLRmYnUDgyPb05BFYzqcuKGzmjGqkXdkBLzhqNwyRqNL+UwSF p6j0/T8qHCktMPqRJTJFC1GT7s2TAY5C9EpXDjKgN1Ku7gjFNtG4bjRV8NBPYhroKP Ths1gi4tx/fezjOqNtev/2cUrbEBbb0TMU0DeamRZ3bpgpuLd+QwhEDTBcPPp2MNKN pZL+o3SZOhQMk749fH/hQ+i9Z9FpoNIGoCwKUSRJIg1i3v+CIB2QQg0OTOpPAo3RzJ Pf1PGmOl0Femw== From: SeongJae Park To: Jaewon Kim Cc: rostedt@goodmis.org, tjmercier@google.com, yuzhao@google.com, kaleshsingh@google.com, akpm@linux-foundation.org, vbabka@suse.cz, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, jaewon31.kim@gmail.com Subject: Re: [PATCH v3] vmscan: add trace events for lru_gen Date: Mon, 25 Sep 2023 21:36:19 +0000 Message-Id: <20230925213619.263131-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230924142343.23924-1-jaewon31.kim@samsung.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3FABA1C0013 X-Stat-Signature: t4qjq6k3bctaufb7tu3sik3bwgegpa78 X-HE-Tag: 1695677786-525760 X-HE-Meta: U2FsdGVkX18RZLGrJTuoYZBH+GzFuwd+lB3Zzhgyne2f8u03YFaoGnr1OQt6BDoLCaeTwgY7yhkPY90Pc5B83QoJ8UrVH76ixrxYuQzqHCSFE/9dYOm38kqm/BPCL7tUyBT4BX/RAwGh6jdDRMRPd6t0HJugFDt7aFj9ef6mnszgomf8ruFh0AIE0ZBrCiZh+dy4lFJH6F1v2gvRTmYEsWkW5Q+fh3mUrLEMOX9aSaTkB5xjCMsm6UeTBddSnWPUyuUyKja9nrE+2rAN79KOMBWx8uIA99+e0hkjYadxqFh/vMEb/WjOukSuyIq69+VEGEMatW3K91mOgPOdTUybfYj+w4h+F+NCK6A8KNM4TNfJ7B/6QP/0S6Ut8kDmnTHJbYUSTzxLdB/HI+pfE41V+nxHyN/wA5HsnU+3B1JZjKWYH1p7CG/AzhdNbY1+ePur+EIlH6FjBC0U3XVSm4d4h1duAzpk+5QhNFWAxERD9adxkn1APgrAGYuV5vgc//8vUFzpRtfOlHvcomPJOgJit6q+9Mo/w1byeFFAty/Hb4hJ6xofspQ4ikJT307lPaRi1W47vzrbmYGidJUT/fZelpBG3PXVq7WQA7zHLFJ3yzk/ZxHAQWQ1UYiIE+wJr/Q1lzPmLGtTS+PRfguBcDKVH+z7LvX1sE3hZR7f+bnyUNvukuZFWeV9C3DhiXMy2sefcj/9SLWjLNBhanPiJEHs2UtHsr6pzf8AnLJxlY4KvVmLpz/lQMPXLyYDyutXUSFSO0SN7O6vjNuvgEae5n2FknRUwj1Fbcy++jDlxsi/lIJZ18S7ZLR+yxi2yCS9tn/RwJaggJU2CdzeJydAjuEUF00al4Y1E5tgoNIM0dehg8Slbevf1NR7AwHMeuXiBK/NLR0s808gIPx0VvYpxFX4M4FFhhoaEB+hhmwR9MYbbweMFC6HCtClyvEp2s2vt9L5QJzkzEme1IsV3jqGLs/ Rfkxf8mU Xf1mnbv+wB9wCUj72yEG9ZVEcRwITsRNy1s6R7Km1MdY3rrsDTY0Ds3O8ylDubsGwj5KiXvzalv4kr67DFO9kxCYohaMchG83qYX4kj4D5mVmyUNZfe4yFhmG9OEMPKA1S38w0A1S11f2hBn5x1mDX2PtcsW4K6401wMuhBR72gDcQ6YpoqBoYnkgK4sGRUuKbFhLNe+7uiahaZz4x9gAGxWQqE4JMYyeAcBfbtAJdf2Cm448fw0UKY4eBcMrRgQrbgrvhw7NQi110h/p/fnjf8EkKl2uACQKl9xtiix6yxl3DU9fKBPfz975qrxo97fMkK8+lVvFKl1gZgG143y0758CGA7Gd8vD2PHHQhUynEALQTq+gN0GcDQq46Izmw6i0/3GljcrwkFPPBuL+pkkc0hwhWm1kDxNY2lJU9Aep4yLWpo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Sun, 24 Sep 2023 23:23:43 +0900 Jaewon Kim wrote: > As the legacy lru provides, the lru_gen needs some trace events for > debugging. > > This commit introduces 2 trace events. > trace_mm_vmscan_lru_gen_scan > trace_mm_vmscan_lru_gen_evict > > Each event is similar to the following legacy events. > trace_mm_vmscan_lru_isolate, > trace_mm_vmscan_lru_shrink_[in]active > > Here's an example > mm_vmscan_lru_gen_scan: isolate_mode=0 classzone=1 order=9 nr_requested=4096 nr_scanned=431 nr_skipped=0 nr_taken=55 lru=anon > mm_vmscan_lru_gen_evict: nid=0 nr_reclaimed=42 nr_dirty=0 nr_writeback=0 nr_congested=0 nr_immediate=0 nr_activate_anon=13 nr_activate_file=0 nr_ref_keep=0 nr_unmap_fail=0 priority=2 flags=RECLAIM_WB_ANON|RECLAIM_WB_ASYNC > mm_vmscan_lru_gen_scan: isolate_mode=0 classzone=1 order=9 nr_requested=4096 nr_scanned=66 nr_skipped=0 nr_taken=64 lru=file > mm_vmscan_lru_gen_evict: nid=0 nr_reclaimed=62 nr_dirty=0 nr_writeback=0 nr_congested=0 nr_immediate=0 nr_activate_anon=0 nr_activate_file=2 nr_ref_keep=0 nr_unmap_fail=0 priority=2 flags=RECLAIM_WB_FILE|RECLAIM_WB_ASYNC > > Signed-off-by: Jaewon Kim > Reviewed-by: Steven Rostedt (Google) > Reviewed-by: T.J. Mercier > --- > v3: change printk format > v2: use condition and make it aligned > v1: introduce trace events > --- > include/trace/events/mmflags.h | 5 ++ > include/trace/events/vmscan.h | 98 ++++++++++++++++++++++++++++++++++ > mm/vmscan.c | 17 ++++-- > 3 files changed, 115 insertions(+), 5 deletions(-) > > diff --git a/include/trace/events/mmflags.h b/include/trace/events/mmflags.h > index 1478b9dd05fa..44e9b38f83e7 100644 > --- a/include/trace/events/mmflags.h > +++ b/include/trace/events/mmflags.h > @@ -274,6 +274,10 @@ IF_HAVE_VM_SOFTDIRTY(VM_SOFTDIRTY, "softdirty" ) \ > EM (LRU_ACTIVE_FILE, "active_file") \ > EMe(LRU_UNEVICTABLE, "unevictable") > > +#define LRU_GEN_NAMES \ > + EM (LRU_GEN_ANON, "anon") \ > + EMe(LRU_GEN_FILE, "file") > + I found this patchset makes build fails when !CONFIG_LRU_GEN, like below: In file included from /linux/include/trace/trace_events.h:27, from /linux/include/trace/define_trace.h:102, from /linux/include/trace/events/oom.h:195, from /linux/mm/oom_kill.c:53: /linux/include/trace/events/mmflags.h:278:7: error: ‘LRU_GEN_ANON’ undeclared here (not in a function); did you mean ‘LRU_GEN_PGOFF’? 278 | EM (LRU_GEN_ANON, "anon") \ | ^~~~~~~~~~~~ Maybe some config checks are needed? Thanks, SJ [...]