From: Jason Gunthorpe <jgg@nvidia.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: ankita@nvidia.com, aniketa@nvidia.com, cjia@nvidia.com,
kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com,
acurrid@nvidia.com, anuaggarwal@nvidia.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-edac@vger.kernel.org, kvm@vger.kernel.org,
alex.williamson@redhat.com, akpm@linux-foundation.org,
tony.luck@intel.com, bp@alien8.de, naoya.horiguchi@nec.com
Subject: Re: [PATCH v1 1/4] mm: handle poisoning of pfn without struct pages
Date: Mon, 25 Sep 2023 09:36:41 -0300 [thread overview]
Message-ID: <20230925123641.GX13733@nvidia.com> (raw)
In-Reply-To: <878264ae-f6f6-04d9-2d52-fb7ae29dca85@huawei.com>
On Sat, Sep 23, 2023 at 11:20:19AM +0800, Miaohe Lin wrote:
> > /**
> > * memory_failure - Handle memory failure of a page.
> > * @pfn: Page Number of the corrupted page
> > @@ -2183,6 +2271,11 @@ int memory_failure(unsigned long pfn, int flags)
> > if (!(flags & MF_SW_SIMULATED))
> > hw_memory_failure = true;
> >
> > + if (!pfn_valid(pfn) && !arch_is_platform_page(PFN_PHYS(pfn))) {
>
> Could it be better to add a helper here to detect the pfns without
> struct page?
pfn_valid is supposed to do that.
This arch_is_platform_page stuff is actually detecting Intel SGX
memory and routing it to arch_memory_failure()
It would have been more accurately named
arch_is_arch_memory_failure_pfn() or something
Actually that SGX stuff could probably be changed over to use the
interval tree of this series. Modify sgx_setup_epc_section() to
register tree nodes per-section and remove all this arch stuff
entirely.
Jason
next prev parent reply other threads:[~2023-09-25 12:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 14:02 [PATCH v1 0/4] mm: Implement ECC handling for pfn with no struct page ankita
2023-09-20 14:02 ` [PATCH v1 1/4] mm: handle poisoning of pfn without struct pages ankita
2023-09-23 3:20 ` Miaohe Lin
2023-09-25 12:36 ` Jason Gunthorpe [this message]
2023-09-26 7:23 ` Naoya Horiguchi
2023-09-20 14:02 ` [PATCH v1 2/4] mm: Add poison error check in fixup_user_fault() for mapped pfn ankita
2023-09-20 14:02 ` [PATCH v1 3/4] mm: Change ghes code to allow poison of non-struct pfn ankita
2023-09-20 14:02 ` [PATCH v1 4/4] vfio/nvgpu: register device memory for poison handling ankita
2023-09-26 5:36 ` kernel test robot
2023-09-26 7:38 ` Naoya Horiguchi
2023-09-28 19:45 ` Alex Williamson
2023-09-20 16:02 ` [PATCH v1 0/4] mm: Implement ECC handling for pfn with no struct page Andrew Morton
2023-09-20 16:04 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925123641.GX13733@nvidia.com \
--to=jgg@nvidia.com \
--cc=acurrid@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=anuaggarwal@nvidia.com \
--cc=bp@alien8.de \
--cc=cjia@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linmiaohe@huawei.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=targupta@nvidia.com \
--cc=tony.luck@intel.com \
--cc=vsethi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox