From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0676CE7A8B for ; Mon, 25 Sep 2023 02:04:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E23D6B011E; Sun, 24 Sep 2023 22:04:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 093726B011F; Sun, 24 Sep 2023 22:04:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9C646B0122; Sun, 24 Sep 2023 22:04:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D67C16B011E for ; Sun, 24 Sep 2023 22:04:36 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A0469C06F0 for ; Mon, 25 Sep 2023 02:04:36 +0000 (UTC) X-FDA: 81273475752.13.5EF31E7 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by imf26.hostedemail.com (Postfix) with ESMTP id BD50514000A for ; Mon, 25 Sep 2023 02:04:33 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JWIOpDsC; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf26.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695607474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gBZHr/pA0EI1w+bv94KDBi76SmbEeqiEs10nDtp9uzs=; b=bi2k7kxoL1UaCiEXuicnb+rnnbFCqR5VPrK8MulZE+E+RzPA8kd3HCoDk7aQUfWv1apiIX jWIW6VFZC2n68t/oJxWB8iTVB7ZKlq0vdWULKOG2Nnc/3/OW0RZutf5XouvRYvZREPOMgz 2ojQWQ+KW+QDAFWEGnzgFaM4joR/OTE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JWIOpDsC; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf26.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695607474; a=rsa-sha256; cv=none; b=pBizb7kuWIHXMbeaM9k8jCk79QZHdkMj3NcTsziTEXb86OOiaGjVxuB57tDkPheh8AH/My XN5IYWqnWjLQawC1rSLDfDBK7QU+UI3mPA+KMBj7kPaKmicDu5gQUfR14V/vGzOAooKevL zpsR/YP6HABuj7bbnyupKGTflx5bvTc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695607473; x=1727143473; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=N5N1MVnoLtn6COPC+Z9AaoRWzoVIYhiBRP33WVklB48=; b=JWIOpDsCF2NKX5yoiTH8SJFIzQpDt5o/v1kjCirS0Mtj5Pl0NHbM3+wT f057B76pnDC/4rlRI9W9Y7boQxhHigVAZAu66wzR1JFF5sz1PUB+dLRvC pDgXMa5yOlj7VgrmkuMD80uCT0P2j/R4aRRpWL7WRkJ7tiq+LzbqtyZvn wbqL4Zm9AG51uJksE3ODbZSSDIUHk5vJnCH70TOOlSwpBUb1AyUZYIjwW R9vgAQD+iC58ZEg4i49QL3442QALKM5Giv87UyFqU+I9ImmEmiDOB7Elu tLsQWITieWC6AUKdDZCXTSffAOuBYwc08v8/9os/j/RKHlAcwaKQTa8Ci g==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="467433263" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="467433263" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2023 19:04:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="751499138" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="751499138" Received: from lkp-server02.sh.intel.com (HELO 32c80313467c) ([10.239.97.151]) by fmsmga007.fm.intel.com with ESMTP; 24 Sep 2023 19:04:14 -0700 Received: from kbuild by 32c80313467c with local (Exim 4.96) (envelope-from ) id 1qkaxI-0000lZ-1W; Mon, 25 Sep 2023 02:04:12 +0000 Date: Mon, 25 Sep 2023 10:04:03 +0800 From: kernel test robot To: riel@surriel.com, linux-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, muchun.song@linux.dev, mike.kravetz@oracle.com, leit@meta.com, willy@infradead.org, Rik van Riel Subject: Re: [PATCH 3/3] hugetlbfs: replace hugetlb_vma_lock with invalidate_lock Message-ID: <202309250923.NEPT0ip2-lkp@intel.com> References: <20230922190552.3963067-4-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230922190552.3963067-4-riel@surriel.com> X-Rspamd-Queue-Id: BD50514000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: wqtqcxy1jxcapj4p71mmuuowmm6tqfce X-HE-Tag: 1695607473-190467 X-HE-Meta: U2FsdGVkX18Tmjnyrz3W1V5GZY/Ri4qC6fJCYPUnAMRCCuRSD9/WSF39G/yq3vjwQfeQhjM41u5TgMoRFyh92hDOrJLFYUp3VCZNj68qvr9njH2gcq2P9g0THksMpfFrhJ1xoQPvi3a51EeL40uzw82vDErGVmexWHSGoa6ZGqroucjzhRm9oiQACJJerVPG6W8DkgNv0ihDndFKKUMEpEGQFMK+5zxnd1wTnF5l99Dgs9zco7r9U/L7wL+IyIdxYqgo0U/GCgmK0fbs4ZMakuJ4Du7QEtPiFk9aII/9fSSddVDHW/MNnLjwWN0MxtBcPS6MlvDKkD91u0Jp9iPOejjabLdo8JM0XNVuk4Y9pTcETgLzUgKySoZzc5CHaxQdY8NBJznuBNP8Q4vELlasAfjc2iIyJGv4Fem85i91r9Hg8AIGB82rYcRIfkZu71T4751k0co9UMfi9XJvyiAMGJ5ZT9lei1BcpxHTqz1cu3BcL64nkWI6RXzOxOxtMM0+OIRT2gSsfeELJIbxIk7FNaJuN8r4tEx+utadL8MbBxx7XwtUbJgwo8tx4mnwCZx4DM2Km7umFo/oghmaFxiOYzatTDdTzT6JutiSzxvTY1yZadZ7l0LfCR0B1O3PSGrtUgvXDaWDKLQ0bSumaK2Yj3LnTER0MNVrOZWoadiFpwg/PVYwv5cAee4ANoSVsLHGwfSWyi00h7M2Zx8ffs7L77ooydTMtv/sjlYmfGkHLgrbSm7jyPLARe+7yDLdtlOp+dTAzEEm7i6HYJ8v0YMYiKCuRjQpnnMToSwmIzVFEgNChTj13/GiHDQVBmh+xr5+0ll+qqIErF8MGrLS6yh2tC3yy1Qkb/kKcGwYCYMfxQqH1mrQWBBHXBkk5iYH/esvldh2aiBVIcRLNyO9DbFbSGRHDU2Y7kLRHRPSWKU0SHPG0o1o9AVl/HoJA+NmH8BY6ta6MpTPR9YEFAiflYx 3pHRsDlN jmik2AcYYqvRjEhS19FwSPwgi3jgrzuTQGugegHjbT+4KpvjmkhZkMRxNBw+eENIkR8Pc5JPF6S3R++vs692+X32RmzgTI0EUJBJSi7rOPLlnG4+AwcodLN6fG0vkSmWY50bx9RyKL34hIpAbqkED/NjkyxqjuPJFsCKLG0wQ+KZbE8bnC4fHuPAv+NMO9TxmCFucXJQkdGcNM16OUl6xTP70Y4qzduyUYzsWhxbaeDpVLp8LCAzOzS+aj6evQkczDIW0AIU154IVCjfkTZJEms1beWEcybq3ub+pINgKn6AYxFpYhFdSTc9nG0TlKuTBe8ddKMjCSw+AbxC4SnsYTtSItbPYI2HuNRFkSjN00Mhv4C+sfZDBQeeJXoVFpeC/v2d9mvEQLgfUt6c7hYar4J+5ff+jhz2d4b0zdOliLhhuPpLnsN5RrXbKwoh+iwjltlMtlBYuAua9Jo8yS89b0kA3roFcr4He+I9U X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v6.6-rc3 next-20230921] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/riel-surriel-com/hugetlbfs-extend-hugetlb_vma_lock-to-private-VMAs/20230923-030756 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230922190552.3963067-4-riel%40surriel.com patch subject: [PATCH 3/3] hugetlbfs: replace hugetlb_vma_lock with invalidate_lock config: x86_64-randconfig-013-20230925 (https://download.01.org/0day-ci/archive/20230925/202309250923.NEPT0ip2-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230925/202309250923.NEPT0ip2-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309250923.NEPT0ip2-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from arch/x86/include/asm/bug.h:87, from include/linux/bug.h:5, from include/linux/thread_info.h:13, from arch/x86/include/asm/preempt.h:9, from include/linux/preempt.h:79, from include/linux/spinlock.h:56, from include/linux/mmzone.h:8, from include/linux/gfp.h:7, from include/linux/slab.h:16, from fs/nfs/write.c:11: include/linux/hugetlb.h: In function 'hugetlb_walk': >> include/linux/hugetlb.h:1285:42: error: dereferencing pointer to incomplete type 'struct hugetlb_vma_lock' 1285 | WARN_ON_ONCE(!lockdep_is_held(&vma_lock->rw_sema) && | ^~ include/asm-generic/bug.h:111:25: note: in definition of macro 'WARN_ON_ONCE' 111 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/hugetlb.h:1285:17: note: in expansion of macro 'lockdep_is_held' 1285 | WARN_ON_ONCE(!lockdep_is_held(&vma_lock->rw_sema) && | ^~~~~~~~~~~~~~~ vim +1285 include/linux/hugetlb.h 185d8dcce62020 Rik van Riel 2023-09-22 1265 9c67a20704e763 Peter Xu 2022-12-16 1266 /* 9c67a20704e763 Peter Xu 2022-12-16 1267 * Safe version of huge_pte_offset() to check the locks. See comments 9c67a20704e763 Peter Xu 2022-12-16 1268 * above huge_pte_offset(). 9c67a20704e763 Peter Xu 2022-12-16 1269 */ 9c67a20704e763 Peter Xu 2022-12-16 1270 static inline pte_t * 9c67a20704e763 Peter Xu 2022-12-16 1271 hugetlb_walk(struct vm_area_struct *vma, unsigned long addr, unsigned long sz) 9c67a20704e763 Peter Xu 2022-12-16 1272 { 9c67a20704e763 Peter Xu 2022-12-16 1273 #if defined(CONFIG_HUGETLB_PAGE) && \ 9c67a20704e763 Peter Xu 2022-12-16 1274 defined(CONFIG_ARCH_WANT_HUGE_PMD_SHARE) && defined(CONFIG_LOCKDEP) 9c67a20704e763 Peter Xu 2022-12-16 1275 struct hugetlb_vma_lock *vma_lock = vma->vm_private_data; 9c67a20704e763 Peter Xu 2022-12-16 1276 9c67a20704e763 Peter Xu 2022-12-16 1277 /* 9c67a20704e763 Peter Xu 2022-12-16 1278 * If pmd sharing possible, locking needed to safely walk the 9c67a20704e763 Peter Xu 2022-12-16 1279 * hugetlb pgtables. More information can be found at the comment 9c67a20704e763 Peter Xu 2022-12-16 1280 * above huge_pte_offset() in the same file. 9c67a20704e763 Peter Xu 2022-12-16 1281 * 9c67a20704e763 Peter Xu 2022-12-16 1282 * NOTE: lockdep_is_held() is only defined with CONFIG_LOCKDEP. 9c67a20704e763 Peter Xu 2022-12-16 1283 */ 9c67a20704e763 Peter Xu 2022-12-16 1284 if (__vma_shareable_lock(vma)) 9c67a20704e763 Peter Xu 2022-12-16 @1285 WARN_ON_ONCE(!lockdep_is_held(&vma_lock->rw_sema) && 9c67a20704e763 Peter Xu 2022-12-16 1286 !lockdep_is_held( 9c67a20704e763 Peter Xu 2022-12-16 1287 &vma->vm_file->f_mapping->i_mmap_rwsem)); 9c67a20704e763 Peter Xu 2022-12-16 1288 #endif 9c67a20704e763 Peter Xu 2022-12-16 1289 return huge_pte_offset(vma->vm_mm, addr, sz); 9c67a20704e763 Peter Xu 2022-12-16 1290 } 9c67a20704e763 Peter Xu 2022-12-16 1291 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki