From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 571A8CE7A95 for ; Mon, 25 Sep 2023 15:14:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA02E6B019D; Mon, 25 Sep 2023 11:14:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C5B616B019E; Mon, 25 Sep 2023 11:14:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3FA96B01A3; Mon, 25 Sep 2023 11:14:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A713D6B019D for ; Mon, 25 Sep 2023 11:14:05 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7E7ADB3ECE for ; Mon, 25 Sep 2023 15:14:05 +0000 (UTC) X-FDA: 81275465250.10.8075512 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf25.hostedemail.com (Postfix) with ESMTP id A30EFA002A for ; Mon, 25 Sep 2023 15:14:03 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=HPJ6GoiC; dmarc=none; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695654843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qoF2P0Ji7kt0PKEkMuiqHyMf9LWMxHhWA3tcCEOf5Ao=; b=RbBZGhLY2wN0UZnNn1vkms2yIm2+/M1fqLEXamjZ+HI2hi317N+yyjqJAO9wQ1mQ8aV9dn gvtNzXsHCPXhMUFhBYgufxDgYU0AfDY00oVX3Wy+24xbuUmI6MQY0TM5BRG6N4vpjTriU+ ipH7FkjEU4iwcqh8FJARL68a05YkzlI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=HPJ6GoiC; dmarc=none; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695654843; a=rsa-sha256; cv=none; b=G7860um4JVaUjmKacVjoDYicMc5GXP5TW168PVhb9p549zLWTDDnTyx6IXnvjRJJZk+UnV EBafNBQ/LqPZjnUW4YiE97bk5Th2HjmfRD808l76ejbde+0GJtqtVTphiFjbVScIdv/E/I BvLNaunPMd6Bv0vux3K+AaNrO2hlwWo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id AC113B80D24; Mon, 25 Sep 2023 15:14:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7B44C433C8; Mon, 25 Sep 2023 15:14:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695654841; bh=YKKQIK4vMhPCWEyAM4Ug/QZsOia0En0oCqy3GEJLLZU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HPJ6GoiCBgUc6GJOH4BH1j9TEjGzGUCAVaAspSKOWUz55wuTZBpAiCYKWOoNohoaN QbTFPGMClExIvBPS1bAyPei7wKiNDh9TV/W2Y8KCirkV6Fj/2NPIERSrPLDhR0QQ+u EKW8V+IgWABOfMqlqKZzTWyVhQzFnNi1gRssPp+c= Date: Mon, 25 Sep 2023 08:14:00 -0700 From: Andrew Morton To: Jinjie Ruan Cc: , , SeongJae Park Subject: Re: [PATCH] mm/damon/vaddr-test: Fix memory leak in damon_do_test_apply_three_regions() Message-Id: <20230925081400.9593189a7665c6ff1f812855@linux-foundation.org> In-Reply-To: <20230925072100.3725620-1-ruanjinjie@huawei.com> References: <20230925072100.3725620-1-ruanjinjie@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: e58f6j78aksxsdi5jrdrki4ijhapagu4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A30EFA002A X-HE-Tag: 1695654843-242489 X-HE-Meta: U2FsdGVkX18k6qw1e5ItJFsQg24KYsvd7euflLgvww9b5OPebA0NBw7Jyncz39ySokkUOWXu6DuDzJvkUwP3rNOBWHklT7ZBS5CVzMzptDPrarKub9bje9wtR+KyhTtrZ4a5GErfIggj0mYSQObf7eqFODqtQsNBPL3hOx8jlWTIxkZ994HSisx+gYVKwLL2B8T240XjCMr0F1DMmGHYMb2WeV5f+2k05shJEwm6AdzeSLuL0ZKwsJK5O9bmDZgwDqyRAckMxfMYbcBMlUP5bx+aHcsZatXLKT6j/AK0KQ02HXtqH4vU0U1oak713KhYm3XCVEu09hKzQ+MqWzO28BWEEz3BOZCTbrk1CQJgFCuEQjbN2mQz++KldtX296y6VTmMBCBAPzK3r+L1uUuucfkTRBjr+qWdvoEIG+57cIT631D3RbBzE4U6UMyuSHAzQDxg4PCc4esUJsxB/YlKf+FTIIrEFGUKwfX4AqPNM4K+ugBlT7d93OROGBqtZ1vccf5ZzIzXa2AnFdjt37zvUqX+QM0XvgDeSLqAk/9JwuuPUcKRJ41ZWrJ8JuhZy4ov1UGfiZmfAq+VmLS09eLNIqT24oUYIU2LkTRbQ8OiV5DCkr+WcbKDvoE+RTeEjKpoWyI/Fzr0lWi0F70QzX95lwRWgxniFwnL0T5PjZgS9gF4Acad+xBS8XbngFtYQNkMzWOsbPPJEy1gF4uGOi6EEm5Fz8N1lzzXDWHqVdhBQy6V5JHNxq/6ZdxgP6BCBpB2tk037YicLJ4r9sdLk66LlI+Rhvk7btpdNCDTA7VDUeddiddhN1VndxCc2wQxCvqbYOL/OCEq2+dv775Cp692b70XY5q4THMji6YBbJbtQUN7EdGjdJPacJsdKCWMoPWictXEIJKId8LU9vuSVa8GWgFgg0ER2tvpAndc8IqXqmXpnCDaSVFO08X1wmqUrB+KK+1m2mTvEDMfAwtqjtU B0Wd428e 4OYiegXOOUjyPpJbMsR0oQHAS1bUgV9Pu6AD7KRXgHhCsy17eFj3d3VKdiiS2TW4Nj2NLnLLtzisAFPbXEJmNEpHsPKxlubRCvCrJ+6fbr9QCK3O1VRIaNnzG8jPNgPp6ZGCoE0fJ7LesP90cnZsFPPFUpH6e3RSwUj4yvq0wm4qA98367kz6WAnXFPs1lK57ie5AnTM5U3A+gQiMzfAFiyaGH0hkgdxvvsm/BcTdn4rlj92OMDzlVTqoooudMn9KzLfZp34WfE9NWuh89xYpd/FapF5Iba2C2LoMBiOccxVGj1OgML9ONBTc2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 25 Sep 2023 15:20:59 +0800 Jinjie Ruan wrote: > When CONFIG_DAMON_VADDR_KUNIT_TEST=y and making CONFIG_DEBUG_KMEMLEAK=y > and CONFIG_DEBUG_KMEMLEAK_AUTO_SCAN=y, the below memory leak is detected. > > Since commit 9f86d624292c ("mm/damon/vaddr-test: remove unnecessary > variables"), the damon_destroy_ctx() is removed, but still call > damon_new_target() and damon_new_region(), the damon_region which is > allocated by kmem_cache_alloc() in damon_new_region() and the damon_target > which is allocated by kmalloc in damon_new_target() are not freed. And the > damon_region which is allocated in damon_new_region() in > damon_set_regions() is also not freed. > > So use damon_destroy_target to free all the damon_regions and damon_target. > > ... > > Fixes: 9f86d624292c ("mm/damon/vaddr-test: remove unnecessary variables") > Fixes: dae0087aeff4 ("mm/damon/vaddr: remove damon_va_apply_three_regions()") Can we please identify a single Fixes: target? Otherwise, how are -stable tree maintainers to determine which kernels need the fix? I'll go with 9f86d624292c for now.