From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E6FCE7A81 for ; Mon, 25 Sep 2023 15:10:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 991576B019A; Mon, 25 Sep 2023 11:10:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 967236B019B; Mon, 25 Sep 2023 11:10:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 857346B019D; Mon, 25 Sep 2023 11:10:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7492D6B019A for ; Mon, 25 Sep 2023 11:10:48 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2379216044F for ; Mon, 25 Sep 2023 15:10:48 +0000 (UTC) X-FDA: 81275456976.20.FB67598 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 34307100017 for ; Mon, 25 Sep 2023 15:10:45 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=r+oxEIY5; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695654646; a=rsa-sha256; cv=none; b=qb8UhqK+VfcL4ZFcJey9Atot8dSr/cSN/p3xz6JYzQJQksrPVm/gHjrTC8qfV+m4VJcvfL NPPWaqnK6Q3wr707PaxiFYeP2hgw9QBPV1Dnp88Au4U+U06TW3se7ZxVeQ7eL0sCf0apLD pwsqX8Byb3VuNOE5CLlJYsvw3yzeyOg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=r+oxEIY5; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695654646; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N6W8dzhWNTrYSwHnH9gHWcZYHgeucRQvEBY6XvFiEgk=; b=yb5tTWr3QWGnhIoDL/gO7mtyFBVnrR8KUZ7NX468f05jWeI6cIGwWnS7TLDpCqi34L6hul aA/yJctKaMRn/mI5eR7T6MAOIlk7iV7U1vtlDuyTnKSSVcTkT2X3P54mS4Xh52dThaeuEw ryJZt+Onicc2hha8Kxe0RbUbE3mJgZw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 131F761176; Mon, 25 Sep 2023 15:10:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67C99C433C7; Mon, 25 Sep 2023 15:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695654644; bh=RSzIWUOnE7T8XNeVBMrB6XLnBz1gFcQH4H/BZEvdBF4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r+oxEIY58+50ytAKbsVPV0M2wse/nGBiBuuL5gcaM9mUUq7mqFXP7UPdZd0BkYs8h I+MIOej3TQU05+ddc47d8Joo9ZsnGYZ2fmXKUhjhM5DLrab+9YhUjJU3M+ZahA6Zdv 15ZV9Skb0m37hBV8ibemCTIIGMllW5UTHktJ5KOo= Date: Mon, 25 Sep 2023 08:10:43 -0700 From: Andrew Morton To: Yajun Deng Cc: rppt@kernel.org, mike.kravetz@oracle.com, muchun.song@linux.dev, willy@infradead.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm: pass page count and reserved to __init_single_page Message-Id: <20230925081043.b4256d18f150e54ee7cb9c99@linux-foundation.org> In-Reply-To: <20230925072150.386880-2-yajun.deng@linux.dev> References: <20230925072150.386880-1-yajun.deng@linux.dev> <20230925072150.386880-2-yajun.deng@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 34307100017 X-Stat-Signature: 4m65n7zd9jekzmrfg4kxhspy7uug6b7k X-Rspam-User: X-HE-Tag: 1695654645-955489 X-HE-Meta: U2FsdGVkX1/svlyKb/lKZ/Onbj4eNXCqEePxoKMuPR7Oy53szp4CQhJZFnb9VUyCBkek5EKIPCiSYKf354JT/HtxT3Cine3NDnlCCBcyUWhNdzdVHP9iDBQeC2w2z8XRuw30HQRYXUu/oiDw4b+U435+inA0SPvPgz2pAai3vSjFJJHUHgFHan7zOd3a4T2zUxHwUe7uMepXdRc5dHns2DcI3W57KgoJFV4SiaMx1Kz9ohlGpJ6/9zwpFOIa/Bt0+taNZ7uTbwb1Pwj1K2iNddUNbGYVkIkq/SavJ9HJJFLuruUBG4nbXdvsXhjm5yj88RK28t/orNPukYUJ+hYMAuCvQmgcMA50UqhIHIfkaQkGL6Yz3r0OKmgBuHf5/7dHBMVRdHLfAns/+gDMXL3zlng2wUxvQJn5YZpbQBXBupGA9fmgL3t37FXOIJ6E0IQvXGi+GkRwhAaXiOlMfteOcLTF+Z8HuzWHni0h06ILAgR6d1lNlEU90lVWVNzuil6B20LNTXk8MxIDTZ2V7amqareguVBsrHXivXdPn1IDOJ/w1uyRyVnKtB/C3ynuD5RKn/YwEXo3B2IQISyNi5icQgNS5B8CyqnIiuLUBsIS4yUnqsywAISOtki5NJmRwhCSnHp+7eyMr6Fjrue2a7pRSkGpewO+TUo0rvrQ8q4wYUkyPbQql+oZ+9+7/mNtAOwVc7VeR5htEa9+qMm0JsynTRYOLUhdgWp9x5ZM2wHDka5BIlBCMvERyq9YG4LALJ3DJcfiF3CI9cUZNwt/M3VQl9HVXvZP/cpL5S5KfhbdWKmVSFgQCtJUMkWaeTcDKL2g/zYH64aZRJIeqwvmeOSt89KcXpBpTORTA4SSrm0GmTCFVZ5bo11zbA8WIhwyKpA1fjnYTUgii3+Xzna/aIdOm6Chs8ybj+7zc29vQWY+uZj1RBu9K23CKH94l4+ATlm+wFXP7+txzcpFOycfoOk paTT28tQ RUQxvmWvP8QDDEGcG5SNloyfQI1AagryBkpEaIL6MedAMxDxVMGzuCD5pSRO+VrsPY5aagTsqp/iRPFqfWOYT3/oGE8YHDAttpTZlZGacl6IJKdJyXUJiJ3Q76dE6i+NB++5zMrD6kRJLAd+IiQu+6raLKQ0ZUrA5L4QmKsYyifS9lKTyS/4zdib1+kzlEnzoZko4K/XR2fcBQJtImq5KZfPfLt26O5uIjaqQBjH2cRJnpNK4mLHjqq89wsGnAJ9DTqP/kSGOD9Iic9qZhBwlU4RSKo3gD4rvwvsp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 25 Sep 2023 15:21:49 +0800 Yajun Deng wrote: > When we init a single page, we need to mark this page reserved if it > does. And some pages may not need to set page count, such as compound > pages. > > Introduce INIT_PAGE_COUNT and INIT_PAGE_RESERVED, let the caller > decide if it needs to set page count and mark page reserved or not. > > ... > > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3196,7 +3196,7 @@ static void __init hugetlb_folio_init_tail_vmemmap(struct folio *folio, > for (pfn = head_pfn + start_page_number; pfn < end_pfn; pfn++) { > struct page *page = pfn_to_page(pfn); > > - __init_single_page(page, pfn, zone, nid); > + __init_single_page(page, pfn, zone, nid, INIT_PAGE_COUNT); > prep_compound_tail((struct page *)folio, pfn - head_pfn); > ret = page_ref_freeze(page, 1); > VM_BUG_ON(!ret); > diff --git a/mm/internal.h b/mm/internal.h > index 7a961d12b088..e9366cce461c 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -1209,8 +1209,14 @@ struct vma_prepare { > struct vm_area_struct *remove2; > }; > > +enum { > + INIT_PAGE_COUNT = (1 << 0), > + INIT_PAGE_RESERVED = (1 << 1), > +}; It would be neater to give this enum a name > void __meminit __init_single_page(struct page *page, unsigned long pfn, > - unsigned long zone, int nid); > + unsigned long zone, int nid, > + unsigned int flags); Then use this enum for `flags'.