From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81AE7CE7A89 for ; Sat, 23 Sep 2023 15:43:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EABBB6B026B; Sat, 23 Sep 2023 11:43:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5B606B026E; Sat, 23 Sep 2023 11:43:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D245A6B026F; Sat, 23 Sep 2023 11:43:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C3B166B026B for ; Sat, 23 Sep 2023 11:43:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A377D16049C for ; Sat, 23 Sep 2023 15:43:44 +0000 (UTC) X-FDA: 81268282368.23.C8CF571 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf18.hostedemail.com (Postfix) with ESMTP id 9681A1C0006 for ; Sat, 23 Sep 2023 15:43:42 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UdoqwjNC; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695483823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wL5Gvjo/BPWLt23TGrAOGlBu3bUE72meVkaWfOqfzxE=; b=UjruKwFKgoQHT9h6F1FjD3IsLT7kwRZZQlqnmRoJ92XYq0ORBTtgzlYeal3DuOAj1aSTFQ 4oOKTTcaWznAJIqsgExeGSnnL8sZG9c24VKXme+lQjAmup+IEt5aqbNecDZ1Bpze4plKPH MSpyB3LtMgm2CrJwUaMkt/qicyNVWo8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695483823; a=rsa-sha256; cv=none; b=u1gw77szB3ZPx+EO6TA/lc66dIX2AV1WTJvsN1oa9eWezpA6qHgqyH8fX4WrqllV6lW5dk ppeednBnk8c3DBjdI04cNXcdxWVEO370kmLd7t7k4Amwz3pUw4qs7TMbQTWrOdhk1FK10J bF7x/oub9kqmf2usHu4NE5UXVpEFuG4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UdoqwjNC; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id EECAACE1F4E; Sat, 23 Sep 2023 15:43:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09A27C433C7; Sat, 23 Sep 2023 15:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695483816; bh=ljgPDKGzFtkM9CGruxS2yf0TQKHwYcBRpz7ZIM8VO3w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UdoqwjNCGj6+dmcR2by5om8f6OGdHooNrFAdirAK1+mff8rgXeaENEbWOfJO5o/PC OJ43I0E8Te05bmcEVu+q3++C1e9dGOgWncbQbW9sES2Ibe2Pdsm+p44SaI/GSc9eJn k1TIpPAI+1+0z14moXMdYfGTEFg/c4FGc6F68knV28yyNaM4SU8WYGPaWhzn5xPNAt FG0AxN1gAVv9xHc/jH6GfcIvluITorwBbApgU2SfgTJcYKv7Yh/vBJZDq2ZFWWRfdD gacKAomGi0R18n+DQTrEIea+0KrDaRDhkeAyfdIkOyz1+kcZ1YK3P1S2X1RDLM9+UU ZFkbq4f/xAuEw== Date: Sat, 23 Sep 2023 18:42:40 +0300 From: Mike Rapoport To: Song Liu Cc: linux-kernel@vger.kernel.org, Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 02/13] mm: introduce execmem_text_alloc() and execmem_free() Message-ID: <20230923154240.GK3303@kernel.org> References: <20230918072955.2507221-1-rppt@kernel.org> <20230918072955.2507221-3-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 9681A1C0006 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 4ksd6746qmy48k3mjen5bd9qaxcbbcyw X-HE-Tag: 1695483822-505703 X-HE-Meta: U2FsdGVkX1/5bWIopCWuDm+r/oN6VsUuDfrE2h/H9gR4U4XKakjgrlBpTQTBMdGJ/Ps20CrquXZ8o6eHU/dztpoFNAZhuImUsW1urpZE3kkWBA0ajqB6e/xb1Asi0rcT7ucmqG/yOAvAv0Wu+zksY4itQMkJV3R06utFcmmCNDhzsEFnW4zhHO0xEBPmgXRCXIs96gGe3qoCQ9Zm2mxEGj837KJza+IFyrQaIy8dTb8Uwl9hsw5qLr9KJ0VxdH4cVf/VM+WuQ2e0Was3lJK7Mpiq8Bs5yhEc+Lb/xUyGAIGiWCBHXAwih3uQghvuQ9R4wDKMIN7mpr7N0+oPV1xP2FF+0BRHKEEF+xXiA+oPknHNVT50voFGy+pgUiWYUisQuWKDfsiv9u+LObbrM7VVqsG8JcoYOjdhz+JOadmZmQBYMloSHGtJTYB/olKMLxOokkpNy/tKQjdIXAxTy5HXs52fBedBgPXEPsWRsA8vp0rNLPlny0Jub4oh+BTb0MICvexUiOt52+7p95KKTCAZ9uSb6LoYb+W5WIenzBFiMIGX/Wxh5qVCcbn9PB/Nak4k1plO3EGXnFiu7xBh6NhOPUjI10NHcu3kAEYAHURp3ARIn9chwhSEPWwIr7oseH7pl9aHsAieOYjFJy5JK6H8aaGF49/l1UG3yvmD1QEIyDgjMpS7BdWTPFVmGbDXdalEEqqBHjLi/5q6R1SDfRvFGzhM350I0Lk8Bn20NqALWutV87niy/FNpsDiuV1ZXI0fqasecmQnrZvHIVeZCa2AuAd0ceuP8bNYNpREiFPuJkiqmQHCQ1zbsDBAweUvsN7OeAA6O6WZA/cq/CIKQ4xAN6fm4Ycuusa0pfvYLxckxqnNQ7+VzpltFjaXqH852Rs8wv9EAEVliHCPkiIiRizE/A3kKJck1dSUWQ1Rq64Jq7DTHxO3S4RHd1Z1sgQe55bI0KstjaNs/rqR5OE7319 jBm+9hzb KcroSJcOeqshzB3F5X1B4ZaRPVbt9tEE1hN5rtb6rzu0htsv+SLjJajER4djh2iw+agG2rx8UUuR7m1stgwVxCSvMOkaEiKc2v293JzMBXLqvSq9rKWxMFY6vCguNisow1zbiN41RYdB2hh2KPWnRh0y3z/Am+vUAFmcyIEtaUdHcXkLDGQRQjyq13J6m7wAfuDeT56nMYKsoK4X/RRkpG6b17MMXW+S/vQDlflrM4SZXsLS38ZNTC+J0u+O81N9VdNkcKPEja6itI1LZ1lq01Mv/AQYZE4gYyl5G6GZfyn9SXCkFt5LBUQFC8aXDcp47xGKDtw66KGTd1SSw/XgaDDUJoLHKY2BRAK6/8qQMyvPulMQ49zlQrS7ILuHhvTp4oWB3N9JwXCkY9lIe9D9Lk+ud2u8b7LMojo+e X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 21, 2023 at 03:10:26PM -0700, Song Liu wrote: > On Mon, Sep 18, 2023 at 12:30 AM Mike Rapoport wrote: > > > [...] > > + > > +#include > > +#include > > +#include > > +#include > > + > > +static void *execmem_alloc(size_t size) > > +{ > > + return module_alloc(size); > > +} > > + > > +void *execmem_text_alloc(enum execmem_type type, size_t size) > > +{ > > + return execmem_alloc(size); > > +} > > execmem_text_alloc (and later execmem_data_alloc) both take "type" as > input. I guess we can just use execmem_alloc(type, size) for everything? We could but I still prefer to keep this distinction. > Thanks, > Song > > > + > > +void execmem_free(void *ptr) > > +{ > > + /* > > + * This memory may be RO, and freeing RO memory in an interrupt is not > > + * supported by vmalloc. > > + */ > > + WARN_ON(in_interrupt()); > > + vfree(ptr); > > +} > > -- > > 2.39.2 > > -- Sincerely yours, Mike.