From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC2CCE7A8C for ; Sat, 23 Sep 2023 15:39:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3D346B025A; Sat, 23 Sep 2023 11:39:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C58F6B025C; Sat, 23 Sep 2023 11:39:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 866EF6B025F; Sat, 23 Sep 2023 11:39:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 726D66B025A for ; Sat, 23 Sep 2023 11:39:09 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 405FFB2C4D for ; Sat, 23 Sep 2023 15:39:09 +0000 (UTC) X-FDA: 81268270818.19.5CDF9E2 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id 565BA40018 for ; Sat, 23 Sep 2023 15:39:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="fw2A/tcO"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695483546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qt+QAoQKTlG31ZR4MUI0U3JAmdt74xDeiw+evrw3oyU=; b=z408qMlfWFT3z2awOliNe97EiGVWFRNDgnuQT8hC6LNTAV8V/spLreIbL4qm8ToCfhetsb CGOH3tdSpFzj/AmC7pf2wPEoyomGCaXoxDk7aHy6ie/EZm18uTa63kozhlTgw8xkpzaxmd Z19rhjCnlIP5PdNdlKWLvVQJaJZ40Iw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="fw2A/tcO"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695483546; a=rsa-sha256; cv=none; b=psmKqcUhaVk3lO4eN2g+ic62qpbMhZyQxTAw+Km8OTZbjsnNdDdzdrDovto5EDa8zHQX/M RNWfpfp0oaRRli9nQXmFwiqF1ZDkLptHHrJT+UGYiLlQWsID6TyYTmIxQkFf1RRLOfFla6 S3t0eMleQ7vx4Q9vQwQfgSTSQgMwfxI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id A4F7AB80092; Sat, 23 Sep 2023 15:39:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2139BC433C8; Sat, 23 Sep 2023 15:38:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695483543; bh=44aW6DcKJaHGXelf02UJMtFK5RbIa4QmGjb00e/7p/A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fw2A/tcOcobQiglJay8dvPT5bEfVdzbbmq0FwMYYkRDEvMMNze6l5vdxXC61b2ule JFCwMCsxrAuMW6D9gVnh2enWSeUtDeXGmVEjWBDuVv9KbPW1MRt9tzybn9NNKJQMj2 y3Lc/W+nmmCK2KsTrqRVvz29GuwFbt1mGULYw6jBfPPwRcYXpuSga9okI5ya4zHkUD tynDeAbBph8ozw0L4VOesv/AFGSBeSrp7QqXSV98fLRWfSHzHFilN6nNqox4/XsFqb GBdnrmPrEZw+uXG8gLcDpColobXRcu9WsCK8bgQKX9ms+oqH3fV0ph2eOZh795NWNU moLZ9gWnlnDaA== Date: Sat, 23 Sep 2023 18:38:08 +0300 From: Mike Rapoport To: Song Liu Cc: linux-kernel@vger.kernel.org, Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 02/13] mm: introduce execmem_text_alloc() and execmem_free() Message-ID: <20230923153808.GI3303@kernel.org> References: <20230918072955.2507221-1-rppt@kernel.org> <20230918072955.2507221-3-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 565BA40018 X-Stat-Signature: m7qji4reasjxfen7qyjdu3mmo9g6thr3 X-Rspam-User: X-HE-Tag: 1695483546-592168 X-HE-Meta: U2FsdGVkX1/2bSd/rRmO2lLxE0+IN2X88817KGV43Fhm7pByeMMatMJmWGRi01xxK0Eysq3KYc4D7NlrsU7XeVUqaXIizsWkV5+YbHGaxi9vfuV+kTt4usYzWQtQ27KCYLfWq2zVVBN5nM+KpZEjZhthUsq3OWTMYQZrgwUg/9XpmLkwY++DMoGIReTDEhUYK6MkjmFLgfCTT7Hc7zjUrdYlO5aCVd0+f40G2rQm8grdIzEUWLzz5ZqtZC0sLJmsS7swqbcoL9Bn1apztKyHxwmFJuDdjH84NZG3W6uoFyAVP/ddpVhZj60snumbemxBzsgV/XnAaGxxdYso1YMLsRymoNqsv402YeSoulKdCjl4obcG7Tf540fxoLyP0KgRGodPZCZOvUtf07CLng9pp3GQ6ojarhvfshpnS+TpOav8yLIfG0OzVtzp15jm9eBoLjsNnH/ujtCnrGPmrxXvhHFFEuxEk2eM0l3DHhQoVTADHA1uK+5fQX82tcPYRU50W6FU6pgkveNSwEcwB4meWGsE5+KobqLbf9B3sYWQ8iHHSpuBCy4Cql8Xh4o/q6XcHUJtHiArcJe/DUKf3FjbRCuOPIbs/6uHQWU1ZNE3HDydmfEa+AKxLGyyd7dkXsmW0hOCiMM2dFrZ2fTqwwAaaakEVeVXuTHiuTX2XOd9vmaBMgePO4vETyOq6qEfYwGOidxgutbaGJJn0CLn4w5NBFTrzlDAxobAuX8yjDMzhasYvl9+2oKcfW3YYQNpwZ2EsagTgmuD23FRmM+g1ra1UK6iC9W0pbfIWYgzy2okpqCcL/86OGgT8GoQU5UpWdDoazePpqtkPoJ6Jef8GnJhVsJ6G6wzHEmgii5tL16dOh2597uGrGKx4VNTk1pdqbuAUfeYuRGjr6iaT2QqX3gYMm5Mr4fDiUMgzQKy0n9g0OJTr2TxnSHG9BwpzgiErMMiGicZhRpZo3rMq35ywff bMnLiNVH LSEDgwRYFdvL34sRcBaw5ujKThumKD58Vzn3eJehoZ4C2nxADPZb9BSaKVMs+w1HBxv1y4Lhh+d9kvIL181w8ma1DpKJobFbu2f02oC81cD5aOTEnJoj4vKYzy7SyuPxC9b9bC5A008Awd3Fbx54Q3tF7m0NSb4RDNGO0U3ld0KncvO3Q/ZBzaL3f/akxWxb0YGezb/JugzRkhxI0rhY0HGxgK8g1Ag/nGJaCkBOvEM6hv4xfXxAfOeckzC/a78EVnBesyJoU7kpl2/ShqbwDD0084LDvU14foEvl7Mz+h0uEccMAhg0iR++B/4tdg2Kgs96Ywu3KYLp1J9FWl3vMevk2wJS4na7uOsLbOXzi0XtG7VtVsKFzJkz/BhMtoBG4YOBeJ6yOB4uiPROO7Aw5N/GFsfV8kLWJFp6+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 21, 2023 at 03:34:18PM -0700, Song Liu wrote: > On Mon, Sep 18, 2023 at 12:30 AM Mike Rapoport wrote: > > > > [...] > > > diff --git a/arch/s390/kernel/module.c b/arch/s390/kernel/module.c > > index 42215f9404af..db5561d0c233 100644 > > --- a/arch/s390/kernel/module.c > > +++ b/arch/s390/kernel/module.c > > @@ -21,6 +21,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -76,7 +77,7 @@ void *module_alloc(unsigned long size) > > #ifdef CONFIG_FUNCTION_TRACER > > void module_arch_cleanup(struct module *mod) > > { > > - module_memfree(mod->arch.trampolines_start); > > + execmem_free(mod->arch.trampolines_start); > > } > > #endif > > > > @@ -510,7 +511,7 @@ static int module_alloc_ftrace_hotpatch_trampolines(struct module *me, > > > > size = FTRACE_HOTPATCH_TRAMPOLINES_SIZE(s->sh_size); > > numpages = DIV_ROUND_UP(size, PAGE_SIZE); > > - start = module_alloc(numpages * PAGE_SIZE); > > + start = execmem_text_alloc(EXECMEM_FTRACE, numpages * PAGE_SIZE); > > This should be EXECMEM_MODULE_TEXT? This is an ftrace trampoline, so I think it should be FTRACE type of allocation. > Thanks, > Song > > > if (!start) > > return -ENOMEM; > > set_memory_rox((unsigned long)start, numpages); > [...] -- Sincerely yours, Mike.