From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB5C6CD4844 for ; Fri, 22 Sep 2023 17:03:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C3DB6B02F0; Fri, 22 Sep 2023 13:03:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59A066B02F1; Fri, 22 Sep 2023 13:03:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 489F56B02F2; Fri, 22 Sep 2023 13:03:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 364676B02F0 for ; Fri, 22 Sep 2023 13:03:19 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F19731A01B5 for ; Fri, 22 Sep 2023 17:03:18 +0000 (UTC) X-FDA: 81264854076.30.8CA047F Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf05.hostedemail.com (Postfix) with ESMTP id BBABE100027 for ; Fri, 22 Sep 2023 17:03:16 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=uZWF7kJr; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695402197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ixwiziejrjHWtGdqHlJNM8EioiUtzsU3cyvRsBLO27Q=; b=aids3aNEPwPtqWc/KpRtc0NmmelUlpCJ1QoHjScyWYeFHPjwrSaOAk4a9TgLIFwoP8XJmm F4M0WxiP3UnncebxF/31Oks5ekF81NZ8wlPAuwRmn+InBEDjyWwcpG3S/bYIOj2qM6VV77 logIQsyvkyDOHFKIVkHO+H4nlCJgAig= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=uZWF7kJr; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695402197; a=rsa-sha256; cv=none; b=46J3Pfa6XFjzKFTp/ysy5cJTdonc/4HEsa/0UF37frYA1kChyDYgZYZByHAiCXwl0GYjWV JLu4LB3duYiAIkMS67vcJNQ8sSwHwl3DN6hKUJ6sm2+2yiuBbaAYV4Nj/p9rt3jA/iPfqj NX4z46fFARVDF5sUnfxOciIP6e8qD6E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C44FDCE23ED; Fri, 22 Sep 2023 17:03:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E909C433C8; Fri, 22 Sep 2023 17:03:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695402192; bh=qa/QJ12DIUWvIeySIX2g6kqd2yUHHXJ+BRw50a4IKNU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uZWF7kJrm5w73mco/RN5kh0tFZqol/wzUHts2vidpRz38ZzJryh0F8Jo8FNJ1KjRS fvytGPaP6DT92lWdNVq/FOf7os8h8kRVgIb6Q+blcoSlcD8L3qWYBYT5RU0unpOhYv ZQz8Myb6yh3K4y1JaIiCCoPWXMFcaasTV8Kdbmps= Date: Fri, 22 Sep 2023 10:03:10 -0700 From: Andrew Morton To: Yosry Ahmed Cc: Shakeel Butt , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , =?ISO-8859-1?Q?"Michal_Koutn=FD"?= , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] mm: memcg: fix tracking of pending stats updates values Message-Id: <20230922100310.102aa12ac2bdf0568e6e7432@linux-foundation.org> In-Reply-To: <20230922082542.466579-1-yosryahmed@google.com> References: <20230922082542.466579-1-yosryahmed@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: g5tt6wfgi54aonseo94swbwjj6918bp1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BBABE100027 X-HE-Tag: 1695402196-880122 X-HE-Meta: U2FsdGVkX18lO2DU6CW/RLcl8q1gIPTBeaY5LEKXRNkbUoFpuNBTz3k4YdA/dn8m+y4sUb0udSc7Zqx0PDghldmtzLcDXOYKcmQEqv2e24eEIMgDkaaOgz+ZSnDt5zcK1875Wg7g5c0S03MgLsqaedCrMwK3LHWg887XJdLlCQXAj0hpYqNrO28M+E4+yABcP3pX/5bRU3OrQfBOJKouE/YoVoBzosMTNLB+7dnkP+4xNZVRTi/7h63rOlC0gY34INaXlWuerGx2mpTPXyWhhrX3+dcR5x8YcBeSaVF6c3fmwUuN9NmlFMzj7Z5iIjdzIKL6fBCrkNe2oPw8yEZtoyqq8K4rMc/WTwWrBzlFwtH+ZwhmnUevv/sbSXVS1u5Nwb/QF55EzjJN8QZZNAWBWIK/HAd97b7unAK7TUf0swsIbu9GRXNJuiKLT+2AbNvvCdDtryUpnUM6LvWqRaVXhS6Fg8CqW5vZAQqfU/JQUXQlrLnFSMs0IzxTXyYjakgMNJmkpZjlwUy2ZoLsLxWUzRrvX82FhsdyUVHVrIbMJe+hpOV2VaN0jYaJuvWtZw0XpUfmbBYR5lhp8C2x8pRDTF0WJwOQ/1X0NYKYNBUga3iTic615S19ex26/wDKZ0dmhY+ldLYOmYosHMndmA5bbtxHDxP1Wm4yMPkbyEMfj71YhHJRGfwFUg9nON0EnjuJ+kKoYuBU1dGshyx7rlUh8MsAkUr9S5savPGAVPuAW2hDq7Daa8T1SY7Q8CCyK4tAZVOtGx8w3UpRnn8/0B6Ne60NtcESrIzyv20D2/ENCWMZJpiNWwSiILq8jvEmCwMJ5PGyS9uhWRcjVSk64z6k97YkMhAEXTYABdCCYx8rnzQF0JeTTOqu7kMaOoLhG1SJXkSoU5ej3TcPre3fUIjIDbOz0dE/mQLShOAAC4Py2H4XWUrh7URRsWxSJcJzCb1l4IWbpmOENsiOzO3iGMw s9YBoGNx 1bJax/KeXVA0mzPCOyMefA6iZKCDyX/Rf2iPS4Dx8sB+DZmwfI9MZ4JJuw+y4V02g0Jv1OBS/l/zAxQCNwzXtikZDtXRaQo2mHjY/8XWRZHDawvFjAOQw5txjen47KMNphiVxA2hCWnISyMcyoVLngAx7txd4E5v4ffiLoiyW2hSpSjZfZqBjxbNtXZf79+BSXEDwupNUZPBLU6Man98ybHDg/7ZOs12AoOfBNg95dnu/7WVBik795M3deTWm3S2MF2NCaAbwU/wawKVuExiX/tTubg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 22 Sep 2023 08:25:40 +0000 Yosry Ahmed wrote: > While working on adjacent code [1], I realized that the values passed > into memcg_rstat_updated() to keep track of the magnitude of pending > updates is consistent. It is mostly in pages, but sometimes it can be in > bytes or KBs. Fix that. Clashes with "memcg: remove unused do_memsw_account in memcg1_stat_format", and maybe other things. Can you please redo against mm-unsstable or linux-next?