From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E27FCD4844 for ; Fri, 22 Sep 2023 17:03:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CBB56B02F2; Fri, 22 Sep 2023 13:03:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17BE86B02F3; Fri, 22 Sep 2023 13:03:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 043D96B02F4; Fri, 22 Sep 2023 13:03:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E87B46B02F2 for ; Fri, 22 Sep 2023 13:03:41 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BB873B468E for ; Fri, 22 Sep 2023 17:03:41 +0000 (UTC) X-FDA: 81264855042.14.E54955F Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf09.hostedemail.com (Postfix) with ESMTP id BB43A14000F for ; Fri, 22 Sep 2023 17:03:39 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ACAx7tCs; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695402219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AGzg3eAITOz+3PG9l86iwz5MyQXEHtM5f7dztnFGn7Q=; b=2UvvVvJtH3AdFDbBjRBiCI8jQffJNUseU56roIS5j543smjgzhyxgj3pnO0miZEPPDltyV g2K0SOHpjIfj7yUyqRtPdeytPV3IZwLugYMcmgjRPh3TX1uZrNfdy57d2qQK+vi84tYsQW UY8v9UGFLScTSfBDJmjwQoVUxpqbAYQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ACAx7tCs; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695402219; a=rsa-sha256; cv=none; b=ORVvC6di8ozndd1bE46vPh9z+9056oG71tTq9eLcOAeDzfjLwP+rS14unFgUf7SMcaaEgn mAeQRJkboPIN0LpIp4oudz6EEtIw7gKFjqeOLHHxINzsH6EVYThiE8cyq5scxS8fV8mDcC rv5Ig44aJr5+7j6n2HMrufDCdK6Fq9M= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1c39f2b4f5aso19648765ad.0 for ; Fri, 22 Sep 2023 10:03:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1695402218; x=1696007018; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AGzg3eAITOz+3PG9l86iwz5MyQXEHtM5f7dztnFGn7Q=; b=ACAx7tCslM7tokFbTYWvDm9VTzN0S9WWo0Dmq8/LPsZR75StQWidllymlWyqQP2vMe oHujfvJf8uwGILcHJeQber2Gm0Nw3QlMC6oyXhVxy7+5sTCSeX/6bZOB4XOnn88fp1Kj ctmGslXaAqWmG6rwM8ErqLgaJnRSoui2mZfBA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695402218; x=1696007018; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AGzg3eAITOz+3PG9l86iwz5MyQXEHtM5f7dztnFGn7Q=; b=EmAZagKfk67uM07koJYCPenFnsXf+OXNaMjnVB9KcgN0lLfo3Z/D/Y9fZ2YdLwuwcx tg8ussC02VKM9YrRVkaYO/Hw795Fz/dmAaYcnwyo+DcAWwEATWTexiXY/SgQU5Q0Er6s zW/scRzZJUuKz8y9ZiC9klpQc45tKSZ+TKLgBFumhXm06kYo5XVvmztPvag+CT0HoXyT y/NdARpKntqlaFsokTjxseKADxxR3tkv69/So409YPJVVAY5ixzffg/p8M6nRT0/H2tx XSPLFrhD/5jay/T6iTseoJH0d9XguVzgSLP2L5fCiOn5vB8e+EK+gQBk2k5EZPIglEcC AtMQ== X-Gm-Message-State: AOJu0Yzwc8v4QbI38tyQbR5dLN2NYj6gF57XRBLoITaaZSUzDsDJC7Ds /9go3UMqZO5BZ34Dv2w01/R+cA== X-Google-Smtp-Source: AGHT+IGyxMlP/AeOViuxm81/eFv99esAftqjvaKIp/tu4J98q6RAeK+lhfhjWF6oRIfko0O4qH59RA== X-Received: by 2002:a17:902:9885:b0:1c5:6157:f068 with SMTP id s5-20020a170902988500b001c56157f068mr12703plp.69.1695402218456; Fri, 22 Sep 2023 10:03:38 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id y24-20020a1709027c9800b001c3267ae31bsm3703873pll.301.2023.09.22.10.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 10:03:37 -0700 (PDT) Date: Fri, 22 Sep 2023 10:03:37 -0700 From: Kees Cook To: Alejandro Colomar Cc: linux-mm@kvack.org, "Eric W. Biederman" , Matthew Wilcox , David Howells , Rolf Eike Beer , Arnd Bergmann , Thomas Gleixner , "Paul E. McKenney" Subject: Re: [PATCH v1] elf, uapi: Remove struct tag 'dynamic' Message-ID: <202309221001.F8554AEB4@keescook> References: <926f8e5c-40bd-dae0-2492-f6e6dbd6c96e@kernel.org> <20230829185121.326228-1-alx@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230829185121.326228-1-alx@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BB43A14000F X-Stat-Signature: fecuqhsfatf1wht837kxhzawi88yb3gm X-HE-Tag: 1695402219-596820 X-HE-Meta: U2FsdGVkX1+m7JOgALUvvRX2fTU4JiKFf39um1BEAp7iHjWqFXxEeIl1dv+/66Pyg6Bdo+jNHp40YnqiqQVqONkQoR8NwyGT9tk8FPO/rTXUQDIqoUC1hWIhXb3sKKLWQhHAuQI6GSTXkkZalUWLkw0DKwgfX0Jh/f6IIEfYC4UPSzadej76xIf9ZL8IYS/admfw6Qmu4FDXlpJ+E4BzEwlyZBUhf/EN+wVPkdsaIIxR6jm18ZDIIKfH9s/qvdnLPakSWZ1Uo8zjl/j4UyA+zvqXHzicK3gUaQDEx9F3IZBSXsck3b8Bw+Joeitv3F9r3jlySJ4Lt16FYOmGgZApc8Mp1StMv1XT1YmQnsgUKw+58kq3RI0Ki6u0vK3qEaioj2x/kMW9W8On6mYdzoFgf32381Jxvj0B1VZ75sOSWMskMnMbcdUeoVG4Qt7ILDF1UXjCgDubk8/hFilQLspaw/28zvMpVQeT7QnLGuTPj+NteN3wBoGyq9/gN4ZxTGy0eUoV8GFbo5ojTHh6zACeZsXKx/kqJmYZ42R/Wh8OcI7jEtg4TvH/aRU7qfZQwA0Wt2MoOEG9kt2/q8W2QwZYlIO5+jUxMM1cdE/LfHrT7/8tLU4n1/9QSdiMbmRrGtS9LJTIxH9ylDwXujz/iGEbqAVbMX03Y9yTWJNAR5RsUqFFx16146NHmSsR+pfq3VFmp1OvA/veocnJ1CQhMMwpGXG73rqqoXc3bokVhPnS7lH7875EsZ7p+/kGb6LhlS9KFAsL3swXx1FOTKDWtM2bvAuVv3E4xU6Hi2sfFTTP/l7lCqybFhwiXlO2EYfCEQEyXEHdEoYeMhBH6oy7ggeCqOCbnz0lu3neL3rB4O5gr+xcitmg1NYFD6QxZAG2Jv9avqs/a1iZ0YtZbDrni3xhTilNsax/XzULPmipZ8cKmJANeDcQzgZWXHA6aGvU/qfOyPHWQlGtHV40sWpX8ss NwPcoziv d2BQBZIGJkRGDHJEewvfzOuCc78c1ICWZtUCkXkjKU0VUpt+arnScrrIiZ8iAWspvOMBnkzWzv3HIRUjPlpAC5mMJUOnj4GfUkPBJufVks+xNKw6e00Jj24c0E5wR7PNxartdK7pTeAMuiMIzpI/xZDv7pfMPDC3mdZlyy2gAq8+2r1KKJ1UvyD+vkVIfo6iq9AEjKtkctgvRxY9tB6eXtRx3i5XB7iX+BAl1sw4A4OnXVnDU5w2OKdA0T463t4QXIqpjRhyVa5+E6LIRHEeS3m8CHDRNQwFubMo7sC3+u1/49WIZQ5FyjDkvlq5jCcC+Rm/xmZycLjm1pD1p+PNJJsU1W3UGNR/Jg/ZlD2naB7wMOvgq5tAt9toCrgo5aoT3Z6OvK896Rq9V9n7iWrgq3vx6IDP8rL/ZtwpXdoFOgkJPk//W9enozagsjE22PSBsO4CX3OillE3LGQF06Cpsm+VtvfagJ4AdexbbJh8SgzTG2rb5Y0awYli9etu1zzG0o/5IzNmwOEuLtqp8Kfb0kBjwfFnNUI77WODgNhf1FhiwgGc/9siCsAcfM1QevpCYBlR2DAynb5ubTBJPDQJiG6iFaTFZs6dkVR/97x1y12CoHB+6ba8Wsz8q4sLBSP2C09WpAVE1eU8uAM+ChhxE+t01qHt5yxr9aSZLpKKKz/bNOdAtMMtjHXNZmavRFphHyqmcN1ANPCz9WAuiFfrWG/Q1z+0qp2DidX5+UBGXklmaPP3vbGXhbG6mh/KonrKbiIhY2bSH5xn7uiGi0Fcra+2m+51Q7tI3bWj+o1Ga076i5ka5mRxc0WJQNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 29, 2023 at 08:51:22PM +0200, Alejandro Colomar wrote: > Such a generic struct tag shouldn't have been exposed in a public > header. Since it's undocumented, we can assume it's a historical > accident. And since no software (at least on Debian) relies on this > tag, we can safely remove it. > > Here are the results of a Debian Code Search[1]: > > $ # packages that contain 'include [<"]linux/elf\.h[">]' > $ curl -s https://codesearch.debian.net/results/e5e7c74dfcdae609/packages.txt > include > $ # packages that contain '\bstruct dynamic\b' > $ curl -s https://codesearch.debian.net/results/b23577e099048c6a/packages.txt > struct > $ cat struct include | sort | uniq -d > chromium > hurd > linux > qemu > qt6-webengine > qtwebengine-opensource-src > $ # chromium: Seems to hold a copy of the UAPI header. No uses of the tag. > $ # hurd: Same thing as chromium. > $ # linux: :) > $ # qemu: Same thing as chromium. > $ # qt6-webengine: Same thing as all. > $ # qtwebengine-opensource-src: Yet another copy. > > Link: [1] > Link: > Cc: "Eric W. Biederman" > Cc: Matthew Wilcox > Cc: David Howells > Cc: Kees Cook > Cc: Rolf Eike Beer > Cc: Arnd Bergmann > Cc: Thomas Gleixner > Cc: "Paul E. McKenney" > Signed-off-by: Alejandro Colomar [fixed Cc: list for linux-mm] [fixed link reference] Applied to for-next/execve tree. Thanks! https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-next/execve&id=d113624679391d9088d0e8fd06797711eb1285ac -Kees > --- > include/uapi/linux/elf.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/elf.h b/include/uapi/linux/elf.h > index e0e159138331..342bd7f2e025 100644 > --- a/include/uapi/linux/elf.h > +++ b/include/uapi/linux/elf.h > @@ -140,7 +140,7 @@ typedef __s64 Elf64_Sxword; > #define ELF64_ST_BIND(x) ELF_ST_BIND(x) > #define ELF64_ST_TYPE(x) ELF_ST_TYPE(x) > > -typedef struct dynamic { > +typedef struct { > Elf32_Sword d_tag; > union { > Elf32_Sword d_val; > -- > 2.40.1 > -- Kees Cook