From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1016ACD4F32 for ; Fri, 22 Sep 2023 08:09:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7718F6B028D; Fri, 22 Sep 2023 04:09:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FA476B028F; Fri, 22 Sep 2023 04:09:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 599AC6B0291; Fri, 22 Sep 2023 04:09:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 470926B028D for ; Fri, 22 Sep 2023 04:09:24 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 138ED160F7F for ; Fri, 22 Sep 2023 08:09:24 +0000 (UTC) X-FDA: 81263508648.11.5D422BC Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id 4BA2880018 for ; Fri, 22 Sep 2023 08:09:22 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kXI++VKq; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695370162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OQolIfhh7homJyMPEX9/UxsWMWPQ/P/HantJlm/8pUE=; b=pDRttilu6bJxdFshhT7kFjDZ3c8ug7fq22nbKX3rOncXgisr8hxEsBBveI2vOlTpvxsCuV RQ1yr6WQIX1G9mTOdM20v97LUGqtjr2WTMSOLZaYvlRdlYd1PpgaLJB3GLDzDG9HHXR94K UT6jxdfTfQ+gCkf/EyeEyfF45qsT9Uw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kXI++VKq; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695370162; a=rsa-sha256; cv=none; b=oz4Jw6ucAqk2be9yrrmeI5uibtfMSBUN+KYs01XswjisiUIzI2qMwXCPkX708abr1VxORC 7mvl4IB2QRZ3iB45isF+hRwlgAaw08/sxvoUCowFFhuXnnz4P004KPaswbe19OFZ1gzb/v jO4E0+LPpkk+0bUZCGTwmsMHewt5qEg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AE0D9B822A6; Fri, 22 Sep 2023 08:09:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03E04C433CA; Fri, 22 Sep 2023 08:09:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695370159; bh=gesgJDKBt9RDzx1mXwpHnVS0bL79H7WYB0zJsn8L4gs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kXI++VKqARiqXJhZfCh8UJGk0/eL1A1I22cQVjhVJVmgTDIGQhuWWkUIzIhnFto/K f+zv1BzXJ/b7Kck3A6G9y7ce9cZ6yaqNWKjcapDD+fPk+Hg6Ct69A5QIDAtnCJT58f TvgGPz44rdMMdEO7o01UsuuEzoSbpQiotkqSd0hT8W0Z/i3RAbOpdiMCVUGHFTJf1R 5GBFiryI+K8buRmSQMF8Ubg5QFvGM01vqncI+w8D2Ao5xS/mOMKl2J2TfBWlHF+KR6 mz3bAOVnXZvwKr7KA2GJ139Qk6o9t1Z7hIvx5WfXgf2F6RxMaC5CaLsKpHayNSpa15 vF6zy836q0lnw== Date: Fri, 22 Sep 2023 11:08:31 +0300 From: Mike Rapoport To: David Hildenbrand Cc: Matthew Wilcox , Yajun Deng , akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, glider@google.com, elver@google.com, dvyukov@google.com, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Subject: Re: [PATCH 1/4] mm: pass set_count and set_reserved to __init_single_page Message-ID: <20230922080831.GH3303@kernel.org> References: <20230922070923.355656-1-yajun.deng@linux.dev> <20230922070923.355656-2-yajun.deng@linux.dev> <2ed9a6c5-bd36-9b9b-7022-34e7ae894f3a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ed9a6c5-bd36-9b9b-7022-34e7ae894f3a@redhat.com> X-Rspamd-Queue-Id: 4BA2880018 X-Rspam-User: X-Stat-Signature: 88f59hpunmcg3w1soc1q6miwdesj9k8p X-Rspamd-Server: rspam01 X-HE-Tag: 1695370162-797121 X-HE-Meta: U2FsdGVkX18fZ2eOCBxEP3QQ9VTwuThnB92bE7tPgrHG2mSM9bYhXIyg849+cwu9R5iK2x26WWb4wRrj210ZDvQK/rGclI0wcHFTYf2k2/+JB/Wsn7Tc0YP19za/jYsp+KZCV8uGqSvqGpQ+RrxbBW0qHQQiOyyEI7TU+NHHkVB41WduBg7D7i45xqCNdQ05DZYSfDO8TY3g134CqT3ZnGBDQprnzLlWnjVOE3vDx50G0B+mV6oJyVdGZqrh0nM7J43l37WizZl1KWTBwnZwdEHbZIj+lK0T8R6yhgXE6+EXp3vWDvRg4yk+PEI+vEuVYzT0mJUcwynxh+oGCmIALMA5NUYoa2uIRykCEutKzW2oT4t2bcAJajMr3FFj/oekgG+tjIxXg+Cq4PRIv4zO4dl3RTRlDgaVSDZ2cYLT7wzG5WLRK5U29C7FHmyosfigisToIelr+qTiawG9pKYr9Io6du8nR5hNjmkeM3hByhkxgnvcaeMIuTHpXl2o93XKTxJL3G5njmN/Tb5XIqok3evHMJS1k9hW+RxwLPzsGnOQcYBb3heZ1YJ4V6fOvBPKmyERZj9dIsxad/IXOMPlXWuz5a3J7EgQ5zeo2c6kW+550NClvJQn/ruds39jYBN+zqtf/AZjJl4lteZxNNywR4KI54e8kXdU4L1KwjBVrWI1qixLNYIYKny49tGe23+ZEfeg7knVUf9EJxvpsQwCF39G6piFAv7V/8WlZ+hoR/V6YQvDch+dfFbD30s0bgkeJSw7yKroB8X0ykX9Ild92jOYFgRRXVDP+T1/9eOdUId6ocULx0I7y/fYQjOx3rqEFz7VWoKFB2BMmNzoE+NHW/3td4vaEuANdLXoIwN4OOIZ5zARXOdn71iggz7mmCfElCaXD3IWsN8dZVORdZK/Nd6RJN0EFiscNrfpoTeL6ikEC7ylPxQABD6xGoG3AQNg77xDAQRVgQkpuYkUiUa xW1rsX5N oA7FQ3Mt4q6nv0cEsqo7ZTkjlJwpgF0632CAM7WaNuNMd0Xa/2IT3ZdLAldOIOtQ6uUJJZzj4LY1eyMBIxbWg5dwpZhmnQmC1mDn+73pOcOYZluhT06545Y1AywgI9Z7zEUd3lOKROp1Y0oZjuhj7X3w/gnFYbKDFAyBOOSmUC2KLFamc0N0LwM9kYt+ajU0JxNaGLKWoYXK6sNr2Kh7qP3PdtVYX+IUIFh4SBr0BAxTA6YSXTAmLkZqWfOD8oLxNhihF9s+CRUKcSCWdk3D+mNAKx9M7KDcMqn8nw0phyV7va6psL5goJJK495b8W8Jh0vzd0XG/GgUjJ8HkFl4qAqhFdg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 22, 2023 at 09:48:59AM +0200, David Hildenbrand wrote: > On 22.09.23 09:47, Matthew Wilcox wrote: > > On Fri, Sep 22, 2023 at 03:09:20PM +0800, Yajun Deng wrote: > > > - __init_single_page(page, pfn, zone, nid); > > > + __init_single_page(page, pfn, zone, nid, true, false); > > > > So Linus has just had a big rant about not doing bool flags to > > functions. And in particular _multiple_ bool flags to functions. > > > > ie this should be: > > > > #define INIT_PAGE_COUNT (1 << 0) > > #define INIT_PAGE_RESERVED (1 << 1) > > > > __init_single_page(page, pfn, zone, nid, INIT_PAGE_COUNT); > > > > or something similar. > > > > I have no judgement on the merits of this patch so far. Do you have > > performance numbers for each of these patches? Some of them seem quite > > unlikely to actually help, at least on a machine which is constrained > > by cacheline fetches. > > The last patch contains > > before: > node 0 deferred pages initialised in 78ms > > after: > node 0 deferred pages initialised in 72ms > > Not earth-shattering :D Maybe with much bigger machines relevant? Patch 3 contains The following data was tested on an x86 machine with 190GB of RAM. before: free_low_memory_core_early() 342ms after: free_low_memory_core_early() 286ms Which is more impressive, but still I'm not convinced that it's worth the added complexity and potential subtle bugs. > -- > Cheers, > > David / dhildenb > -- Sincerely yours, Mike.