From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B91E2E7D0D7 for ; Fri, 22 Sep 2023 07:10:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 592A66B0290; Fri, 22 Sep 2023 03:10:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 543E16B0291; Fri, 22 Sep 2023 03:10:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 458DD6B0292; Fri, 22 Sep 2023 03:10:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3688E6B0290 for ; Fri, 22 Sep 2023 03:10:29 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1154A1A0DFD for ; Fri, 22 Sep 2023 07:10:29 +0000 (UTC) X-FDA: 81263360178.10.BBDF4A0 Received: from out-226.mta0.migadu.com (out-226.mta0.migadu.com [91.218.175.226]) by imf01.hostedemail.com (Postfix) with ESMTP id 65DA240011 for ; Fri, 22 Sep 2023 07:10:27 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=fPPxKFrT; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of yajun.deng@linux.dev designates 91.218.175.226 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695366627; a=rsa-sha256; cv=none; b=R6Hw46kAV3Wwhx3/FJtRkLn9Eud2JhMQtV0aV7KPpPLPqQeT6ISR+mOgYac2w2mv7XQVMg fPcSEwI8IVL+Ik3lzuwQrhgAcXxAYKRLxOjzqjTq6AIFRGzI3c22vBIEtLZGpvQsDRTF5e hds2CplZ9jCMQDa8Je/W78duYHaPnK4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=fPPxKFrT; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of yajun.deng@linux.dev designates 91.218.175.226 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695366627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0NMcmRX/w2n3M3EQea1/2ZhpgRQyZV6LdD1tfFyUHrY=; b=zTThQYjWAHoO4BSbCaM5LWgQI3qhzuAkjP+0HefSqlLhcdv9v6w3KykOnr5GHZ7hb29MZe Q3+4NSKJl0eJBlWyGodM52boQGIqad4hghfaRrMib4Vn9gOVvjPSXQOw6W/ebcSIIc5ak3 ZP/HAX4TjIIE3UQNey6E6XjJX+WWJDk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1695366626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0NMcmRX/w2n3M3EQea1/2ZhpgRQyZV6LdD1tfFyUHrY=; b=fPPxKFrTLFfvL3jUV7itB9gMnKWR/r7Snjv26hnF+iiC5cBKWt1EOcJiso/9kwp07Pc/E/ xO9LzRFYie1qlDtSrkxynAhhzP/0j+M5qMOLAGoypKYac3zL2PZvrY3sznXwcP3QWg6wwc 6fDf5t+PpwLmQdL+crOn+jgf7v0Hej8= From: Yajun Deng To: akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, glider@google.com, elver@google.com, dvyukov@google.com, rppt@kernel.org, david@redhat.com, osalvador@suse.de Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Yajun Deng Subject: [PATCH 4/4] mm: don't set page count in deferred_init_pages Date: Fri, 22 Sep 2023 15:09:23 +0800 Message-Id: <20230922070923.355656-5-yajun.deng@linux.dev> In-Reply-To: <20230922070923.355656-1-yajun.deng@linux.dev> References: <20230922070923.355656-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 65DA240011 X-Stat-Signature: jutncj9qprf9r7rnnfhc1mxrnuah78bg X-HE-Tag: 1695366627-754192 X-HE-Meta: U2FsdGVkX19amj7HkTgHIC52Mo8o78aEkV5vko5s/Hqsq5gJqLRLTWyeEtzrHehHh6WQZSfqNUTeu1Ou7Ur06QYCDU2mrV8zeihZ12wxRzwo7Y9jbv7PzkPnwNQ4BbPr0qTFRNHf+p1/VGWYpxL0MSBpGyqtpG1S8HunCp8eTpH6YGXGLGmRQMLb7Me6e/VZ47+Ng1L2cs1zZLqKVl4kJx/8SLv3N1PpIk5abfT6BhvFJRWkn5sDRInapAkc4bYrcynygqOdPr5k7BkuArWlpWokMGAiDdnFdNElOWwYivrObYS2wXySpbD2YCm0VxYjo8/1v4yDaTcSFE4IlkssSW4TQYxAwHknJDictHmRs2eJZG3DLLk1keO5l4fiURcmFREPbdDV4VZHm0tR/nUXd8IQinWeal3mzPK9mRoDJxgtwIX9+EGiYXte/Jgtrqrme+CQRJ42rwE4XCpCBP3FvcvnqC4jtf/mKb5J5FZVS0wbiZ7P3SquCEoUBvDMCpu5Qz+3kPax8cy9ACPBUCD37YEiGnbocSST32ZEXx4kq1lfvet7mEoKq/YocGWaGVrnW+DpX42LyJqOMnwUT0E2wI6elDNqM00UerAQnRFV92a41jY7MTZ8i6l+f9kmF1cF6QvPv/UrEMQ8x0SUdsquvucPbxsYaNml1xXdwGRsHhY6indnFmG7itaDfTg+eYxuyJEGIeTh4zScZkFNzsxi1ogROLU5I+YaOXrtd13W2uK+7/69N+1PUpZP9qtotiiMzD4Xenn16I8VrkZRLZUxNv2ZQ9y5j4L63Apt/FjjztY1vvj1IWDy0P5MoHiXnpTJNMyOnJMeUiBhyg4Rahh/K1snVI95x/GDT9DyDvkGbntcKIFXC9P/DZ7AEGFtoLr0XRqCgQyOFL8PuOoLhOVbtoJ3npYX4W+fphxZPt7CYvTcZUK/7O1iCxt3mnozhds5g5rbyJwXqkcWIRWx6yO JKJVG8u8 ruSwI0Z2adhRkY0ctNbLAaWC/gyqw20TpXyA3dTCJAXGQ/IbrbcYikJfmbDTT1U0yZ234bnRMpEiRxeDDTqQR9vnrAckUnkPqGUWkSK7ONECg95kwQ3YcdQU203NCxeXrgxG9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The operations of page count in deferred_init_pages and deferred_free_range is the opposite operation. It's unnecessary and time-consuming. Don't set page count in deferred_init_pages, as it'll be reset later. The following data was tested on an x86 machine with 190GB of RAM. before: node 0 deferred pages initialised in 78ms after: node 0 deferred pages initialised in 72ms Signed-off-by: Yajun Deng --- mm/mm_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/mm_init.c b/mm/mm_init.c index 1cc310f706a9..fe78f6916c66 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -1984,7 +1984,7 @@ static void __init deferred_free_range(unsigned long pfn, if (nr_pages == MAX_ORDER_NR_PAGES && IS_MAX_ORDER_ALIGNED(pfn)) { for (i = 0; i < nr_pages; i += pageblock_nr_pages) set_pageblock_migratetype(page + i, MIGRATE_MOVABLE); - __free_pages_core(page, MAX_ORDER, MEMINIT_LATE); + __free_pages_core(page, MAX_ORDER, MEMINIT_EARLY); return; } @@ -1994,7 +1994,7 @@ static void __init deferred_free_range(unsigned long pfn, for (i = 0; i < nr_pages; i++, page++, pfn++) { if (pageblock_aligned(pfn)) set_pageblock_migratetype(page, MIGRATE_MOVABLE); - __free_pages_core(page, 0, MEMINIT_LATE); + __free_pages_core(page, 0, MEMINIT_EARLY); } } @@ -2068,7 +2068,7 @@ static unsigned long __init deferred_init_pages(struct zone *zone, } else { page++; } - __init_single_page(page, pfn, zid, nid, true, false); + __init_single_page(page, pfn, zid, nid, false, false); nr_pages++; } return (nr_pages); -- 2.25.1