From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86226E7D0B9 for ; Fri, 22 Sep 2023 06:27:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B01016B0250; Fri, 22 Sep 2023 02:27:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB1346B025F; Fri, 22 Sep 2023 02:27:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9785B6B0269; Fri, 22 Sep 2023 02:27:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8625A6B0250 for ; Fri, 22 Sep 2023 02:27:13 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4F12A160EC1 for ; Fri, 22 Sep 2023 06:27:13 +0000 (UTC) X-FDA: 81263251146.24.F18952C Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by imf28.hostedemail.com (Postfix) with ESMTP id E4E90C0008 for ; Fri, 22 Sep 2023 06:27:09 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=EmAF6m7J; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf28.hostedemail.com: domain of jason.sim@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=jason.sim@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695364030; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=Hb4LK5km1WEqj6D7AXzSXon9Q0vrfwXxLWOoV26SQdE=; b=KaCio7Hu7SMQM3cBQTUUwCp+dEEr0+NcOrMi+vl5lFUIisr34TUuMdPL9eqSW6TCk2u6UL TonWknQeluR1uW6JIVRQqOn0/sTnJBFEkHhKA/K4Gyyv+cln+5Fr9MAICzUZrJAbOV5EvV L8L6xN7KLJzvq8RLp5s7EAgN4SCKEgM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=EmAF6m7J; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf28.hostedemail.com: domain of jason.sim@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=jason.sim@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695364030; a=rsa-sha256; cv=none; b=s0otDDAnqYZcTD0v8Rl6rjZG7IrEdjOKKRtvaVxRKHYhkQP3ssxA6P5sZHFcCbhFj3uoWI /EFm8h2qOlFyD1UGQN4GJIuOqtvzrBu94p39ZCGtW3DqjC7ojqQTwdYhkGMiPBsRWtmf5/ ureS0pEUKqUnMdN9okJOJv6WO2hqwMk= Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230922062706epoutp015a0b83be9e568996fb554f22a18ec9fa~HJJlpfWzF2468724687epoutp01R for ; Fri, 22 Sep 2023 06:27:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230922062706epoutp015a0b83be9e568996fb554f22a18ec9fa~HJJlpfWzF2468724687epoutp01R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1695364026; bh=Hb4LK5km1WEqj6D7AXzSXon9Q0vrfwXxLWOoV26SQdE=; h=Subject:Reply-To:From:To:CC:Date:References:From; b=EmAF6m7JoU8D2EZTeEB/Pa6OJhUy9xxH3BdYD+F4Jl+erdpmvzTGP2MwI9Zobpd5i NBxRaC8IdM8Wc+cmXqQigPl4xPJP1+eStz1Tozgpnu0iUGf7lwHp3sqRmwLXzAXUmm NcyJd7rhPPPLrydPqqj/df+MZ0xDxmcKIsP4HDfw= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20230922062705epcas1p34f0ace6c5a64263ee8e96a68e7bbcd4f~HJJlG8xmN3259332593epcas1p3J; Fri, 22 Sep 2023 06:27:05 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.38.242]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4RsMkK0hR2z4x9Pp; Fri, 22 Sep 2023 06:27:05 +0000 (GMT) X-AuditID: b6c32a38-4dbf8700000027b3-12-650d33b849f7 Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id FA.B9.10163.8B33D056; Fri, 22 Sep 2023 15:27:05 +0900 (KST) Mime-Version: 1.0 Subject: [PATCH] mm/vmalloc: Remove WARN_ON_ONCE related to adjust_va_to_fit_type Reply-To: jason.sim@samsung.com From: Jaeseon Sim To: "bhe@redhat.com" , "urezki@gmail.com" CC: "akpm@linux-foundation.org" , "hch@infradead.org" , "lstoakes@gmail.com" , Jaeseon Sim , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Jaewon Kim X-Priority: 3 X-Content-Kind-Code: NORMAL X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20230922062704epcms1p1722f24d4489a0435b339ce21db754ded@epcms1p1> Date: Fri, 22 Sep 2023 15:27:04 +0900 X-CMS-MailID: 20230922062704epcms1p1722f24d4489a0435b339ce21db754ded Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmk+LIzCtJLcpLzFFi42LZdlhTV3enMW+qwZPNTBZz1q9hszj/4Beb xekJi5gset+/YrJYdOASo8XlXXPYLO6t+c9qcefbPHaL1RdZHDg9ds66y+6xeYWWx6ZPk9g9 Tsz4zeLxft9VNo++LasYPT5vkgtgj8q2yUhNTEktUkjNS85PycxLt1XyDo53jjc1MzDUNbS0 MFdSyEvMTbVVcvEJ0HXLzAE6TEmhLDGnFCgUkFhcrKRvZ1OUX1qSqpCRX1xiq5RakJJTYFag V5yYW1yal66Xl1piZWhgYGQKVJiQnfH2zhLmgkNSFRe/3WBsYGyQ7GLk5JAQMJHo//eerYuR i0NIYAejxKwPn5m6GDk4eAUEJf7uEAapERYIlph1eQkriC0kIC9xdksDI0RcW+LUyovMIDab gKZE14Ut7CC2iICPxLnvh8BmMgucZZJYevQMM8QyXokZ7U9ZIGxpie3LtzJC2KISN1e/ZYex 3x+bDxUXkWi9dxaqV1Diwc/dUHEpiTNtS6DmFEusX3OdCcKukTj6ZD9U3Fyi4e1KNohffCUW 7fMBCbMIqEr0LLzIBlHiItH2aivYX8xAvyxb+JoZpJwZ6Jf1u/QhShQldv6eywhRwifx7msP K8wnO+Y9gdqqLPHx2wVGkFYJAUmJCbvMIcIeEjufroSGWqDEu98n2Scwys9ChO0sJHtnIexd wMi8ilEstaA4Nz212LDABB6dyfm5mxjBqVLLYgfj3Lcf9A4xMnEwHmKU4GBWEuFN/sSVKsSb klhZlVqUH19UmpNafIjRFOjjicxSosn5wGSdVxJvaGJpYGJmZGJhbGlspiTOe+xVb4qQQHpi SWp2ampBahFMHxMHp1QD0/znP1/pvtq786jtVh3RglTHS2bOp4275zCozDJckHd48krf/3+u xT/KDl/mdvpqxAZG888JiwQnHGLSkW/o29h1TOkos8gxptTHu44Jv/q3XF84ZJmTbMifJ5cv eNoGGvZJp+fMMrhx7/TeiZ3aN+cG872OT+TeZsU598GCbuk9l+aeZTqjurg0Y3HL5KKqZ2WR uz/W3VNkz5CaJFp+KNT/HKuUxMKlv+8ELzqoLOp0ccNxq5znC6W/FJxpDs/5oiV0+nhv3azp uqIrmS5P6g4pm35T2L5KOludaSrj/47G7bmbjuvFSsecff7vUvd/iYNJhz33MB45WLiwfmFu aILorkfrVB/fOjY1aafhwc1KLMUZiYZazEXFiQBwXZhTHgQAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230922061715epcms1p7cd5a37f4bba0abf4bc159b844bd8ee65 References: X-Rspamd-Queue-Id: E4E90C0008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: hxbui3ph4tma37kaxtikujsxae9nbcub X-HE-Tag: 1695364029-542680 X-HE-Meta: U2FsdGVkX1/T9hGIeOdwQpC1OyvSPK5iSvtqrR2VAoYJoYj4Iig5tdPQCJ/wOuxm5pGaBn2TE2FSV1SgYyfoHnRpwdY2L2luhqHEbjWG7jdDbiq+JyoddQO2OTTJ00D6cHAGmyWM2lHK7mqvYVcH7UAQieGBpNdVuUpRmiDOI7g3cqwZxwRG8SnIxT1EYqHBBkeOS2h2GsDNRzkTnAEGA3boUzsBxk5DvqqZTsBFout/RQMHJ3W0MMNJVU29e7FH06RDSZNuVgWcUYvZLODwvoMW7fyp5yDYh/cvU1diXhSgVCLDIABvGHAEi6yMNpfK4NX8fVpuXEOPgJw2a0VLm4lfLTCVo/MeaUbljH/3+t/7SC0te6lkbFQbu+G4m+7mhDdUtxwmrvy+UIj0gU+OoAL65FPoOh21pzM026J6wgmWelFa7US8jNAum8VWCb5+nDV1TVISksLuUPnxamaZPZgoI1OqgYJWlw+eq2GWesb0Tt4HV2mAAuFSfExT75hRt3d9a5lI5EVT+WkB+lyUesrpWq4r0GMcaSUakn6kXJGKzWK6w1aFSDT9EmYrq5ax8mny86N0D+M3oEZZcUP9aXxz7yVS+PU/hM/hKYee6UVp7uNmnk718UUo9juL6nBpmLWjHukl6ti1jK3DXl5m28223GgHOHzAizgfU000CsiH2B/yJWTVAqwl1ts1u2eIEIUeaoKbvZPrABwiIIwbnsQyJ6jkhdAxmDZtf+Fe8Kukbyuw4bK49iTcKjoREJa0e9s9lr4FqCNM8V7i7G9m1zFPvFnFTJ3uMR5UvZZ58dcVYchlAtw4GCmUtR5LaqRO+UvdljOeidkcEzahQEQQ7BEh5Pb9jbdK64Sf3VxrxGED+qDOrr4+D+gslihw+wOjYlmKC9QeJho4KY6dPsDyJi8mIvMallfK79yegQWF+B3gEl4J0rsOZbeD8zLrdYGL6OKbfNdy1d8t/0/NalY d2LRJPE3 Z1X5cng1cQgP6ridrtRZW3d7t1Xqb6e0iScmiwyKq4/963uwEbP1EJAjQIrQbSEERsECyH7g8tWeDppUbLGR+EIga2b1/1KgaCCpNT7zGo5UPg/yx9+k1+A7zf1KD9iN8RqZhLen+M3khCntdjimo0uLeOfE+61rIfWqLFggpD+S8hPzkwWK0BMfSqM2RuoSTxi7XI3i9nb0yyt3J/DWhMOBf4jVDQdEJazBjVX0ki0S2O/9PMeb0bxpzh8EFELhWk/UlXMKb3hJ3DLisPNjp3AcmBWIp5lpgSMNkIoIBBQQqHogw22CX+daOZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There's panic issue as follows when do alloc_vmap_area: Kernel panic - not syncing: kernel: panic_on_warn set ... page allocation failure: order:0, mode:0x800(GFP_NOWAIT) Call Trace: warn_alloc+0xf4/0x190 __alloc_pages_slowpath+0xe0c/0xffc __alloc_pages+0x250/0x2d0 new_slab+0x17c/0x4e0 ___slab_alloc+0x4e4/0x8a8 __slab_alloc+0x34/0x6c kmem_cache_alloc+0x20c/0x2f0 adjust_va_to_fit_type __alloc_vmap_area alloc_vmap_area+0x298/0x7fc __get_vm_area_node+0x10c/0x1b4 __vmalloc_node_range+0x19c/0x7c0 Commit 1b23ff80b399 (=22mm/vmalloc: invoke classify_va_fit_type() in adjust_va_to_fit_type()=22) moved classify_va_fit_type() into adjust_va_to_fit_type() and used WARN_ON_ONCE() to handle return value of adjust_va_to_fit_type(), just as classify_va_fit_type() was handled. There is another path in adjust_va_to_fit_type() which could return failure and will be handled in alloc_vmap_area(). Remove WARN_ON_ONCE() for this case. Fixes: 45c62fc2897d (=22mm/vmalloc: Remove WARN_ON_ONCE related to adjust_v= a_to_fit_type=22) Signed-off-by: Jaeseon Sim --- =C2=A0mm/vmalloc.c=20=7C=204=20++--=0D=0A=C2=A01=20file=20changed,=202=20in= sertions(+),=202=20deletions(-)=0D=0A=0D=0Adiff=20--git=20a/mm/vmalloc.c=20= b/mm/vmalloc.c=0D=0Aindex=20ef8599d394fd..4a82b6525d48=20100644=0D=0A---=20= a/mm/vmalloc.c=0D=0A+++=20b/mm/vmalloc.c=0D=0A=40=40=20-1522,7=20+1522,7=20= =40=40=20__alloc_vmap_area(struct=20rb_root=20*root,=20struct=20list_head= =20*head,=0D=0A=C2=A0=0D=0A=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0/*=20U= pdate=20the=20free=20vmap_area.=20*/=0D=0A=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0= =20=C2=A0ret=20=3D=20adjust_va_to_fit_type(root,=20head,=20va,=20nva_start_= addr,=20size);=0D=0A-=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20if=20(WARN_ON_ONCE= (ret))=0D=0A+=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20if=20(ret)=0D=0A=C2=A0=20= =C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0return= =20vend;=0D=0A=C2=A0=0D=0A=C2=A0=23if=20DEBUG_AUGMENT_LOWEST_MATCH_CHECK=0D= =0A=40=40=20-4143,7=20+4143,7=20=40=40=20struct=20vm_struct=20**pcpu_get_vm= _areas(const=20unsigned=20long=20*offsets,=0D=0A=C2=A0=20=C2=A0=20=C2=A0=20= =C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0ret=20=3D=20adjust_va_to= _fit_type(&free_vmap_area_root,=0D=0A=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20= =C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2= =A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0= =20=C2=A0=20=C2=A0&free_vmap_area_list,=0D=0A=C2=A0=20=C2=A0=20=C2=A0=20=C2= =A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0= =20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20= =C2=A0=20=C2=A0=20=C2=A0va,=20start,=20size);=0D=0A-=C2=A0=20=C2=A0=20=C2= =A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20if=20(WARN_ON_ONCE(unlik= ely(ret)))=0D=0A+=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2= =A0=20=C2=A0=20if=20(unlikely(ret))=0D=0A=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0= =20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20= =C2=A0/*=20It=20is=20a=20BUG(),=20but=20trigger=20recovery=20instead.=20*/= =0D=0A=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0= =20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0goto=20recovery;=0D=0A=C2=A0= =0D=0A--=C2=A0=0D=0A2.17.1