From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D406E7D0BB for ; Fri, 22 Sep 2023 02:27:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DA8E6B0275; Thu, 21 Sep 2023 22:27:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 263446B0279; Thu, 21 Sep 2023 22:27:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DCDB6B027B; Thu, 21 Sep 2023 22:27:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ED5426B0275 for ; Thu, 21 Sep 2023 22:27:57 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B8DDE1CA90E for ; Fri, 22 Sep 2023 02:27:57 +0000 (UTC) X-FDA: 81262648194.29.291D7C1 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by imf13.hostedemail.com (Postfix) with ESMTP id 7B39620020 for ; Fri, 22 Sep 2023 02:27:52 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=rbMkffvP; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf13.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695349673; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NGa5OGxo5RVDzGu+ZrGtp7FeoN4edCqHbGJ9tpz0C6E=; b=1aWR3APtWWnbl+Hdsuc4Fp8U5cMB2IQdAP+P83fdDa6VL0aD6LmZDa9GigvLDiIcINuZ2h RDcLdlOrd813/cSB8AiMYzetw7PzOQ4EZQ9tvjLtSX5dQ78UTrZt+VpsQYhsW/JYxNfwHz Az+AcAOlRxUDZtm6gh8qGbeg+VeEsUw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=rbMkffvP; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf13.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695349673; a=rsa-sha256; cv=none; b=RNBsZ8sPfWxz/MfcYjp4qUWuEFJa+VZSxmf8Esos+wTWPOgd1uHkVtqRyzv4BuQXzf18ks ljAVKhzVqram48S4/YKqkZxX5DA8jT/lxTOEg9XT/kIfq7DeYVMepXsfLYtSdNV691N9ho mke5SyaAvnFnCSZaMDdNYZp6O3uNjp0= Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230922022748epoutp01d4bea79f1fafd336c1b014f635e85b00~HF4px1gFP0147901479epoutp01I for ; Fri, 22 Sep 2023 02:27:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230922022748epoutp01d4bea79f1fafd336c1b014f635e85b00~HF4px1gFP0147901479epoutp01I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1695349668; bh=NGa5OGxo5RVDzGu+ZrGtp7FeoN4edCqHbGJ9tpz0C6E=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=rbMkffvPxsXPDTh/Ef59HCPi2V3lPDead2ni6yJIGZWOBcZ1itjogCtM1DFqQsujC 3rTZ7BctPh4wieJWzLaTq50XF2FShhAcczKyh/r1FxdiBoSH/Ezb1IwGc3B+9h1unm A8XyKL9jojSpkOrOyK5FkqzPklwpG1MhEXxQTtYE= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20230922022747epcas1p1f131fcb113246de442a91104a865cd5c~HF4pQuSbf2642126421epcas1p1b; Fri, 22 Sep 2023 02:27:47 +0000 (GMT) Received: from epsmgec1p1.samsung.com (unknown [182.195.38.240]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4RsGQC1JLyz4x9Q2; Fri, 22 Sep 2023 02:27:47 +0000 (GMT) X-AuditID: b6c32a36-0d9ff700000025af-1c-650cfba3db91 Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmgec1p1.samsung.com (Symantec Messaging Gateway) with SMTP id 93.D3.09647.3ABFC056; Fri, 22 Sep 2023 11:27:47 +0900 (KST) Mime-Version: 1.0 Subject: RE: [PATCH v2] vmscan: add trace events for lru_gen Reply-To: jaewon31.kim@samsung.com From: =?UTF-8?B?6rmA7J6s7JuQ?= To: Steven Rostedt , "T.J. Mercier" CC: =?UTF-8?B?6rmA7J6s7JuQ?= , "yuzhao@google.com" , "kaleshsingh@google.com" , "akpm@linux-foundation.org" , "vbabka@suse.cz" , "hannes@cmpxchg.org" , "linux-kernel@vger.kernel.org" , "linux-trace-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "jaewon31.kim@gmail.com" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <20230921122244.1cbf2d57@gandalf.local.home> X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20230922022746epcms1p323c50015241eb01311e7e10579fd4c6c@epcms1p3> Date: Fri, 22 Sep 2023 11:27:46 +0900 X-CMS-MailID: 20230922022746epcms1p323c50015241eb01311e7e10579fd4c6c Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMJsWRmVeSWpSXmKPExsWy7bCmnu7i3zypBu2N7BZz1q9hs1i9ydei e/NMRove96+YLJr2zWS3uLxrDpvFvTX/WS2OrD/LYrGv4wGTxbv1X9gsZjf2MVq8m/CF1YHH 4/Cb98weO2fdZfdo2XeL3WPBplKPTZ8msXucmPGbxaNvyypGjzMLjrB7fN4kF8AZlW2TkZqY klqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA3SxkkJZYk4pUCgg sbhYSd/Opii/tCRVISO/uMRWKbUgJafArECvODG3uDQvXS8vtcTK0MDAyBSoMCE7407fA7aC h9YVE1+9ZmtgnC/UxcjJISFgItG3fwlLFyMXh5DADkaJ6Q9nsHUxcnDwCghK/N0hDFIjLGAj Mft6ExOILSSgJHH2xxV2iLi1xP5FM8DibAKWEttvTmQEsUUEAiX6vqxjA5nJLDCBReLlwsOs EMt4JWa0P2WBsKUlti/fCtbACdQ8904vI0RcVOLm6rfsMPb7Y/Oh4iISrffOMkPYghIPfu5m hJnz5/hzNgi7WGJZ5wMmCLtGYsW5VVBxc4mGtyvBbF4BX4m2MwfAalgEVCX+/H8HdZuLxIz1 HWAzmQXkJba/ncMMCgdmAU2J9bv0IUoUJXb+ngtVwifx7msP3Fs75j2BWqsm0fLsK1RcRuLv v2dQtofE7Fe3mSDh/JtRovHnRfYJjAqzEEE9C8nmWQibFzAyr2IUSy0ozk1PLTYsMILHbnJ+ 7iZGcOrVMtvBOOntB71DjEwcjIcYJTiYlUR4kz9xpQrxpiRWVqUW5ccXleakFh9iNAX6eSKz lGhyPjD555XEG5pYGpiYGZlYGFsamymJ88553JsiJJCeWJKanZpakFoE08fEwSnVwMQisODT 9j/n/wpFJDm/5mz71+3qnef/PtXpuG0gV/qm921vH8fXbA59GP1OuOiJVcHchANeuv4PW1Uu /XFteqNjYCXy8VR/lPaXnxYWSbJ/Q702zRIrPtBttl77UMqz/jW3Wjd+vdd6q5b3dPvMDral 0V+ezTy2Y6N7Vaae2fL49PnLHp/e4FYRdWXSXUX+3qfvzvxn3hRmHPRk07JkG9UNkhkJa6qT Dv9dkqKaMaFk7/wkzmdbL/L/n/WZZ4tx8b5zL/Z8vLesQ6ZILvrE874UroXLP1m9511Yv1Xu 1VZeTffIACmhsl5p4bJHAQfjZX9rN+b85P8tWJV1bOqsHV+W5DR9VnxyOiA641lCspsSS3FG oqEWc1FxIgBP9sjGRgQAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230921061944epcas1p2f8a022282709da12840b33c0f5898b5f References: <20230921122244.1cbf2d57@gandalf.local.home> <20230921062206.14429-1-jaewon31.kim@samsung.com> X-Rspamd-Queue-Id: 7B39620020 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: darp3fmxwxghk5gmt58rkwiwqdtygxaw X-HE-Tag: 1695349672-477036 X-HE-Meta: U2FsdGVkX19QsOKIF95rysFX1XeXEmp1jKA/Pf9aqY5/wW1/u7qospXGWsCJnC+Z8cRBO149XB8evi1y3sqVD4SZHBF5Y+qEOcoceCtmMAKcnUvGe3mCdw7kM8U9UphaEL2PEhRP6PqLquOju4GOjnQifVE9nWws538wc+rX6/dUNiVHrnt58RugaOGZjghn2TRXkupItcGkdOgV77TkKoolPlnbDFEq8DOZ87tNTimxUXniEzf/jdB6ZrwVRjW419flfPxkBDg7Hv6TB/S3YQAx+uPEkaekQWQZ8atDA95EHXx6hcA7V79JaCjXOGb4vYx/b5ER8BiEF+MHQGFiJz0M0XqK91URk9hK8O01WiY8h3GuPXkUPrL/E4+sT45Ag1xvedobIH5KQKYPQU6zuZTxtBk5cFu04fNK+aakN+3M+SeYDZ+sK4vs5WdJtgQF5KIlnK8Qg0mhR7+nGqfxQJ6tI+/evr60AVk3IwDYD2YLlf2ID4EmamUvLZRy1nklzektCyKh0GgZEBMP6wZZNDYo+SbVb6V1O0V15v8vfV/lMwsA2rb3bJWgo8/dLHez8M46ynJjCqhSe0nHhd6V3dfxFVjODpOrPHa1Q87NEffKq7ZVtlS1WHwUcjC8NO7dyxu5xXFL+vBO2JgSzbdtU3gsJV5oSp1+CBLMuuhIq/VPh0h7nrS7e130tgJtpG1yy4SRqkC8Tia/vMIFAHTZarFlaHMv3QPeO0vubGMYFF68oLD2g3nY1Ld286O03iLprlDm6zreIgLZ0EBApAhr3lKEipIhaEKthoee3jZ1c9/t2vIz5qHKc7s6DmJH6WezQxH2vCYbPB0afod41ENIW94tHQi2Dx1iw076Mh2XLleSUusjSNF8sVOpHmeuz6OOD9ocbzMhb+mdxxFonIxe2X5kLs+C1wJTsDliIJN+UoDWp7V+I7jH/kAU3Er0p36ujNjhnrSt66ZQ/TkbFPg CoIfbvZs 3GHjXc0/FJa3ePiwijGc/v7ajO+l+JdFLUFBu4oj+NfcEPKsVNG6nhDtSWEg2gWxx37UtDoKaAZ0X7dtzhqr6xNfCh1bOR9hcCImQu23ixqi7iPM1aCj66quFg5nvixx3pvGhueS9oP2wLy7M/nTKda+K4Po4Uq7jTbDT82YLiCTBaRd5b/LFQTo3/5WFWl7spRnj0mfbpHv6UWVATC0LYACiZFjXPR513wYL4uAftfQ8NRZhDTWGnGugx9u4pcK52Ky5lgUfwc9o+CZn8ECUaJjvxDkcAcnxRkX8P4yfS34suRJRqo9+vyggTZl0o2SYA3kCeHD0Ar5/2OxK5//Q+RaHQmbUlwlwGIpNhhQsrL2TTLfpVn3oz3YHXpdDrndftDf4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >On Thu, 21 Sep 2023 09:12:30 -0700 >"T.J. Mercier" wrote: > >> > + TP_fast_assign( >> > + __entry->nid = nid; >> > + __entry->nr_reclaimed = nr_reclaimed; >> > + __entry->nr_dirty = stat->nr_dirty; >> > + __entry->nr_writeback = stat->nr_writeback; >> > + __entry->nr_congested = stat->nr_congested; >> > + __entry->nr_immediate = stat->nr_immediate; >> > + __entry->nr_activate0 = stat->nr_activate[0]; >> > + __entry->nr_activate1 = stat->nr_activate[1]; >> > + __entry->nr_ref_keep = stat->nr_ref_keep; >> > + __entry->nr_unmap_fail = stat->nr_unmap_fail; >> > + __entry->priority = priority; >> > + __entry->reclaim_flags = trace_reclaim_flags(file); >> > + ), >> > + >> > + TP_printk("nid=%d nr_reclaimed=%ld nr_dirty=%ld nr_writeback=%ld nr_congested=%ld nr_immediate=%ld nr_activate_anon=%d nr_activate_file=%d nr_ref_keep=%ld nr_unmap_fail=%ld priority=%d flags=%s", >> >> Many of these values are unsigned so I think many of these format >> specifiers should be %lu instead of %ld. Hello T.J. Thank you for your comment As you expected I got this from the legacy lru trace. I've changed as you recommended. Actually I changed isolate_mode, too. Please let me know if this is not actually needed. --- a/include/trace/events/vmscan.h +++ b/include/trace/events/vmscan.h @@ -367,7 +367,7 @@ TRACE_EVENT_CONDITION(mm_vmscan_lru_gen_scan, * classzone is previous name of the highest_zoneidx. * Reason not to change it is the ABI requirement of the tracepoint. */ - TP_printk("isolate_mode=%d classzone=%d order=%d nr_requested=%lu nr_scanned=%lu nr_skipped=%lu nr_taken=%lu lru=%s", + TP_printk("isolate_mode=%u classzone=%d order=%d nr_requested=%lu nr_scanned=%lu nr_skipped=%lu nr_taken=%lu lru=%s", __entry->isolate_mode, __entry->highest_zoneidx, __entry->order, @@ -525,7 +525,7 @@ TRACE_EVENT(mm_vmscan_lru_gen_evict, __entry->reclaim_flags = trace_reclaim_flags(file); ), - TP_printk("nid=%d nr_reclaimed=%ld nr_dirty=%ld nr_writeback=%ld nr_congested=%ld nr_immediate=%ld nr_activate_anon=%d nr_activate_file=%d nr_ref_keep=%ld nr_unmap_fail=%ld priority=%d flags=%s", + TP_printk("nid=%d nr_reclaimed=%lu nr_dirty=%lu nr_writeback=%lu nr_congested=%lu nr_immediate=%lu nr_activate_anon=%u nr_activate_file=%u nr_ref_keep=%lu nr_unmap_fail=%lu priority=%d flags=%s", __entry->nid, __entry->nr_reclaimed, __entry->nr_dirty, __entry->nr_writeback, __entry->nr_congested, __entry->nr_immediate, > >Other than this, from the tracing POV: > >Reviewed-by: Steven Rostedt (Google) Hello Steven I've appreciated your Reviewed-by, let me take this on my next v3 patch. > >-- Steve