From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF34FE7D0B8 for ; Thu, 21 Sep 2023 22:54:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72C9E6B0274; Thu, 21 Sep 2023 18:54:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DCC16B0275; Thu, 21 Sep 2023 18:54:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 555BF6B0276; Thu, 21 Sep 2023 18:54:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 45D4B6B0274 for ; Thu, 21 Sep 2023 18:54:55 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 16A688073E for ; Thu, 21 Sep 2023 22:54:55 +0000 (UTC) X-FDA: 81262111350.12.70D660C Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf12.hostedemail.com (Postfix) with ESMTP id 5B81540014 for ; Thu, 21 Sep 2023 22:54:51 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=cjwgm2HT; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="LzUoe/vK"; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf12.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695336891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Akz8/uxZyJgxJDaMlio67BAurWK63nDDi0ad12BvSIU=; b=DeqvlR8xKaqY9FTaffn5swZqQAqn9Kv0eLrFocsxQjpx9UQp6k+tfFn9fImQArSNrH0Iqi IQLiLCmqQaLs7GzqGzeVDO3blPn+fZBBZKomp+7HrcqgEDZSE8TTZ3AxQS1CwR57w94/pp LVdceERE7omDJYT1dF1fOtGd/BF6hiE= ARC-Authentication-Results: i=2; imf12.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=cjwgm2HT; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="LzUoe/vK"; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf12.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1695336891; a=rsa-sha256; cv=pass; b=m1bVCS5PzkM2gLhTu0cy7muHLWnvzO2+8qT5JTRUT2WKgb5IfOgMqYHEj/e0fNGlwT5hzh Yg/tC4zMthEvLkf2bZJC81v46d7Ra0ImDXfIpt0IJPjfYsFsUL0QxQIBFEP/1G1a343OjU eBNc9SrOzxQt9zRqD+mS0JaohwM3PxI= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38LIsMPN011445; Thu, 21 Sep 2023 22:54:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2023-03-30; bh=Akz8/uxZyJgxJDaMlio67BAurWK63nDDi0ad12BvSIU=; b=cjwgm2HThHnDzpnVATcyLi3tZjM4G0WJsGIByE8MGwvwIcz8VSkBRvkuPOBCBZ8xHkOI NVe15b51g0JRttZAgONQLvH7sI1fOD7GxJdLvSKkTIbKEFLOW9zF1/7SgfA5bVMAU2ma xcK6dQ6A/bNh0KH/L6Zv67P2SLVAEDa1DLFcXWEMgWPH6agfaR5y/UdWZ1KXJ9oX3UK7 ulW8G6CIMud+UYWrrAZ0MZEfan3TRVKdVYrAL3ED2FZQoEaMHtPaVzBogVdyX0WpftOG i8wZPywtzTK7E1BPefp2B0u5x60RXx98LD50sqftqII6AqKUGWhN/pmFduBL9a23zkUV Qw== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3t8tsvrfma-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Sep 2023 22:54:50 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 38LKGR08001085; Thu, 21 Sep 2023 22:54:49 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2045.outbound.protection.outlook.com [104.47.51.45]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3t8u2n0pqm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Sep 2023 22:54:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mv4ZwPrpmVOkdyCxodlcZvGcFdvW+fWk5QXYhYoOBQFCUrZc/dXd7iDnjxnCBihhtO9Qjx5GIwo6EV7Yjj2zcNyv7qgogRwz4fp4N+R1zkvisa76j/Nv+/bvXhuN1iwb/O0X1IZ52DCoKoeFmjmgDt39Y4lUgnOysUb5cigHLXwlJmuGq3/bBMji2T+pnXB08f7rd99QAkj4FY/V3fzsc7FJf0QocV/FDDUBTITkffT9s8MF6tACZZgbgHIDH0meNr2HvmevFPB7aZe6tKaDS6Dq6FrswmTtz2g2d+dtxymOfkduCpZ0X5YnB7Sjmctcq7BZcwBSdB9v31Ap6CEGRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Akz8/uxZyJgxJDaMlio67BAurWK63nDDi0ad12BvSIU=; b=OUBhbpT+tife3SAg0+c8Hq7gEccV2N6znpqqSfMWIP53RuBRpjY8synXMHnzUZQ0PbefBS6TV/XrZ7tWOqdRXdqbXnYsSuVxf4NZ3+GLgOGgM7ZcfeyEruBSr2tcdZnU8tRhvRlpYbexZQsIyZ5aOp+NsycklJqZUbKh/XQaO9YmN3hTTb+CpH/Eqil8wqIE8MFYVXdDZz6IMq4CFiUDW3MiFkUqG2s/5R9+tpj4fycIAw/qY6AVCPgGixXKuQ59ASSnOzi+6UxW9SQ81NchTcsJ2oMlH1hKnoPRNqszYVrZlwgdSR/EM8n/xPP+FhHVgG6/zdrFAci0ujqnfFhcnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Akz8/uxZyJgxJDaMlio67BAurWK63nDDi0ad12BvSIU=; b=LzUoe/vKBzYxks9Gly/cQuGlYpazV2/Mt3R8mcreCUdmAZq7uf6gqBwb+XYnsKz2RZpWAYg6PFBtpYQxEJ6jigIlw6EKQo5IS1PTq5XORrALSF1TjQ/NE0vvUC9Knxlcz1z9Uo0uwOXRBA5L1mDXyLU7BgdZ/4DPLuxuccrzNZI= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by SA2PR10MB4506.namprd10.prod.outlook.com (2603:10b6:806:111::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Thu, 21 Sep 2023 22:54:46 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::c621:12ca:ba40:9054]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::c621:12ca:ba40:9054%5]) with mapi id 15.20.6792.026; Thu, 21 Sep 2023 22:54:46 +0000 Date: Thu, 21 Sep 2023 15:54:43 -0700 From: Mike Kravetz To: riel@surriel.com Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, muchun.song@linux.dev, leit@meta.com Subject: Re: [PATCH 0/2] hugetlbfs: close race between MADV_DONTNEED and page fault Message-ID: <20230921225443.GC21193@monkey> References: <20230920021811.3095089-1-riel@surriel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920021811.3095089-1-riel@surriel.com> X-ClientProxiedBy: MW4PR04CA0081.namprd04.prod.outlook.com (2603:10b6:303:6b::26) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB4196:EE_|SA2PR10MB4506:EE_ X-MS-Office365-Filtering-Correlation-Id: 2762671d-a94f-4e9a-50ca-08dbbaf5c0b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /UQwY9BtPAjx0TcTq0uYekxW5vcMPOIASO7X1AgC5dtLuJUr46vbXUm6lGqd4BeKs9/xKdxF1TocxLqy2unas+UgG+DwG34MYLYx6yCLhVOrugEydPV9+e/fbOrFSa1u3qU9qlUpu2f8kxBbavgnOBzYmOOzNVj5PGn2OtdpA1daCBYKTkBp/3NekmDI/RCtMp7ucD/8jUg6jeIcqbSvEJSbQAfEegVodGFld+OurhWTcP+4wJFxWTJ8pd4PJimCmZPG44DKeE6thzmN8kNLIfpXbF6hDjC2BEHEK0vNMkf301Xyu8mjEwIwGnLiphuz+5TQFQfsK3gWN4GWnRDZSWVHH68UbwIctAXoLdqgPnrhET4JMNvT2h3eqioRZmAGojcJvFjIGK9qv1elADJ4EW66RO/ogALocSMOK3XZ67i5tTLcafvQz4gANRIzaGKiR2rmcZAid1GlR85265haa2Npe5KhU2SzgVGqOsTrRKBjBA6YlBL92PugMpaK2TSqHmbssaFpda8SxEijoOBnFkPZTzqlkLFt4WXdxBS9kiIuqlzlMLGGzZKiH2aakEqK X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(39860400002)(396003)(376002)(136003)(366004)(346002)(1800799009)(186009)(451199024)(83380400001)(6666004)(478600001)(44832011)(86362001)(1076003)(2906002)(9686003)(6512007)(26005)(53546011)(6486002)(316002)(6506007)(66476007)(33656002)(66556008)(6916009)(41300700001)(4326008)(8936002)(66946007)(5660300002)(38100700002)(33716001)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?u6vgYfw3Y+BiapElvZrY4k18myW7FciFeq6lK6eFDeWEnmwo/9LKjDHK/nRC?= =?us-ascii?Q?Ie7K8FdU22QsH1T3js/kOgRpCgUkx+kkTro5GE+Y5rhUlvIASOdHXmqFyNEh?= =?us-ascii?Q?WgJ9uDhKNUIh2Cw59gnGBEscrBNaTf8Y/+9kfKEjRQ9Au33R9JNMu8dfJ8j/?= =?us-ascii?Q?7dLRpER3rf1AVQaOZRfYOI8Kgurdcl67nxc18Ho4jop8fsBZtZTouYl/QSm/?= =?us-ascii?Q?leXenoTSkLhidm7En2Fhbd3hbnvpTE5iZbbF2lrQyT7+0R+Z9eDzcDV5ysu1?= =?us-ascii?Q?1ZjSW2I+SJdMJQuWyTwBpVh8kU3/HIPy+YXpdZwD4jtS9+Ct6HJAkBI9miF4?= =?us-ascii?Q?OsYGwB5igpbyrImaLYP4lwxPk7zY9Qx1YnUeprO1laOTURKZ9uVxQYjtizvI?= =?us-ascii?Q?HaQCSq7bZ2t6lpaDhrBM/lmuQiFEqhPJeXawuZZe4Ngffd9l7n6wOVbXMOfz?= =?us-ascii?Q?WJsH9UPetgwUcEi6djL/xA7NrCB+FVim/974JY0sBnWrZn2AWWE2/YiBBLma?= =?us-ascii?Q?VRv1ghFYBx03R+YAYyl9m+BF7oTx0Lvh5dyiPVqlUyBrzV3L9/7nNnYYyQJN?= =?us-ascii?Q?4yuIhY4Iugwm29ZkTdplX/dRrBQqyJCCv8QzM0yDb+VqYFfOJFzCkI80E4HF?= =?us-ascii?Q?ZuKZSiFFWFVwBVAckvlsJj88DvcoqlTmVV4ILjOAx/wnawxLTuXvyv78Op0D?= =?us-ascii?Q?fhp+g+UqqblMA9NU83RxY7g2ujTHH7l15ADIBIPjiYG4yIF0fKBjV16YLULN?= =?us-ascii?Q?4Nzw3HC1Rtqw6uI2dCJp2Es3RgIUFM02fiakVSI1EKr/nZnQFji2sfKMS0SH?= =?us-ascii?Q?rmNl68+LJ8NpIrkgBK+NqQVFw1Aw2T7pGHOMZCqxlEcEZn5qMMURXyY+3o0p?= =?us-ascii?Q?PyKSp0qs6sRSlYIZapLkb6aqBXskFKLIPTToLMzi6I+n+5hwWHaZZSgSWONu?= =?us-ascii?Q?Rqf6/FPy9vib8VQjhVtjS7mwyo+qmlfZ53B/S94OzjWgXPMa2jDt8IvYWPjf?= =?us-ascii?Q?NjpEIwbFBOgNAyztG21s68IDBTzCpUqi20Pv7wAm0g6tEk38PogzFK6vzA4g?= =?us-ascii?Q?YKlGfSJQ744gv1j/8MbEUGINX407LcfYVGLh1rSRKB/Q8+/dbBsoniSaKiS+?= =?us-ascii?Q?S10u+9lOLoG0+vMghLt4813OPhZ4w0IQP9tBuAVkFGByen2jNeaGBny82Vrh?= =?us-ascii?Q?EBvibDwvk+MSBzzUaZXX3RHMPaiiNYXNwJRfJm+RgVQIQsR0sZcYhEdVULa5?= =?us-ascii?Q?jG17r39DsdBzCW1eTxK5rr6FkPT+hhE4KZ+AsydrORQ0fLsCy4UpjS/rOQ3S?= =?us-ascii?Q?0yZZxrsGxCmYVm4YIu33Jw4dE7wkP59dwjnVHCvHvudQReinZ1h+6O/rtt4K?= =?us-ascii?Q?ytOMPOCbBNXvkIcgOvS5ZRrr0x+BfE2iXxnkT9l9fZ8GFib67ZDBAg8ztuIa?= =?us-ascii?Q?cT+9JKzsht8rxmRZ/cC6NEKf7UUWB4YmAxYK7N1fZahEqbowbFupk37Ascoz?= =?us-ascii?Q?WBGqy0uQpD4LNMFy5qLmaAcdA1Uua9Jb8imAHHgLtbd/oVKw0L6FMSZ+qbCz?= =?us-ascii?Q?8YyClKOaxD0sajDSQvaoJaHKP1ukdkjE7dgY/ogcRazGbtfwLLfsg7ANnXQo?= =?us-ascii?Q?Og=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1svX8YJAZNSGDdh7PvUs0bcFYr92bCc2UqXhzBU6PSXqhaTx96d/UQjaZWsW5mF9Ll+rUpsO1g0WRvAEIB6sT7MnB9A0S7lJoHEN9Cc5w1T7tKb1ClzJfBM87kBj/6v2/UFodJNPjiiXtn9fybud7pUagRB71FAx2+KTSG7q4LULRf6R6vz7q04kUaPYeRuDyrX9LkygX50barTZcu+E1GB/G+Twc6FULMR8Mziv9/IffVMxYL+1vLaWAwXIStZP7jwg19DlEjwk7V/wmfLe2ZfwuqeKGt7u0GvX9kc+QEW5uFllmh/thfLlMObeha9zrJCqkFMY9DWt1KKnRuytMnHiWnp4Qts6/R0eYA2KiF1QODJE4OeuWvk+pVFN7aboKoWxIynVghavRfdtPzT6kDZgajG8J0LRxrCZ+5ich/y4ASPoDIHmBtr6qPMO81nCCDTX3mVBDg7AD4cvK4mVTUOL5B8alcDff8FGPyg0gNZu9CsFJe2E5H2sbwKQDAFknpEvOuf9enkewyxJjA+KsTBKeU9m3KNXyAAVCjyGysrAxoqFO1BD9zm5fhF+Q4gbjMoc4jJaveKjYWFYdcFWoqPPj1UrVZp/b2alXpZQsF6LFvyGczYghkgOMBBboRF42INs8sJML7Qg6bu7TKiQRmIE6VnNnfJ5tKp8bdgq53yVFSv/QDj3gCA9c+Xmsx/I5yK246FIFsdg1mJQ/fqzUPV7gK09drZfCvJOG/3X6/hirnG1GpU59N1uE1CrNt8XrNuKr0HktG+6dWJWbasFufCbmN1BhvgX9jaiYeUhGniUgGrFsLsF/H3qQ1GG7eb2ZBm3eEMP1PO1nvE9VApj15oCiTHW0KxIFRW0m05Fq0cW/9v8yovCe2dh/irlq8tKgaS76RTb1vgb1hFTbLtnpa0TiYn5OD636XRORdeACE4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2762671d-a94f-4e9a-50ca-08dbbaf5c0b0 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 22:54:46.7508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RQDPommWgONLfCCln5+RtAOKVAH5bKfnK9G2RH8hRaa8emgHqZ+kg2Y1RuBJVbe6pAyjG6PIObj7tA0LsCTJvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4506 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-21_19,2023-09-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 mlxlogscore=633 phishscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309210199 X-Proofpoint-GUID: T4lF5wFqcz9aGWTtGD8kFK70CzSL1Hq2 X-Proofpoint-ORIG-GUID: T4lF5wFqcz9aGWTtGD8kFK70CzSL1Hq2 X-Rspamd-Queue-Id: 5B81540014 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: dmx4ty1cdzrt9jubi1m89kzhgge7tx5u X-HE-Tag: 1695336891-86791 X-HE-Meta: U2FsdGVkX1+vOlRo3r4bonLkPvImikUyprVZcwBTzc/0SyibELwyhrrHa5tBrSMA9go7fSxj890wQrCm5N/g02kdQ77rfRCoKq0VYTderMDuyytUgO+Up969rstn7l26wjBcINfCYDA7ylT/ij1QaPVUUF8524Z0Ue08US7auExrNjyEWzMY5AV1KEEffXy4fytG3D3h36wksiGMu65o9mpWTl2WvKS5jhzlKzsNhJoVOo4kke1Mj8NGkRy1vwLrDxw+7g6pdbPCN773i96sDKJz9MxVRnD3sqOb9jMx7EGz0phiL3Vpjf0fn+Ci9TA0T3SFPwtGNBj4kIfrVEd9iLNBhBQTHb/eEgQzu06q1ZUidPFf0XwLLvu4/yzLdhpbNMQw5YDViMuD0WD+gpSKrb2PuACuZhQGugtPmKRieG6ceS9Kxb1yWQMOn/1xYZwal+Y3uWyiSWYEnVJP3BE58BeOCQ3Br4by3WlVE5yOBUFgPn23ojRQK1gBT01m8jcM6ZNcvjAxKpaqmo/ScJwUvAG0/4mJW2n1rT/IxNVmvJr6rfC9hs4qlkSZkWVCDSaOc7RVh3AxbAqcIi6tOczfMZYXH4Bvz+yIJkD7I/VzE8vCXNGVNfYmJG5aGa/ME05SK7EddTlObl0OA0rUbvDUXwY1zV4phnM6EEMtnRczopvRNmvzR1pK5PQKoO+BZarcJ6wSjUhv34U3GNpALQvkIAvIXUL/QFU3V0q+/PSY0fzJI2oOhe6oO7kZrJ9YHGVOTIOWqAy3NG0i9jAM6dOS8z3xofoydDkTbP9MqckL6AeVEdi5XH1XKWOOkRQwHCTsnJX9mbF0gCPwUf4zY28sN+sdiCJMiCwWov61lRBxZs3QbK1XScfCD40ay7OHHgLajpyLOfcWgo0pANktoK4cbAJRyZP0+iizFzkdyQZDxxDsVstycCYIMQyPitR8vlcRtLsFMtjBzjrfbKsZeVX U/kJ1wed 7FRB2KJzTFvjsSWwHtTJGPmcouUmYDBLVvy/7GN+0VOYLTRzu6K4dzUpGjrLk5nRs4Iyl6KAhtaM/zBsig5XddgyO3ykg/6fKv/v+zW1t2dU5hwL9FsR1/VXvf7NT3E5q82DlXYsTiOiB7FSbN1teNj8Wthxv5/mgZiMMH4HTZdc0kRCaaVwyMY55cpfJYKphRNs/yMfLAIrhwSLjJV54Qo+EFTiq2e1TmxHiQ3UfM8YZCTPdQEgZ4Q4JmVX/Q2/E6SxN9shoehgh5fdSKsCn7Om9Jeq/kHUY6ve6DS6FE6lbK7gYEbmh7eKl4KcL12DmBYlTjQoQIJcpSTPiQjetgRInDGK4vyFwiD9HQOCh1VKxTBhTWN5+l+C61TsDl+9SMw0RfaKzY7dxL55MjEfKEPcd9UWzmKR7aoBaME0zzEZso2xNUaPmcWJL2DVljo4gI+j/cZ5zwqq189TornbNb95D57yyJIMorfXZNeSTAXR6wG0c1Pn+AjCLrHVi9RMBwSM0v0gPmsAYzdsJKdH39vGsR5odiCb5Msa6Ff0vIxImsedv/oRkPpvS4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09/19/23 22:16, riel@surriel.com wrote: > Malloc libraries, like jemalloc and tcalloc, take decisions on when > to call madvise independently from the code in the main application. > > This sometimes results in the application page faulting on an address, > right after the malloc library has shot down the backing memory with > MADV_DONTNEED. > > Usually this is harmless, because we always have some 4kB pages > sitting around to satisfy a page fault. However, with hugetlbfs > systems often allocate only the exact number of huge pages that > the application wants. > > Due to TLB batching, hugetlbfs MADV_DONTNEED will free pages outside of > any lock taken on the page fault path, which can open up the following > race condition: > > CPU 1 CPU 2 > > MADV_DONTNEED > unmap page > shoot down TLB entry > page fault > fail to allocate a huge page > killed with SIGBUS > free page Hi Rik, I think we discussed this before. Even with your changes there is no guarantee that the free'ed hugetlb page can not be stolen by another application. This is true even with hugetlb reservations as the reservation is consumed by the first fault. After the MADV_DONTNEED no reservation will exist, which allows another application to steal the page. This is VERY unlikely to actually happen. However, I do want to point out that it is possible. Of course, the way the code is today you will always fail if there is only one hugetlb page in the above scenario. So, your changes will help tremendously and I support them moving forward. I suspect you are already aware of this, but just want to make sure you are aware there are no guarantees here. -- Mike Kravetz > > Fix that race by extending the hugetlb_vma_lock locking scheme to also > cover private hugetlb mappings (with resv_map), and pulling the locking > from __unmap_hugepage_final_range into helper functions called from > zap_page_range_single. This ensures page faults stay locked out of > the MADV_DONTNEED VMA until the huge pages have actually been freed.