From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27A75CD495A for ; Thu, 21 Sep 2023 06:09:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E0D66B01FA; Thu, 21 Sep 2023 02:09:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96A5B6B01FB; Thu, 21 Sep 2023 02:09:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E47F6B01FC; Thu, 21 Sep 2023 02:09:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6BF1E6B01FA for ; Thu, 21 Sep 2023 02:09:24 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 35E14B37E3 for ; Thu, 21 Sep 2023 06:09:24 +0000 (UTC) X-FDA: 81259577448.03.B8E474F Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by imf13.hostedemail.com (Postfix) with ESMTP id A73EA2000B for ; Thu, 21 Sep 2023 06:09:20 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=onAix5jU; spf=pass (imf13.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695276561; a=rsa-sha256; cv=none; b=v+II37D54Aze8uVr1704NfwKpnCz3u+ozW89iLjaXDJhy+zPLxkyaWw4fyOvwBztw2+T7H b27V5uIxJ1rZb13IWsm7pB8Vu0OBE8Ar6f3HpR3H9dvGT3akwQFZbXu1gkwEh10DnMLMWG /3fK0xmPBavYlfY1YYyPgqQK9I0OwwE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=onAix5jU; spf=pass (imf13.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695276561; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I8UM2dlWqwJKF2IV08T8CuxTIF9GZtJKl3Qqt09nY/I=; b=J6U2PhlOACyPGu0prLG4nGx90AMFc5hU/eftp3Dua9CFJhlBxxdU3oVyKuHfC0X7ixkcEN AlAwL0bdQp4UBSpdcISfGOn5t+7pxN8qthZn6HZ3G1q9sQfe2roZTxhoNL5lAkqPRGPdy1 q6veg1827lLWjkrxrV3icjZifgUsHOs= Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230921060916epoutp0126d3192b3f3bb4f13e3a027759854afa~G1QvWvV8h0882908829epoutp01u for ; Thu, 21 Sep 2023 06:09:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230921060916epoutp0126d3192b3f3bb4f13e3a027759854afa~G1QvWvV8h0882908829epoutp01u DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1695276556; bh=I8UM2dlWqwJKF2IV08T8CuxTIF9GZtJKl3Qqt09nY/I=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=onAix5jUPMdb8CfFj2m6Y6Mjm/5GQtxT4N+q71xojyq00znsl4cFJEEK6RabXncT5 zI46GIk9qPvGbXLUOSnebF+oVW6IMv4uhvGlGzJ+g+SbH5o+VIjHZWuBWGlHmLkMTT bVPExzsXaNlUqCIYrYRr2NWwZW8vhyImmArO9hrI= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20230921060916epcas1p2d7a0acf2f0d470e9710f1913d8bf209f~G1Qu23-xt3228832288epcas1p2Q; Thu, 21 Sep 2023 06:09:16 +0000 (GMT) Received: from epsmgec1p1-new.samsung.com (unknown [182.195.36.227]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4RrlNC51KRz4x9Px; Thu, 21 Sep 2023 06:09:15 +0000 (GMT) X-AuditID: b6c32a4c-d19fe70000004a18-20-650bde0be748 Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmgec1p1-new.samsung.com (Symantec Messaging Gateway) with SMTP id 27.92.18968.B0EDB056; Thu, 21 Sep 2023 15:09:15 +0900 (KST) Mime-Version: 1.0 Subject: RE: (2) [PATCH] vmscan: add trace events for lru_gen Reply-To: jaewon31.kim@samsung.com From: =?UTF-8?B?6rmA7J6s7JuQ?= To: Steven Rostedt , =?UTF-8?B?6rmA7J6s7JuQ?= CC: "yuzhao@google.com" , "tjmercier@google.com" , "kaleshsingh@google.com" , "akpm@linux-foundation.org" , "vbabka@suse.cz" , "hannes@cmpxchg.org" , "linux-kernel@vger.kernel.org" , "linux-trace-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "jaewon31.kim@gmail.com" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <20230920103233.145ac387@gandalf.local.home> X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20230921060915epcms1p6a03b613816b2a99d75ddfd1e8c4a44f7@epcms1p6> Date: Thu, 21 Sep 2023 15:09:15 +0900 X-CMS-MailID: 20230921060915epcms1p6a03b613816b2a99d75ddfd1e8c4a44f7 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGJsWRmVeSWpSXmKPExsWy7bCmgS73Pe5Ug5Y2dYs569ewWaze5GvR vXkmo0Xv+1dMFk37ZrJbXN41h83i3pr/rBZH1p9lsdjX8YDJ4t36L2wWsxv7GC3eTfjC6sDj cfjNe2aPnbPusnu07LvF7rFgU6nHpk+T2D1OzPjN4tG3ZRWjx5kFR9g9Pm+SC+CMyrbJSE1M SS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMAbpYSaEsMacUKBSQ WFyspG9nU5RfWpKqkJFfXGKrlFqQklNgVqBXnJhbXJqXrpeXWmJlaGBgZApUmJCdsfXDI5aC T1IVPUemsTUw7hLuYuTkkBAwkdi4exlrFyMXh5DAHkaJ6ZebmLoYOTh4BQQl/u4AqxEWsJV4 c2wiO4gtJKAkcfbHFXaIuLXE/kUzmEBsNgFLie03JzKC2CIC8RJft7exg8xkFuhikdgzazk7 xDJeiRntT1kgbGmJ7cu3gjVwAjWfP/eQFSIuKnFz9Vt2GPv9sfmMELaIROu9s8wQtqDEg5+7 GWHm/Dn+nA3CLpZY1vmACcKukVhxbhVU3Fyi4e1KMJtXwFeidcpusDksAqoS8/b+gqp3kfgx 4RuYzSwgL7H97RxmUDgwC2hKrN+lD1GiKLHz91xGiBI+iXdfe1hh3tox7wnUGDWJlmdfoeIy En//PWMFGSMh4CGxbQMjJJiXMUncurSefQKjwixESM9CsngWwuIFjMyrGKVSC4pz01OTDQsM dfNSy+ERnJyfu4kRnIC1fHYwfl//V+8QIxMH4yFGCQ5mJRHe5E9cqUK8KYmVValF+fFFpTmp xYcYTYHensgsJZqcD8wBeSXxhiaWBiZmRiYWxpbGZkrivDGf2lOEBNITS1KzU1MLUotg+pg4 OKUamIqMJ3Xf41zv+UPWn3v+P+tDNdN9rsv9ObqDx9ivo+CldJvVF9bJLw/ZO1x8IGn2wvj9 zWPbDx/aZln87NzavkjPeqNzs2sEs6f92S7IPmmpKb/Z54fml/cs2Png6tOr+2843vt+WqBw 54zUFSGZXclX+r4GTrPf63tAdY2/2VHeuKlxz/PVVpQtnzfdp17C/8Hi39qK/KsU/y8LOO43 +dJ2qdSwOzc/69zUkk1qYf65anHJpY7nNcan0qW10zY9mdsy6b/K3Pr/xuoC6456PSrsnMiR u/3vz+1hDMU3c1u6hDO/vElv23meWTMusDF5fVK4U5IG+2srltvW7fV5fpmHp6TsiRBz8vr+ SmH7g+VKLMUZiYZazEXFiQCIJqZ6SQQAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230919025012epcas1p2c2c57a34eea3299ef3bb643f4cbddf0b References: <20230920103233.145ac387@gandalf.local.home> <20230919095927.5a964094@gandalf.local.home> <20230919025216.1878-1-jaewon31.kim@samsung.com> <20230920074948epcms1p82d18c2f4d6a0b5699d50fc419b9ba9fe@epcms1p8> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A73EA2000B X-Stat-Signature: edhgg4gacc3d71czuqor9o8jx36h64fk X-Rspam-User: X-HE-Tag: 1695276560-315799 X-HE-Meta: U2FsdGVkX1/YhfgKVr8frHlAAgb9ylngv7v5xcTx+oGub2o5f+jbQmqDx9dLRlGv60qLy3Mui+j0lDjvtvBGbcmxPICWRipcKv5Yh7ZA11Qxr8vpPite4DCwxoE8cDEvSBRFhpTgcFU+ZfOdAEBct0l5p7J7bgVaAw6qJ2NkXdODZyqJUGMUuGf+WJRCJ8pIOk/n0MkzvNeU6B+9HByomufq+6719Je3/jwkg4NVmz0CA+JhHe27+m4IHHkRh+VcJzLO9WXmy60d+0Xz48xEeeM/WvUQDwmXfg2x8GdhgvYypHmmHhWe9th6o5DQovYEXub7DqVXjoVA48bZDagpOFK1oHzV63pVdY1suIFMG8DT6SJhjV6K6nlLpWH4NjnqZqchR370mdegZecuVTZnCXLJUcUZ3zkZZwe+eBgCak4xy9U0uZfUP21QXsRSkSAyuA+xm/MzJ+0HM8hJzB0cRNyIYZT4FbMxJeXuIynDWDinlLJlIJSSS3qdIiytnyDjhmVDigGMXrSlSmnGT0sf2/gijieTQuPPHQBGWQs9M7Sfeg4aalQQp8RHrS2q2uUTrQDFk6phIrQwmUr1l2FMPwFfK5MVAooVONsQooXXdDLgqF9QF9lei5YSDqHpQPZgEosBjbbE6+Grt+5mHYnaV51SXoTe8IAmAzIjMDXKNko4mkHdRIPGFiCuVCjMAR/+1Vpowt+88TMlCJ1U8ihRcPsgCgsUYzlriXJ1UzUpTpk9LhzLFfx2PidPoT1mOUFy/5Tzdsi7cKLw4k+fCaXKSzTzJpojHNdTNfOvW07gi4VxLrEF3ytcsgrrlhZGZQldxQ6jTe4nLZ//kDM0RaOXeC1F3RU+17fEbV9G5es0GGbKOaYTtyHF9CPLgs1lbgcD5ERN8BcJAL2101n7MbeLZsub8NtWP9S3tOkEKmXyS7wV3+r/rkHaA6JlfinicjoHWa6REvnRgR9lMMIaGs8 JKm16+MC /lN8dS17b9Lt8qVSr033pPHNgIbuVloUBmKi6nkuJy4ytlG6lGSQgbceH4MDYESEmI982pu8hlOGho+niS7K0iFGJCfr6te8pS4IDelqmuabl2TXuIP3TDxMY4j7HDv8OC6V7KQsCNm+M2j8EtOIlzmv8J0DHcPn/W8yv+4hzHSxMIv4zNWdH+9FeKrtVLT9OTK7+FnFn3S47hab+cYJf03LP7IDsEcjQQ2VXX8elSdz+ew53sgH1gYZYgpmyk68kCVXEp4JKy1VJYcr5f+GMWLtt6zCH+zsH5/zsK81gL3CpC8WUyaYlf5wZ6kaJvheb3YqbeL5PNaPQ0/u63nDIF9fAaBp60XjrTIYhr98zegtHIF1voAtQUWET6fC9MCCiQ4gT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> Great. Thank you for your comment. >> >> For the putting the struct scan_control *sc inside the trace, >> I couldn't do that because struct scan_control is defined in mm/vmscan.c. >> I think I should not move it to a seperate header file. > >Well if you ever decide to do so, one thing to do is to move the >trace/events/vmscan.h into mm/ as trace_vmscan.h so that it would have >access to local header files. Then all you need to do is to move the >struct scan_control into a local mm/X.h header file. > >> >> As you may expect, I just made this by copying the existing >> trace_mm_vmscan_lru_isolate and trace_mm_vmscan_lru_shrink_inactive >> >> I've tried to change like this. >> Would this be good for you? > >The below looks fine to me. Thanks. > >-- Steve Thank you for your comment. But I still don't know if I can move the strut scan_control into a new separate header file, mm/X.h. I guess it was meant to be located in vmscan.c only. Let me just send v2 patch with only this change, and wait for other mm guys comments regarding the moving the struct scan_control thing. Thank you very much. > >> >> >> --- a/include/trace/events/vmscan.h >> +++ b/include/trace/events/vmscan.h >> @@ -327,7 +327,7 @@ TRACE_EVENT(mm_vmscan_lru_isolate, >> __print_symbolic(__entry->lru, LRU_NAMES)) >> ); >> >> -TRACE_EVENT(mm_vmscan_lru_gen_scan, >> +TRACE_EVENT_CONDITION(mm_vmscan_lru_gen_scan, >> TP_PROTO(int highest_zoneidx, >> int order, >> unsigned long nr_requested, >> @@ -339,6 +339,8 @@ TRACE_EVENT(mm_vmscan_lru_gen_scan, >> >> TP_ARGS(highest_zoneidx, order, nr_requested, nr_scanned, nr_skipped, nr_taken, isolate_mode, lru), >> >> + TP_CONDITION(nr_scanned), >> + >> TP_STRUCT__entry( >> __field(int, highest_zoneidx) >> __field(int, order) >> @@ -494,7 +496,6 @@ TRACE_EVENT(mm_vmscan_lru_gen_evict, >> TP_ARGS(nid, nr_reclaimed, stat, priority, file), >> >> TP_STRUCT__entry( >> - __field(int, nid) >> __field(unsigned long, nr_reclaimed) >> __field(unsigned long, nr_dirty) >> __field(unsigned long, nr_writeback) >> @@ -504,6 +505,7 @@ TRACE_EVENT(mm_vmscan_lru_gen_evict, >> __field(unsigned int, nr_activate1) >> __field(unsigned long, nr_ref_keep) >> __field(unsigned long, nr_unmap_fail) >> + __field(int, nid) >> __field(int, priority) >> __field(int, reclaim_flags) >> ), >> >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -5131,10 +5131,9 @@ static int scan_folios(struct lruvec *lruvec, struct scan_control *sc, >> __count_memcg_events(memcg, PGREFILL, sorted); >> __count_vm_events(PGSCAN_ANON + type, isolated); >> >> - if (scanned) >> - trace_mm_vmscan_lru_gen_scan(sc->reclaim_idx, sc->order, >> - MAX_LRU_BATCH, scanned, skipped, isolated, >> - sc->may_unmap ? 0 : ISOLATE_UNMAPPED, type); >> + trace_mm_vmscan_lru_gen_scan(sc->reclaim_idx, sc->order, MAX_LRU_BATCH, >> + scanned, skipped, isolated, >> + sc->may_unmap ? 0 : ISOLATE_UNMAPPED, type); >> >> >> >> >