From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7615C00E86 for ; Wed, 20 Sep 2023 15:30:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 512576B017C; Wed, 20 Sep 2023 11:30:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C2FB6B0180; Wed, 20 Sep 2023 11:30:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 315136B0181; Wed, 20 Sep 2023 11:30:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2015F6B017C for ; Wed, 20 Sep 2023 11:30:42 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D1DA7160D52 for ; Wed, 20 Sep 2023 15:30:41 +0000 (UTC) X-FDA: 81257363082.19.A6E28E4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf15.hostedemail.com (Postfix) with ESMTP id 85B86A004C for ; Wed, 20 Sep 2023 15:30:39 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cPiRr5Nl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6KZkGGsM; spf=pass (imf15.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695223839; a=rsa-sha256; cv=none; b=oNHB7waAgaiq49iEgRr4ezVK2k48dEaMXwlvva26n8efhNhN7krv8sBmqKkYurOrjzc4LC RAlrhbLFwbbZcxeHAKXy4Y7JhKNLvpQYauv8BCkiGvSOpj1XyfHF7Kzgpf8nu3WW36RVvw ayrjRTTcxzEeJPnp4E79EkyQ4OnCI0g= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cPiRr5Nl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6KZkGGsM; spf=pass (imf15.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695223839; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z07gJ0ljk8a9zukVNTeRislBXMh7pJ7EEuF8a+v+/FI=; b=iebOB3yYPJeRJfuc2jD0KerGlQsMELze+11WYqsZgmf7gGc/G6Bdb4xmTeetXnwCJV9fZ5 RFvVN6xfX7fGzSijYN50fbryP5xwFbbliSjZaTzaoSK3GLkzcdeDDOIpCI1Uem9sbruxYZ pVpxOPmtcanxTgXC12YAoxx72Jamgac= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2A37D21F95; Wed, 20 Sep 2023 15:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1695223837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z07gJ0ljk8a9zukVNTeRislBXMh7pJ7EEuF8a+v+/FI=; b=cPiRr5NlB4Iwub7EwKz86boVSJQJZ3WLxzLaU6G09EfO4FmtVOdy7KUFneBvjrGmUR3ITh 2SAzepsqhIpBmvq/dM3lwFGS4jeZb1JiYpwLyM/YRSlBcScjreBuxS42wYeBxMo6k0JIzb vOOpZeXkJqjpWBWmAFVZOTXkw8HJ8lk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1695223837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z07gJ0ljk8a9zukVNTeRislBXMh7pJ7EEuF8a+v+/FI=; b=6KZkGGsMv2dh1rvGNnyToBfPP9oSwDD0PDv8XeIzbn7pcxdfbwlBblC3C43EGbanxkRyi5 mASfcKX9dgdX2bCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0DEDB132C7; Wed, 20 Sep 2023 15:30:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +bZeAx0QC2WLRwAAMHmgww (envelope-from ); Wed, 20 Sep 2023 15:30:37 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 97616A077D; Wed, 20 Sep 2023 17:30:36 +0200 (CEST) Date: Wed, 20 Sep 2023 17:30:36 +0200 From: Jan Kara To: Christian Brauner Cc: Chuck Lever III , Jeff Layton , Jan Kara , Bruno Haible , Xi Ruoyao , "bug-gnulib@gnu.org" , Al Viro , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , "coda@cs.cmu.edu" , Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bo b Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "v9fs@lists.linux.dev" , "linux-afs@lists.infradead.org" , "linux-btrfs@vger.kernel.org" , "ceph-devel@vger.kernel.org" , "codalist@coda.cs.cmu.edu" , "ecryptfs@vger.kernel.org" , "linux-erofs@lists.ozlabs.org" , "linux-ext4@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "cluster-devel@redhat.com" , Linux NFS Mailing List , "ntfs3@lists.linux.dev" , "ocfs2-devel@lists.linux.dev" , "devel@lists.orangefs.org" , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-mtd@lists.infradead.org" , "linux-mm@kvack.org" , "linux-unionfs@vger.kernel.org" , "linux-xfs@vger.kernel.org" Subject: Re: [PATCH v7 12/13] ext4: switch to multigrain timestamps Message-ID: <20230920153036.pfg5h4aoed6ua6s3@quack3> References: <20230919110457.7fnmzo4nqsi43yqq@quack3> <1f29102c09c60661758c5376018eac43f774c462.camel@kernel.org> <4511209.uG2h0Jr0uP@nimes> <08b5c6fd3b08b87fa564bb562d89381dd4e05b6a.camel@kernel.org> <20230920-leerung-krokodil-52ec6cb44707@brauner> <20230920101731.ym6pahcvkl57guto@quack3> <317d84b1b909b6c6519a2406fcb302ce22dafa41.camel@kernel.org> <20230920-raser-teehaus-029cafd5a6e4@brauner> <57C103E1-1AD2-4D86-926C-481BC6BDB191@oracle.com> <20230920-keine-eile-c9755b5825db@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920-keine-eile-c9755b5825db@brauner> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 85B86A004C X-Stat-Signature: 94a98sbee7ug4ax4a1suja1mxa31c7dn X-Rspam-User: X-HE-Tag: 1695223839-553675 X-HE-Meta: U2FsdGVkX1/+bD1P+7w0tB9+BXln9pmCroks2feaduR4qKvze6nXG60syN42pqVinMw/MHnHmJchAcRB5Qr4oZ2SmwppEG2LJJ/1NEqQdqK70s/Jg5HXkAmsQb7GfF2UMG2lYAJc6i7vIJqm4LOxtLcgyVHBCZZGjO/sHDDHF8KyEYDriodcBcmBOXp4FMepD8152/0B9Z+PSD9rRkdt+hPXGW6yXlbCLjg8xUffActY+Hv67X+7kL5erhum9l9r43Z95ZGG3qgaZskW7Bg8GzBTFifpMyQ2KH4Ew1VjMLK7sHBf9M3ysg+gu456xMe4lbAoLZOhe0kONFj87f5tuOQaMb4QxvVFEiAPwASLHQjwzUJjaTA9kcGhHq6QEeGUyX2Ra2QsuHvIBQM7SPFrTj8NiCmxdpQ3tCDeJCpzHPOyvqwAAgkTquG2ynwygH8VYrrTOx54ZIaSc1/34+Nugeruq9dSR//VNLac9L0TA25Nj7pdjuqoqUWSzBg0CcTnY/52xheoLB/aTm4XxEyTqA5DHtlAPY3HFWUKCxN6B1CFMr5i9hQSVtq+Ps1sfzEFxcPsDVRXVHZ4F7uxyTBMqLfdwiFhGyXRRUVP+HtSF3bKi+u+tjWOMpMSja4bdo+2aK1dx5iVyiyfMGypF/vGexu94seRIoGe/XZem7DIo7rHR8ShuxhQFVBeTbuY/roMPzs/DlmwzLx1aoQibfKsr77EaT492FQkztxjTMYdibuM/j+esOYjDaaxC6Z0/TdyLCixq+XWBljf7sCDfrvycu2S+1eEuIuejkbZIG6Erhxukx9uoHqU3JDzyH9KwGziBgEddNw2+YYMS9qI0sp953XzwYzkufLd1+yRInW4VZFob0nkBYIP6KPQjlirmWdIOCd7KeAY5Wz/n8XmOtSj6P7uTZkOlXvYjkDcB2gJgBBpm7W97jp1Eb1uVDZqmjAyE2TH1TWCU1s8cxzbZc9 I9eym5iR uqcrdbARrOerKvb+WIyYba6wGoISPktweMWSIQa1mqMI4INeruTtbJZT0jxqeFUsFWIFi/WikfWFGrYTab9u7ME7go/0LCMlbGb5gAYEIYcw3vmv2bY3qwhEDPa26dsm/2eKhMt74RL3nUBn7t+iMJxrdf7PodyAv1vYQXTN6qedBRnzSjc+Psxtk9dSY16RBCJe+mSI8/oYMdTmTsWXrQB4MdArYNYwPS8aOtPuJ09CvwyRi4+8o5dK55JUnChdQF6WIYfi205K3yh3prwsiOUm4dS3AdZrgvkRPvNnweXdzPHHUtmc2ZH04Sy/p2MefLTRYNfJHfWbxGp6ukOsrV5K0RqdcL0BnWsln X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 20-09-23 16:53:26, Christian Brauner wrote: > > You could put it behind an EXPERIMENTAL Kconfig option so that the > > code stays in and can be used by the brave or foolish while it is > > still being refined. > > Given that the discussion has now fully gone back to the drawing board > and this is a regression the honest thing to do is to revert the five > patches that introduce the infrastructure: > > ffb6cf19e063 ("fs: add infrastructure for multigrain timestamps") > d48c33972916 ("tmpfs: add support for multigrain timestamps") > e44df2664746 ("xfs: switch to multigrain timestamps") > 0269b585868e ("ext4: switch to multigrain timestamps") > 50e9ceef1d4f ("btrfs: convert to multigrain timestamps") > > The conversion to helpers and cleanups are sane and should stay and can > be used for any solution that gets built on top of it. > > I'd appreciate a look at the branch here: > git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.ctime.revert > > survives xfstests. Agreed. I think most of ffb6cf19e063 ("fs: add infrastructure for multigrain timestamps") will be needed anyway but there's no problem in reintroducing it in the new solution. I've checked the branch and the reverts look good to me. Feel free to add: Acked-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR