From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC3EBC04AA7 for ; Wed, 20 Sep 2023 14:53:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A3856B0183; Wed, 20 Sep 2023 10:53:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2527D6B0184; Wed, 20 Sep 2023 10:53:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CD0E6B0185; Wed, 20 Sep 2023 10:53:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F16CF6B0183 for ; Wed, 20 Sep 2023 10:53:49 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A1174A06D4 for ; Wed, 20 Sep 2023 14:53:49 +0000 (UTC) X-FDA: 81257270178.05.14F5545 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id 96F0240032 for ; Wed, 20 Sep 2023 14:53:47 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hUm3CDqB; spf=pass (imf27.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695221627; a=rsa-sha256; cv=none; b=BITEud8idcuXLODOaeecaCKB8qSt2xez/74o1XK1mVa9p0vlWAvSPqPzahfcVlhRfAxdFS kt8q04BXXg++6JzPUKIvk9z0LO01QexG1194k1ria7oDvqC2usmhYl+qZFFUo5SQeNnz6W v4dHiYUaZewZ7lhLZSIASgRrRY8BUC4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hUm3CDqB; spf=pass (imf27.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695221627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pv/mshlnOGkJ5ebR+d6AqRiPt7G4UklH+5Y/YwatjVw=; b=xdZuF1bhSJq5I5ouXIaoEhljpvu3BMIlWRp42nLLMJDlwL0YUHnM0lvbY/n2f/2KvCNvTB 40yGexxXU5lGbEGyNaxfPufsZu+/lANKkh/ZIdJaFx6Lzdpp1IEzZJebz8Bh+fwLtaw10S BpkKTTrX/TzmxVRsIXw6dtm2lwygHY8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7F51AB81DCF; Wed, 20 Sep 2023 14:53:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B10CFC433C7; Wed, 20 Sep 2023 14:53:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695221624; bh=pv/mshlnOGkJ5ebR+d6AqRiPt7G4UklH+5Y/YwatjVw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hUm3CDqBbqdWl1gTcXLfMGrJ4YfO3wokaDGaQDO3xOEWDbllQ4Mfpj/KueremMgA5 pBL/JzWz4+0hsTX69O5jnf1yRuwKeufAxYGRi9hiZ4ho9usSCqwyLkEScujErQvTLd pH8R4MxKr1CGxSHyPru+0iqA3gh7pydF57H5YT0p+7Rd0zhQBTnYL0en9hUyWFooe+ Mdfj3r0q5YN+5TWuL0JXteBwUKeABbsXdunQnhbthSc1EwQj0hbuY8ac5vX7VekjTf fGOHz5omQ2+B/RCVrXr9woAH7FyctwMygMiv3giawQBEFR5HdvJ9UunmoJQb2brq0N 41leRmH4Vm1Jg== Date: Wed, 20 Sep 2023 16:53:26 +0200 From: Christian Brauner To: Chuck Lever III , Jeff Layton , Jan Kara Cc: Bruno Haible , Xi Ruoyao , "bug-gnulib@gnu.org" , Al Viro , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , "coda@cs.cmu.edu" , Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bo b Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "v9fs@lists.linux.dev" , "linux-afs@lists.infradead.org" , "linux-btrfs@vger.kernel.org" , "ceph-devel@vger.kernel.org" , "codalist@coda.cs.cmu.edu" , "ecryptfs@vger.kernel.org" , "linux-erofs@lists.ozlabs.org" , "linux-ext4@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "cluster-devel@redhat.com" , Linux NFS Mailing List , "ntfs3@lists.linux.dev" , "ocfs2-devel@lists.linux.dev" , "devel@lists.orangefs.org" , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-mtd@lists.infradead.org" , "linux-mm@kvack.org" , "linux-unionfs@vger.kernel.org" , "linux-xfs@vger.kernel.org" Subject: Re: [PATCH v7 12/13] ext4: switch to multigrain timestamps Message-ID: <20230920-keine-eile-c9755b5825db@brauner> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230919110457.7fnmzo4nqsi43yqq@quack3> <1f29102c09c60661758c5376018eac43f774c462.camel@kernel.org> <4511209.uG2h0Jr0uP@nimes> <08b5c6fd3b08b87fa564bb562d89381dd4e05b6a.camel@kernel.org> <20230920-leerung-krokodil-52ec6cb44707@brauner> <20230920101731.ym6pahcvkl57guto@quack3> <317d84b1b909b6c6519a2406fcb302ce22dafa41.camel@kernel.org> <20230920-raser-teehaus-029cafd5a6e4@brauner> <57C103E1-1AD2-4D86-926C-481BC6BDB191@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <57C103E1-1AD2-4D86-926C-481BC6BDB191@oracle.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 96F0240032 X-Stat-Signature: b5kix8q9gskr393ybq65ynreikoybbn9 X-Rspam-User: X-HE-Tag: 1695221627-806359 X-HE-Meta: U2FsdGVkX1/xIuwuydeSCYr3qLkazksEsa6knpdD70o9GbQ72ilWOwAaKeldCVmPfPwTLCibnJEQ2tVRFTh9CFykBKwGRnMZruc9EVM9lX7quvQfr2I5er7+3hnspXBdhs4VLMt9d8AWLT9LNGW+UL3CbrK2IoMJWDHwj1SktNybt4v9a9wC5s9rWdm5AvG5SHR/Dq/+xJs0cOl0hKG9WrreIt7uPrWxwNmvDkZYqmXV4f4gnWB83GDs15G+E1lCb11Q9kEeuDZ2+T0C1ulZ4ot7cb/YoK9gvkjM8yy56My6Fgx9D9B00d9nREbXHN+TM4NVhVkEH/emR7Ry3CrSshW7QWFBV/VaYlwHHq7aKzj0poETMHmtk2djEp5pkOWHTJkTA1vS4CDtiuVoXbTTYM+KKJFMcAedy7WvsCLhDt8/P02+9fFhtqwypoqIrSzOxUWom8JbyWrEyaOfnnk4d26fuU+ifM0FHjx35BQ+/eV1SXNwgiV4A1odSyPgTMH0dotnAGJl6ubDp2yvbk7m8e+iibzLi+RzwOsSjxQqWGRxkTbwazHMN2iZFlMNV1pU3scpXX1po5Vsps6fD3qFf4nPP1Qn+AxZRaEK0aYWpeNsdE+ldb5KgVqKS/weHgDFpWCHjBF/qofWkS01Ob77imiCXLCo36F5V8yrYPYWbVClt3L4Z/05XIT2fpnBn+z/eJId7QeGszIC10cypZ1xZoNcjuBABZwIRCMXfH5qRuk3Js6iz0JXjjwghbkPJrxGcFMdEM54VgCsgUlWkEhF2GGUhoSSq7Zf8tcK9+0nWjAE0Z5IG5dwBCV0khH+cKJGKYH7DsjpzNoWMWpzf+95Ycs2W1K4abRHsNP4pV/GJ8Xg2+IMjnmFf+2w8I6TBqrE1EDfyECT9qq2WRVlRFjYtp46Z6Uh+CRLo0omLcLE35OIpo7EE2EDhmIPytalRDM8gb6L3yLJaKEK9XtwtI1 j7JEzJsf OGXgQnnjZ3wuhy2O1v+jZyPRUSAlc+J6+L2mwJChldhp3wkzpDO1TP+T9VJ/28Bp2qe6w5cLVnfmZ9dyyVFqsLwWHynpBq2nA68L5MLLeWFMHTqj/csqm2Ero2P6atd6w3pMxUGeDinEVT3FwN6eN+gSTzvUbB5uCZPYcFGAGoLaK4iknn/za6Ro+0rbzjzfiszZjtbO1CfeVtIQb+F/BKXo78z3y8t7YVS9+yfqm7wFo09/T9FNZz6I89JS4aHXjfR4KTslQzUPbTW2Jn1Quko9O7EZmQkPbt3gQxFr4HNEJ87OK075X52wT65kMByaRaYfFsbnuSYHY1+9liZRHZ0wRU1tM4WJYt32vxh1+X3jsCEWElAX5yq5qf/ZPsR8OHzbb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > You could put it behind an EXPERIMENTAL Kconfig option so that the > code stays in and can be used by the brave or foolish while it is > still being refined. Given that the discussion has now fully gone back to the drawing board and this is a regression the honest thing to do is to revert the five patches that introduce the infrastructure: ffb6cf19e063 ("fs: add infrastructure for multigrain timestamps") d48c33972916 ("tmpfs: add support for multigrain timestamps") e44df2664746 ("xfs: switch to multigrain timestamps") 0269b585868e ("ext4: switch to multigrain timestamps") 50e9ceef1d4f ("btrfs: convert to multigrain timestamps") The conversion to helpers and cleanups are sane and should stay and can be used for any solution that gets built on top of it. I'd appreciate a look at the branch here: git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.ctime.revert survives xfstests.