From: Axel Rasmussen <axelrasmussen@google.com>
To: Alejandro Colomar <alx@kernel.org>, Peter Xu <peterx@redhat.com>
Cc: linux-man@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Axel Rasmussen <axelrasmussen@google.com>
Subject: [PATCH 03/10] userfaultfd.2: comment on feature detection in the example program
Date: Tue, 19 Sep 2023 12:01:59 -0700 [thread overview]
Message-ID: <20230919190206.388896-4-axelrasmussen@google.com> (raw)
In-Reply-To: <20230919190206.388896-1-axelrasmussen@google.com>
The example program doesn't depend on any extra features, so it does not
make use of the two-step feature handshake process. This is fine, but it
might set a bad example for programs which *do* depend on specific
features (e.g. they may conclude they don't need to do anything to
enable / detect them).
No need to make the example program more complicated: let's just add a
comment indicating why we do it the way we do it in the example, and
describing briefly what a more complicated program would need to do
instead.
The comment is kept rather brief; a full description of this feature
will be included in ioctl_userfaultfd.2 instead.
Signed-off-by: Axel Rasmussen <axelrasmussen@google.com>
---
man2/userfaultfd.2 | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/man2/userfaultfd.2 b/man2/userfaultfd.2
index 00d94e514..b2b79f61d 100644
--- a/man2/userfaultfd.2
+++ b/man2/userfaultfd.2
@@ -881,6 +881,13 @@ main(int argc, char *argv[])
if (uffd == \-1)
err(EXIT_FAILURE, "userfaultfd");
\&
+ /* NOTE: Two-step feature handshake is not needed here, since this
+ example doesn't require any specific features.
+
+ Programs that *do* should call UFFDIO_API twice: once with
+ `features = 0` to detect features supported by this kernel, and
+ again with the subset of features the program actually wants to
+ enable. */
uffdio_api.api = UFFD_API;
uffdio_api.features = 0;
if (ioctl(uffd, UFFDIO_API, &uffdio_api) == \-1)
--
2.42.0.459.ge4e396fd5e-goog
next prev parent reply other threads:[~2023-09-19 19:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230919190206.388896-1-axelrasmussen@google.com>
2023-09-19 19:01 ` [PATCH 01/10] userfaultfd.2: briefly mention two-step feature handshake process Axel Rasmussen
2023-09-25 23:26 ` Alejandro Colomar
2023-10-09 8:38 ` Mike Rapoport
2023-09-19 19:01 ` [PATCH 02/10] userfaultfd.2: reword to account for new fault resolution ioctls Axel Rasmussen
2023-09-25 23:29 ` Alejandro Colomar
2023-10-09 8:39 ` Mike Rapoport
2023-09-19 19:01 ` Axel Rasmussen [this message]
2023-09-25 23:32 ` [PATCH 03/10] userfaultfd.2: comment on feature detection in the example program Alejandro Colomar
2023-10-09 8:40 ` Mike Rapoport
2023-09-19 19:02 ` [PATCH 05/10] ioctl_userfaultfd.2: describe two-step feature handshake Axel Rasmussen
2023-09-25 23:44 ` Alejandro Colomar
2023-10-09 8:42 ` Mike Rapoport
2023-10-09 10:58 ` Alejandro Colomar
2023-09-19 19:02 ` [PATCH 06/10] ioctl_userfaultfd.2: describe missing UFFDIO_API feature flags Axel Rasmussen
2023-09-25 23:50 ` Alejandro Colomar
2023-10-09 8:45 ` Mike Rapoport
2023-10-09 10:49 ` Alejandro Colomar
2023-09-19 19:02 ` [PATCH 07/10] ioctl_userfaultfd.2: correct and update UFFDIO_API ioctl error codes Axel Rasmussen
2023-09-25 23:52 ` Alejandro Colomar
2023-10-09 8:49 ` Mike Rapoport
2023-10-09 11:01 ` Alejandro Colomar
2023-09-19 19:02 ` [PATCH 08/10] ioctl_userfaultfd.2: clarify the state of the uffdio_api structure on error Axel Rasmussen
2023-09-25 23:56 ` Alejandro Colomar
2023-09-26 17:58 ` Axel Rasmussen
2023-10-09 9:03 ` Mike Rapoport
2023-09-19 19:02 ` [PATCH 09/10] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER error code list Axel Rasmussen
2023-09-19 19:02 ` [PATCH 10/10] ioctl_userfaultfd.2: document new UFFDIO_POISON ioctl Axel Rasmussen
2023-10-09 9:09 ` Mike Rapoport
2023-10-10 17:13 ` Axel Rasmussen
[not found] ` <20230919190206.388896-5-axelrasmussen@google.com>
2023-09-25 23:37 ` [PATCH 04/10] ioctl_userfaultfd.2: fix a few trivial mistakes Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919190206.388896-4-axelrasmussen@google.com \
--to=axelrasmussen@google.com \
--cc=alx@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox