From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8906CE79A8 for ; Tue, 19 Sep 2023 15:38:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 053BB6B0560; Tue, 19 Sep 2023 11:38:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1F296B0562; Tue, 19 Sep 2023 11:38:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBF3A6B0563; Tue, 19 Sep 2023 11:38:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C791A6B0560 for ; Tue, 19 Sep 2023 11:38:36 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 95A1980128 for ; Tue, 19 Sep 2023 15:38:36 +0000 (UTC) X-FDA: 81253754232.14.27D6AE4 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id D38CB100007 for ; Tue, 19 Sep 2023 15:38:33 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LVkuPzu1; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695137914; a=rsa-sha256; cv=none; b=mbhSisF93il4UdAucMbqrpxvxTDBghVFmNAunk2b1jdqS3X10ufzcHbRbvNnva/0A7Z9YF 7/SO0sI0Csgcy+bQ/MRUG49lLyTCqQBzH17MuArGDzO47/K431IPN1Gl+p1scxjg8CIMW6 xjjnBOP1eLCtBv0hZp90zi4aPjGT4K4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LVkuPzu1; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695137914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5N3CbstoImwIQAb+dRTeeVTazLAXTIbcxBgZG6DSs7w=; b=i3H+vezmgy+AIO/yG91tlVbMyy/w1QnbLqoQrhcoPzCv8qZ8d7gW+Ai9K7QWCJbRjIWlWb y0Rsxu5M15fZa/vsHVqKGZ7sa/ecrwvwVynp6mUX+48a1AOo7RZ2EMd4BUvDgJnzZAzw/4 bMH9tlrwuVyLN43xnLAnsfs+FajgiR8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 306A6B81620; Tue, 19 Sep 2023 15:38:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3948DC433C8; Tue, 19 Sep 2023 15:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695137910; bh=J8+U3XCWGGk5acPLvSGMBRc9QaTjuUp2xG4OFZxegoQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LVkuPzu1JrukWDxKdgvTxhPeE9Tp9Ac2mjS+sJA/V6txBxst8hHheHxTH67txsXj5 CmZvAtkHe3hi8lq5p4fJpTu0A66jzbDAsd7imPJE9vBzZYB0gukkCrVWOYzrPMTMho W73QxBpGaOwXWEtyGxvLMLC4O0moP/HXP4u8I9Tlrkx7dEBadQEhIcxAbOrjzc/v3G 0MBQa5O7eWSjYnyeu5hwESClSD031A459oAnakbMGp5m7o81Dj5xYvtzFTKG3WYBLW 9Xfe9vKbvdkiNWzY4CDDCqGlJWbAMa8JjhIjZSMGELdk3Shkcc6pr4gWB+H/wU5Qcf 4qrzJc/GNzvcg== From: SeongJae Park To: Huan Yang Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev (open list:DATA ACCESS MONITOR), linux-mm@kvack.org (open list:DATA ACCESS MONITOR), linux-kernel@vger.kernel.org (open list), opensource.kernel@vivo.com Subject: Re: [PATCH v2] mm/damon/core: remove unnecessary si_meminfo invoke. Date: Tue, 19 Sep 2023 15:38:28 +0000 Message-Id: <20230919153828.8190-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230919020057.29388-1-link@vivo.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D38CB100007 X-Stat-Signature: 98ajkz9izjimt4qt7oza6cr3uhnnpmj5 X-Rspam-User: X-HE-Tag: 1695137913-40468 X-HE-Meta: U2FsdGVkX1+6a0t/WSKv39UWCSG3xS599SxqBslBnlb0OsUFNnOlIMIcY2a8aOW5lKg9OjCqFkWnBQXf6YYzyJXagoZqMGssxZCbktnLz5s2atoJpbjG0DJ8/8lT8SLYz1AdHIn6vh1AzOzFnHAitQO5TzHD8Xk9HWmKC4YasAKMvzq+mN8a5R1FdrB6NtLceqFGEroSX8Zbvom7R1uVJjYcdl91SOPLzI6LO6PdDxRP2OFhTy8on9f4U3UOrU5Ci9TIVQYJ3EdMbe/sv9S0zcS3LCBjZULuu5RSXJbfjiNJU/3RWLb9zqMydgSXqlepWna61XsSZ0JztWCmW61bdzpp1/aBRbtUp6qiv8bhYl6IgrTcErOimUFG4116A5SJLrQz6efCeelxLvWg8faHodWiNQc0El2Mgub2CoeMJgUh70dyYxnKr2dzpFlyHh6VnWn5E/fEePeWTDC9hEa66qNwnRsXbFpFj5WtyWgow9vjJ/aJvSdM5ec00QOoCkkujhFlTiE02Qpz5bMwFPmnCf0yGWGz6zXCs++PpsNMRXdsOwR4KJcaxuQmfyT9aemo8Bs8nkt+u/VCw01jBBZOxmw5gXwGR3TQWgEjcBhBCTlBKy21O/Qept1jueMwAogIcVDKm3h/6geC0Eckzhu7CcQV3XLo5Lhi32PpHobfJbldmtTUSDDVl+y7heACPpBT0SaEq89ym12iTN5S4na/71cP9QYj4cHAxys9vJ8CvInOsfrOwShqV3RqrbbuTzQUDXwnqziGBSl8+HU0akU+JUt/sDZXAnsf7QVhP2Dld7VvytGDRCIF9AuE0VvSDOEl1BUdIBoO+DjCxUC3fsGgT/JB59b+Ededfflyrce766NJeU3N5SmaAKxbVe15tUYk8UUTjRD4dFHAOWJu+CwzRlYBEs0aFOqa50nj7I+FovE8kfPqXiqhQ1shxfJyb3tEfCKYsKpFqfcANFPFd73 KJcyO1D/ jW8ScavFap+vZH1krLh+yYd7Obg7Bnt8SH1hWyzQeHO7vv4qWqbjBMsY//QiV48MGZyJGWU/S+rmJiGGgrU6esBm1d4umjgRSDXpQdVKJsxZP4LsjslGNwoT8w+B+Z+feRBQt2nShC+dlUAJp/F54YinKYxVI8qYn/1wJ+TLfV3IrmipuKZ+qFK9ovCi9HyLJoV/k41DXAytbkbN5BVt6w1/GSGDEx2AhJLqr3pfuZFfXTu7712WFGTAnXq3t+zFvYIvvGNnWTD+V/vZPw7HJdyCith9B6r/uDHbD6ZboFRYmPqhO659Z4E2j1AYsE22J+NZiBliuYvwKW0SCFP31QZ0O/VW2+5g+FRscK4PWeMB2yFGe2F8IGk0/laEqulHN20Zl8c9Dk8TmbWXe8+yuk2StkbJeP1HSgW+uZEWAOwNFU8gL9SsSEW5CejquXtJTlB+rdUEY12cGIfdoGb4avcs7Ge0QI7Pcu3Fmr8XSIVot+pU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Huan, On Tue, 19 Sep 2023 10:00:57 +0800 Huan Yang wrote: > si_meminfo() will read and assign more info not just free/ram pages. > For just DAMOS_WMARK_FREE_MEM_RATE use, only get free and ram pages > is ok to save cpu. > > Change from v1: > v1 fold free mem rate logic into __damos_get_wmark_free_mem_rate and not > invoke si_meminfo, just get free/ram_pages in global. > v2 cancel this __damos_get_wmark_free_mem_rate and just calculate rate > in damos_wmark_metric_value to keep it simple. Thank you for accepting my suggestion and making this change. Nevertheless, we usually not keep patch changelogs on commit message but after the '---' line[1]. > > Signed-off-by: Huan Yang Other than above and below trivial comments, Reviewed-by: SeongJae Park > --- This is usual place for patch changelogs. > mm/damon/core.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index bcd2bd9d6c10..a3f812d78267 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -1280,12 +1280,9 @@ static bool kdamond_need_stop(struct damon_ctx *ctx) > > static unsigned long damos_wmark_metric_value(enum damos_wmark_metric metric) > { > - struct sysinfo i; > - > switch (metric) { > case DAMOS_WMARK_FREE_MEM_RATE: > - si_meminfo(&i); > - return i.freeram * 1000 / i.totalram; > + return global_zone_page_state(NR_FREE_PAGES) * 1000 / totalram_pages(); DAMON code still prefer 80 columns limit[2] (sorry for being stubborn). Could you please break this line for that? > default: > break; > } > -- > 2.34.1 > [1] https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format [2] https://docs.kernel.org/process/coding-style.html#indentation Thanks, SJ