From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2639CE79AA for ; Tue, 19 Sep 2023 16:42:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C35B6B009A; Tue, 19 Sep 2023 12:42:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 873D76B009B; Tue, 19 Sep 2023 12:42:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 763466B009C; Tue, 19 Sep 2023 12:42:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6A2A16B009A for ; Tue, 19 Sep 2023 12:42:09 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3563C1405BA for ; Tue, 19 Sep 2023 16:42:09 +0000 (UTC) X-FDA: 81253914378.12.5D103C1 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf16.hostedemail.com (Postfix) with ESMTP id EB23F18000E for ; Tue, 19 Sep 2023 16:42:06 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=UzU0qq8T; dmarc=none; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695141727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UZGg+e/Qjnxq6NJJp4DCv68RxxcoX2PanZ0hukHoTmM=; b=ok4MiEOG9LdP/bl9gzSDUwcEagFes8ZvmMX8rx+zeGfyfL3dsP3O74uHXQ11Mkqk48MzSk y/54KOPJ8krDLiD+WDimoFxrrN7OfdVZFQzaWgpBkq+ZQ191klbCmP3UPONr4GdS5e9GoP PaSypbCKxRoecNvIl4wAqouQKWoGbqQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=UzU0qq8T; dmarc=none; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695141727; a=rsa-sha256; cv=none; b=OyPuAdpxHhWHO345c54CUA4D4UF5CqZ6QXryMtIwo3ftAGxwpt3elcCbOD9z7Ieq2AJmVy GnaonEFblM/16Jw1mBPAput9ZSY8D8CJEoBYLqsODojKtyHra5rGli9GJ0cj0tv7LqLfCT AT3dx1wFQfNdNfKtcSBznplhvNlqEIE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 15C92CE1392; Tue, 19 Sep 2023 16:42:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36585C433C8; Tue, 19 Sep 2023 16:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695141721; bh=y+0HL2408rXuAWIiNdyb8f+aOlsE9EsNrIMlfo6YXzQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UzU0qq8TexCNx6DUcl5GhDQFJiEvtJg65zNnPTVK7TdW5c9TUOOjtzB10OqyXP/hB RTXlO4NF95ri9OvaEZ6e+g7Y82c9bl5KW28jKRIbWr/t3zkuDR4AlxXaawZ+rX26aw qazlyDjAxdyyQ4nWS4IBFM27mBVwBc05jzUt1xs4= Date: Tue, 19 Sep 2023 09:42:00 -0700 From: Andrew Morton To: kernel test robot Cc: Baoquan He , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Zhen Lei Subject: Re: [linux-next:master 5741/5912] kernel/crash_core.c:214:13: warning: argument 2 null where non-null expected Message-Id: <20230919094200.0f6495393a8eef3dc398e8ac@linux-foundation.org> In-Reply-To: <202309191144.B0MToaPG-lkp@intel.com> References: <202309191144.B0MToaPG-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: EB23F18000E X-Stat-Signature: meaf5keaicpsi7pxcas5orpsztoxzg87 X-Rspam-User: X-HE-Tag: 1695141726-601396 X-HE-Meta: U2FsdGVkX18KzFVbNWLDKKG7sMM3A5KV2UHbvEznXZDY4MT7OPxCo1tXmqX9rEXZefoqGM4WjvWHiQww7ogr5KWBkmQT0TpeTDqP3VOr0MdoDW2E2jQRwsh5W2pZx2JZtjYEeUeigY/2o/s9PAJm1Z6uYEx9P8ubN4DPMr2q2mgoLR/GmxY0a0eXwTAYXAbzUKBDfCb6PpXuj4bubegZi2Uzn/7k4m+nMBb7s+puMm4mfoXwcDVwfIeecGu0JLbj4qReW0VbjZPt/K52Ov6bA7WEEbhNusJonehuDGfMnqguEv/R8cXY3jQXdx4a9NGMFUM3ih/AY2Sl9UG15qooEWmnU8W2AoqSIBQHRPIkKVlt4x6uc7x2iunoCQjA06295bpXvhO9XVZfw5ZcVBVmyPx8yHWhX8GonsYSmV5xY2xGnx4idfRqjxBMASMT8ezbC1mUV+O7uPr3gYbgNuWqhV7EdSN/nvCvpGcdw+eWnnRnB2jeVc+4gj79T6uqwtZyBYKZ3Zf2GlaZJC2Kd0tLl+C5nznFhkGKJQknAqInSQXhz8EbReOQIMcgwepv0zi0SvQ+eTiMYn9ecDoHJ6OljDxFw5hZxaJZU6tVdwK6eIIEkaXG82AA2kEi8g6liDkDAWamQnNY11Ra1tdyxzv/ndLudAvJzoWBkWzw6Ve7ZCZEPtK5lpE0oJFcvi1fKERJEKY1NejtvHpWjvE4ECH+Bs2YIuuKw+BGSMsh6BXg1vgoPNxKL1pEdCga6QJc6sT0Pp4fKMVMWW6poKGQED4+c4Bs64AbTnf2IoTL4Ek3+YVTh2uenYgJn55csxLBMqxnIFI67Lgm5JQ66XoObH0mNqVWco6PrHNjuNc0FN7ffiQAzYVNNOyUodkJqhr4xwJMgr8zCrrO9coTCFLXU4tzYyPDc/ogLxSr1twwLaKaSCi48A9NngC/ddV0YFg8dmsiPzijAwC+vAmffgAcJoq IdOPusKV Vi3O62PJ20R/e9seW38vERrhLX29pp4pPcUNbzrcE2TNsr2OBCSpta/1wZBMBK0Qx/8Q+PIGnGWnYNMT0H5qYhFe6Nur7Irw4xIjSDMHCEpNs7lSUGNIhc4OMKtS8smbnZMp0KRLIN8y4KxVcVFJr/0BhPISIyf4ynU9Hk8oLkmzA8BQjMz0VRdiFNo4hVFXW5NhTAfIE9YZyTLCAXFaW9mQ4tmvkg6PheOiLoBPfRHB/f84SJLxLZF/NOZgj8K6u5VKZo7qdYuid8raKpNYtzLJ1q2Fqhv6f5jNuriGTIgV1Fm5OFjBK38YeGaJzIbNcBL769m4+7VvRt/3gxpnBwxYpuPKJNFw/18wQC8PLIbLzs6XP1vVhVxDdsuhZKORpifCJbX5nBmMv6iojazcNS2IqKkqLuW58PZpl3vMNhnnWU1Vp4wc60m8tEo7mFtgYU/edxoEWU4qecrl+rFtGDQyCrPjLiOe+BhgAIlDXIX3XhpftAgvmuBjSsmpPvs1VWJKq/dV/G1wg33A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 19 Sep 2023 12:02:17 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 7fc7222d9680366edeecc219c21ca96310bdbc10 > commit: 5c322f6aad10f0920f842a4ccf82e9b9f351c0a5 [5741/5912] crash_core.c: remove unneeded functions > config: s390-buildonly-randconfig-r006-20220512 (https://download.01.org/0day-ci/archive/20230919/202309191144.B0MToaPG-lkp@intel.com/config) > compiler: s390-linux-gcc (GCC) 11.3.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230919/202309191144.B0MToaPG-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202309191144.B0MToaPG-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > In file included from arch/s390/include/asm/atomic.h:12, > from include/linux/atomic.h:7, > from include/linux/mm_types_task.h:13, > from include/linux/mm_types.h:5, > from include/linux/buildid.h:5, > from kernel/crash_core.c:7: > kernel/crash_core.c: In function 'parse_crashkernel_suffix.constprop': > >> kernel/crash_core.c:214:13: warning: argument 2 null where non-null expected [-Wnonnull] > 214 | if (strncmp(cur, suffix, strlen(suffix))) { > include/linux/compiler.h:68:10: note: in definition of macro '__trace_if_value' > 68 | (cond) ? \ > | ^~~~ > include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var' > 55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) > | ^~~~~~~~~~~~~~ Looks legit? parse_crashkernel() does ret = __parse_crashkernel(cmdline, system_ram, crash_size, crash_base, NULL); and that suffix==NULL gets passed through to the strncmp()?