From: Andrew Morton <akpm@linux-foundation.org>
To: kernel test robot <lkp@intel.com>
Cc: Baoquan He <bhe@redhat.com>,
oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Zhen Lei <thunder.leizhen@huawei.com>
Subject: Re: [linux-next:master 5741/5912] kernel/crash_core.c:214:13: warning: argument 2 null where non-null expected
Date: Tue, 19 Sep 2023 09:42:00 -0700 [thread overview]
Message-ID: <20230919094200.0f6495393a8eef3dc398e8ac@linux-foundation.org> (raw)
In-Reply-To: <202309191144.B0MToaPG-lkp@intel.com>
On Tue, 19 Sep 2023 12:02:17 +0800 kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 7fc7222d9680366edeecc219c21ca96310bdbc10
> commit: 5c322f6aad10f0920f842a4ccf82e9b9f351c0a5 [5741/5912] crash_core.c: remove unneeded functions
> config: s390-buildonly-randconfig-r006-20220512 (https://download.01.org/0day-ci/archive/20230919/202309191144.B0MToaPG-lkp@intel.com/config)
> compiler: s390-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230919/202309191144.B0MToaPG-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202309191144.B0MToaPG-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> In file included from arch/s390/include/asm/atomic.h:12,
> from include/linux/atomic.h:7,
> from include/linux/mm_types_task.h:13,
> from include/linux/mm_types.h:5,
> from include/linux/buildid.h:5,
> from kernel/crash_core.c:7:
> kernel/crash_core.c: In function 'parse_crashkernel_suffix.constprop':
> >> kernel/crash_core.c:214:13: warning: argument 2 null where non-null expected [-Wnonnull]
> 214 | if (strncmp(cur, suffix, strlen(suffix))) {
> include/linux/compiler.h:68:10: note: in definition of macro '__trace_if_value'
> 68 | (cond) ? \
> | ^~~~
> include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
> 55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
> | ^~~~~~~~~~~~~~
Looks legit? parse_crashkernel() does
ret = __parse_crashkernel(cmdline, system_ram, crash_size,
crash_base, NULL);
and that suffix==NULL gets passed through to the strncmp()?
next prev parent reply other threads:[~2023-09-19 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 4:02 kernel test robot
2023-09-19 16:42 ` Andrew Morton [this message]
2023-09-19 23:11 ` Baoquan He
2023-09-20 1:16 ` Andrew Morton
2023-09-20 1:36 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919094200.0f6495393a8eef3dc398e8ac@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox