From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AEF2C46CA1 for ; Mon, 18 Sep 2023 22:31:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A97B6B0457; Mon, 18 Sep 2023 18:31:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3594D6B0458; Mon, 18 Sep 2023 18:31:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 248846B0459; Mon, 18 Sep 2023 18:31:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1609F6B0457 for ; Mon, 18 Sep 2023 18:31:01 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D3F06160A21 for ; Mon, 18 Sep 2023 22:31:00 +0000 (UTC) X-FDA: 81251164680.29.25C7453 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by imf13.hostedemail.com (Postfix) with ESMTP id 3F4DC20031 for ; Mon, 18 Sep 2023 22:30:58 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DQtKeqDY; spf=pass (imf13.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695076259; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=8xBTm5zmVVkUMB6Ff6keuFoKJi+fX7tXCEfHkl59svQ=; b=6WZcipIXIKc3CNwv6qwcIvqRa3V4BK1boy6sIKddkjo6nPT5JmQgMz73qfmHPclysHsu/G LbTZ9K6Y4JQMG3p22Fg9yYAB8mvmLYh5n3PPACYn+PcCdOmGhTqb/78Ns3MG2NFYkT9uap 9pkV/g4nMIcVXyW4RnmfeObROOf0Xck= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695076259; a=rsa-sha256; cv=none; b=Bo5epi2qBue0T0GO3sD0Miuq6v7iIrZVlKoZ0+bCArXK6iwNVkxcoX7IbpcBMLpN+IPW9y O4vksFSHhjy2wGDe1Hbk9Ldia7tP6ammFg/rG9xFu4VotCHRb+Z4CKTHplJBzovQDAu3cf ii7N9u3jbgr4qMldiP5An1AxSgJ4zNg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DQtKeqDY; spf=pass (imf13.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695076258; x=1726612258; h=date:from:to:cc:subject:message-id:mime-version; bh=gRADdTb7wvW2svTuph32crKZ5CApE4KcvrsznUfArq0=; b=DQtKeqDYuOcp/6ckrWYThRy92WZbzNrQ+KYYTCP+NCIMqiA3PZNrrBxf Ei356Hhep1suLGlNzSO0zTYk+wpeR/2FHkrNvYkGJVFr6aU5goDkfDXfD jvFlsjGTTa27CgHzbXHgEFFKbdHBRa5286xI6CDm8T7swga79gOlkD1Fa IhUpjhjDq5zd6KbkMQrZ5I+ecYZ//j7njMDSW+6tZevicWO5PEJWl0zJ5 IZ0qUBNVA1fFlZApGAQ2/cC4dWN03jK2SzA3IZ8WAHJhhzKBnJ+wNMVyj KzxHiEub9kIpE3LYZZ8gji5uCU2ISnLZS1JLwZ5rDhYngRvU5HS9fmImb Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="466131740" X-IronPort-AV: E=Sophos;i="6.02,157,1688454000"; d="scan'208";a="466131740" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 15:30:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="992913535" X-IronPort-AV: E=Sophos;i="6.02,157,1688454000"; d="scan'208";a="992913535" Received: from lkp-server02.sh.intel.com (HELO 9ef86b2655e5) ([10.239.97.151]) by fmsmga006.fm.intel.com with ESMTP; 18 Sep 2023 15:30:53 -0700 Received: from kbuild by 9ef86b2655e5 with local (Exim 4.96) (envelope-from ) id 1qiMlX-0006aM-2q; Mon, 18 Sep 2023 22:30:51 +0000 Date: Tue, 19 Sep 2023 06:30:49 +0800 From: kernel test robot To: Kumar Kartikeya Dwivedi Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alexei Starovoitov Subject: [linux-next:master 5430/5912] kernel/bpf/verifier.c:15232:13: warning: variable 'prev_offset' set but not used Message-ID: <202309190634.fL17FWoT-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: 3F4DC20031 X-Rspam-User: X-Stat-Signature: nct8g99brdbtdjoqnhz5n8mjjghdz54j X-Rspamd-Server: rspam03 X-HE-Tag: 1695076258-976178 X-HE-Meta: U2FsdGVkX1+AQWVEmsH12elNwv9BHUvLLqFiPA+9gK1q11x4AiNHSMR37A9vNuvqJQPgGaxhSUiusqF8fyiDr9Do9PhzSStJOLGIMs7NUpweGE8HhRkrDunSS1yzicaacW2Sdjwh7H7R6B36AgcVkVH6l19huEYLfqWixkijUWEstcssNREfUvOLZyX3QAgdimHPWSG4ws5l80IlXLimqwBLW7rm5o7d+KGVmMizY9eEgAA0Muc/GHyC+SF2fI4nuY/sRO1dCOjycOAvr781Y/CrXP7AlfQfZEsSN2yeg2DDlI/WTNJLhjuhB+y8OyBFlkqrK43gXssHfmd+bBlBhSvFgTyQpvet390VGecz9cxF1MdzY17QHj59hXAggsGKc2D3OMuOubKt8+9kbPGQ5lxK0diExxq1boHarwlunir6Xz8A2JVgrkcRcfR3p/GqezOQ9B0Tkt0dFT7bXk5zMvB5vSdAG41c4Y7XabFHD8+Bis9ms8azzlb/kdQ5no6mw1JNyC+YwU7DUXDumyFEh2dXl1/8Vs4z3dCOc5B8J9O1os4/iDuLt0tLEXNhP43bKdGMVuDGaU4rvyc3WvXQKpgynEhxe5QQZ3CVzYPvTr/PaxC7At4Hj/YVyMmvLzolna5c2RkulNJp2A44WOWU+upq7DgwG2WuaodEhSk23r+yrqPT9q3HaL8Kaq7McF8Fq/hIUAw8g8cdTRti+fhMTmfJRuyC6k8liFVLqOBrPIwzqKSUZrNY42VAYXR36OqzjFUtYnxVgemvbJ1RLYTK/dpwyNLkly1M/ojwGwN4WAjHdImLkMviic2KXRKfWpqUK6j/xoJ1nN6qkTyVjMX/Ys3WamuSSiQKOgV1IpaqHP2gUc+Y+Hhvhm5gY28axTK+mj7EF6uju9/cnoZfMEszZKdp2aYtG1edpFE4iV4TlNdRUdYjrWbQB0mr/zlEbIrmPB/P/vpuuxdQ2EZ64t/ QFwDGkZU LqvDMLlFpTzFn9VXXL9bc3fX8tI27TlkHwnsN/9kanu6P7c2JGAveV2RX6hz/rsDNnGlhLZJviz9fa4bIPfSHgurO4hALYPbwJBVlVL2NGjB0SxDg8Zjfj8LldX2LPRUu97ztqvXfPWu2b1PdIM3tO+q/1KVZJFN9Bk7MaeOwzStizL+HZ3MpBcPMEq7aYpzHeQ2AdxCC3PZQaMPSSduaRc6+Jwl/UWSnkkiguit6dzirR9FP+dUAoZZdskpyDVyjnpsayxjc7KknjccJJYUXwqkNiszuBQTnlacse4ap48C5N83ngKhE4OP+d2Amn2O3QXIclmyOVw3+8N6dKJpRJE66+7mdiDnnFvR9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 7fc7222d9680366edeecc219c21ca96310bdbc10 commit: aaa619ebccb2b78b3c6d2c0cd72d206ee8fc0025 [5430/5912] bpf: Refactor check_btf_func and split into two phases config: arc-randconfig-002-20230919 (https://download.01.org/0day-ci/archive/20230919/202309190634.fL17FWoT-lkp@intel.com/config) compiler: arc-elf-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230919/202309190634.fL17FWoT-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309190634.fL17FWoT-lkp@intel.com/ All warnings (new ones prefixed by >>): kernel/bpf/verifier.c: In function 'check_btf_func': >> kernel/bpf/verifier.c:15232:13: warning: variable 'prev_offset' set but not used [-Wunused-but-set-variable] 15232 | u32 prev_offset = 0; | ^~~~~~~~~~~ >> kernel/bpf/verifier.c:15225:35: warning: variable 'min_size' set but not used [-Wunused-but-set-variable] 15225 | u32 i, nfuncs, urec_size, min_size; | ^~~~~~~~ vim +/prev_offset +15232 kernel/bpf/verifier.c 15219 15220 static int check_btf_func(struct bpf_verifier_env *env, 15221 const union bpf_attr *attr, 15222 bpfptr_t uattr) 15223 { 15224 const struct btf_type *type, *func_proto, *ret_type; 15225 u32 i, nfuncs, urec_size, min_size; 15226 u32 krec_size = sizeof(struct bpf_func_info); 15227 struct bpf_func_info *krecord; 15228 struct bpf_func_info_aux *info_aux = NULL; 15229 struct bpf_prog *prog; 15230 const struct btf *btf; 15231 bpfptr_t urecord; 15232 u32 prev_offset = 0; 15233 bool scalar_return; 15234 int ret = -ENOMEM; 15235 15236 nfuncs = attr->func_info_cnt; 15237 if (!nfuncs) { 15238 if (check_abnormal_return(env)) 15239 return -EINVAL; 15240 return 0; 15241 } 15242 if (nfuncs != env->subprog_cnt) { 15243 verbose(env, "number of funcs in func_info doesn't match number of subprogs\n"); 15244 return -EINVAL; 15245 } 15246 15247 urec_size = attr->func_info_rec_size; 15248 15249 prog = env->prog; 15250 btf = prog->aux->btf; 15251 15252 urecord = make_bpfptr(attr->func_info, uattr.is_kernel); 15253 min_size = min_t(u32, krec_size, urec_size); 15254 15255 krecord = prog->aux->func_info; 15256 info_aux = kcalloc(nfuncs, sizeof(*info_aux), GFP_KERNEL | __GFP_NOWARN); 15257 if (!info_aux) 15258 return -ENOMEM; 15259 15260 for (i = 0; i < nfuncs; i++) { 15261 /* check insn_off */ 15262 ret = -EINVAL; 15263 15264 if (env->subprog_info[i].start != krecord[i].insn_off) { 15265 verbose(env, "func_info BTF section doesn't match subprog layout in BPF program\n"); 15266 goto err_free; 15267 } 15268 15269 /* Already checked type_id */ 15270 type = btf_type_by_id(btf, krecord[i].type_id); 15271 info_aux[i].linkage = BTF_INFO_VLEN(type->info); 15272 /* Already checked func_proto */ 15273 func_proto = btf_type_by_id(btf, type->type); 15274 15275 ret_type = btf_type_skip_modifiers(btf, func_proto->type, NULL); 15276 scalar_return = 15277 btf_type_is_small_int(ret_type) || btf_is_any_enum(ret_type); 15278 if (i && !scalar_return && env->subprog_info[i].has_ld_abs) { 15279 verbose(env, "LD_ABS is only allowed in functions that return 'int'.\n"); 15280 goto err_free; 15281 } 15282 if (i && !scalar_return && env->subprog_info[i].has_tail_call) { 15283 verbose(env, "tail_call is only allowed in functions that return 'int'.\n"); 15284 goto err_free; 15285 } 15286 15287 prev_offset = krecord[i].insn_off; 15288 bpfptr_add(&urecord, urec_size); 15289 } 15290 15291 prog->aux->func_info_aux = info_aux; 15292 return 0; 15293 15294 err_free: 15295 kfree(info_aux); 15296 return ret; 15297 } 15298 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki