From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E6BDC46CA1 for ; Mon, 18 Sep 2023 15:56:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 889E56B03C9; Mon, 18 Sep 2023 11:56:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83A0D6B03CB; Mon, 18 Sep 2023 11:56:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 728756B03CE; Mon, 18 Sep 2023 11:56:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6396D6B03C9 for ; Mon, 18 Sep 2023 11:56:55 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2E374C0472 for ; Mon, 18 Sep 2023 15:56:55 +0000 (UTC) X-FDA: 81250171590.24.83B5B4E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf06.hostedemail.com (Postfix) with ESMTP id 5D309180023 for ; Mon, 18 Sep 2023 15:56:52 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Lzo4Z7su; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695052613; a=rsa-sha256; cv=none; b=HKQV+DmxJsR5HZefwfTB3JZ66lw7XrXiclm2ndMAytFmoYRNklrH5DBa6a3yQyy+yfoCDZ Ha+D4VPY3ljTZlitWsMSudF8jCAeAHRssjhqmLAsfMgvVezXakpFSOyMq/e8YaF5YQjKID 8XVww1QxcJ6qyE80wjEPHSHzIk3wtpc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Lzo4Z7su; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695052613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ERiVgQPkYdOYRRuinb9WxrG3EVWK2UUiyawSRLM7TVI=; b=mHW1Iqgxytsc8Wmu75qOMRn+n/3DDin7kIu6Yg87DxK6bgxo8C4XG7/sR1bsRhN54zD7WM 5/9d2WaGNlX1vdY/2DQ6MEvd5sLCP+gxNBL7x0NOa9yU3qJZ5VqYq7MISYxKXGN7gNpPww aPe+Q4OQ3NF+VPzqpLtdUuebsEwkqmM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 73F4FB80F1A; Mon, 18 Sep 2023 15:56:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C4DAC43397; Mon, 18 Sep 2023 15:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695052609; bh=VvMIAd0IbbqotUUOoCyPiPmt1MLsOviC0xJ4TYimsAU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lzo4Z7su2CfaS68/lpoY6RgABqbMAipJoBMeCXxsdgub4CuJNP8dgiIjNmDtPjQ+v mHzEu/rxlr2fy3HhUjcScKhLz5otvFbUZXavt6K3198YDq9TL7IyU/zKowjWgw5ogE YTVh7jZfmGeL+FqmHd62lW82HE6nq0mtze3Flk1rNcIG8DfhOqofS9Cn66zn3gZ4Ei LxR9Hbn/hOZnFc4tn5V1dE+aQxp7PHel6BRu7hzGWQGCI2VUGUTjgWJOHqxk2JZ2oY VjWXwmiBrQuktaQRzkgA76oIOzMc7t581ZKq3vMUvn86JPPfEN4I2+LlNR4PHtOAMp zMla6GlL3L39A== Date: Mon, 18 Sep 2023 18:56:07 +0300 From: Mike Rapoport To: Usama Arif Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, muchun.song@linux.dev, mike.kravetz@oracle.com, songmuchun@bytedance.com, fam.zheng@bytedance.com, liangma@liangbit.com, punit.agrawal@bytedance.com Subject: Re: [PATCH] memblock: add missing argument definition Message-ID: <20230918155607.GD3303@kernel.org> References: <20230918090657.220463-1-usama.arif@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230918090657.220463-1-usama.arif@bytedance.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5D309180023 X-Stat-Signature: 8mzjztr3rm7mhy7h9qh3htp1yrat9jr7 X-HE-Tag: 1695052612-221425 X-HE-Meta: U2FsdGVkX1+ViapHtvglXKhtuWtNAYxWd5hpUyVPMaxPwmb9w+wT/85BuM53BlvmKRPi7Cz3YoTTOqW9rCzJb/Y7iE9q71atLZuR6FzRgxP20E2GNCDIDOWU6yvbDguMwnszOPERJgu05Cx9gCnDqHgDQUmI7kCxoZW3WF03kynoCL1BPaJvoPZ2N3F3wFnGoUmi43OpxosXswAjAJAQm7H9yeWdDErwDxEBHXGNsECYhoRtFwWM3IndrZvNkf4ItIQWzpCWzxh+KlI3sm0Te9bgNIoSB88cxBEOIUFDIi9RozbkkyJJp+0OZd6rve0+QOYiCjlGW8XCNixM6PvXLzNxdqo9GoBUzAO3mDg7Rdj0JYc6g2J+6kaHAhNOP8Amnb+Rn6QshN6jM/y4cEjE3IGxCJuvMYsKe6ONopyT5zOzLBSthWnpS4kP0ehr4486eZz8VDuxjrkrTLbjfJP4eGXhSX8S8hIx8onw4PNFN9NPCofgbhxoIMQFvhBcijXHZbNSroes/7QWu/7ISVOk4RADISPDVzQ0fpdYLInaRok8C2qwGLv204lNbLkV97lff++kddUjP8xECjfalBg92bq6mY92ZGj+QKbtgyEJkM16g1ijSJwIMao1v4M7ptjq7da4WFtS8CVk6qkm/EH0ITeMW1ZjoitLmUBs55lBIgMwpww5yQpkTJctUyzZWTUvamu7a6EoxQiJM5u54QbobovyIybM29LeUP5icQ0LT1WlRfrylIh/DKGjVuMwVIscYAdLJQn2bW50Z7xSvxXxTdowWjBHAxCaoc7oC8av0GfHST2kRj43cUwy3YzYIhQyr5LCH4KaZXJxuUJaAMVSSE5d8p95DQiYPFjCKGV8RHteUQjvEcNei05UCfW8e+deZo2x5/PNa8SDGg+znREsNhlglJiMBCZyftmTjJdveEYm23ESeAxKYceB2W9doQUv7498kYGD7hGRqrI1GJo o4TGH89l POG0jAsE97YvoytL0ueCa3QP8cWHKXMxEJpv06+/BjEt0TVWrYWsLxOFLLudBBlQwx/8fT7ir+suITeGE+BCWVSexOfWEZqHAU8TbwbMplTLnzfUrvw6fi6KV4VYRk8T361YQPhn1ktqTxCo+mnkJiIv7eHB1TKQTEVYPKGXHXUdGhKJyIUlfcxtJ3tAHeWkQFebhOeF7iJerj6Q9hdIo+hiE2BBfNuLGmqHCrmJzg+EyR07kvggCwOsWw2O9ui7/WXSQX/1OdMd18Dfmva4XLbXpv+moQ1Ch8DjrrxsDGqn83kLqa68WOrZqMzVRxBIUOfhUZ7D/OnN0x73IXZrj286eXCSVOLbmDTnZaIGxfBPxGADUL4DSWJxDA7MdLFIPuEZbKIeSSABDP7W22fNF5XhQKi0mAE/0lCwPiB30IW1hfCZk81/Xt68AzskeCl/o1WyoGtkWDLlBIDE7xhYBW0MNqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 18, 2023 at 10:06:57AM +0100, Usama Arif wrote: > Description of argument memblock_type was missing in the commit > that introduced it. > > Fixes: 70083e1c8ab4 ("memblock: pass memblock_type to memblock_setclr_flag") > Reported-by: Stephen Rothwell > Signed-off-by: Usama Arif Reviewed-by: Mike Rapoport (IBM) Andrew, the commit being fixed is in mm-unstable, can you please pick it up? > --- > mm/memblock.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 8f7a0cb668d4..fd492e5bbdbc 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -892,6 +892,7 @@ int __init_memblock memblock_physmem_add(phys_addr_t base, phys_addr_t size) > > /** > * memblock_setclr_flag - set or clear flag for a memory region > + * @type: memblock type to set/clear flag for > * @base: base address of the region > * @size: size of the region > * @set: set or clear the flag > -- > 2.25.1 > -- Sincerely yours, Mike.