linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] memblock: add missing argument definition
@ 2023-09-18  9:06 Usama Arif
  2023-09-18 15:56 ` Mike Rapoport
  0 siblings, 1 reply; 2+ messages in thread
From: Usama Arif @ 2023-09-18  9:06 UTC (permalink / raw)
  To: linux-mm, akpm
  Cc: linux-kernel, sfr, muchun.song, mike.kravetz, rppt, songmuchun,
	fam.zheng, liangma, punit.agrawal, Usama Arif

Description of argument memblock_type was missing in the commit
that introduced it.

Fixes: 70083e1c8ab4 ("memblock: pass memblock_type to memblock_setclr_flag")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Usama Arif <usama.arif@bytedance.com>
---
 mm/memblock.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/memblock.c b/mm/memblock.c
index 8f7a0cb668d4..fd492e5bbdbc 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -892,6 +892,7 @@ int __init_memblock memblock_physmem_add(phys_addr_t base, phys_addr_t size)
 
 /**
  * memblock_setclr_flag - set or clear flag for a memory region
+ * @type: memblock type to set/clear flag for
  * @base: base address of the region
  * @size: size of the region
  * @set: set or clear the flag
-- 
2.25.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] memblock: add missing argument definition
  2023-09-18  9:06 [PATCH] memblock: add missing argument definition Usama Arif
@ 2023-09-18 15:56 ` Mike Rapoport
  0 siblings, 0 replies; 2+ messages in thread
From: Mike Rapoport @ 2023-09-18 15:56 UTC (permalink / raw)
  To: Usama Arif
  Cc: linux-mm, akpm, linux-kernel, sfr, muchun.song, mike.kravetz,
	songmuchun, fam.zheng, liangma, punit.agrawal

On Mon, Sep 18, 2023 at 10:06:57AM +0100, Usama Arif wrote:
> Description of argument memblock_type was missing in the commit
> that introduced it.
> 
> Fixes: 70083e1c8ab4 ("memblock: pass memblock_type to memblock_setclr_flag")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Usama Arif <usama.arif@bytedance.com>

Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>

Andrew, the commit being fixed is in mm-unstable, can you please pick it
up?

> ---
>  mm/memblock.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 8f7a0cb668d4..fd492e5bbdbc 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -892,6 +892,7 @@ int __init_memblock memblock_physmem_add(phys_addr_t base, phys_addr_t size)
>  
>  /**
>   * memblock_setclr_flag - set or clear flag for a memory region
> + * @type: memblock type to set/clear flag for
>   * @base: base address of the region
>   * @size: size of the region
>   * @set: set or clear the flag
> -- 
> 2.25.1
> 

-- 
Sincerely yours,
Mike.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-18 15:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-18  9:06 [PATCH] memblock: add missing argument definition Usama Arif
2023-09-18 15:56 ` Mike Rapoport

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox