From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6FAECD37B0 for ; Mon, 18 Sep 2023 08:41:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 521D56B02B7; Mon, 18 Sep 2023 04:41:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D1EC6B02B9; Mon, 18 Sep 2023 04:41:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 372866B02BA; Mon, 18 Sep 2023 04:41:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 26D2D6B02B7 for ; Mon, 18 Sep 2023 04:41:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F00B71A0C75 for ; Mon, 18 Sep 2023 08:41:45 +0000 (UTC) X-FDA: 81249074970.02.F2D1D0E Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf26.hostedemail.com (Postfix) with ESMTP id E54F7140016 for ; Mon, 18 Sep 2023 08:41:41 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=dp7Lmea9; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf26.hostedemail.com: domain of da.gomez@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=da.gomez@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695026502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I6/F7qFZPtrg6H/Jcv8LXXx7VGKpvo96ZTN4LGrf6fw=; b=Alwo+JtYBEbsVO44kQus7y3vj85b00erxC8SKXIPUmanVGMUjZf3IWsvC1BnVga+8FKcX1 XcNoZ1dxNXAclf72HtgETOMr+rCMP7hPdtAQrVjm2eK+BNH2EWd2DGqZiPYKR8Y2hh9DQg pZSKepT+hTggALCgxrgyDmaSkSGP574= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=dp7Lmea9; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf26.hostedemail.com: domain of da.gomez@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=da.gomez@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695026502; a=rsa-sha256; cv=none; b=xJ7ieB7o+ecenfjHUnJ0g5b2lG1zqe0nnhZuwsv94sMX05OxTfPzL5umoaBe4LW9WhIUDW jKhsQ55+PPz2cLbfp7S7pn771jxhhlvQ72j/V5Qdig4Y32gOxOnpshtLG1R4MpOlevjB3L R6ZIugvw9rXm7PwCU0fIESeh0mtRWpo= Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20230918084139euoutp0116a0153827e0505c4bd773a4fe153893~F8Z7qCG-B2933929339euoutp01I for ; Mon, 18 Sep 2023 08:41:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20230918084139euoutp0116a0153827e0505c4bd773a4fe153893~F8Z7qCG-B2933929339euoutp01I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1695026499; bh=I6/F7qFZPtrg6H/Jcv8LXXx7VGKpvo96ZTN4LGrf6fw=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=dp7Lmea9EJ7tbdvZDslnP6QUxppeaNpFLMQDgxDUVIU2zPqhR6CbI85J5ObViZBoJ cwH22lQE2vP1BSZbI1R0uq9/GAveSrl2JxsxypRzcuEtyFqbkS83fuF0mUQMKtNdRt 7mpIEHsPyhl06C5LPbz1uo0upe7xEJUpeKbeTD+U= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20230918084139eucas1p2bca1ce458c270cd2d518ba89853b4b2f~F8Z7Nddnn1417714177eucas1p2d; Mon, 18 Sep 2023 08:41:39 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 63.83.37758.34D08056; Mon, 18 Sep 2023 09:41:39 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230918084138eucas1p1ecd026f8b438b8023d4a7b1db5b2a776~F8Z6vIPXh1114411144eucas1p1Q; Mon, 18 Sep 2023 08:41:38 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230918084138eusmtrp2db991ae9bf97063fa586edd5cedc7b12~F8Z6uUAsB0622806228eusmtrp24; Mon, 18 Sep 2023 08:41:38 +0000 (GMT) X-AuditID: cbfec7f5-7ffff7000002937e-33-65080d43afb8 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id CC.AB.10549.24D08056; Mon, 18 Sep 2023 09:41:38 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230918084138eusmtip1ee030262885b16ac08365ff6c0b85118~F8Z6hVy1p1042310423eusmtip1B; Mon, 18 Sep 2023 08:41:38 +0000 (GMT) Received: from CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 18 Sep 2023 09:41:37 +0100 Received: from CAMSVWEXC02.scsc.local ([::1]) by CAMSVWEXC02.scsc.local ([fe80::3c08:6c51:fa0a:6384%13]) with mapi id 15.00.1497.012; Mon, 18 Sep 2023 09:41:37 +0100 From: Daniel Gomez To: Matthew Wilcox CC: "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "gost.dev@samsung.com" , Pankaj Raghav Subject: Re: [PATCH 1/6] filemap: make the folio order calculation shareable Thread-Topic: [PATCH 1/6] filemap: make the folio order calculation shareable Thread-Index: AQHZ57ovaMdf9q/cjECRh1BbWSoXsbAb1A+AgARjlAA= Date: Mon, 18 Sep 2023 08:41:37 +0000 Message-ID: <20230918084134.d276vadcmkvwonmb@sarkhan> In-Reply-To: Accept-Language: en-US, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [106.110.32.103] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA02SeUiTYRzHefa+e/dutHib14ORwSgzNc0OeCuNousljFSiQLpWvbmxTWVv 6zCijYJSQs1Y6bSaS6fzyHw7pistVmnrorDWtDJddrAiUbND7XC+K/bf58fzPX4/eHBE8owf jisy99CaTJlKionQa20/H89ZIcbpud1WhCxrqMPI2tcFGNnRN5l8N5iPki1dMeSNFidKdtjL MLK77g+ftI81CUh34TtAWob7BeT1RjNGjv4ow5aJqVLdU5QysVrqcnU01fFIS7E1uRjFDhYJ qHvFoyg1xEak4OmixF20SrGX1sQv3S6SX31Vx8vWifb3NFciOvBNkAeEOCQWwCf9Ll4eEOES ohpAV5HbP3wF0FTkBdwwBGCl1cL7ZzlydBj4WEJUAfjnqeK/qNtY5Xc8BLD14oA/ywqg0dbN 91kwYjZsdbLj7TgeTETBz1fm+TQIcZcPK+pZ1KcJIpLhYLttoi6YWA+7btoQjhfDzsvnEZ8X JWbCWyeCfCgmFsK3lxJ9CuH4cs6KhokUQEyDHuvIxJ0IEQa7+s77D5gCzaU3EI5D4W97L8Zx LHz0og9wPBderWxFOZbCsePlgMuJhabrgxjHi+Azp53PcQy0lH+ayBSP5ztL+lDfWZAwiKC5 psQfuhKOfi/2LxEEve1XBIUg1hiwnzGgwxjQYQzoMAZ0mAC/BoTRWkadQTPzM+l9cYxMzWgz M+J2ZqlZMP7xHvxuH24C1d6BOAfg4cABII5Ig8UlCRgtEe+SHcihNVnbNFoVzTjAVByVholj kpw7JUSGbA+tpOlsWvPvlYcLw3W86S8jj+Wo3UkvxjZW6JRZxHM3eUIzNLO/1JUfeakw124D kjPNIdpOxQqXvjbxgNcqarwTdTbJY0uuGli7AMtPPWiomR1xPzI1V7x/9aYLjnXL2/Vj2oX1 StZc+16boEkJ/SVMjWea03K/Hsou3oq4ez/u69XLDA8sR11N0QVvBiKuhWy+F9uzRmBpW7ZF dNehCrNFHw8/V16ww8P/IM8aEubhux0f9aYZd1Z5XuNyxeEm+bn0nzm3RpTepOkpLvSNUnWs onEkeVYa9QFUzdAbeqzLg257QhhpT17+Z/Maz5fJhpOHJx2pVUundnUknw6+vZ09tWFJfMOP zg0thTukKCOXJUQjGkb2F87yX4HnAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLKsWRmVeSWpSXmKPExsVy+t/xu7pOvBypBtOnKlrMWb+GzWL13X42 i8tP+Cyefupjsdh7S9tiz96TLBaXd81hs7i35j+rxa4/O9gtbkx4ymix7Ot7dovdGxexWfz+ MYfNgddjdsNFFo8Fm0o9Nq/Q8rh8ttRj06pONo9Nnyaxe5yY8ZvF4/MmuQCOKD2bovzSklSF jPziElulaEMLIz1DSws9IxNLPUNj81grI1MlfTublNSczLLUIn27BL2MrXfWMBU0cFU82LmU uYHxG3sXIyeHhICJRHPLV8YuRi4OIYGljBJbZ+1jgUjISGz8cpUVwhaW+HOtiw2i6COjRMN7 kASIc4ZRYn3zemYIZyWjxLvdZ5lAWtgENCX2ndwEtIODQ0RAQ+LNFiOQGmaBo6wSS9ZuAlsh LOAj8en4drB6EQFfiS0ntrBB2FYSNzfPZwbpZRFQlTjQIwxi8gqYSjzeYAOx6jWjRN/8V2DX cQK9cHLJerCRjAKyEo9W/gJ7jVlAXOLWk/lMEB8ISCzZc54ZwhaVePn4H9RnOhJnrz9hhLAN JLYuhfleSeJPx0JGiDk6Egt2f2KDsC0lrpzcxQpha0ssW/gabCavgKDEyZlPWCYwysxCsnoW kvZZSNpnIWmfhaR9ASPrKkaR1NLi3PTcYkO94sTc4tK8dL3k/NxNjMB0tu3Yz807GOe9+qh3 iJGJg/EQowQHs5II70xDtlQh3pTEyqrUovz4otKc1OJDjKbAoJvILCWanA9MqHkl8YZmBqaG JmaWBqaWZsZK4ryeBR2JQgLpiSWp2ampBalFMH1MHJxSDUzqE5p+C8s3fn24MzO31Z9L+ml6 96zLRptVFfdaF+V9n8K63/IJ9/LNXoyNupcVv268tNsxMSz1HdsDCU6r79/cnbVkFnxf0aZU 0HJoQx2j2M/sIoZnxnt2iPJLHl/vOCPIVX772y1VdbNdJd4VN3MFs4YJPHmazqAo5nCiovs7 4y3jrkUdcvJmi3jVKjVZ+82XvF4hu0tc7VfrvsripN3aqVyrg8WKp62YKnnp7GN2bpY24anr VnHaP7m2LN5B6fPH+4u9u9icZv+JE1Ccb/Po/JRbFtNMm55/FrLZu7Bp2qKE/VPF2XOSIpx5 hBcseLPxW0Tk/9bm/fdv2pgcEJ+0fvU81RW7siyfnmDXElNiKc5INNRiLipOBACzjsVg8AMA AA== X-CMS-MailID: 20230918084138eucas1p1ecd026f8b438b8023d4a7b1db5b2a776 X-Msg-Generator: CA X-RootMTR: 20230915095124eucas1p1eb0e0ef883f6316cf14c349404a51150 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230915095124eucas1p1eb0e0ef883f6316cf14c349404a51150 References: <20230915095042.1320180-1-da.gomez@samsung.com> <20230915095042.1320180-2-da.gomez@samsung.com> X-Rspam-User: X-Stat-Signature: 81dmaukzfk699f1gn38qhpbuzwfnpu1e X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E54F7140016 X-HE-Tag: 1695026501-453897 X-HE-Meta: U2FsdGVkX1989wBt4ziaWe8oPJnAjrEemtQQUMDRERUlj+3WvyU3pyZNWyTxaxEWIuHbLcFLSoGBLVE9Pnifp5Hkpjb8+jnrVgXLV4purSvJ5jtnck90luRZtX3leOapR8ihKtF5xJSzB3qdFvSf8b6YaoGsGq3cs4dBi18Tm7iI5knKPmrIQeHNPlEfpj4aEcfxDodsi6tlPGCsf/Ch6n37vd/VXyIjwzqCrMQURY74KfpBUghLCooZHwrN9SpCyngsRSUiy2YhQMf4Jc2gROC+mABV8FglCfpg1tsbbEngZ6Is7yWDX5bYjpFDW6GIkf4bI9/5PTO/jzKd7mEpCNvxAenbCmLNyRWXi+vZKMEF+AaPUVl4Cl7tTcEcaKwkqWABigh/eY9gW1y+3R+77vsSGIcd7hmEmKh49mKRyJD9nFSVh7riShWKglm2O5lJKZKXzFpUwCh99N5OnE6bESGu/aWvAy/I5DXoiEv+xLhe7VxaTiEyDccxaTbhXw9fXrRv+2jWDeUQSZBGlVB0mYZeLmv64Zw77WMlrVPdyq2Dw/a1dfXXvjZ/iCnxh7S0mV4c2PXMq880sKYmwkdnt/nYRecMz6NDdUa2mahghDxM6w0GPADbB6ZHdFY+ySZIP4d9hq0ZzPXcbZNc5gqE+Oq8UyzLR4ZZfnG025I3jA2l3bQjaSPovZTs44m23WBT8wq7loSImi222oZqZbvXM3XNrmyhWi6Ym0vA5Qg069lANLsea14BEeo1BMuiIvB/o0ENinQKuvq8ShSqDfIivUOQ1H1YAZ+nP6lmnVeebrLc+gauFBvwWOdNyhjr6DqlGV/DRnk0hWz49CSfrAafTsA2N7Gcwx0vaXIN9R7j8yB9qZMZHAFfe9Ky4zUmWjML/R89MVfYifhHiUOw/W4diehKGkpy73q6SqTPbX0Ket7YNo1va+IpX+wKMlR6f7+UChefE8PKdU+kgNqzS6t I4klybeI H7jYLWLbL0cVFKuVMiCtL2OIipf+/jIXaFwixQOU7LClvWGAKPzyPMZayLNgOf/pZ+17rJjUUL2ldUqb/vmMh/Pn7E0UrSPnapSGsSazWPkRb5lxH0pzMuxYu+GKVU60MFaHS8n09Ti2J89Ja2jqfYkTxd9XTn2L4rPcx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 02:40:07PM +0100, Matthew Wilcox wrote: > On Fri, Sep 15, 2023 at 09:51:23AM +0000, Daniel Gomez wrote: > > To make the code that clamps the folio order in the __filemap_get_folio > > routine reusable to others, move and merge it to the fgf_set_order > > new subroutine (mapping_size_order), so when mapping the size at a > > given index, the order calculated is already valid and ready to be > > used when order is retrieved from fgp_flags with FGF_GET_ORDER. > > > > Signed-off-by: Daniel Gomez > > --- > > fs/iomap/buffered-io.c | 6 ++++-- > > include/linux/pagemap.h | 42 ++++++++++++++++++++++++++++++++++++----- > > mm/filemap.c | 8 -------- > > 3 files changed, 41 insertions(+), 15 deletions(-) > > That seems like a lot of extra code to add in order to avoid copying > six lines of code and one comment into the shmem code. > > It's not wrong, but it seems like a bad tradeoff to me. I saw some value in sharing the logic but I'll merge this code directly in shmem and add a comment 'Like filemap_' similar to the one in shmem_add_to_page_cache. Thanks for the quick feedback and review Matthew. I'll do a V2 with the changes and retest the series again using latest next tag.=